From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Lin, Du" <du.lin@intel.com>
Cc: "S, Ashraf Ali" <ashraf.ali.s@intel.com>,
"Chiu, Chasel" <chasel.chiu@intel.com>,
"Chen, Gang C" <gang.c.chen@intel.com>,
"Duggapu, Chinni B" <chinni.b.duggapu@intel.com>,
"Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
"Mohapatra, Susovan" <susovan.mohapatra@intel.com>,
"Kuo, Ted" <ted.kuo@intel.com>
Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()
Date: Wed, 13 Mar 2024 09:57:48 +0000 [thread overview]
Message-ID: <MN6PR11MB8244A996123008C2CAD09AD28C2A2@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <15718c1dd224a860cbf24f9d1d5d8e4afd14ff85.1710235504.git.du.lin@intel.com>
> - ASSERT (MeasurementExcludedFvPpi != NULL);
> + if (MeasurementExcludedFvPpi == NULL) {
> + ASSERT (FALSE);
I prefer the original meaningful assertion instead of ASSERT (FALSE).
Adding if-check is a good change to me.
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116713): https://edk2.groups.io/g/devel/message/116713
Mute This Topic: https://groups.io/mt/104886876/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2024-03-13 9:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-12 9:27 [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Du Lin
2024-03-13 1:46 ` Chen, Gang C
2024-03-13 6:55 ` Ashraf Ali S
2024-03-13 9:57 ` Ni, Ray [this message]
2024-03-14 2:32 ` Du Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244A996123008C2CAD09AD28C2A2@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox