From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 94A5BD80470 for ; Wed, 13 Mar 2024 09:58:00 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=oPg9E/LahWYKZvCOkF85XhG/JTBxfnZrFanpYyyKrE0=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710323879; v=1; b=Qa+CT1aAcageng1DMckk8W4soQj1tlAInY6c3W7OQJK9e01MhnokLNz3rnGfyYyoltsWOl9y 0voxTthnOkuMQuo8GyalgIHMTyTbIedtVGlyiIFXqC+9VJBSA3mkIKcpWhLgGdL78s2kIIdEM+i hxKBiEriBhc9WeRgv1qqiLXMBJSBD9qf7ue7cXJ+3Itl9aN/M9eD1dGBXmH+HpnVuEp6zH1EihH ja2iEBDphDweH5s9tBbnTqOuldM/P7wTaXVYpk+BZYdHJkhNjwyfG4CV6Y0+yzDUatWsnvqvr7D ySZOmIa2fJ5eyg12DRFK1hb6Gch9N3pBh29kBhRaK/Cyw== X-Received: by 127.0.0.2 with SMTP id F4G3YY7687511xYgB3InOSLc; Wed, 13 Mar 2024 02:57:59 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by mx.groups.io with SMTP id smtpd.web10.12492.1710323878294650875 for ; Wed, 13 Mar 2024 02:57:58 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11011"; a="8896731" X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="8896731" X-Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 02:57:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,122,1708416000"; d="scan'208";a="11787467" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmviesa010.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 02:57:57 -0700 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 02:57:56 -0700 X-Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 02:57:55 -0700 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 02:57:55 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 02:57:55 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH0PR11MB7657.namprd11.prod.outlook.com (2603:10b6:510:26c::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.16; Wed, 13 Mar 2024 09:57:48 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7386.017; Wed, 13 Mar 2024 09:57:48 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Lin, Du" CC: "S, Ashraf Ali" , "Chiu, Chasel" , "Chen, Gang C" , "Duggapu, Chinni B" , "Desimone, Nathaniel L" , "Zeng, Star" , "Mohapatra, Susovan" , "Kuo, Ted" Subject: Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Topic: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Index: AQHadJQNU5TFs44LU0KnKQ7A7+n9irE1cGnw Date: Wed, 13 Mar 2024 09:57:48 +0000 Message-ID: References: <15718c1dd224a860cbf24f9d1d5d8e4afd14ff85.1710235504.git.du.lin@intel.com> In-Reply-To: <15718c1dd224a860cbf24f9d1d5d8e4afd14ff85.1710235504.git.du.lin@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH0PR11MB7657:EE_ x-ms-office365-filtering-correlation-id: 2bb0b8ae-4f36-424c-cf7b-08dc434409e3 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: fkEpJTfBqiWbGbjLOHsnOMUDRlrgxmzutk1sEl3XMoybsv1Jo6F5m+Xv8HSPdOJkRVSxQanX6wRMgmZFh9O++yTVh5v7jPpJLOtah5JttPwR7FPYiRSY9+yQ7iZYJJMgMRuroO1eEP4fOGyVU1NJmh4cJvJnABpUs7Zn3xYUFjqf1YpYT2CsjWcNWZ0s809Ci8mygEnkDKZfYHjDxwDVSLYr6Bc+GzAf6zPVtgwZE2+c6ExTmd4L6Ut58qbHE91rw7HKSGJgv8/vY7EaMvHKZlUaDB+VZlnZR27Iz7AWTgq5v9RuZH/4oI9FF0e6qT5Ex6THwsvw381xHEvpDUYBA+oZgpCyxozBG2YCXZNfb9GZ2GKMJsg961Lt0tkEaOjZe0tklpB+RQcZPaFBDBsS79p0ADKs7lp3/jjz0OvFHCzJtithIZjVuzegyXFSMP97v+5S72BsP8FjKobgQLu057jbH12Cq18PUtdVCL5KLmK6rO/Qr7acYOw0Mhrb5JFqhg6Usjg5kaiIzYlOR0w8HC+6t3XrTpw/i7JnbcBq1QNv782YJh851Da27xeYjiurGKz7xxeSPTnTOx13q1htzyWUV5Diy77kskBUyIbDSU+mM+66635oUPrMDtwXFv9OcyCCXc1QKTjXLQWMU8mLfzUJ7SAtkYX0rTWCFyl7Zfad/k3PuTy6x39ivk5QX1xcbgiIXJacU7BwvyyZU1c0rA== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hzk4adri9EsU1BUj69Ofd3lwR8A3XFoDgvC91XP+bMFzOQ5IDEL2zbFfmu8I?= =?us-ascii?Q?NEY411Yol6ySU6QnZEs4I7bm5QoA/uLex57MagL7p1CZx9iaRFi5FDh+sDYl?= =?us-ascii?Q?YMe/v7IRqgAJeexzB5ssZpANrcK66/1LBz7MRLeG9MvXKv6uQaQ3cCnLeCu5?= =?us-ascii?Q?ABHqPVl51vHF2DEZ1NErvlI8cMBjkkjg0hAp/UmkauRBg5GA3els4DKYcOOs?= =?us-ascii?Q?DXrf8wA+dIoeZQa/R5WJ4DhruJvotvGHwsggReJppsbq4qqjT8CSt8Ms9QVY?= =?us-ascii?Q?i6Ar8Ei4uDEXdNzJx3oEUYhQzMPL1jUlPFTzQ/QuLbWi2Ksbj+940Mjzb5tp?= =?us-ascii?Q?nSsUeeEEs6wY+qHQ9jCQ47DxDKpnQJmSqhvwnTCuOSmj/D/dSBqzL1oxVmiX?= =?us-ascii?Q?vOUuwU/UjJ6Ww1kfWyyv5bAYeu9RKqSstz7RDctkIx5FByJO807Gr9WKXaZW?= =?us-ascii?Q?ifCQrJXlkxuZA4BcVBCWbkdWRUcA3k/2ifyvgCkCMwUEtU+x6TU4deqprESz?= =?us-ascii?Q?yA0ZZ0eTVeHft74d+1VJpOC4cl56RByf1WhZzgbIMBSEkGXqM8vYn084Go4/?= =?us-ascii?Q?FSs7bNEH3LQyFIXLb6nRIr12EE7CqinLwfMoSeEnZblPbbTNqSabCBEg1Qu1?= =?us-ascii?Q?VHKsNrY0AQzLVz1gyZs9QkqZ1UZlILCq7yiWu/HOw5gJ6HDKzwOjZIk+WYJs?= =?us-ascii?Q?+L38F6hKtbnerEl0NYFBStWIvTv4LGVLCZDN3yKM76IY10KhN1jcxHtETp3D?= =?us-ascii?Q?NfzqUmYuLtyLQx+BYi+M0f/LQqqNMg/MKz9deuA6W/zBQuwpIMG9lHOGCxP2?= =?us-ascii?Q?jzKCyf3dTO6ifr1eCCnXg67INlZ5QwtRKxEpf7u85XCxdDdvyjpdPRuyCJTv?= =?us-ascii?Q?aSpyXtKjMrfCjAW5RHJsi3Km1XdeNpBgmwzbxvx8/QKfOnyoqpA2uZpiNPoP?= =?us-ascii?Q?af2pFwBzPthq8v4UEu3ehTXFpH5IT7i50rvUO/6Ppnj/2EGz6DMVsW8Q57DA?= =?us-ascii?Q?XalplUtPw9xdBZQ0jPRSHhp0e+hpLKTA3s9eGRxQX2gK+dAUNDd/vEakDmN/?= =?us-ascii?Q?/YdV2p/Z377EsFuRT3LQsTUl/5Bhv5ALatNHfVDHxktENkN9Xh/9IVQvrw6F?= =?us-ascii?Q?WN/LWtYMP7B82J2gZrH7USfLbfjNdJwYVvyB1jDqdLQD9jxOqJkteeZB3wIT?= =?us-ascii?Q?pJM+bRuYrv5aV9q30JIGO72h+vpnM/qJIBdlNupAiGw58H+2FnwOiBHkWxqa?= =?us-ascii?Q?TtJXYol8oY4FA//HGKwr37t3PjjNQZbe/RJnwADXgTd29A2tMSDTHvol7/QC?= =?us-ascii?Q?wzz93NtcdlMl9ZvKmYMEPp/ins30vhmgc+N41rBb4+o257neUHhudooiMYJt?= =?us-ascii?Q?NasXJwfyome4/GKk60MWCAcGencwNjyhdXiy3N3+qO0YRj9gnuC1h7iRBqoZ?= =?us-ascii?Q?Ry40dpmEC4DgL5umF00o3Vq93uUJIKEu7/flaCriP2eCTAbG2J4eFlF95hxm?= =?us-ascii?Q?37apVoi9WYblYPnjDce0LeRZnC6ArtSA0VZqHo5N71C0VUrsx0/adO7sBfBw?= =?us-ascii?Q?sduTbTZZ/XNtaTsjJW0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2bb0b8ae-4f36-424c-cf7b-08dc434409e3 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Mar 2024 09:57:48.2066 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OHGX7xuDVp9MbvyKU4vio4NxZqPYBhzK9Wqil5Sa1lIH+dyFTt0JCJM4iFF2fqhz8DjtmqUPFDMlDfFoNb3CCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB7657 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 13 Mar 2024 02:57:58 -0700 Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VTTA8kp3OgJvyNbNWGFVpdg5x7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=Qa+CT1aA; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) > - ASSERT (MeasurementExcludedFvPpi !=3D NULL); > + if (MeasurementExcludedFvPpi =3D=3D NULL) { > + ASSERT (FALSE); I prefer the original meaningful assertion instead of ASSERT (FALSE). Adding if-check is a good change to me. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116713): https://edk2.groups.io/g/devel/message/116713 Mute This Topic: https://groups.io/mt/104886876/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-