From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.10890.1676281074418948253 for ; Mon, 13 Feb 2023 01:37:54 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=TZFfmIU8; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676281074; x=1707817074; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=fkJaoYS0A0jGNwIRdo/ManhpwiyhdoXzEypZ+5URVU8=; b=TZFfmIU8AQEuX/QdBgnqJpQR4Qh0/RxJz0qVrfqK9FBJ9AwonhwhdSUb kbxuqCRqYearU9t44Ty5s0lIHlbpeSWykyV9N7eBVHQEc6gPfLqLtl4HP Et9VSl3lImleHFVYmIWnZ7yLTmmfZ/xcCG0xdfRqkFVEpaB3vA7p8owWg X4Sq0OmdsZVXrKWSOPU4WLFnJ1/DsIwXNNjmRGye/x3ILLnoa1VH7+jTf SUujs8vsa9Js4Itq1dDEJn6TYC2uZs4jwT4gTFezahr/RB4vLVOYnQHys tjEVFBFi6fwysDtF5WMksQ2Od4D0kXNr4i7sFX6LVYM+haPT1CYtCUqal Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="358260704" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="358260704" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Feb 2023 01:37:54 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10619"; a="732434078" X-IronPort-AV: E=Sophos;i="5.97,293,1669104000"; d="scan'208";a="732434078" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga008.fm.intel.com with ESMTP; 13 Feb 2023 01:37:54 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Mon, 13 Feb 2023 01:37:53 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Mon, 13 Feb 2023 01:37:53 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Mon, 13 Feb 2023 01:37:53 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DCyGtxwY8bt1ACeL8ZwaziNxyer+OYbjguMZxaO7WPYlnOM6ph2s6K8gxMr0CDUZTyDZsvv7yVToDf8x9GeY0AcgjAFTYWA0zLbrSmzpcqa2ezihNvpMiks2mXbZ4iHuPzUXhuMq5Zr3eu4Rdw0owmOcteeXtBP+nlW/7IEpjaoUi1OWCDpzQ/mu4+BM6Azl2cUeMkVRGwTH2gxLpjVGkcLH6n+gootQbfz9bi5+c3qJRJ2i0KUKFL1P+vj4xqIMWheI5zgTOIWE6VU/01JBsftfDAnDoBMERcl6GFdtxc0p9QmH9eL7CZcFwjbWV7zi9zBrjX/DiYxRr9OCJ+L6Yw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=nn5XXLO0bzjyAGzC8RDY1x5rs1/BHOtfXW7L9Pg538Y=; b=k9WfEQIdxgcoJ98nq53223LyEPWjWzkvGXNV72uI7do6m1U+zbRcW0wzdCxyy+q0bRXzUB2HN/hMIFSqFAS7V2nQEfa3cY+Q0+S4nO5uw7k5Y8JDjZjyffDBcJ69Vi/z4GEJAuvPZIE30lhzqOHrbhExoi0eTNsVfAOZycbr4gU85ZxAabVtglSf2WiK+qkzM7W9SfPPuJjiph1KzqsPax3X7raXnreihv8tynVGbOTMRjx3dUM52JTk2nxXJaOvIo45UNby/TBh3z0HxbKqbDEasJe5z9n5TP+mU+EAPTFlcoedtUtF5K59WJyvp+G5HRNzHxZdOwBUxrsxGc9TwQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CY5PR11MB6390.namprd11.prod.outlook.com (2603:10b6:930:39::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.24; Mon, 13 Feb 2023 09:37:51 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.6086.024; Mon, 13 Feb 2023 09:37:51 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Wu, Jiaxin" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not Thread-Topic: [edk2-devel] [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check SmBase relocation supported or not Thread-Index: AQHZP4dxyb1Pi/rie0uuTItFZkV8sa7Mnoow Date: Mon, 13 Feb 2023 09:37:51 +0000 Message-ID: References: <20230213084417.9232-1-jiaxin.wu@intel.com> <20230213084417.9232-7-jiaxin.wu@intel.com> In-Reply-To: <20230213084417.9232-7-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CY5PR11MB6390:EE_ x-ms-office365-filtering-correlation-id: ed381a25-4b2f-42e4-2206-08db0da5f9a9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kj6N0VAl4LDyK61b0zBmd6M5k5+ijuqkREK1rM0EEP6z27UxTYs7XbXP1DwJcCqsdWEZrpDzXYP7+N2Kdv/aPNRA60iaq9zKrguUAdyLM8Znv1A32GM29mah+Qp3caVpVk5aPUx1/mHpu0Jpz8PcaPmvxU4+jhvAnypdIlfUSO7Qfl9x8Mo2EbNJqNL4JH2cR11hhq4ooUWqRv8dZ6/StM442wQcsRA6+NixO4wtGVjJUYTtDgbDt28SEBmBKMRTEP6U/PzvKcmm0jCAv9uEIOdRBl2NFipv907G47jXCjCiEsDvoCCZ3Of5ASORFaihq1ZrjGl+FzPLOUAiafmc6Tv67UgtGNB5zmQtV20aLfoh0C+ht9T8IknhoyPrhHk6YOO8wOnAokuvVuFn03LwZGFsRyb9U/aZPTAaBhUizgKO2XYLUaRXXbHPyz1PaP7wxM4g0Zu+9XdxIMlnD1i4CKDHwqvtbsBYhUt6Pu3rcWpJZLl8dfFDA5CRvIn4y9SYBwfjnPmZzrtTsgUBbRTRalrUq3YcO5OkJwTfdPQkzCDnhzEwStVLmEs2vhTsB0m84Fom0kL36B0/64J9Oc6PjG20wgbLZy3l0yxnZi2+N/PytJW4E37DM0lf+tFeif6inPf/iSc+KVUKxrT/EHtHDTahew6LLcQsnW79DllMNGbVqvKuv59cUKSQWGnw/g02Dfx5LKZwRcskYzDRzxRNKgq3D8y8DFHXBNzfoSjB5nPiEyxZ4DuMyrdR6EDussMwk64EBavZCRJwM/4k5Ws/QQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(6029001)(376002)(396003)(346002)(366004)(136003)(39860400002)(451199018)(2906002)(5660300002)(83380400001)(55016003)(26005)(186003)(38070700005)(9686003)(122000001)(82960400001)(66946007)(38100700002)(76116006)(4326008)(8676002)(64756008)(54906003)(316002)(66446008)(66556008)(8936002)(66476007)(6636002)(33656002)(41300700001)(478600001)(107886003)(53546011)(86362001)(52536014)(6506007)(110136005)(71200400001)(7696005)(966005)(66899018);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?IKYckLWOAmfHaceFT3LoH7EWywrhcXVk7gG3C/jO/QO2XGy8Igp5Z4tl+JA8?= =?us-ascii?Q?RDAGNWBn2euLbWPdfH7WMyZo/TvAKtmUgtcblS1ajhX0sA3jjN2nCp1bLDi6?= =?us-ascii?Q?v1IT01Nu8hAvy8388J5TkJxDQm9AWNzwRhai8YOdmg+VY54aCuRYEHxtiQ+o?= =?us-ascii?Q?rDH8eX5PLaM21bWuTgQvNLQgtThRDqBeijCuiQOZxOuBFYoT4F/K9+MwPsLo?= =?us-ascii?Q?KAbvW1PI3QAjn5F4Q0mimj4NvtiMLFiyxrEfAVbvayvgxj18yuPe2NcFVBk8?= =?us-ascii?Q?kV1iaZ3ydSLQR2FSZhPsKC/MfjGpok7sRUqDL6zh/bhm9BZekb5uu2R7nIvb?= =?us-ascii?Q?joz0VkUeom/jts6I4T0Ep2gkBp8MnHYrC2RJbPEk0Ny4oHsbw1Xly6vr0/h5?= =?us-ascii?Q?LFY4O2AqX/fAv/3o3yMjWoNx+k5B+M5URVoo8RbDTG9MX/uviCzkMecGGZ4Z?= =?us-ascii?Q?aQ1j3Uki7734P98AFj3U+WOuyfQOAsy0Vk7M8JImpz+phi43n9XkB96DFK9Q?= =?us-ascii?Q?B8J8mSaYqHQ+2no2AhXlC6hIFf+SkCTIyscMyQIK0HZcCF6LDW8LylOpl9BL?= =?us-ascii?Q?seRNgZ9lCoHNUukwZXl8R8BBwKgRdqWDdweXX74tGXdWW1oE6dFtWLPoWiA0?= =?us-ascii?Q?AnexXndAzUmvg6MpdMpjHsxcraFK43vfevLTYtI0cJFsrHKIJqhg9mGCW8uP?= =?us-ascii?Q?lgRSh8pxJJu5XjfdoNNBJMGvsZd0ORLMCoS2eruTKYgC7cvGHQLcVMoQC3ct?= =?us-ascii?Q?d5fUPJmtrmAOuUzBBvanw/0O2ur+3MNq6JnT/wu2ArHfG+zarSNf2szxhCt/?= =?us-ascii?Q?dQy1w5UPnc1jseOSEC3/uxkBvQTVhreU+7J44nhOLI10kQIJmeIHzQUZz8q7?= =?us-ascii?Q?c2rO0Cvaqq9QIcBRK5Yz6JWh/qb8ULmVxR14V/SkswKUAhT6QHGX9ohAOfqm?= =?us-ascii?Q?QRBxEU7dTe6voMWTHtvhZBdSXOcvZ1YuAq2cy7UsyOXliB2lEolYxY9Fs0O6?= =?us-ascii?Q?o0DysvenTFOoSReHZMe9e8JuHjbDdmo2+ghL9K60ynf0fpIyoQCQ32PDjiv4?= =?us-ascii?Q?sOo9cvwL5VTLjCFrsa/8Yd5OKEiz5tBLnZjz3wHfvDY17EfQsZUfSAU4zlnh?= =?us-ascii?Q?4OuhL1YFogbC4wOFYWx5RmNclxBnmig4bslKMsx6BSbLAfYjvMsKQnJwjYim?= =?us-ascii?Q?eZKVfdZFifiEPoa1nBvgDA8a/xj5TaaJLLoZ7ckHnwaAApKew5xwm0yQDpNq?= =?us-ascii?Q?x+uVl6h37WsyWqxwgbeygL6x4HFEdtYv4shf1yWUnrxb48hDlEgOgKiYRaWc?= =?us-ascii?Q?tXuLX1C8JWxVtFcvN0mOU4lyhfoLwKVah7SvcAyRq5xFFUhE2Aj0zqp6YU9D?= =?us-ascii?Q?ZvuijDg8hPHZp3yJbKAexx4rWPqGGujWZHFSczq+arqCPl2ey9PdxLLDB5su?= =?us-ascii?Q?tS7X/qnHIt2/Fv7D3gwXpxLEgY1YsNABzPDTJB3UUcs4Ox3RmqwBz3ukIHmd?= =?us-ascii?Q?BNExMelgi1e/CB/tSt3PeQaDiDSx5NWO8SFNG1rP1lsiWJHtxK2DnO/uGS7w?= =?us-ascii?Q?GG0APy9IsIYebVLisKg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ed381a25-4b2f-42e4-2206-08db0da5f9a9 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Feb 2023 09:37:51.2276 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4sZIIkfFEHmkauAdgR36eIQqqsZJFE6voiGcVlTg1uSwH6U8jTRaScy7JU9ef3zmYvRbCpHAnxjn/5dzu1m0hQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR11MB6390 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I remember both Gerd and I have provided R-b. You can carry the R-B on the patch since it doesn't change. Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Wu, > Jiaxin > Sent: Monday, February 13, 2023 4:44 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, S= tar > ; Laszlo Ersek ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [edk2-devel] [PATCH v6 6/6] OvmfPkg/SmmCpuFeaturesLib: Check > SmBase relocation supported or not >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4337 >=20 > This patch is to check SmBase relocation supported or not. > If gSmmBaseHobGuid found, means SmBase info has been relocated > and recorded in the SmBase array. ASSERT it's not supported in OVMF. >=20 > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Laszlo Ersek > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Signed-off-by: Jiaxin Wu > --- > OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c | 10 > +++++++++- > OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf | 6 +++++- > 2 files changed, 14 insertions(+), 2 deletions(-) >=20 > diff --git a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > index 6693666d04..a1dd10c9f2 100644 > --- a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > +++ b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.c > @@ -1,9 +1,9 @@ > /** @file > The CPU specific programming for PiSmmCpuDxeSmm module. >=20 > - Copyright (c) 2010 - 2015, Intel Corporation. All rights reserved.
> + Copyright (c) 2010 - 2023, Intel Corporation. All rights reserved.
>=20 > SPDX-License-Identifier: BSD-2-Clause-Patent > **/ >=20 > #include > @@ -15,14 +15,16 @@ > #include > #include > #include > #include > #include > +#include > #include > #include > #include > #include > +#include >=20 > // > // EFER register LMA bit > // > #define LMA BIT10 > @@ -41,10 +43,16 @@ EFIAPI > SmmCpuFeaturesLibConstructor ( > IN EFI_HANDLE ImageHandle, > IN EFI_SYSTEM_TABLE *SystemTable > ) > { > + // > + // If gSmmBaseHobGuid found, means SmBase info has been relocated > and recorded > + // in the SmBase array. ASSERT it's not supported in OVMF. > + // > + ASSERT (GetFirstGuidHob (&gSmmBaseHobGuid) =3D=3D NULL); > + > // > // No need to program SMRRs on our virtual platform. > // > return EFI_SUCCESS; > } > diff --git a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > index 8a426a4c10..2697a90525 100644 > --- a/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > +++ b/OvmfPkg/Library/SmmCpuFeaturesLib/SmmCpuFeaturesLib.inf > @@ -1,9 +1,9 @@ > ## @file > # The CPU specific programming for PiSmmCpuDxeSmm module. > # > -# Copyright (c) 2009 - 2015, Intel Corporation. All rights reserved. > +# Copyright (c) 2009 - 2023, Intel Corporation. All rights reserved. > # > # SPDX-License-Identifier: BSD-2-Clause-Patent > # > ## >=20 > @@ -33,10 +33,14 @@ > MemoryAllocationLib > PcdLib > SafeIntLib > SmmServicesTableLib > UefiBootServicesTableLib > + HobLib > + > +[Guids] > + gSmmBaseHobGuid ## CONSUMES >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuMaxLogicalProcessorNumber > gUefiOvmfPkgTokenSpaceGuid.PcdCpuHotEjectDataAddress > gUefiOvmfPkgTokenSpaceGuid.PcdQ35SmramAtDefaultSmbase > -- > 2.16.2.windows.1 >=20 >=20 >=20 >=20 >=20