From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.79654.1682430857830698468 for ; Tue, 25 Apr 2023 06:54:17 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=lHuCOxa3; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682430857; x=1713966857; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=46EhuxSnh2rm54yQRZN8hIjua9lBwk4dADGLuwd9ljA=; b=lHuCOxa351lP8rczEj6v1EAPhwH2Z/C2lgeMNxZBEZbyvc/yNmeXuiy2 W9n6HGm+SzZClThH6QyrO5L4jyeV6dVUnnkeiMLZoyRvn5/UTlsiLcRLT K/M27bbOr18ds3d8TMBUOZ+PrPbETMFLIot9MOo1Mtp/BUhecTaVCVahw O8+K3SI1RkfsB9akyzxOdTUKAGeYMvt6bVza5LKxwqD4c+k7BoF/VhwrN BGnrDCZzZDck6xlpmMQmbwAF929MfdsqBZL9uUreeECmfOhWQUJwo/UAi su8PafnlPwnvLlwVO/NBOtzeq55pqFbO47mBFVhUpfgeNzCswNP/K0QMo w==; X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="433032032" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="433032032" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 06:53:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10691"; a="805077782" X-IronPort-AV: E=Sophos;i="5.99,225,1677571200"; d="scan'208";a="805077782" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga002.fm.intel.com with ESMTP; 25 Apr 2023 06:53:50 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 06:53:49 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 06:53:49 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.46) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 06:53:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ONu/bj1TMd8HKvOUJwkJyGDHkbIkXLJGGtycQLxMvPIgO4qIEi+i+RILwbaxstU8AiZFEN2ndyWy+sb5QOX590dSWr8jzv+yK+1OjNuZhj6T8P9HWIGHKVQVmrsboPGApEpX8jGhfwD3oZq21Q8cMxKdArTf4xOw/suyEfzVoNb8tAhfFhhAdNic37iDipZWxW8q4sde6fijf2/9qWroMr6qqx8LSRTAm4NAVMOJdJ27CnXXqhTqzC/Hx0XEnq1nRsxA/MbOGLctu//54Z/xfuZqkcZ0OS4KGojBrCx7yT6EvI0gw1q79LrU2G7YvlQppn+e+51IplnqqgRSi5DV5A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HHUat5/1HhuTiaLLuzrUWCSGJ98WQDysYsmCZNbigKE=; b=lbxnjyuM3wm0OKRZTF3/b+JO0y52Tzxel0GSvj+yn6O3OzG+wq0XUUbJHZbJVvs3ma9o0Qxb+r0l57lSYQWsuVRBM+xiS3FoQozbyCaafeyCCAnxFRy4QRcFuO58UMk0m5MnKFYTVHle9NZaAXTrpGdWELWU+cg3qdIF63AMi9C7TZNIM536K0IW9ku0IQeaT7MFThOxsyRBYCXYCJvHDbbQjExChRjMwQ1+icuNRn+abPK6NI88cHUUGLItMDUCqnDe4fCmseyTDrZoreqVin9WjcvOhcICl7nquMZ5acMqkRa3X6xv3ChVUit3mcazfn7ZZrba9PP/zdboZDQkMg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB6373.namprd11.prod.outlook.com (2603:10b6:8:cb::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 13:53:48 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 13:53:47 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Liu, Zhiguang" CC: "Desimone, Nathaniel L" Subject: Re: [edk2-devel] [PATCH 2/5] SimicsOpenBoardPkg: Move AcpiVariableGuid hob to MemDetect Thread-Topic: [edk2-devel] [PATCH 2/5] SimicsOpenBoardPkg: Move AcpiVariableGuid hob to MemDetect Thread-Index: AQHZd0QT3pyWpAl2J0mbPHxm9EaXza88DCOQ Date: Tue, 25 Apr 2023 13:53:47 +0000 Message-ID: References: <20230425070304.2120-1-zhiguang.liu@intel.com> <20230425070304.2120-3-zhiguang.liu@intel.com> In-Reply-To: <20230425070304.2120-3-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB6373:EE_ x-ms-office365-filtering-correlation-id: e342fb82-440e-4783-f748-08db45947e3e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: riB+ZFTZfYjjYNytrDOzCuk0KE2uo12m9RPm0jJr/62LweNH18hpFNIbgMC19HF5rIupHeGWGxfEj8ChVidK3GW72ylgUUVKQRZ8XbgB5+/lEQj0bBhfT+5k6P81zYpe8At6pjXjCaaDOYL0DlGKOJ6BXtY408JorTA1l7qWm2nOwLbfsBQYSzJpAA6TDn5xkVfoqTVO4z/R9crHHcFz7K7faxG8Wjx2MGZmZvzLjx0q9nnVfLgHgvEf8dhXprbBgPw6ajFx3lPCi+Z/DJ6n5gpLF3AJCzI6dSHxvnnSJnjqWepU6dN7TCDBdndFL/dseDqppEN/7znqyUhxknyEaknLUitHUcMT2JS2EApObTyNM5Msrx9v5VRNPETKSPDg42DYc6jioGeKrIFqVk/6q+1WQu/zj0lPH9mT9NeNN6qrnW84E0r/Y1hN+CwYnDZmXHdB6dGx16HT2ziqU4EiYClePxXwvMISePhWfGZtRtqsG4zJIaEIIfWxomfJHs9UFHWxWzXVzC2ijic5wCag4dpfIU9XQxzlZZk6rOjG98KJp8Augno395pq+cKkk5MPR5aNAp7TPC2Auyi2LhpJLiR/H8M0j16soQAb3pRlApdbgOmFXmRjm2GQRbf7jwdSBm29S6DHiXf25CFf9DhhnA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(376002)(39860400002)(346002)(366004)(396003)(451199021)(966005)(38100700002)(122000001)(82960400001)(6506007)(9686003)(53546011)(26005)(55016003)(186003)(83380400001)(8936002)(107886003)(33656002)(2906002)(8676002)(52536014)(5660300002)(478600001)(7696005)(38070700005)(110136005)(316002)(71200400001)(4326008)(6636002)(66556008)(76116006)(64756008)(41300700001)(66446008)(19627235002)(66946007)(86362001)(66476007)(66899021);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tDvGLYwMtggN4q7Sl/uKczaJFEJF36fvHxsfHk+vLzJF4VDYfg6MaxJAOFbP?= =?us-ascii?Q?GoAF9juu08SXx265JfYqTEmrrPW2U66WinMkqJXuR8fbQ3pFo8PtKNNbIKS0?= =?us-ascii?Q?9Rws8BvNAGOORkIjqOqPB10tvfapD/O73Ho11Z96XT8Q7Sq1pT0J/v7qg561?= =?us-ascii?Q?GtKNuP6Sq0t79fUEW4ieB08Nm4GCizpmLbcsxDhKrLmfZhDZBLqnr4tPSah8?= =?us-ascii?Q?X+IjzxZp95bUqeeEF2c/1Mmmp35utumj2GBzEUmrzzczoiaarvfIx4Qx2pVt?= =?us-ascii?Q?nXhzks/Vqn03cXjsGaWkaGKPSo7HwNbVrS6OcFggROKcwrlnKy2hD8iUL5Je?= =?us-ascii?Q?iMivSnLLyxH5EMaBSFk4w5z0iHZEBB4x3Ksp9G2WYMTKL6cfDaHzeBWw6VFQ?= =?us-ascii?Q?+LbxlETAXcsH88/mzaESximLLSJiwY1GRxR7luIKMqZZ7MYcfB4dK/TnffSo?= =?us-ascii?Q?wF4agrsJPFMDl+Fl08FjHHPW7YMI8R2P4uFk2D0s1aw1OEfbuWhiAZZ5QCEC?= =?us-ascii?Q?9x029CrJMWp9JCfaVMiim5CE47TzR8+RAk1i0y9pcTmYoQtIC9r9lWO3yUWn?= =?us-ascii?Q?IOnLzxJ46Y0KqJmTSxwRhNgo+0pVJnv0GRjxEUxkK3UEHPjyuAhKFSKf2mIV?= =?us-ascii?Q?c7kEo/MUcwt0wx1nPitk9zSolW/h6bgsY6e8Ocp9oBopvaRScnwF9gWQeADh?= =?us-ascii?Q?YLW+awtbtc/ALq2rOD2dhEIAwfF7AFbn1YCDUVx+6WiKxF3r/+cA1iSOkYbQ?= =?us-ascii?Q?3PoU66lnORE/l9TBmM9XEhOtbl1c68n1pUaGQDar/Rmc3vmkZ5/LC6suMytx?= =?us-ascii?Q?uSIMkjqhO4pGf0UC9bmge83uzljo6iZi+hkhV7flUxLpe17d1mzn3KRDQIIO?= =?us-ascii?Q?CZCXoO8JQgofCOUYJ8A7JKxOHslAjhyH0z5qF3yx7pgdRmX4kMLyabZio2sm?= =?us-ascii?Q?a9g4XwaDP/pQnMhKG5GwDNA0I22xntXW7T+8UbhtiKWboouvgtfVc5t8DmEX?= =?us-ascii?Q?WoA/O3fsw5C7iSo8+YxYsR9L9sfwd3OAeEqenHCOd2ZYjP/jyBej/SCoaX0z?= =?us-ascii?Q?gNwW04rcQ56FPego+oQpr9wYuXgVwnY5UgIyXu/+D1cYvxIdFrXT1btqiti1?= =?us-ascii?Q?yvcW9ZUkTjQF/jUsL45GN7fTLOFSBeub3Dbe3zvE6HwHqWH5mH2b2nP+4+cR?= =?us-ascii?Q?gZeEN7xDcJlhicyv73CNt6nNfEC91WkHGp1oWdWIfCy4cP16QoP4ihDNInNZ?= =?us-ascii?Q?thQcJkGCXAifPoq6vahAUnAyWHSd+ehyP2bY3EXvAGVNR2ZabaM6prOtXA23?= =?us-ascii?Q?vcOcvEQ6tXZQnMya7b5IyT9LaVkJvEPAw35/pA/5bALYpRAoHoQfqAkqiHGm?= =?us-ascii?Q?6W4kyJuBuizd1oiz9WQBmjuPKNGMvcVaHjAYVtSL+yuCQLXXiFJRr5lEHWlK?= =?us-ascii?Q?fcS0d/oUqkiS7/6o673Re/v/bbLhG3mDPtZTZ8runmRBoe/kbIu8talZpx75?= =?us-ascii?Q?3Ac/zmUebgBul8+br6EG2I3Eik//X+MwgvSKrFWRfXKcL0OSEd/ag/0SIhQV?= =?us-ascii?Q?1XxEe6NlNt8VxZh3iTtuNISGFmyMMWCDrGJKe8Pl?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e342fb82-440e-4783-f748-08db45947e3e X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 13:53:47.8070 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: LeHUo0t4r6BduxS+63ZYpfxnaf8rdRT0A7dFATne2j8BpPAj9t3RABAIWzbkVMcl4MjXK6mlMK9XxephGVn/pw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6373 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Zhiguang Liu > Sent: Tuesday, April 25, 2023 3:03 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathaniel L > ; Ni, Ray > Subject: [edk2-devel] [PATCH 2/5] SimicsOpenBoardPkg: Move > AcpiVariableGuid hob to MemDetect >=20 > Currently, MemDetect create gEfiSmmSmramMemoryGuid Hob containing > one > descriptor, which should be updated later, when AcpiVariableGuid hob > use some buffer from SmRam. However, the Hob doesn't get updated, and > this is a bug. >=20 > Move the logic creating AcpiVariableGuid hob from PEIM SmmAccessPei.inf > to MemDetect, so that in the same file, it has both knowleage about > the smmram and the acpi data structure. So it can create the > gEfiSmmSmramMemoryGuid Hob containing two descriptors. >=20 > Cc: Nate DeSimone > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > .../SimicsOpenBoardPkg/SimicsPei/MemDetect.c | 36 +++++++++++-------- > .../SimicsPei/SimicsPei.inf | 1 + > .../SimicsX58SktPkg/Smm/Access/SmmAccessPei.c | 8 ----- > .../Smm/Access/SmmAccessPei.inf | 3 -- > 4 files changed, 22 insertions(+), 26 deletions(-) >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > index d80ac1d213..13ee415f40 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/MemDetect.c > @@ -391,11 +391,10 @@ QemuInitializeRam ( > UINT64 LowerMemorySize; > UINT64 UpperMemorySize; > UINTN BufferSize; > - UINT8 SmramIndex; > UINT8 SmramRanges; > EFI_PEI_HOB_POINTERS Hob; > EFI_SMRAM_HOB_DESCRIPTOR_BLOCK *SmramHobDescriptorBlock; > - UINT8 Index; > + VOID *GuidHob; >=20 > DEBUG ((EFI_D_INFO, "%a called\n", __FUNCTION__)); >=20 > @@ -418,8 +417,8 @@ QemuInitializeRam ( > AddReservedMemoryBaseSizeHob (LowerMemorySize - TsegSize, > TsegSize, > TRUE); >=20 > - BufferSize =3D sizeof(EFI_SMRAM_HOB_DESCRIPTOR_BLOCK); > - SmramRanges =3D 1; > + SmramRanges =3D 2; > + BufferSize =3D sizeof(EFI_SMRAM_HOB_DESCRIPTOR_BLOCK) + > (SmramRanges - 1) * sizeof(EFI_SMRAM_DESCRIPTOR); >=20 > Hob.Raw =3D BuildGuidHob( > &gEfiSmmSmramMemoryGuid, > @@ -430,18 +429,25 @@ QemuInitializeRam ( > SmramHobDescriptorBlock =3D (EFI_SMRAM_HOB_DESCRIPTOR_BLOCK > *)(Hob.Raw); > SmramHobDescriptorBlock->NumberOfSmmReservedRegions =3D > SmramRanges; >=20 > - SmramIndex =3D 0; > - for (Index =3D 0; Index < SmramRanges; Index++) { > - // > - // This is an SMRAM range, create an SMRAM descriptor > - // > - SmramHobDescriptorBlock->Descriptor[SmramIndex].PhysicalStart =3D > LowerMemorySize - TsegSize; > - SmramHobDescriptorBlock->Descriptor[SmramIndex].CpuStart =3D > LowerMemorySize - TsegSize; > - SmramHobDescriptorBlock->Descriptor[SmramIndex].PhysicalSize =3D > TsegSize; > - SmramHobDescriptorBlock->Descriptor[SmramIndex].RegionState =3D > EFI_SMRAM_CLOSED | EFI_CACHEABLE; > - SmramIndex++; > - } > + // > + // Create first SMRAM descriptor, which contains data structures use= d in > S3 resume. > + // One page is enough for the data structure > + // > + SmramHobDescriptorBlock->Descriptor[0].PhysicalStart =3D > LowerMemorySize - TsegSize; > + SmramHobDescriptorBlock->Descriptor[0].CpuStart =3D LowerMemorySize = - > TsegSize; > + SmramHobDescriptorBlock->Descriptor[0].PhysicalSize =3D EFI_PAGE_SIZ= E; > + SmramHobDescriptorBlock->Descriptor[0].RegionState =3D > EFI_SMRAM_CLOSED | EFI_CACHEABLE | EFI_ALLOCATED; > + GuidHob =3D BuildGuidHob (&gEfiAcpiVariableGuid, > sizeof(EFI_SMRAM_DESCRIPTOR)); > + ASSERT (GuidHob !=3D NULL); > + CopyMem (GuidHob, &SmramHobDescriptorBlock->Descriptor[0], > sizeof(EFI_SMRAM_DESCRIPTOR)); >=20 > + // > + // Create second SMRAM descriptor, which is free and will be used by > SMM foundation. > + // > + SmramHobDescriptorBlock->Descriptor[1].PhysicalStart =3D > SmramHobDescriptorBlock->Descriptor[0].PhysicalStart + EFI_PAGE_SIZE; > + SmramHobDescriptorBlock->Descriptor[1].CpuStart =3D > SmramHobDescriptorBlock->Descriptor[0].CpuStart + EFI_PAGE_SIZE; > + SmramHobDescriptorBlock->Descriptor[1].PhysicalSize =3D TsegSize - > EFI_PAGE_SIZE; > + SmramHobDescriptorBlock->Descriptor[1].RegionState =3D > EFI_SMRAM_CLOSED | EFI_CACHEABLE; > } else { > AddMemoryRangeHob (BASE_1MB, LowerMemorySize); > } > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > index 710fa680be..618ad4075f 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > @@ -40,6 +40,7 @@ > [Guids] > gEfiMemoryTypeInformationGuid > gEfiSmmSmramMemoryGuid ## CONSUMES > + gEfiAcpiVariableGuid >=20 > [LibraryClasses] > BaseLib > diff --git a/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c > b/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c > index c54026b4d1..d489cc7513 100644 > --- a/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c > +++ b/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.c > @@ -241,7 +241,6 @@ SmmAccessPeiEntryPoint ( > EFI_STATUS Status; > UINTN SmramMapSize; > EFI_SMRAM_DESCRIPTOR SmramMap[DescIdxCount]; > - VOID *GuidHob; >=20 > // > // This module should only be included if SMRAM support is required. > @@ -322,13 +321,6 @@ SmmAccessPeiEntryPoint ( > } > DEBUG_CODE_END (); >=20 > - GuidHob =3D BuildGuidHob (&gEfiAcpiVariableGuid, sizeof > SmramMap[DescIdxSmmS3ResumeState]); > - if (GuidHob =3D=3D NULL) { > - return EFI_OUT_OF_RESOURCES; > - } > - > - CopyMem (GuidHob, &SmramMap[DescIdxSmmS3ResumeState], sizeof > SmramMap[DescIdxSmmS3ResumeState]); > - > // > // We're done. The next step should succeed, but even if it fails, we = can't > // roll back the above BuildGuidHob() allocation, because PEI doesn't > support > diff --git a/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.inf > b/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.inf > index 2b6b14f437..3c71e64fe9 100644 > --- a/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.inf > +++ b/Silicon/Intel/SimicsX58SktPkg/Smm/Access/SmmAccessPei.inf > @@ -38,9 +38,6 @@ > SimicsX58SktPkg/SktPkg.dec > SimicsIch10Pkg/Ich10Pkg.dec >=20 > -[Guids] > - gEfiAcpiVariableGuid > - > [LibraryClasses] > BaseLib > BaseMemoryLib > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20