From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4F5FEAC049F for ; Wed, 29 Nov 2023 00:56:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=grhpQ3HGbnzk/aGlY6wTEvwMTbJ5ZJni/ykp9onls9Q=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701219376; v=1; b=HGUshL96cd8iIUIb02TTfC0/8mXpllH2EhBTpy5ejytKyTa0az5na/0ifjGhrJ8DpmDMnXQT f/yt4fxTQx3vyi+HZXp/17LZVk+wchzd2NmVgxJUbGx102iiOSD3AlTI3AwY0NbWLRtd1Akg6og B2dw8DmrQaHG6eP8o6rddiJo= X-Received: by 127.0.0.2 with SMTP id uOimYY7687511x5gOAPZhJlU; Tue, 28 Nov 2023 16:56:16 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.16070.1701219375841276766 for ; Tue, 28 Nov 2023 16:56:16 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="383456288" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="383456288" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Nov 2023 16:56:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10908"; a="768725807" X-IronPort-AV: E=Sophos;i="6.04,234,1695711600"; d="scan'208";a="768725807" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 28 Nov 2023 16:56:15 -0800 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Tue, 28 Nov 2023 16:56:14 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Tue, 28 Nov 2023 16:56:14 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Tue, 28 Nov 2023 16:56:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GEektZ1Iv3b8AKp9Y9oBQyKNDUVff7EFx+rRk3bs7yNkmRXXwOj2h3iYa7+360A+8hLj3vzacBsz/fKo6yL6ZsLt0ppjdMpLaFGUX2TDjRr7F+oiGC7sekLjiJDQINbrclrqE5IRuAqBy2KMBQrUhtZ6NfGm/EOOMc1ztOEyXV4ykaOJwCgXj4tBf5ljUDZI5ySws6nnhQ9077DRsGXz69NFPgfTW+fGAF6/t/rgIt5gmdsF+DJTDflc0MvdoOOGxPiaD2Kss8jvwryp+42DnQn3mm6pjWTW51jdM8hYfAg9P1HpeImCzmj8nXXJmErv/B/7FnQJYvI81QvRXsVD1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J/9VL16HBJc2uEPkCPzXPiOZf9RP8CKRI1KsRMJG/Fk=; b=CmD7yLHBz84NQha22dVr/4pOL0p8hkfHt8hWf4jTHbaEf/UzvkWZCPU50dd50U9a+it+Mi5UhQY8jtTUbD/hzUIjWyWHs2ZUZTIdG8cexbZ3coMCrcL2Ue15kkNeIPvS8L1C4pgAKOnKNjCAm1UlcbPNrKkFzqSSfV83atOpDYl0VlT0aAxHs/2FZwb7uJntMOajwlCSPNxoOxg4sjW5sgqOPf/e7Q1vlGVFyGcMA/W7V9JMAY3UoajZBCmOz0ha70MpcLRlSeCN+S1uRZHxFr7WddYgyZVeefqXW5FFOanxuisEDE74w+tTGSZvPDAORnxz1tsALMNJJevbBvaOYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB8591.namprd11.prod.outlook.com (2603:10b6:610:1af::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Wed, 29 Nov 2023 00:56:11 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7025.022; Wed, 29 Nov 2023 00:56:11 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Chen, Christine" , Pierre Gondois CC: Rebecca Cran , "Gao, Liming" , "Feng, Bob C" , "Sami Mujawar" , "YeoReum.Yun@arm.com" Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Topic: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-id Thread-Index: AQHaHUZt4TVZbx8oH0OpOpEDrsh8R7CQefEAgAAJF6A= Date: Wed, 29 Nov 2023 00:56:10 +0000 Message-ID: References: <20231122131444.1885823-1-pierre.gondois@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB8591:EE_ x-ms-office365-filtering-correlation-id: 78317f85-792a-44ef-4ab4-08dbf075faa8 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ltLEGqwEHgtKvtxpIUAM38VUJjwiZNBfBi0hMiTmHJbnygANu1vTj8VSsNmzWGOq4BlFczEdrZzlBdOMRIWb1O3x3yfRtCvOsrfWTQ4hjhJj4XHcrR6ACNj7tJD/0m2XXJOJ9WnlHCd5QY9jfMq/htDS7cb6SqPDZZyiYKS+YPtbR0rKH366/IvVYZI/vse97X2W3d3mnsbR+ZfAVnVftQrsxqssn+iAnxCUuAx3sSTticzC7+AsQebrA5F8tPLGXD2KTdFOudn7yKAjJ6cOAp162YQJz03sBST6s6+MG9NJ4jxn1iyYC6Jq2JtDiyONVveDyUKjXJJXIN1lowf+oj4yEO9Os1hEQRzCLEWO5GmC5sn9AS+t7RigDGaNNMaJbBiYukG0kiNBWglqu/iOFSSv9WGQ4b9bKYK11F91Qgg17PkS/dPr8fgxOxDhvjS2Df1/9aT3Mjcs3A5nCHR/wGpKcBAZzPqiIHaYZ/cgvcZnC5x85HQ3ZwUjGUhnW+BhJE7xZxCqlAcqHJfyYT4gkqGhVyQ4gpwAENGotYck9Js3R7OczQVptACbet/Zm2Eff9hcOpboQMDAAjag7QE80P0/eqPaxCjdOPRz0vaAvC8hRIgUnxsEJdVxqnluD7oSesPvfRzWdXbtFMbemF8OiYbz6x9gwWsuYt1FHG90+q5j8h68W6Ok2DsmMCStW2oP x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?Ms5IgQl+4Qe5jhTcKjI4c1R1mexBULBLv5WgRZ8n21zmGnSBydIGIAXt30TT?= =?us-ascii?Q?KFc0i5MHL9oItpSngTClCpQu0uLupi/yBCadURfR6PoJIRZMZuFb7zejZNVa?= =?us-ascii?Q?UUcFOpj4J46nHqW/O5cahF3ebpGMUOeF6nO8+lGQjiXE7CO3dJVVrtjbyKfm?= =?us-ascii?Q?/m6NdoZX4oJYar3VGwGkmyrqzWIrUuV9W2aMA+1x+pKYmctamQ0Ec3qR85/V?= =?us-ascii?Q?3ckDFFr15QlI05UEMJ/3QPzWBu6Kgd5fFH6hCIZeLhRaFUSOk0pY2/OIF0Qf?= =?us-ascii?Q?sOOYG+7kUlw1G1TY1N/cYQRyNEwlizQ11Hjft1l8vwQ4Td3iyHvJ+yI+v9Ua?= =?us-ascii?Q?l/gg+TvKB8UKP7OF3fLfWYjOz/VlScWWjg6ddzg2yRlj+A0eQrAdULbXXz/T?= =?us-ascii?Q?NVBjr7a5dYafqovc8ddgyxB7uhn6eddQOXNj0uv9DW0W2VEZeYpsqF/0LT4H?= =?us-ascii?Q?+iw3pPggMAHesKXGIKCTIwssL9/LBdR6eY8giQOu4WmOPZjdzTXQ4i7aLTd8?= =?us-ascii?Q?nn1VZF6MtwmK7Bno89VeRwKro/aOBrFqOy5UQ/nzmTs2IzJTSDL//+Yzp+1l?= =?us-ascii?Q?bwhYsUIH4jOui4qTaH6ZnnF6wOafFZmEIkrhbuwOx0xQyr4qi87ybMi4r04i?= =?us-ascii?Q?T4RAxZaDgTo1gOETmhitwhc9kH4kfQv2/Y2SgCrLQZj4tqJNGBkmmZ4P5Qfg?= =?us-ascii?Q?q+5woeUrHWaHNCRH+MVsloTZ7ZveOHi8RN7PMl4bedqltIdT8bz81pFEsl3z?= =?us-ascii?Q?TVOX4g/+IvRKglwFa2aqnkDsBdMygusSqVtGvVXG/B6oG5MLW4xymjvQEqW9?= =?us-ascii?Q?LyDz3JfMBbOv6MgkeZv5xhrd3nX0arX8Lv4N3vonxi0AiUsBOX3rN5vK0vsl?= =?us-ascii?Q?iEGIsgfHFQ5+XXoh6bCcpKvqJgGaVZB6/BOzEqTmgfpalaEUMX0udf6hNAaf?= =?us-ascii?Q?fM7LVuVvKzSOhzZ0PFKoa0GjUYs0TuaqWoQ2dmtrOmVq3IDoy87Q7ZH6HGdT?= =?us-ascii?Q?PqNat9BzhAeyG6FFndj6a0I/vJqxmpREP7FKEHXAhdLYDv+IWQxNEOdt4zCn?= =?us-ascii?Q?s6nzK1Vt20TPdNZStAuBdm6Az/oeNUTXgz05B7YUve5xeshxC+iMQJAfhOjv?= =?us-ascii?Q?fPf0gJRMu2SMuMZ9xLyY6rN9h4rFJb1JfUJxIEE9Jt6ENA/HVWLLVMnHIdz/?= =?us-ascii?Q?6JX9Ujj1Gu+kfvW8MbMhB7wOFpNUef2yr8KjYaK6AtGGXtQsy7ljnZStUVZQ?= =?us-ascii?Q?JPn4t84McVhqaHyWiHojAr/A4F3bCSmamVe12shYtiKviLkZaydfDCcEVctK?= =?us-ascii?Q?Sz5hi2PJNNi+1brsNEOhgYl6w0Hd6+aw9wchW1zFQJHOxMxjjqvCJFTdgqql?= =?us-ascii?Q?FFdPF5hxExchzlVOdy6JUPUZwelqJqVRiepz9vmhIt1WOcYFNm+sSK1rCdyz?= =?us-ascii?Q?h7+fwiSFtvoegQfQ7qPLT+oTI384LRDZ56JAo8a7qo3mVyxY2DR/Y6GpEswJ?= =?us-ascii?Q?B0b9THKF5OL3MDftcw1bjBYSzPOQ+X2LPIVF4xNe5fPBFX9eN2NPTmMel24n?= =?us-ascii?Q?pT0H/XUKS2dmzmVYF5U=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 78317f85-792a-44ef-4ab4-08dbf075faa8 X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Nov 2023 00:56:10.9985 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Y8RtgPmQ6cF2lH/jcUxqPntweh76S6aqpdX0PAYVdxwsbca/Lk4cZVxVsZ6GkKqLaPCxQ0APevR3O2Ng3FYjfw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8591 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5M7Qw9Bh2EBpfViJaN97NfSyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=HGUshL96; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io It's good. But I am curious why --ignore-change-id is needed? Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Yuwei > Chen > Sent: Wednesday, November 29, 2023 8:23 AM > To: Pierre Gondois ; devel@edk2.groups.io > Cc: Rebecca Cran ; Gao, Liming > ; Feng, Bob C ; Sami > Mujawar ; YeoReum.Yun@arm.com > Subject: Re: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: > Check for Change-id >=20 > The patch is good for me. >=20 > Reviewed-by: Yuwei Chen >=20 > > -----Original Message----- > > From: Pierre Gondois > > Sent: Wednesday, November 22, 2023 9:15 PM > > To: devel@edk2.groups.io > > Cc: Rebecca Cran ; Gao, Liming > > ; Feng, Bob C ; Chen, > > Christine ; Sami Mujawar > > ; YeoReum.Yun@arm.com > > Subject: [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check for Change-= id > > > > Code review tools like gerrit might use a 'Change-id' tag to track the = evolution > > of patches. This tag should be removed before submitting a patch to the > > mailing-list. > > It has been observed that contributors sometimes forget to remove this = tag. > > Add a check in PatchCheck.py to automate this. > > > > Also add a '--ignore-change-id' command line parameter to ignore the ab= ove > > check. > > > > Signed-off-by: Pierre Gondois > > --- > > BaseTools/Scripts/PatchCheck.py | 18 +++++++++++++++++- > > 1 file changed, 17 insertions(+), 1 deletion(-) > > > > diff --git a/BaseTools/Scripts/PatchCheck.py > > b/BaseTools/Scripts/PatchCheck.py index 7f372d40b570..7770d1e37318 > > 100755 > > --- a/BaseTools/Scripts/PatchCheck.py > > +++ b/BaseTools/Scripts/PatchCheck.py > > @@ -3,7 +3,7 @@ > > # # Copyright (c) 2015 - 2021, Intel Corporation. All rights reserved= .
# > > Copyright (C) 2020, Red Hat, Inc.
-# Copyright (c) 2020, ARM Ltd. A= ll > rights > > reserved.
+# Copyright (c) 2020 - 2023, Arm Limited. All rights > > reserved.
# # SPDX-License-Identifier: BSD-2-Clause-Patent #@@ -26= ,6 > > +26,9 @@ class Verbose: > > SILENT, ONELINE, NORMAL =3D range(3) level =3D NORMAL +class > > PatchCheckConf:+ ignore_change_id =3D False+ class EmailAddressCheck= : > > """Checks an email address.""" @@ -111,6 +114,8 @@ class > > CommitMessageCheck: > > self.check_signed_off_by() self.check_misc_sig= natures() > > self.check_overall_format()+ if not PatchCheckConf.ignore_ch= ange_id:+ > > self.check_change_id_format() self.report_message_result() = url =3D > > 'https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message- > > Format'@@ -307,6 +312,12 @@ class CommitMessageCheck: > > break last_sig_line =3D line.strip() + = def > > check_change_id_format(self):+ cid=3D'Change-Id:'+ if > > self.msg.find(cid) !=3D -1:+ self.error('\"%s\" found in com= mit > message:' % > > cid)+ return+ (START, PRE_PATCH, PATCH) =3D range(3) class > > GitDiffCheck:@@ -780,11 +791,16 @@ class PatchCheckApp: > > group.add_argument("--silent", acti= on=3D"store_true", > > help=3D"Print nothing")+ group.add_argument("--ignore-change-id"= ,+ > > action=3D"store_true",+ help=3D"Ignore the pr= esence of 'Change- > > id:' tags in commit message") self.args =3D parser.parse_args()= if > > self.args.oneline: Verbose.level =3D Verbose.ONELINE = if > > self.args.silent: Verbose.level =3D Verbose.SILENT+ = if > > self.args.ignore_change_id:+ PatchCheckConf.ignore_change_id= =3D True > > if __name__ =3D=3D "__main__": sys.exit(PatchCheckApp().retval)-- > > 2.25.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111832): https://edk2.groups.io/g/devel/message/111832 Mute This Topic: https://groups.io/mt/102748141/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-