From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.106.1680836954985002307 for ; Thu, 06 Apr 2023 20:09:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=cmvlJpcu; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680836954; x=1712372954; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=/+dY7fHTX7rvoB9db/OtaxpozwyHPrqYCZ9amtb0G6M=; b=cmvlJpcuCHNk6WJbzrnhaBjUyD6e4aAzkcjAZhyAd52W4bgzgPcZFe0u xWoQZ/zlqOE/Ygad/usjILuy0FRPWF6THHgYHjq8KgkmNx1x1YKWggMLg xjO/lcesnmB0fqCmIzSRi2vj73DBa12L58hmn0Z1ikqM+FrL1mXCzf+0p fN1BoyOfxDcUWNaEz1mZLjkqZkjxMTchE3MdIq2kWOMWiTs2s8REAKzX0 5bbwo8hyl19FP8fLJjoYAYtb2uX08ER2eboVnHsZHb4ON7UyWHoRbYuY+ 6GZZFuIYlfD/MtTYnPnqPq7/hWX6u3oEwr8Plitem+ns5PNCztweKyccD A==; X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="429205189" X-IronPort-AV: E=Sophos;i="5.98,324,1673942400"; d="scan'208";a="429205189" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Apr 2023 20:09:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10672"; a="933455295" X-IronPort-AV: E=Sophos;i="5.98,324,1673942400"; d="scan'208";a="933455295" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga006.fm.intel.com with ESMTP; 06 Apr 2023 20:09:11 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Thu, 6 Apr 2023 20:09:08 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Thu, 6 Apr 2023 20:09:08 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.107) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Thu, 6 Apr 2023 20:09:07 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RYCA0uG93NcUMXwuV5xi36Q8leFHTOkIQ/dcLmSE29DNfTHm3+ITTQCmtpO5lilbRylwcZ00eApF2S+OLJx5+MCLYmMJzbWriXQsTh8cFgZPmVuZxDqAzfQP9ZBaiyqwMFFsp1I9uvgSEmH2cySIGbjNpseG9nVVRmoIc2I62L7ALT1yMcS4sJr2p4OPqncvv4QqvdhEorMYHSAixCOHfaP4X+fepNZMyOVP9THpfW47Myb781ITDtAACrkSDhqotIc9D4lYWdwRvkm7XI0J10CzizmxeEmVcfqX4/VbqxiKyRN6C97/8AXKks8G4P/sjxQZr7J778kuDjuWV9hxhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YDrln/OiOlI536EeL6MfMDnwAoFpqPdRTvLO23n10LA=; b=Mfls5etvFmS+U7cHDiE9IYm0E9y8aObVv4s/XMKlZGm0OZKAsmXt4J1DY5fSx1fwclMEQL1iyfHW4XBd/Txlr+sftmdFzzaboQ1iYicS/AbP/imQ7h0NXc7yryVIhfWMRq5i9RShE+LOYMWh7XSPWCf/SfPwRd+m1P95PrTl6KP6mKeFKkT0q7JuatPwBjKSTmVVgoTBxvWk2oAKqsqDHBDPCWzg9BITG2qQ9EwdqaFvDU6yQPg0cuAD3pPf4Kak8Sb626knm/DlzRj0CzKRe/5TCNGdkWBfthtq+NUS4W5Z8zmJlPPIb1lCb/ICBebOLkCLkbih4oUtR8B6o8pZBQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by IA1PR11MB8245.namprd11.prod.outlook.com (2603:10b6:208:448::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.33; Fri, 7 Apr 2023 03:08:56 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6254.030; Fri, 7 Apr 2023 03:08:56 +0000 From: "Ni, Ray" To: Rebecca Cran , "devel@edk2.groups.io" , "Gao, Liming" , "Kinney, Michael D" , "Jiang, Guomin" , "Xu, Wei6" , "Dong, Guo" , "Rhodes, Sean" , "Lu, James" , "Guo, Gua" , Andrew Fish , "Wu, Hao A" , Maciej Rabeda , Siyuan Fu , "Yao, Jiewen" , "Wang, Jian J" , "Lu, Xiaoyu1" , Ard Biesheuvel , Sami Mujawar , Supreeth Venkatesh , Michael Kubacki , "Desimone, Nathaniel L" , Sean Brogan CC: Leif Lindholm , Abner Chang , Nickle Wang , Igor Kulchytskyy , Daniel Schaefer , "Xu, Min M" , "Justen, Jordan L" , "Gerd Hoffmann" , Peter Grehan , "Aktas, Erdem" , James Bottomley , "Tom Lendacky" , Michael Roth , Sunil V L , "Warkentin, Andrei" Subject: Re: [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__ Thread-Topic: [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 compliant by using __func__ Thread-Index: AQHZaNaWqN9RnESc4UuzwX5nIHtC368fKtpQ Date: Fri, 7 Apr 2023 03:08:56 +0000 Message-ID: References: <20230406222319.2281263-1-rebecca@bsdio.com> <20230406222319.2281263-16-rebecca@bsdio.com> In-Reply-To: <20230406222319.2281263-16-rebecca@bsdio.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|IA1PR11MB8245:EE_ x-ms-office365-filtering-correlation-id: 3fc2754e-e25b-442b-f445-08db37156cfe x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: I0hIug2020KHWhs9sf66HUbvlV65LbCwGycUIO+cxHyoVOPe11WmS2SPzpyr3/zOCFD2DBQSij1ogwlkubIcud1CAWc6575LTVD5ut01MhoxswWOmtA+ykLq8HV9dzG19iRfZW7osFDRPqf4zSXhBErZg07ElCuRCa8s6PMZf+DSKUSJumNn4N+VwUFtvGUNBusN1A6+Xco0OVRsQCh9Tg3pl5nY6ns2GWHQaNlKveVX0aH7fQD8RN8vnlMRGb0v+dlgzVVY41Tcqo7PDAHYBPKgvHRPLsVfu8RCNKH8U51hEPJbTgSo9065NgicFGlsksJrOjdicl1+o+Zt9aVqNbzNAE+iMNi26l6YrIKKsrFkhMZg1+LqBm5TP/0tY9Rno4VpIJt4pF7Zu0pqO8iP8zXDn+hxCXOaW1209Lvlm7lb5qBbVdQXdMpKc8XKsQ1T/pqwG/GTz4sT+HVGWBC8eeA4CYYLpbOZwrpzoLF1csBb9+8+HTcRi+aI+EfmUIYbDmC7RlGRuGjqRqhgVCfRJ7ef8T37T7wwisOfhA4qwKYlXZv+FOVViecp4deFugTOElQX+uW8rlvCjHGXVQbBaa8KnC8vwHPX+9ttp51BQroxIhJMwHIWbitEX5489CngdYFT8DYHgxyTE2cd7FyqUQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(39860400002)(366004)(376002)(346002)(451199021)(122000001)(6506007)(82960400001)(316002)(15650500001)(921005)(33656002)(38100700002)(38070700005)(2906002)(71200400001)(478600001)(9686003)(26005)(8936002)(5660300002)(110136005)(86362001)(54906003)(52536014)(83380400001)(19627235002)(7416002)(55016003)(41300700001)(53546011)(186003)(76116006)(66946007)(66446008)(64756008)(66476007)(8676002)(7696005)(66556008)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?tEYRRmP7To0dcZcB2agPEkXczLjHeNwuFCeF+jsbsx3rVOFZG/HeLGThnkgg?= =?us-ascii?Q?tlJxylh0+RV0+d220wKt3UXgMQRcuTrsrGVPZPc/s/Hbndf79JxasDKo634g?= =?us-ascii?Q?XjSLm51/jcLFdNUVv1vdAsJ0PdmJnyZ6yLUY7MV9rT3XB7rvtW27L05Ij+ur?= =?us-ascii?Q?GBZJ+hYNBtDjmvPYOzzu7b2rNLINW6bNIdmtNh3AVYxCB4Ny3aRs4xhhrEzY?= =?us-ascii?Q?vT3zOT7uw8kuji4m1y6Aj91qZWxeB7fRQqY3j8B/JAh8QYQJzKqvl2YKhL5R?= =?us-ascii?Q?QPwID3mfLwNTUgb+FkPTNmjyVonb25ccLN2Yr9FIQmfTjTEavsTbnsJ29zRz?= =?us-ascii?Q?/VVWXFd9s33FDfUjcu7bVz4GzLpsT5Fn9nQXjhpBPmUr/u3GZLuVcuIas8HA?= =?us-ascii?Q?Z15bEfpZ8woHEPz7AGFpwYWyqeRmW5d4dxJbdFdsyJ2HEluOsI6QFdvZVbVY?= =?us-ascii?Q?ZPMbkj5lEvijUNfJZwURpT7R9CclQ4IDSbEapPWxzZZBGUGumFN3WFRL1wXn?= =?us-ascii?Q?KTpnsvhZ+aZDHSvQ7I6EBEHGDHWBp3qAIdTIQLzuKBpNqQSVMFtDKOqshLyb?= =?us-ascii?Q?uiMRCYCg08BCnFLKDhctDjDw8okjrldAdRJ+D+cy+0AzjYdr3J0rcH81VNvp?= =?us-ascii?Q?vEUsJH+KXcEW+iQ8RpKJ4sPZ4yu+A9CLkFFDLxeQx5EK0+Usa2I6BQM2NiLU?= =?us-ascii?Q?u7KVaRTArSiwIxRk14KtxbXYNhzxWrBpkoO6j24/bQTnjSIG030EK38JaURQ?= =?us-ascii?Q?u8gzQyL2LCCgC1u2fwnlNxR3jKSamJNyjEhlt/ZYyVgrdqCzQTQQmXzlvBaf?= =?us-ascii?Q?8xKi3VmuYBY9kd3r33YGC5/tU3mTY45zp5I98Uii0VatZ9UI1pELug5l4LwH?= =?us-ascii?Q?1ZIUq/tKVdlc5RfJcq06ADhkneKAYQL4T9YuxQoyFQGjPM7RIuENWwLnbPgn?= =?us-ascii?Q?kUBIGHQgK+DlnXnL72winQpETnmVINyjDpSR3xZmX70roLA6x7iPDp0eQtpS?= =?us-ascii?Q?GCdYbn3r4+dQqb26Ctdm+Rx06zdBTEfPEiKBanTz54h2WP/mJdDadrp6cGER?= =?us-ascii?Q?geXxAFzLe+R0sjBDAkuGb3eSy+XyHpg8Y212fMK9yW6ORXoW/Hz3HIsjwTTl?= =?us-ascii?Q?fiHURlE1iJfw43gPtRkj4EvB3/oelaUaJhncLIXGxnOXC4i7tdOzmr9hmK5M?= =?us-ascii?Q?QF/U9lS3M8kSV7n3K1GhdVTdAgP7U9I+SDB1MGkQjRADC1ybNq7+TmkX1uT8?= =?us-ascii?Q?Lki93VxOTxe8P/RtEkHaAtHCcfvUKOn5iG+bLyn1DQKRfDHCnIQOO0RCOLCz?= =?us-ascii?Q?F9hWAuqzVaXPQfTQHIaH5KoFxphjwPpg5WngUvdRY6QqhFavHEbPtgExlguC?= =?us-ascii?Q?BEvLHHYk3cqIBh+beCnwb4RfaSTcjZvK33ZDkxpbRAaOlhhEg5glFsL7bjjm?= =?us-ascii?Q?/YMftYFvMJyoVtVUtH/0DGQTw36SQrkIR5DNX33ETz7SgUFrEBnm1RlLWjAK?= =?us-ascii?Q?TF/GF8sWcq45Zu0Yo+HJfaSSOqERmylviB80CpA3LlfU5G3+Ms5vZId3OfxA?= =?us-ascii?Q?7lzdsxz91gdA2wTbP1w=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3fc2754e-e25b-442b-f445-08db37156cfe X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2023 03:08:56.5533 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: dXM3hAH+DY24GeAZ4/0QWl5eZCfcxmDildBegoHl9YbFWy56sP4lwaBRIH00tcq/UWUOGC0MaOyz81oPt3JK0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8245 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Rebecca Cran > Sent: Friday, April 7, 2023 6:23 AM > To: devel@edk2.groups.io; Gao, Liming ; > Kinney, Michael D ; Jiang, Guomin > ; Xu, Wei6 ; Dong, Guo > ; Ni, Ray ; Rhodes, Sean > ; Lu, James ; Guo, Gua > ; Andrew Fish ; Wu, Hao A > ; Maciej Rabeda ; > Siyuan Fu ; Yao, Jiewen ; > Wang, Jian J ; Lu, Xiaoyu1 ; > Ard Biesheuvel ; Sami Mujawar > ; Supreeth Venkatesh > ; Michael Kubacki > ; Desimone, Nathaniel L > ; Sean Brogan > > Cc: Rebecca Cran ; Leif Lindholm > ; Abner Chang ; > Nickle Wang ; Igor Kulchytskyy ; > Daniel Schaefer ; Xu, Min M > ; Justen, Jordan L ; Gerd > Hoffmann ; Peter Grehan ; > Aktas, Erdem ; James Bottomley > ; Tom Lendacky ; > Michael Roth ; Sunil V L > ; Warkentin, Andrei > > Subject: [PATCH 15/18] SourceLevelDebugPkg: Update code to be more C11 > compliant by using __func__ >=20 > __FUNCTION__ is a pre-standard extension that gcc and Visual C++ among > others support, while __func__ was standardized in C99. >=20 > Since it's more standard, replace __FUNCTION__ with __func__ throughout > SourceLevelDebugPkg. >=20 > Visual Studio versions before VS 2015 don't support __func__ and so > will fail to compile. A workaround is to define __func__ as > __FUNCTION__ : >=20 > #define __func__ __FUNCTION__ >=20 > Signed-off-by: Rebecca Cran > --- >=20 > SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu > nicationLibUsb3Dxe.c | 4 ++-- >=20 > SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCommu > nicationLibUsb3Pei.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) >=20 > diff --git > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > index 4490526273c9..d37fb991f1f2 100644 > --- > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > +++ > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Dxe.c > @@ -186,7 +186,7 @@ Usb3DxeSmmReadyToLockNotify ( > { > USB3_DEBUG_PORT_HANDLE *Instance; >=20 > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); >=20 > Instance =3D GetUsb3DebugPortInstance (); > ASSERT (Instance !=3D NULL); > @@ -290,7 +290,7 @@ Usb3PciIoNotify ( > // > // Found the PciIo for USB3 debug port. > // > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); > if (Usb3GetIoMmu () !=3D NULL) { > Instance =3D GetUsb3DebugPortInstance (); > ASSERT (Instance !=3D NULL); > diff --git > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > index 15842a317ef0..aa04442918d2 100644 > --- > a/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > +++ > b/SourceLevelDebugPkg/Library/DebugCommunicationLibUsb3/DebugCom > municationLibUsb3Pei.c > @@ -35,7 +35,7 @@ Usb3IoMmuPpiNotify ( > { > USB3_DEBUG_PORT_HANDLE *Instance; >=20 > - DEBUG ((DEBUG_INFO, "%a()\n", __FUNCTION__)); > + DEBUG ((DEBUG_INFO, "%a()\n", __func__)); >=20 > Instance =3D GetUsb3DebugPortInstance (); > ASSERT (Instance !=3D NULL); > -- > 2.34.1