From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web11.2445.1676622366353316102 for ; Fri, 17 Feb 2023 00:26:06 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Q966Y9yc; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676622366; x=1708158366; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=C7uKbfQXKDDlSMvopBL4br9xBx3iNw9sPtcqIxnpY+o=; b=Q966Y9yckU+ocsgo/i6IBYQk62hSMwObu+A+OQqcH0ocp/ra277faoFQ UcXFcB51M10T1kYru4sJkmgA8PX2fpAYW7opy6kHHZgrIC/hiwaN+ace8 xk8ldGgkyHtUOxkBqvoyKWCFyaWx3kd4aFBi7kVOBIoXvt3YQN7mi2BUn vSX7wrwSnrtjNQNl9yjmV0C/k3YOHWwlZUA10B3pV7TgbpDslC5H543Hd 4cAd2L1pyx9DZ/kwD8yaKl5WUfUGinuDVafHvL0lYB7OyHCd1oYZ87Ft8 pv+nFtUJCDYhn9z9DEsvfVrpPRN12AoY+GVBPUpc/Hc94HS+YY9dLPa4A Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="329663123" X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="329663123" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Feb 2023 00:26:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10623"; a="670470467" X-IronPort-AV: E=Sophos;i="5.97,304,1669104000"; d="scan'208";a="670470467" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 17 Feb 2023 00:26:05 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Fri, 17 Feb 2023 00:26:05 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Fri, 17 Feb 2023 00:26:05 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Fri, 17 Feb 2023 00:26:04 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RVJ9YVhEersgeqnCiUjhJ6qXJJBXl7Xdob50BH3HH5HY00rxF4nbXE4P52a4J0IF8eg6dI8n5L2scYfBUIXZgX02tZdYIVzVsap9eri42qOgTlc7p6PKqTtLKzdyRKHIPB33hoXqq2BvupbRVwzokQPXo4lvaZ2XuMg2256dzAR4ureFRmuYm3aE1oAMu4IG1POLCL2xUiQ4Q2omxfx+uJmAavAWURPTO/gTUxl4/o0Mhh9cZQpEH2TV7pzVxamwJswvyw9riDC92WLuQ3P1vXqCavA2UMIU+qkEzz098BS6i9jxOOHbFkKlDncinKoNcXFH/4EaDT7orKyXEVpwYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/rrwm5unicFm1DwWL82601126Wc5Ycz5KHCqkCBVSrw=; b=mCximJ1QIvqb1J6HbiGSbqY3febSOk1YGmEbh9IXeKddtiXalz41M+QiG+nVWAH1Eu/0AROd/nFf9p7KEXdtuWC4ZxoBFwDsey49aj1Mx2ekKLpwFSep0z0PXYcdPyeD0pWCbvJXDJ+7lSTKgZ3QtHy61ofKFsW9nzxpOXjqTyurKsTIUZ4hbhdfL+GTmKVkRZ8S7u9+7wSdZUCPyalWSop5BC9UZmDx5UCkM8OowMTpQPsMmNyv1DIhDhyHC3Sydl/uSALbwxKVCv0WKzkjPVvq+z4TlcQZfiuo7qJmAho39/vJ/puJeOK+eJL30YmxnUiZNkUa1wvO7PcuYPxGiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5270.namprd11.prod.outlook.com (2603:10b6:208:313::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6111.15; Fri, 17 Feb 2023 08:26:00 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6%7]) with mapi id 15.20.6111.013; Fri, 17 Feb 2023 08:26:00 +0000 From: "Ni, Ray" To: "Wang, William2" , "devel@edk2.groups.io" CC: "Kinney, Michael D" , "Gao, Liming" , "Kuo, Donald" , "Kumar, Chandana C" Subject: Re: [PATCH v6] Update CPUID Leaf 06H to follow latest SDM. Thread-Topic: [PATCH v6] Update CPUID Leaf 06H to follow latest SDM. Thread-Index: AQHZQqlAicq6pnCWyUaDDIN1uyJy7K7SzadQ Date: Fri, 17 Feb 2023 08:26:00 +0000 Message-ID: References: <20230217082417.732-1-william2.wang@intel.com> In-Reply-To: <20230217082417.732-1-william2.wang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5270:EE_ x-ms-office365-filtering-correlation-id: c5077103-d5b3-4762-8c9c-08db10c099ad x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rLG8MiyKo0Tr9rFr3/FgfP0gwBioVTZDSGdxG76mc+uTqA3Lg/tVF0OpM8uTTh+uXxyhj8c9aPcv9gPMw2KWdTpj1fxHZNaKby1lTurM2xTpxuSlkJQGcYVWr6ZLuddQa7gt2/ApA2dZFhDzkNP5BfVzzWNFwH+iCziGWOgE/U9BnvmHow+BdIBP96d2QlT4GdmWshq/p1k9ixPC4UVOd0G2wBh5BGhmbo7GC2Qzuj9DGALpI1eAQTPUAiDN4Pq8zqRxfCSPOqaqNAnS08nU4j2x5tp+HpXBw2YahWFSfPlc5bodcDh8dB49OAGsbN2grHdBxKeNZ5sVTiqaLkiGZWKxc7TONbCLp+79cOX0v2SbRkWvkWDloclv15x/bNAFTRsArH22TysyRK43g1B1eRgdh7jA6RwP+VFp+urys1oiEMLt6MXKIMYJFaMiE338l7OleF0OvaRdfnx/IJs0QiOvg65Ag0eCbBtM9VXMKH8j1Qpx91Jwa1z1d6SyEp7z8Kqyj1bG47iM2HSL/MWxs1bHlWifxdTjQUO7ftxmCmhX0eZpUk9uNn+Hb75qozwrAD32PwokFTsvbzbQPgZSr6Xeq8jDnCmTU+W3g5FP2P9moFSum08Jjlx5Hj2D28SbZZWmEXGgF7u2RzOdn/A3yHRuKIUxugdv/Wr/KoSIG/Jw5cU3vVOYUa47OggxhJiP x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(366004)(396003)(136003)(376002)(346002)(39860400002)(451199018)(33656002)(55016003)(66476007)(66446008)(8676002)(64756008)(2906002)(76116006)(8936002)(66946007)(52536014)(66556008)(15650500001)(5660300002)(4326008)(82960400001)(38070700005)(38100700002)(86362001)(122000001)(7696005)(6506007)(107886003)(478600001)(966005)(110136005)(316002)(19627235002)(54906003)(71200400001)(41300700001)(83380400001)(186003)(53546011)(9686003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?BXyoByT+oRrvGV6xxBVDxuA4Leu+FurAJL6WiFTshsWrTxGwaklddVUJeB/0?= =?us-ascii?Q?6FFBNvBKBvvDI8zWCep2p5TtHJKUWsfEwTU+MghlvHyUT3c9pjNaGpbCTPVM?= =?us-ascii?Q?J9lpELfHAEue7lmVZ9JGk10/cXQPehdSI/+BzwZha1lGn+3QIAEDWuAPJLXj?= =?us-ascii?Q?L5jguCLFQrCJciIdcl27W2uzX2d5h8i5BkiW1UO3pLIMGfJ9PEV+0cHh/biq?= =?us-ascii?Q?QVs06aR04LHeS1CiRwEMSpClwt2H/Ffc/XCLCpwitopsrWwthpmUhXVTKmhM?= =?us-ascii?Q?R9YKNeQIv/dN4GtyyV4AEoWI3PAWg7UusW15mSzv1JyBwjWnd/N5pEwzaR/R?= =?us-ascii?Q?O49zZUEgHRFBzlzVHtxSWyI3LML9BQe06S3/oYLZrA7m91EeD8mWETHE8Ln/?= =?us-ascii?Q?aE/k9Gwl9rillEc/wy0KctXYFWl2BxBxa/LoeeB30khejrvM7EV9gEdwdnon?= =?us-ascii?Q?XtNpzmt0rwjtX7+hwt/7KSJdaIxdBg4+WN8z3keS2gD0t/dH2hRHzpV9YB6e?= =?us-ascii?Q?ehz4Cq47AikZrUaJwrV/3H/kcRlxJjPaVSD2OHtK0hoTo03dWT5ajIY5mBY8?= =?us-ascii?Q?p6GaddvZih66cDNDX8LYtxB3RN8dpzVFrhws7DUR1hfXLSUM98zw56J/bqVm?= =?us-ascii?Q?/rJ8iH0O91Kgor4gfYGnoi2jZn3xyH+p8K7BXApNAtRO5QtvqBjx3xjcacv8?= =?us-ascii?Q?7mHm1/yg3j/SnxEZPcWKiDM3Kr3t/JOLpEIA3TegH2pQADqOT9Nbnhtpuh7J?= =?us-ascii?Q?UaBZXiNQaoGyeyg8de2goJdr3TirjypwpGiej+6nvak8b1Fh69m2IKxGBjMV?= =?us-ascii?Q?3UOTU5QERqkZlgLuUocAmtTiaMIlgX63xBqLNioKBZD4ifWlCy5G2YBdPgAm?= =?us-ascii?Q?E4iOx9BNtHKqxyhZWT878Z60AABYPW80y0mvGbTsJEHUz/r3w8z8Z/l22oPA?= =?us-ascii?Q?YbVsnkCaHctAs2zlhrnafElzxzmtf4ScStZUopJBduFEZwGso12qEawjK3s8?= =?us-ascii?Q?nRQT9/AWxmiCXxG1+qRYMUnJ3e/eswk6+p4iJwWakWmwa/UcB0MFzZdeGGXA?= =?us-ascii?Q?cUH0HK0tygM03uYOerzkO7ImoEm2DXwkkhtar+6KAiUM++4tnGeGu8p1k1JD?= =?us-ascii?Q?WYTqssxdmQQRZky0InRqoRCcqsdSR+dRkN+4ql3sFAbR6C1dLesVYbbCh63b?= =?us-ascii?Q?D4Eub008sdkhZCwW8jMShxGx3qdPzVaVd1A3JDQ88Z9SluLgzUGKvRf4M5s+?= =?us-ascii?Q?ytCxa6OHIBl9KwJPVinigTX/bXV6Ls3sWD00B6R81hnJ2PbsajfWoPse46jN?= =?us-ascii?Q?k6Gh1R4WH8hv/rUYCaMoFcwDGBEJXnYDCoAtv5jhz61ojyEJ/OesjosVYc8+?= =?us-ascii?Q?zOHqlLJ5KFAjoWBiYqUUHrluUgSdxRM7s6zyHesaWlNRKKkoXbyHITwfzd2a?= =?us-ascii?Q?R84s5tA04lU+kL0kvXp8l44ytrSYkEDpPuK1WvtywQvtS2ZnvQFT/O+ly0X1?= =?us-ascii?Q?6ZhVFs9tOL61D/dgE7VQHsGTACgun3QiUzZNBmQOZcBm9+7n7K6ZShaJrA?= =?us-ascii?Q?=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c5077103-d5b3-4762-8c9c-08db10c099ad X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Feb 2023 08:26:00.0485 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xPnw0RjNP02X8ETKHTOW2FJ9xbbi+Fr3IQnaffwR0cIN7AudEtk9JAiseQVW5uF0t0Q/snQG6fwfp1NXwpSkYQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5270 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Wang, William2 > Sent: Friday, February 17, 2023 4:24 PM > To: devel@edk2.groups.io > Cc: Wang, William2 ; Kinney, Michael D > ; Gao, Liming ; > Ni, Ray ; Kuo, Donald ; Kumar, > Chandana C > Subject: [PATCH v6] Update CPUID Leaf 06H to follow latest SDM. >=20 > From: William2 Wang >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4262 >=20 > Update CPUID Leaf 06H to follow latest SDM. >=20 > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Ray Ni > Cc: Donald Kuo > Cc: Chandana C Kumar > --- > MdePkg/Include/Register/Intel/Cpuid.h | 65 ++++++++++++++++++-- > 1 file changed, 59 insertions(+), 6 deletions(-) >=20 > diff --git a/MdePkg/Include/Register/Intel/Cpuid.h > b/MdePkg/Include/Register/Intel/Cpuid.h > index 350bf60252..a8d25671bd 100644 > --- a/MdePkg/Include/Register/Intel/Cpuid.h > +++ b/MdePkg/Include/Register/Intel/Cpuid.h > @@ -1195,12 +1195,24 @@ typedef union { > /// [Bit 18] Fast access mode for the IA32_HWP_REQUEST MSR is > supported if set. >=20 > /// >=20 > UINT32 FastAccessMode : 1; >=20 > - UINT32 Reserved4 : 1; >=20 > + /// >=20 > + /// [Bit 19] IA32_HW_FEEDBACK_PTR MSR, IA32_HW_FEEDBACK_CONFIG > MSR, >=20 > + /// IA32_PACKAGE_THERM_STATUS MSR bit 26, and > IA32_PACKAGE_THERM_INTERRUPT MSR bit 25 are supported if set. >=20 > + UINT32 HW_FEEDBACK : 1; >=20 > /// >=20 > /// [Bit 20] Ignoring Idle Logical Processor HWP request is supporte= d if set. >=20 > /// >=20 > UINT32 IgnoringIdleLogicalProcessorHWPRequest : 1; >=20 > - UINT32 Reserved5 : 11; >=20 > + UINT32 Reserved6 : 2; >=20 > + /// >=20 > + /// [Bit 23] Intel Thread Director supported if set. > IA32_HW_FEEDBACK_CHAR and >=20 > + /// IA32_HW_FEEDBACK_THREAD_CONFIG MSRs are supported if set. >=20 > + UINT32 ThreadDirector : 1; >=20 > + /// >=20 > + /// [Bit 24] IA32_THERM_INTERRUPT MSR bit 25 is supported if set. >=20 > + /// >=20 > + UINT32 IA32_THERM_INTERRUPT : 1; >=20 > + UINT32 Reserved7 : 7; >=20 > } Bits; >=20 > /// >=20 > /// All bit fields as a 32-bit value >=20 > @@ -1244,15 +1256,21 @@ typedef union { > /// processor performance (since last reset of the counters), as a > percentage >=20 > /// of the expected processor performance when running at the TSC > frequency. >=20 > /// >=20 > - UINT32 HardwareCoordinationFeedback : 1; >=20 > - UINT32 Reserved1 : 2; >=20 > + UINT32 HardwareCoordinationFeedback : 1; >=20 > + UINT32 Reserved1 : 2; >=20 > /// >=20 > /// [Bit 3] If this bit is set, then the processor supports performa= nce- > energy >=20 > /// bias preference and the architectural MSR called > IA32_ENERGY_PERF_BIAS >=20 > /// (1B0H). >=20 > /// >=20 > - UINT32 PerformanceEnergyBias : 1; >=20 > - UINT32 Reserved2 : 28; >=20 > + UINT32 PerformanceEnergyBias : 1; >=20 > + UINT32 Reserved3 : 4; >=20 > + /// >=20 > + /// {Bit 15:8] Number of Intel Thread Director classes supported by = the > processor. Information for that >=20 > + /// many classes is written into the Intel Thread Director Table by = the > hardware. >=20 > + /// >=20 > + UINT32 NumberOfThreadDirectorClasses : 8; >=20 > + UINT32 Reserved4 : 16; >=20 > } Bits; >=20 > /// >=20 > /// All bit fields as a 32-bit value >=20 > @@ -1260,6 +1278,41 @@ typedef union { > UINT32 Uint32; >=20 > } CPUID_THERMAL_POWER_MANAGEMENT_ECX; >=20 >=20 >=20 > +/** >=20 > + CPUID Thermal and Power Management Information returned in EDX for > CPUID leaf >=20 > + #CPUID_THERMAL_POWER_MANAGEMENT. >=20 > +**/ >=20 > +typedef union { >=20 > + /// >=20 > + /// Individual bit fields >=20 > + /// >=20 > + struct { >=20 > + /// >=20 > + /// {Bits 7:0] Bitmap of supported hardware feedback interface > capabilities. >=20 > + /// 0 =3D When set to 1, indicates support for performance capabil= ity > reporting. >=20 > + /// 1 =3D When set to 1, indicates support for energy efficiency c= apability > reporting. >=20 > + /// 2-7 =3D Reserved >=20 > + /// >=20 > + UINT32 InterfaceCapability : 8; >=20 > + /// >=20 > + /// {Bits 11:8] Enumerates the size of the hardware feedback interfa= ce > structure in number of 4 KB pages; >=20 > + /// add one to the return value to get the result. >=20 > + /// >=20 > + UINT32 InterfaceStructureSize4K : 4; >=20 > + UINT32 Reserved : 4; >=20 > + /// >=20 > + /// {Bits 31:16] : Index (starting at 0) of this logical processor's= row in the > hardware feedback interface structure. >=20 > + /// Note that on some parts the index may be same for multiple logic= al > processors. On some parts the >=20 > + /// indices may not be contiguous, i.e., there may be unused rows in= the > hardware feedback interface structure. >=20 > + /// >=20 > + UINT32 LogicalProcessorRowIndex : 16; >=20 > + } Bits; >=20 > + /// >=20 > + /// All bit fields as a 32-bit value >=20 > + /// >=20 > + UINT32 Uint32; >=20 > +} CPUID_THERMAL_POWER_MANAGEMENT_EDX; >=20 > + >=20 > /** >=20 > CPUID Structured Extended Feature Flags Enumeration >=20 >=20 >=20 > -- > 2.34.1.windows.1