Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS

["Ni, Ray" <ray.ni@intel.com>]

4 minor comments.

> +        if (FadtPtr->XFirmwareCtrl) {
1. you should use "if (FadtPtr->XFirmwareCtrl != 0)" to align with edk2 coding style.

> 
> +          CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->XFirmwareCtrl, TableIndex++, Context);
> 
> +        } else {
> 
> +          CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->FirmwareCtrl, TableIndex++, Context);
> 
> +        }
> 
> +
> 
> +        //
> 
> +        // Locate DSDT in FADT
> 
> +        //
> 
> +        if (FadtPtr->XDsdt) {
2. Same comment as #1.

> 
> +          CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->XDsdt, TableIndex++, Context);
> 
> +        } else {
> 
> +          CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->Dsdt, TableIndex++, Context);
> 
> +        }
> 
> +      }
> 
> +VOID
> 
> +GetAcpiTableCount (
3. "EFIAPI" is missed here but the CALLBACK prototype contains "EFIAPI". You need to match them two.

> 
> +VOID
> 
> +CalculateAcpiTableCrc (
4. Similar comments as #3.