From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.4026.1685498542724708245 for ; Tue, 30 May 2023 19:02:23 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=mH2MTqQm; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685498542; x=1717034542; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LL5fgMSPShCfNIhHaNTO1kUg66Z/Y4ERMGON9OZu+Uc=; b=mH2MTqQmT23TQnrTKh3VKqydrXkukLO5L12SANKQpYhW1qWwTk236hFE tws5AI/Y5Y9kcAMlPKqTNAE0aCZtIg2ort+iSUJQds8Ymrog9ZFPAQh7Z 56NKGkM3DYC10hGeRw9by1gymft9MffGMDc87N0Vxhpso/JO+/GvgpyS4 SY9vwxn+yaF4Am9RtR/NeByf+PDd03mQnr0uWlGBogCWI4UqP8D2jSPXe Qxtgnd607T59e6UoHgt3G1jJ0ntg+sNmaxbbOWE7pcj7PF9cdxqtd3L6T s5x2jmcfL354B8g0CQ0HJhocXWylM3MZRsR6TfwwU+1/i09M2/JfamUxv Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="339696257" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="339696257" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 May 2023 19:01:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10726"; a="1036821953" X-IronPort-AV: E=Sophos;i="6.00,205,1681196400"; d="scan'208";a="1036821953" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP; 30 May 2023 19:01:14 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 30 May 2023 19:01:14 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 30 May 2023 19:01:14 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.48) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 30 May 2023 19:01:12 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bIs44c4f4BNpOtw8HFccGhXqhN5qa0VO53N3JraduKAKTVi1MdO8fMSpKWyjhCd2gHvTk/2eHQWjyUEHdxVsMWFv+OtdR+jVj40NMi5oJBDByqObN32RqE3PPbEiXXFxk9yp42uE/hROsXpqbzr8G2Ay+RYwYVnLicggs/JuSyyuBjieOBQ9/YbJZA7Ih1f3K75G2cJV2Pb/7WVlAxJsGu94KRsED5JivjthAaSVODTM59PBvssp56Ps7UYDVMdQwkw3/s3IO/e0wWofWGxxBNZOshTPxxfVPz5QOpUxmWYcdljKJrN4Y4vRdVvHnn15BksNHI0fRq+T1s2wIOovgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=snffUafwYfLdEx//99Lzx7NIngVUNIwOZBvwQz1DyR0=; b=Khem8ydzC30hb3XMD8/+k0KZGSsiFE2rlH3+gD1yDCkuPMwmP7n3uDYRi/P6Mjwo1rLfL1TW5PV44uBp9wRNgl2s9xdpXHBEOifW8tdjSBk9CVwPUVyB3HZYW/jI/2Rqc40Uq6g8NBSOU8cZ5qO6W+qHaQwmTR4oP8QBVRZHviAZCTPayrpwF0uQs3+pFCn8cIH4s3kcIgjYVsaNHDgV9ka+JGASPGEpXmsjHZKWZwwROzT88cjQSmoDMTN1LXYyqcR7hSFHXIlbPUR6kO6riaTc62qgSOvt6OsRsiK6IB1JHR5635u2tLkFEwiKwgEoQ+p9STzKrDZIHIgWom2jjQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5544.namprd11.prod.outlook.com (2603:10b6:208:314::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.22; Wed, 31 May 2023 02:01:07 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6433.018; Wed, 31 May 2023 02:01:07 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ke, VincentX" CC: "Chiu, Chasel" , "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" , "Sinha, Ankit" Subject: Re: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS Thread-Topic: [edk2-devel] [PATCH v9] MinPlatformPkg: Update HWSignature field in FACS Thread-Index: AQHZjhtO0FyKe6VCU0iHl1K/1H345K9zqgxg Date: Wed, 31 May 2023 02:01:07 +0000 Message-ID: References: <20230524083923.1963-1-vincentx.ke@intel.com> In-Reply-To: <20230524083923.1963-1-vincentx.ke@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5544:EE_ x-ms-office365-filtering-correlation-id: 38a3e650-4d4c-499e-abde-08db617ae5d6 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 95HYZXsSjmMIs+VCt/40zvApHS0XLjtS88AuLI/SZf5IMVGfo2/fFiwK1stg/1Ri62eQ6qCmXMn+waa9N0hiZSEWgJirYzwjw0qXxulI7Y9IeMt4IxyZQeunISK/9RJ8pTRyfAA/sE46fzvqpUmsCGlNsK0p/NlKfLhmR1JK+DHhIB9R5r9UO495vF5HYjfpmJDmBGodyT3Auna/CaYx8hImqrtINGt7QJGWN5BaUHAxgoccXY6UIuZrwUk60BXmBEu4X63tO8oKt3W8vz6a0HaDLLxYrp34upEvYGq60wz5andfgHYpPz5ux8m2FIwkycm2T8xQ2hiHKhquk405JmWqG9vMMXnekavsEqOYi1LeLW0sBLDR5P7kZRZ47BxcrxYA8eX+k2Axy1x6opjWS0nflM1GE+LqqwCfBLpHXCBW9HNsfjKX//gKXAmq4/29/zu6zm2F6SjvpZuBQDGwigqtXnuZ/0LYniCX4mhkN2oQQMY3PZJZsVQpk3tP4XJWsYKQWr+3sPWXWnlyQttNF3IdB+Q36pRvqf/ZvNRtaKRwq9nJka+tNxx9NzwdTTaes4UzajslzzIJATOOxUXRCel71KH6JhzlXZoG1L34znpC3prwAtcZcxdFj5h+soVM x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(376002)(366004)(346002)(396003)(39860400002)(136003)(451199021)(66946007)(6636002)(478600001)(4326008)(66556008)(76116006)(38100700002)(66476007)(41300700001)(64756008)(66446008)(55016003)(38070700005)(71200400001)(110136005)(122000001)(82960400001)(54906003)(316002)(8936002)(8676002)(5660300002)(107886003)(26005)(9686003)(6506007)(52536014)(33656002)(86362001)(4744005)(2906002)(186003)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dJFP2sc6vwG8bNoPAfV9PkwZxyHAXBNWZUnErxGGP0zPVPvMkTD6KPcJj2L8?= =?us-ascii?Q?5xS8jiW9/3iIfeaZ1UXtdXvqx5UdEHWORsup/21Iirxvxbg8DFYmBVJqhQsq?= =?us-ascii?Q?ACCD69A0p42Bt3Bm2HHrRxOizPCUwjmOoUzcd0Tg3gYJa0BHyx6Zp1umlaul?= =?us-ascii?Q?Wh/tkvWPC3lAdD/HpdmGud5+X6BZNLXYLoO6hzYZSkER+obrkJX50a2AVGnj?= =?us-ascii?Q?YojeDTtW6ArqRIhzK/niwX2UBt73bPRxgbTJNc6OpZem6Fvbh5SiJuEWAbhN?= =?us-ascii?Q?JzEgGpY6VSYAWF2jT+pYybybRYS8Xy2PGNYFpJdHOvtMKBJ2arKdop3gPdEP?= =?us-ascii?Q?/Txhby3HV3AhKcZewCqBiSzsNJOI6QsdzqM32BzC3r0YKvr2m74bthNkRgt9?= =?us-ascii?Q?B0ZLrTzfJrR55UF4rMK40F8c+hY+5G6TAnsLfCWpnBGmf+0O7W6uG3TQgZR+?= =?us-ascii?Q?lcxiH2EJD9AW/Qdc5N4odDnbQTfyppUgpxr6+weH0t7MPf05Saxh7HSOAuWO?= =?us-ascii?Q?gG2rG3Fi978ksR1yhiVOIzhhKMq8PinI/yZn2RTZEGbOEIuM00ep8U05IZmM?= =?us-ascii?Q?bSaBTDmuaDuVbGFkTjh4TfReOxwL6eqIm7WNvuNPdyDGIEhYHXhGRltlBuZQ?= =?us-ascii?Q?CysK3mz/kaB5w2VO092G1FPv1J6CCdH0+6EdJbFRFBS8mlh6y/cttrk0o39h?= =?us-ascii?Q?EihNAfAU66rpQa1qU/uA+WTRKBiRceOQzqD0DuQeClK3EnS2jsYwA3jufmB8?= =?us-ascii?Q?3tNn6UPJv9P6vH1/PcRW0siyjPgr248bfz0erbQWvOTf4XRBBh3ZIyEEs0/L?= =?us-ascii?Q?0ub5hqOnqmWARRH5vHGKkQJ7BG7cMa0hRjyeRNQ6WSDnFlJc5NJXYmP6mDZX?= =?us-ascii?Q?JzUCesS54PI+BM0690dxpAgdEhUITnz6spqiCtMENlbyjKxSBVA2oSk4qwy0?= =?us-ascii?Q?ocNdqhe8SkoAKE3eKkCgXstHmNzFl5+x5Ei12ay2i6Bt8Q8mhR9wvxzlS38m?= =?us-ascii?Q?qtt5h7W/Ri5/j4uKjyOkJKa7gXNWPiqI1LXDVQ3Pnboije1z++zjpi9VbCN5?= =?us-ascii?Q?Vpmv5yjauGi5KYAwLffvu7B760Jje6W7IQyvEGUCKRwnQKo0E7uIchzFqdXn?= =?us-ascii?Q?lKssZSUJALX9Wu6JUibj/j3YSvvQ6lVl7L4N4hV0jTFVLt153xqN3gZg0PMD?= =?us-ascii?Q?Ep9gbWfRj99Zk7T9Xfh7X0rMOTKBj0yGL5+8IOkIRckntrBMGwIT+34jE6UY?= =?us-ascii?Q?xYcJ7BkQ1YGdS6KBZvFtwWLmSKBRTvhCIFWS5zbePT0MX36vtSjrymQHEyK6?= =?us-ascii?Q?T+qblOYsG4GK4SgSjuYibemvb4s3DAmsLmSX0duY3U48wH+9P/1dzE4CFBRD?= =?us-ascii?Q?jASL/239Ok2fib13/maA9oqSQNNMZ+hOk2oJ7gTfJoe86fstYLjG3ffZk0x8?= =?us-ascii?Q?rhw2+J6STe97C87WO+9LLRevrCqwm10mxxIxm+2GXkVipdSmCWqDFNp5JsdI?= =?us-ascii?Q?kXG+l5D7C+v2cjZNFWeNB3HKHQXZl4Ya/ZE/xU8DCwc9AM8gYXx+pArwskYB?= =?us-ascii?Q?/+ObzBpF0Xs/09WBdjI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 38a3e650-4d4c-499e-abde-08db617ae5d6 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 May 2023 02:01:07.2539 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: F/XRudyxr1Pa2wjUE4u+TBFuacrdwQH2pO7OSaGOSXfE736jxSUIASKYLJbaMONcS+A8yNAln4uBRSj9dX2JTA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5544 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable 4 minor comments. > + if (FadtPtr->XFirmwareCtrl) { 1. you should use "if (FadtPtr->XFirmwareCtrl !=3D 0)" to align with edk2 c= oding style. >=20 > + CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->XF= irmwareCtrl, TableIndex++, Context); >=20 > + } else { >=20 > + CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->Fi= rmwareCtrl, TableIndex++, Context); >=20 > + } >=20 > + >=20 > + // >=20 > + // Locate DSDT in FADT >=20 > + // >=20 > + if (FadtPtr->XDsdt) { 2. Same comment as #1. >=20 > + CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->XD= sdt, TableIndex++, Context); >=20 > + } else { >=20 > + CallbackFunction ((EFI_ACPI_COMMON_HEADER *)(UINTN)FadtPtr->Ds= dt, TableIndex++, Context); >=20 > + } >=20 > + } >=20 > +VOID >=20 > +GetAcpiTableCount ( 3. "EFIAPI" is missed here but the CALLBACK prototype contains "EFIAPI". Yo= u need to match them two. >=20 > +VOID >=20 > +CalculateAcpiTableCrc ( 4. Similar comments as #3.