From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.48834.1680246105699839193 for ; Fri, 31 Mar 2023 00:01:45 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=GNKiwBZs; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680246105; x=1711782105; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=DzCR8d+NOrStMaW9zPmQgyEHtmyZd2MpwsPGKHzMCTc=; b=GNKiwBZsetAx4ZjWwS1dFKqF6wm/PBmm5uk2UL9rpu7mCyV/+HWFDUOt wFignFOj0Ga34v1PFGOYjT0Bu5CdKgrjkY7lZtJyPta8IxKEUD8q3TWSW SVUK0yTOYybp6cuw0cYMGOSQWPB2qW2Rwc+/fFXEfUuQ+Y8WsGPo2o7rm ljFWtkOasfeqlfrT1d27KD9IaXhOTBbNtNOkH9uHvQ433btyTDZKhQ6B+ xL+Ca8xLD+7zahCgNqGa/jN0xaI+obV+VY1+6Yu2eLD7Oa89WTY91TZ8U npzTO/6GEeUr1+XZdWSLUzd4wZAiVSv+K5R+XGb3aKENK3M4zsEUnt4BP A==; X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="321766702" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="321766702" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Mar 2023 00:01:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10665"; a="635184979" X-IronPort-AV: E=Sophos;i="5.98,307,1673942400"; d="scan'208";a="635184979" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga003.jf.intel.com with ESMTP; 31 Mar 2023 00:01:32 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 00:01:31 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Fri, 31 Mar 2023 00:01:30 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Fri, 31 Mar 2023 00:01:30 -0700 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.42) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Fri, 31 Mar 2023 00:01:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oc1F6iH5M35fT98fjIJPjn1QcA6Nd66VlsZWCZ8jifVj6x2jSUMS3mGtgHT4PjJO0Auj5jqklqYhh9Yto/ZNMX148TG5xiyLzwzcBFu/EYzDEs3ARtfD6kBuJIiXlx/OuJBdO6n+0kijsX0xQfCWJ434Zfucf6nY2gP/P9S5nUA0ogfb4U12hh0UXQgE1K/KqZrOMYcorF/La0UbJD/Z3P0mF6vYo1NF/8qeaT9K5xhafmlvHvolisOyjJYc0OXVvJeX9rczze0yWZPR/2bWH1p0mCqVvws8V4wd4Ud2CMTY2zSAphi+vK4/MPbdm+7tI/FnFrGGidzb9s9aBd6ZPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=G7QunNqGkHdLBRFN42tzHV6Ro9FIw6TKd2tJ1i4eohQ=; b=jgIJKP41y/VOwdqgmJfqTAkpwa5i5C8kGtlV7mEBwz1yRNYyph8xBBxvmfnKZI/eJekRCFR8vLQ42l2ZoAlkHp2iIDExj+355DDBlS/oLGHxxetnSquH8TJMFy7TIrfO/ntQdL70zuszqKWpYejS9pigArylzNW8dqZ3CuvQrE3jRUZ9cvIu/suIQJRTSHmNTgSSFK1qQ5Oxa9W4w1uhY1IAQ6p/h8lzm4ibYUsWrwiKG+uCDe827CovR7ngMQtEwUv85U9pUAIIl0UDqjuD27bY8au+WrId2gzcSfEoUhCw3s/HccMkwo+ZJ74UVkGG9p8jts8edTfM4ZL5L1xaPA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5255.namprd11.prod.outlook.com (2603:10b6:208:31a::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6254.20; Fri, 31 Mar 2023 07:01:28 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%8]) with mapi id 15.20.6222.035; Fri, 31 Mar 2023 07:01:28 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Bi, Dandan" , "Gao, Liming" , "Wang, Jian J" Subject: Re: [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib Thread-Topic: [PATCH 7/9] MdeModulePkg/DxeIpl: Create page table by CpuPageTableLib Thread-Index: AQHZYR82Bgk1snFskEa+qCDSLp4Kt68Ud/Pw Date: Fri, 31 Mar 2023 07:01:28 +0000 Message-ID: References: <20230328024302.2085-1-dun.tan@intel.com> <20230328024302.2085-8-dun.tan@intel.com> In-Reply-To: <20230328024302.2085-8-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5255:EE_ x-ms-office365-filtering-correlation-id: f031e435-0fed-4f11-0bff-08db31b5c031 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sua8ZbAjl0dbWwqmDzXDwcZnYLDCTjr9cJndNczQsbx+hTWJmrHEXUiLEJl0VB2yG7aQDFfFOcemFdNINyFjtGgbNQl6MZUsKPsoN/0G9zOUfx7OQKVnnVK3yRsv/YI5WW1S29pumPWybOTFlqJP/ecGTQwGCgtiZ4CyKIizLwW07QWKOB/bdekr03/Gm1lLEanO1BwXEYY0fAnpeAEdhNuDdRdceVHj0ahduxlmS+JDXJGSK4156KmOyWfvr0TVe6FgDF4jaHMgzfGZzogVmVtPgM3XreWf6JJ9zxaLsqs4Np8Xf1+p0KnuETRtX1Onu3OoUGcWn7VqpxGRtIdvSWTdEptxKaROjDaOXkgIu/woSbGV5h1hSlk3C5Gb9S0IzblMt2OcDkkViTfpzxQRpNmbX9h4knDOCZdPh5xfu8R33s/EiUrkTteXLrpkq8PfyxjqXLWHfbv1BmQFmbN6gUUTk8RAEl4aTX9MNNLRnux3SYztfkux6lJjbDZ/SWmuoYLcVnV69gvU7vNSKtYbVVOTUZGATWqwGBwjxeq6ZnaQP5FR2avWQ1umuX8TwkvLELVXAGlctUYt7T0DaKTsd1sQzKyVnyqxf/PCGJ7aWgvT/gaLU6zGTRLAYJc8Ga6c x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(136003)(366004)(376002)(346002)(39860400002)(451199021)(19627235002)(4744005)(41300700001)(8676002)(2906002)(5660300002)(4326008)(66446008)(64756008)(66946007)(66556008)(66476007)(76116006)(54906003)(110136005)(316002)(71200400001)(7696005)(478600001)(55016003)(52536014)(6506007)(26005)(9686003)(186003)(8936002)(83380400001)(33656002)(82960400001)(86362001)(38070700005)(38100700002)(122000001)(107886003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?O64bjFy19123ULYL27AdyTXvvYv0WrcRlsHhhYWNhuprRTHm9helsvWEgTJO?= =?us-ascii?Q?YNNbb9QQrUNv3JlRNHtSCBL7eXN2aIkWo/RtFZjiZGZFEjch+gnz3D0/wDGa?= =?us-ascii?Q?Trq2pg3aPqmbu2t13KWMj/HfjiY2l+IdSICmpX00MNvv6bRpP2iaS5JuY2os?= =?us-ascii?Q?jXRiUImKuun/CSUBo8o5hR86gZbPz+2WHqQPrK5g7IMBZY3XQ/T8gXZhJNsT?= =?us-ascii?Q?2KvZf1QSpP9QXAtAQAcIYkokIaqGTUz6hjpqcao6wAu62O1Q7NExDWsb8WlZ?= =?us-ascii?Q?E3jK8wU3oEv8hhMalgM1/xlBPi3WZfrDYcv8E84XnJh/YPJ5uTj5X+eZh4uY?= =?us-ascii?Q?lgptjcqrOGsALd2LCm6niP4+WGr03ZbeKuRP8LW6BneFPJyRxDUAi+o2SF21?= =?us-ascii?Q?htIzJXn7rSyUXehrf1OhOoT4D5dYx99vc8pgqKw+pm4AR3KKEf+qKd23EMsY?= =?us-ascii?Q?uQoxsmI6sWVNbosnE9fh8NOm/9kWJCr+2Fjw13Ivjwn69gSLPK5g9fEZQ1kI?= =?us-ascii?Q?U7038iF9dLS7o5aKgFCQowg92XGhEnGRR3BobgAuktErAJ44f5Rd0dVJy7aV?= =?us-ascii?Q?KClQGCpKB+pgmq8vlA2oeW8pCEEkYlFZiFHmugX/nI82qTTynDpec79dUCxa?= =?us-ascii?Q?jU/W8x5373WHRDMkMY6u4RPMsmtwlT0qjCAkSotqCAcnouiRaRBie59mZ/4d?= =?us-ascii?Q?Fv2kiZoYC9JBl8DpINcSmS/aUTrna4eyXNy/0xDXEC75lRvmZxqCylkAQm8w?= =?us-ascii?Q?HAFVkM6f67BMyCPg5ph7amt+eensNUy+PtUL84QoyAhyJ4GTN8wQ1NbMXhIk?= =?us-ascii?Q?zjslqLXsyLoLFlaOkaH82PDcxk0Nvx5x3Ma0XBEjPSCVwSAui6iMrlDDiOfo?= =?us-ascii?Q?lI/A69RnXBu1IxXFvefq0SOzr9ketdjuyLmfRiOmODQqbAmRrFy0xqOvfDCn?= =?us-ascii?Q?GB2ZQjHoNGzqRL+vw8tUmdC0Ft4jjSaHOhwCLjxpx2ldTEGwHvhjKuKvt5pb?= =?us-ascii?Q?IGypz7ZxTgbcd1DdKXax/JKzl9OnbNznemFlz+Vkh8zJfgsTQ2Mv81Nc0tjU?= =?us-ascii?Q?QwQsQbEyYeQBvbJfnWN5cg/JjCBYzDJKOhuqX4CHvGwLxWrivdYA7g+MfbEx?= =?us-ascii?Q?ro+lkpXkDHgKtJskz+CuuOHlkSFqkPFX5ZYknCAj4s3AC4lpRGiqMvk4nN0x?= =?us-ascii?Q?6kx/HlFNq+4KuMX5J8jibTSo4q3Q0/wmqFZ9ASjn0+lMEx2MHAmgM7k81+y3?= =?us-ascii?Q?eWFutPSrPpVSW+I7Qw3Z1piVuisW/oGGUfTakEUC+YDZYvQpTIKSCTncT8US?= =?us-ascii?Q?eve/Cf7Z3TFKA4HAxXxpnjMC5FIj+oo5qLWKvV1d1Kx9Z+XJz8zr6KUtqoH6?= =?us-ascii?Q?ZmK0peG8szIDYgSHMH0F5peguhv+qAIH0WrBNu2oVJhwRUYXguGYRjbyeeP5?= =?us-ascii?Q?LpceYQxxURm6A7iKCyPMQi/AZT0nkM5y16ZTgZwip3Jtc2SF10KvQKmEu1PE?= =?us-ascii?Q?8tECwSq0f+P2v2gT+pUF57z/Nrq+Nhp33om2R1czFQOwiePvBDyawj7FVqpp?= =?us-ascii?Q?q5l81Nt9vmi+JgjC35g=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f031e435-0fed-4f11-0bff-08db31b5c031 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Mar 2023 07:01:28.6062 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: bDKyk7X3St93EpL2TFz64OpAydx3k/H1r+1VXq9kKgFilmktlOuQJz+VaP5q7A3//rDL/EXm8MPMuwVkIQx3/A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5255 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the cleanup: 166(+) 679(-). 2 minor comments: > UINTN > CreateIdentityMappingPageTables ( > + IN BOOLEAN Is32BitPageTable, [Ray] Can you change the parameter name as Is64bitPageTable? Because 64bit = is the trend, I don't like to say future is "FALSE". > + MapAttribute.Uint64 =3D 0; [Ray] Can you add explicitly "MapAttribute.Bits.Present =3D 0"? > + MapMask.Uint64 =3D 0; > + MapMask.Bits.Present =3D 1; > + if (IsNullDetectionEnabled ()) { > + CreateOrUpdatePageTable (&PageTable, PagingMode, 0, SIZE_4KB, &MapAt= tribute, &MapMask); > + } >=20