From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 2C195740034 for ; Tue, 26 Dec 2023 02:19:27 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=gVrpjeerHHcvkD+NCNdSqGkAngR28+a3/WUJGJrpe9s=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1703557166; v=1; b=e2SZ/RuaI+4EKdmF/kLQQU6soHeqwkNO9dsV5z1cjlZE3Q1BwhZwYtlzT1NDn+av2pk77Iy1 r6tbGQa5+htLkHWxCS7YF8278NeoSn9sAgZlEzcNf6SCjIGG/aWkQLDIDqPFijamGYpkmFy97a2 izfeelsZy1dzsxuQGx/NpflM= X-Received: by 127.0.0.2 with SMTP id BjF8YY7687511xmsErvGDwtQ; Mon, 25 Dec 2023 18:19:26 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.13]) by mx.groups.io with SMTP id smtpd.web10.73808.1703557165995875722 for ; Mon, 25 Dec 2023 18:19:26 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="3397556" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="3397556" X-Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orvoesa105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Dec 2023 18:19:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10934"; a="727630414" X-IronPort-AV: E=Sophos;i="6.04,304,1695711600"; d="scan'208";a="727630414" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 25 Dec 2023 18:19:25 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 25 Dec 2023 18:19:24 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 25 Dec 2023 18:19:24 -0800 X-Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 25 Dec 2023 18:19:23 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nk4rd1Kh9zzwvYrkPzC8NjjQzjLqTc65fx2l4356GJTbIgzRPHMxMvJtaZ+AXNDteI3wWU3nPugfEpJwFhYo1obOub+DxNZOS0tsgbkOnAGaciz6tO9cYpO7t0ynpb9HxgEklUeQHgyVH2hLDwOfwXURkwrxjVPkMh0Fjw9/Bfx0dlIzUa1OV6gSqO39+bi2Q5IzXHvtXh6XLEGh2pdbduy8C7x+H3kxxbK22h2bvksCfgAIuY9fnFFlyNApMyi1CfMxYDur/X9LMT2jIMSQ9/Yr+WfGO/SoFkxNxoP9FhYZCOTUD8g16sflbELaQxmSIR2Rtdf8nYlp6oWkh7KWcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jj30xCuxRLaa3BxWcT22qH2GzQJ23UX9lnTEKrExCYI=; b=XmE+7Gfla+ov5t6z48my9yNPbXWOy8+iboVK+E7QbB4sKrSSshroIhqsOViFxbQtyYj1thQrJ7+wL9VOZ+7rpQHw1/NsJxlaagrTdK6+Z04/LCfHWTyC7f9DX3CIsi3LxwZ2TsxT3CDHaacDZMtSIxGqQH+lHOe8DWgKzFKPaNTUV2kkC7flBZmIYHRIpoQm/TaXPbCSYF33iLi5LAZSGmqovsSl4AlonQbIYM3J047WyP9lrWbq6Fv/fp43StnCJsfcMqW7oyPto9KdTTy1siPtWPdA1yfDOVFkNya+P4Ew2KVzmgJSk9G+bykqzoFIttC9zjEUHdYKQgFaJfemFg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7804.namprd11.prod.outlook.com (2603:10b6:8:f3::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7113.27; Tue, 26 Dec 2023 02:19:19 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7113.026; Tue, 26 Dec 2023 02:19:19 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Dong, Eric" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v2 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Align BSP and AP sync logic for SMI exit Thread-Topic: [PATCH v2 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Align BSP and AP sync logic for SMI exit Thread-Index: AQHaN05TLZYbm/tl+E6SzVKMIdEKlrC61Tgg Date: Tue, 26 Dec 2023 02:19:19 +0000 Message-ID: References: <20231225162034.2052-1-jiaxin.wu@intel.com> <20231225162034.2052-5-jiaxin.wu@intel.com> In-Reply-To: <20231225162034.2052-5-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7804:EE_ x-ms-office365-filtering-correlation-id: abecae12-7ba7-4a3d-4f96-08dc05b91119 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: DJS586W6WgYwNmTO5EWgasrjpSbT+9H6ZgyXRq2D1g3lLZn6Zss1lw9p3UH1ttC4jBxHRXZGOc36uWSEPJI4xoohF/pPHSjg/LMxYtCGR/npJZ0OHK+5ZqdfbwecxherCumHID99Izb0q9Zo5Dp2XXQVBwgBldmmYmHqF9xdoYYqEcPpVKpLiDXkFo46Fu59OLNHh68/r1qFr5SlPCr9gUKy2s4TT4m0uthANDi5Me94tflUwbVd+xYabJtOtteisi338uTi8biSIRTEbUSVU40p6urzEIn1rI4MnjT2YxUX9hFh7NjZyDgeD5tcFW5KetYgY6obM7h5R+0WHOLzzdi4Ma9GVPLsTcsh2YuhpoRsb0QbGD9dnVWOeNrO5akqzu7f+QDd6+Uk2O/wiGNdC1896j1o/92BvUFhcKUJVi7owbdG8sP6U5YQ74pgj2TIw2miqICydyNn3jSvEx8ShVGzUeFnvTwPoAKj2DtnY8ffVODO07hsyOJCFsIh6aY6uxZ357hlYZrJHOZwFMHE9aofv/Jl2mksUANUglvrsKsQdS6kSJ9KrXoQNAs40QOYaTFTVbjuoGH9PG8UcwXIyvQa9xCsR02hmSkXxfI5utq6AoNNummLtm43VsR+KCI3 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0Rni4VdaizBDjwVVAf9+2P2xpwy4ilxLcOak8qLGP/r7wbzLQP8R0bSWIMkM?= =?us-ascii?Q?h7Akq1X3jQ/8rN6hG+WOZ0Zyp/nsP7klvCo3HbDjIu80ph3PIrjDqN4Nqsef?= =?us-ascii?Q?2zn4GtEC4fAoklkSjqbzTG3HGpitZSHNnmRWdp38cxuKeu4luDXx3q3rHWhd?= =?us-ascii?Q?LIWv2un6BeQ6JMDiSvco6TyX54J+EIKJT8XQYAaylN95HBwYd/EA9TfbV1pC?= =?us-ascii?Q?n6p/Cz1hkjaRz2WM7RF1ZSLixlCixbGEDQB2ASHEWHPdP//unH0u7PuQ5BTu?= =?us-ascii?Q?tb53URyw+iCYSqx4XTv5saQS7uHPfy/d07hLBFhz2p7xzl8BukpN1ugavSgo?= =?us-ascii?Q?fudy0yWzSKNHTJbSV/kS0JISpauPw8SwllP4HRblNw+qZTdzCDwCfHl9zvHK?= =?us-ascii?Q?fFuLzDSFHyhtgZHMPYXHr65etfx9q+8s9+FgMkkBWsuAYipujg3M+jf/zVcf?= =?us-ascii?Q?W0VP15Wjs1txeeYotB0NyXmWUpcqNtRc2aC83oMfRbhD1XFeC7XzlnG/USHJ?= =?us-ascii?Q?5s3QgmEhDDgEVItiO397Pf5tOnxot6Pvv5wNvTW832AMzN3GWmbg4nGlRPnq?= =?us-ascii?Q?kdrwRmVzJ7L1RlRHgq1wqpSyO3d+RPKYA93Io8fFpqFzsoy6hbOVLp28In25?= =?us-ascii?Q?W1tzN5vZmQPZBlI1GKPn9UOh635YTTbwDUK3rn5wVTbqcHDzL6qCN2YXDwWU?= =?us-ascii?Q?B3lH51TGM/aPuadIyK2OfLunWTIhYghzjpcbO3UEpCvdclbXY4daqTLjwtn4?= =?us-ascii?Q?M37xgM8jKxoe1UmW4HwgenapDKgkm8terC/ekgmzpLUtVQWH8K6zebaeZsqa?= =?us-ascii?Q?1AW7bxrspkjoDVgNHUChcMGue/Cxllw26c1LyRZ7CC2GfG79VIv6XqabbCBU?= =?us-ascii?Q?T29a7yulOLWigz5g+jufyuFGGzu2Nfqi7FmVVyuuPhDNtYPg8+uHpJPjUmiT?= =?us-ascii?Q?piDe3P35VOMHkV0pZyOMBZ/8Y3BaDDSlRLCCfDzjYuoRQjNDu4puZLzXyN5e?= =?us-ascii?Q?x5jI4IVlE5XYzOonP+VLZwaKCaAtsA2mvrnP9Z/uhY46aJn1sz4A3QccW488?= =?us-ascii?Q?5F2tHGy2OElb0jRI8uVLckX7hOD77h8fRZHrMT+bM0YYroGMcNK6NPvrXraZ?= =?us-ascii?Q?PL8LcyUXdFgHiMcsQDtogtCr01o5mLhCGLwz+Xd/1xt87vAFBMnZZSCZDpCY?= =?us-ascii?Q?2P8PKj0oHOcb3ccleGiwwfgfE/t7KA6EfN3UlPt4M27Nks+ZAi/0Q+31+We9?= =?us-ascii?Q?HTI6LClPspz0H3AnPQcrpffJO5B2oc2DBMHbcsDBlO+H23MFdiRgw7x2hLIH?= =?us-ascii?Q?tVO2CoxLnrvbjPvA8kF2E43SbyxAa8HGbC/9+9kKEqkYUVS4F/MuHLyDmza3?= =?us-ascii?Q?I6CY8GQy/q8oPoL8ccgItjAg8+rDCEY5iagbqRv566QkZGyMZpXY/ZZ/WsCJ?= =?us-ascii?Q?JCimSADd75rvrol7+hpcEvNd5dRwGxfOqaIo5cjhfisB/T/o25R7WSBgxja/?= =?us-ascii?Q?1uvmm3LVJ6gAWhmu/QjWt5xGyJEjWKkD9l/CwZ6XXjUPHvzR3BylLkEnbSh5?= =?us-ascii?Q?0/krXBQgRVDaUdAm3RE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: abecae12-7ba7-4a3d-4f96-08dc05b91119 X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Dec 2023 02:19:19.3355 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: wg9CQOV9U+C1A8azR9HNkaKzFdVtoqKbMe/3s8h4rSbTecFGp7AuPR/CdZolRHFoVbvGEreDLN676M38uCxohA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7804 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3tiwHwoRi1PQHQrf7cy4D3RZx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b="e2SZ/Rua"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, December 26, 2023 12:21 AM > To: devel@edk2.groups.io > Cc: Laszlo Ersek ; Dong, Eric ; N= i, > Ray ; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R > Subject: [PATCH v2 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Align BSP and AP > sync logic for SMI exit >=20 > Below piece of code is the BSP and AP sync logic for SMI exit. > 1. AP after finish the scheduled procedure: > if (SmmCpuFeaturesNeedConfigureMtrrs ()) { > SmmCpuSyncReleaseBsp (); > SmmCpuSyncWaitForBsp (); > ... > } > SmmCpuSyncReleaseBsp (); > SmmCpuSyncWaitForBsp (); > SmmCpuSyncReleaseBsp (); >=20 > 2. BSP after return from SmmCoreEntry: > SmmCpuSyncWaitForAPs (); > if (SmmCpuFeaturesNeedConfigureMtrrs ()) { > ReleaseAllAPs (); > ... > SmmCpuSyncWaitForAPs (); > } > ReleaseAllAPs (); > SmmCpuSyncWaitForAPs(); >=20 > This patch is to make BSP same as AP sync logic: > if (SmmCpuFeaturesNeedConfigureMtrrs ()) { > SmmCpuSyncWaitForAPs (); > ReleaseAllAPs (); > ... > } > SmmCpuSyncWaitForAPs (); > ReleaseAllAPs (); > SmmCpuSyncWaitForAPs(); >=20 > With the change, it will be easy to understand the sync flow as > below: > BSP: SmmCpuSyncWaitForAPs <-- AP: SmmCpuSyncReleaseBsp > BSP: ReleaseAllAPs --> AP: SmmCpuSyncWaitForBsp >=20 > This patch doesn't have function impact. >=20 > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Ray Ni > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Signed-off-by: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 20 ++++++++++---------- > 1 file changed, 10 insertions(+), 10 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index 324e85d6b5..bd2c9f841b 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -625,33 +625,33 @@ BSPHandler ( > // Notify all APs to exit > // > *mSmmMpSyncData->InsideSmm =3D FALSE; > ReleaseAllAPs (); >=20 > - // > - // Wait for all APs to complete their pending tasks > - // > - SmmCpuSyncWaitForAPs (mSmmMpSyncData->SyncContext, ApCount, > CpuIndex); > - > if (SmmCpuFeaturesNeedConfigureMtrrs ()) { > + // > + // Wait for all APs the readiness to program MTRRs > + // > + SmmCpuSyncWaitForAPs (mSmmMpSyncData->SyncContext, ApCount, > CpuIndex); > + > // > // Signal APs to restore MTRRs > // > ReleaseAllAPs (); >=20 > // > // Restore OS MTRRs > // > SmmCpuFeaturesReenableSmrr (); > MtrrSetAllMtrrs (&Mtrrs); > - > - // > - // Wait for all APs to complete MTRR programming > - // > - SmmCpuSyncWaitForAPs (mSmmMpSyncData->SyncContext, ApCount, > CpuIndex); > } >=20 > + // > + // Wait for all APs to complete their pending tasks including MTRR > programming if needed. > + // > + SmmCpuSyncWaitForAPs (mSmmMpSyncData->SyncContext, ApCount, > CpuIndex); > + > if (mSmmDebugAgentSupport) { > // > // Stop source level debug in BSP handler, the code below will not b= e > // debugged. > // > -- > 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112902): https://edk2.groups.io/g/devel/message/112902 Mute This Topic: https://groups.io/mt/103360805/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-