Re: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build

["Ni, Ray" <ray.ni@intel.com>]

Thank you!

> -----Original Message-----
> From: Chiu, Chasel <chasel.chiu@intel.com>
> Sent: Thursday, May 25, 2023 7:07 AM
> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>; Gao, Liming <gaoliming@byosoft.com.cn>; Dong,
> Eric <eric.dong@intel.com>
> Subject: RE: [PATCH 4/6] MinPlatform/build_bios.py: Support performance
> enabled build
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> Thanks,
> Chasel
> 
> 
> 
> > -----Original Message-----
> > From: Ni, Ray <ray.ni@intel.com>
> > Sent: Wednesday, May 24, 2023 5:29 AM
> > To: devel@edk2.groups.io
> > Cc: Chiu, Chasel <chasel.chiu@intel.com>; Desimone, Nathaniel L
> > <nathaniel.l.desimone@intel.com>; Oram, Isaac W
> <isaac.w.oram@intel.com>;
> > Gao, Liming <gaoliming@byosoft.com.cn>; Dong, Eric
> <eric.dong@intel.com>
> > Subject: [PATCH 4/6] MinPlatform/build_bios.py: Support performance
> enabled
> > build
> >
> > build_bios.py supports caller to pass in "--performance" flag but the script
> > implemnetation just ignores this flag.
> >
> > The patch adds the missing logic to invoke build.py with "--pcd
> > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=True"
> > when "--performance" is supplied.
> >
> > Signed-off-by: Ray Ni <ray.ni@intel.com>
> > Cc: Chasel Chiu <chasel.chiu@intel.com>
> > Cc: Nate DeSimone <nathaniel.l.desimone@intel.com>
> > Cc: Isaac Oram <isaac.w.oram@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Eric Dong <eric.dong@intel.com>
> > ---
> >  Platform/Intel/build_bios.py | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py index
> > da4097d5db..9c95cfff76 100755
> > --- a/Platform/Intel/build_bios.py
> > +++ b/Platform/Intel/build_bios.py
> > @@ -1,4 +1,4 @@
> > -#!/usr/bin/env python3
> > +#!/usr/bin/env python3 # # @ build_bios.py # Builds BIOS using
> configuration
> > files and dynamically@@ -421,6 +421,10 @@ def build(config):
> >          command.append("--pcd")
> >
> command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelectio
> n=1
> > ") +    if config.get("PERFORMANCE_BUILD", "FALSE") == "TRUE":+
> > command.append("--pcd")+
> >
> command.append("gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable
> =T
> > rue")+     shell = True     if os.name == "posix":         shell = False--
> > 2.39.1.windows.1