From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.1752.1684975461656811274 for ; Wed, 24 May 2023 17:44:22 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=jvpCixDJ; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684975461; x=1716511461; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=5EN5kgMYEQ7BmLoJj5+hue9TlzyBiSzROt21yAOuyrY=; b=jvpCixDJ2hr6sCNq48L+B1XMp6lUuoUZIQwRA5Q14bczNP+QTHffyosI p0w6yr4zSuUFaJtGIV7QNa5ifazttBW6P0exInhipoxuC5fDh5H3XJw2o mq0Bx/oj3nEyVQoAVw0Ozbd/DWS9lAbgKNMFbF/6MUU9/3RB409weE2mj TLYHq8uJitoj5ko1Zdiw0EAHZZh/Ej0fweszhOIMOxlzVhKRw7zOalmCu wqqSR9uqQTB4hUJsnYJKvNIIXSJ2uWsPhhUX1A/Dq3CYAEnyxxjXnzSNg bWteAlt1a4dCafzBUo2cGRci4hXnwkqyha75Wh2iTlGlDPCtc9qc7fAWB A==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="343199252" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="343199252" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 17:44:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="1034766663" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="1034766663" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga005.fm.intel.com with ESMTP; 24 May 2023 17:44:20 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 17:44:20 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 17:44:19 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 17:44:19 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.103) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 17:44:19 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iBaE5SDJB/BjyTYQ6YLGAoq+sHZPTlLXpuyw6VE/NSUZPT8cw3E6wshbf3Ugp9v9sW16McgtwgtZShHhGQep3opKi+C7ByEZxuaiqBVVFwG1Ls/SlTETc/MT9QDb4oZqDQ3n1EgMNDYgA8WZ83lLZ2HeWDkJTb/7IUnd2Ml5n/ckAYGCGI4tmiUiAzPlUP2/p6Ah6Iy3E13I8FlBcLIOTxAbXVZDa60WwDxdgzcjgpdN8Fs5nz3y1rdqKiBJ0bH738TKJPmOBU2BTNgwyl0S5vhKz/tTQyc5e/EhF/Dld9pS44KGbcLx4QKlFa/uzc2m8xSljJEmXOBnmIcWhZbt9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3uBtgSJVV80Wknv1LHEgsPmPLwS9sQTpjywExAYpz2M=; b=T6S5u6Szr/pse8DSqkkACQW68Ba5LMYp52dFiszJy7cWHgWAYRfQ0H+yP/UeGWR4bKuel6j8zwWpJ4i7JB3dO0tg0Czu6BopSOomY1q4ITInvHwdPTrTQt03FLVecEBhlOPwWn9+7EyK+iQxy5/hqncOFN0a3O6sxksCk5q5mFUqy/7vuHJrUnbCesbW2Jq405Gnnu63yr7oYMlfXs8FcVoJbVV+oGXFZjG8TQ4+Qr8oTwj/mNSDP67924SiaogOF0zb7PYygQ0oRL3IOXN1ssN4TOAKjmKHIgYjakVcN4GBw1oh3cV/PfwGG5UkHAmZI3e/QcCzK+M2CtFXtJSIIA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB6449.namprd11.prod.outlook.com (2603:10b6:510:1f7::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.28; Thu, 25 May 2023 00:44:16 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6411.028; Thu, 25 May 2023 00:44:16 +0000 From: "Ni, Ray" To: "Chiu, Chasel" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" , "Oram, Isaac W" , "Gao, Liming" , "Dong, Eric" Subject: Re: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build Thread-Topic: [PATCH 4/6] MinPlatform/build_bios.py: Support performance enabled build Thread-Index: AQHZjjtgzhu4JqC/+UOv9cor1V3NXa9qDFDAgAAbQMA= Date: Thu, 25 May 2023 00:44:16 +0000 Message-ID: References: <20230524122852.2047-1-ray.ni@intel.com> <20230524122852.2047-5-ray.ni@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB6449:EE_ x-ms-office365-filtering-correlation-id: ff74eaaf-2364-465f-a16c-08db5cb92b29 x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: HZirq1Zpd9ho2E5GJ0TW1TBMrfEfTg0G31MkCOZ+0vvcQcIZgYIZIzwwBPeMAvOV1/aj7KgHzGxyfbX3QJC3fL0cHsDfgWUJnTEpkJ723HWyVxTqeo3O10KqVIO99688rrie86xTSh9Vw+gsF6ajbYzYxkrVGdp790BadhH+coFvkkZAutcGDfm4TzqZjHdAA1fXNT4TxjXTZqW+Bs3yG/HZRNtOTcsjitRqB4H8ycJGRcHvsG/9EhDN+BAYdbw/VhwmLbaRHkvg957YVzLViuJTmJxTg2C0Pir1M3/7b8VspO646WmgLt8goTreAxGzQdDi0fg1NQsMW7nwCpA48fkmnbyuVekI1QNyCRzesWLBbNrRHdN/yf3eeMJ+gbsJRSQbDS9EsEw8FGv8tiIj62yucC0LeY+OOGFVMTMiOYGpyz12lnHcxVUd3xINqWg8JaiqqZUtrY4zPtkqZzQG+nDLF7sOKwdoWdKVAJFQp+B0wLrejLXlgEqCPJRHqk5ZaokrLJGSBvZ9A2Twrk1ypstxJGCulE/h9Ilr6wABtYk9+QDTd9VvC+tClWpiQlKQ4FmO7EFMuRJb+G/mJ48ne0N82ET82gqSa4hUTmqRN3jkajIJQKFR5ajOWyUW0gZq x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(39860400002)(396003)(136003)(366004)(346002)(376002)(451199021)(9686003)(110136005)(6506007)(54906003)(33656002)(478600001)(71200400001)(86362001)(26005)(82960400001)(186003)(122000001)(66446008)(64756008)(53546011)(107886003)(66556008)(66946007)(66476007)(76116006)(2906002)(4326008)(316002)(7696005)(83380400001)(55016003)(41300700001)(8676002)(8936002)(38100700002)(38070700005)(52536014)(5660300002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?be1YVzF2+Fr/LIPLZMVCeH8USbeqrJn/2a4Q1m83t0DH3ADW8lfONKwYyN8l?= =?us-ascii?Q?87Wr/x36UYnsYFOEV3DDr39kBMYFFuc8lT9F1C17inbMRAAh6Ccgjny2cYsa?= =?us-ascii?Q?LvmDiZ0RdJeaNRgnZNtzMu8N9gp8JbteSlSIoKYoAAhHPvXs4nFNl2txYpCW?= =?us-ascii?Q?dAm/V4HH+KzNBZLVpYAsg/zeJoit+Oj7BAuI0Kx/axbPZAWU/shOypIzl014?= =?us-ascii?Q?dRVnjTzlv9kL365FACbTdoVM5pc39NxFLUbN5PlHPoO9AMLwHrcvBrhZQ9zs?= =?us-ascii?Q?JIPAnJf2OfTEzNaCPjfyVd9PXraquj0LCwD/IXQZwijLzblNS6W9te7i9JZW?= =?us-ascii?Q?Z52UKZEpVJ/j04/aPKHxS/5mF0/4kQmAnQPt0wkBK+M58kR92uO8qQPNTG+0?= =?us-ascii?Q?14l4sRjTjRF6dEzwrSV7rzdMkuq7tkoM5ZkFbEg6IEGWcjpcbRctNQnBhxkF?= =?us-ascii?Q?vBmPuURWzfgyHMlhSUi0C0r0gEmR9W5v0ReajGvi38cTMECSvSAXP9eoMImG?= =?us-ascii?Q?kVvumWENf/hL4SHZX0xyaqO3lt8MzJ3MPaY/86Jyrplfnm9tScKAqBkAoGLo?= =?us-ascii?Q?0nk6o3vlqKijcBGxDSyvkMO6FwnB0j3Gj21dHBjZ92dSdW/v4ti9ZLH2UAWH?= =?us-ascii?Q?psM4ivgXTe5T5vbXp22R/VfhRc2/XPZwnqV1DSSDf4cOnfTEQJ7cU5gBLjeK?= =?us-ascii?Q?LFbYBb5k6oZMzwdSJ+FHVCeOwpl+03XggYYZvMb7tLolpr+Ul7YXGupdQvBH?= =?us-ascii?Q?nHY4UFEq2bYlsKInnoPgShjp9Is5TtJk4WSTVmGjf8arS0lUjTDPB7qonP9r?= =?us-ascii?Q?rmpVxPaXcL77VZTE71XniP5zLPdZ5KP1x7GxtdD1Tt3KMWS4kcfsUZnUloZW?= =?us-ascii?Q?UqQP/xJtQLg+8nYT9swx4LJctojYRv0WLz77stLggV4qmHk0OStyYklqh+Ci?= =?us-ascii?Q?9q8hQVKrB77CpMHfXfhbQmXFoP4cOpEtVa2co/jM5Xcai45E3hvesiRywxnk?= =?us-ascii?Q?3hgSWpQuDxNrJ9iZWcBnIsUU1k1EHjXWUY7cymdf895XIB+P+NBCMKtVu7ev?= =?us-ascii?Q?1VHWtVe2ommCLQQ3QTwAQN2qqwoBv9oLUiggS8psWMIccyUvkhy5mKdjfpnN?= =?us-ascii?Q?1ZTVgAHOLwzXD1bGMC5CeF3WM6AXgLhrZ3CHUiGgRvZVkblKc+Prx5eYcA2R?= =?us-ascii?Q?WmbuFD0+1Ws7QhjUmnV1u23ts8teRkdZoT4y+h5qtcjHxupGK1BNLeMGahso?= =?us-ascii?Q?NFVyAxyyzRJnGrIyWzOu6AK+FV1fmtzUFALpRo/U9kZoIv5A6CbSSIieMLNu?= =?us-ascii?Q?ns4b51McdH86pdf+OOcQGJECval+QWtW8CXSfA2UM3MR1E6Rn/K7OkuDJbfW?= =?us-ascii?Q?aSvoVvMtfwO7hl9f3Dwr3v5rKvtirhvKm6Wv+Bpwyw4T6n0qTxVMWDXzv5ZQ?= =?us-ascii?Q?n3HIAAuMT6URi4t6LZdRqXhgvKIF5+z21z4EPy590JC1GjPV1lpZh7deAa3A?= =?us-ascii?Q?MaXj+MGFYzZGM3vMrIP1przr9Ay+J0+CMS/qwC/oHJDnjuZS0T+FF6eAePtD?= =?us-ascii?Q?uNbagzIFWr5lk8k2bLk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ff74eaaf-2364-465f-a16c-08db5cb92b29 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 00:44:16.5343 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: nRUffG08fMCT2Q/lknvcKh+daJWgZKoMs4+mF3UfGeJ88LoF3aMkt9+NxgDcfwDZCruthXGuR4cCqzsIn6nyPA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6449 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thank you! > -----Original Message----- > From: Chiu, Chasel > Sent: Thursday, May 25, 2023 7:07 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: RE: [PATCH 4/6] MinPlatform/build_bios.py: Support performance > enabled build >=20 >=20 > Reviewed-by: Chasel Chiu >=20 > Thanks, > Chasel >=20 >=20 >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Wednesday, May 24, 2023 5:29 AM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > ; Oram, Isaac W > ; > > Gao, Liming ; Dong, Eric > > > Subject: [PATCH 4/6] MinPlatform/build_bios.py: Support performance > enabled > > build > > > > build_bios.py supports caller to pass in "--performance" flag but the s= cript > > implemnetation just ignores this flag. > > > > The patch adds the missing logic to invoke build.py with "--pcd > > gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable=3DTrue" > > when "--performance" is supplied. > > > > Signed-off-by: Ray Ni > > Cc: Chasel Chiu > > Cc: Nate DeSimone > > Cc: Isaac Oram > > Cc: Liming Gao > > Cc: Eric Dong > > --- > > Platform/Intel/build_bios.py | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.p= y index > > da4097d5db..9c95cfff76 100755 > > --- a/Platform/Intel/build_bios.py > > +++ b/Platform/Intel/build_bios.py > > @@ -1,4 +1,4 @@ > > -#!/usr/bin/env python3 > > +#!/usr/bin/env python3 # # @ build_bios.py # Builds BIOS using > configuration > > files and dynamically@@ -421,6 +421,10 @@ def build(config): > > command.append("--pcd") > > > command.append("gIntelFsp2WrapperTokenSpaceGuid.PcdFspModeSelectio > n=3D1 > > ") + if config.get("PERFORMANCE_BUILD", "FALSE") =3D=3D "TRUE":+ > > command.append("--pcd")+ > > > command.append("gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable > =3DT > > rue")+ shell =3D True if os.name =3D=3D "posix": shell = =3D False-- > > 2.39.1.windows.1