From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mx.groups.io with SMTP id smtpd.web10.1918.1678843510520438272 for ; Tue, 14 Mar 2023 18:25:10 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=BQeuaWuI; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678843510; x=1710379510; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=NGoHlQl2b4NTFwbJqo/WTlhqlO3h1QiaP5cKs7LqULE=; b=BQeuaWuIm5kxsioKj4P/7OwkejQazDbgJFeZPkYX7ZZu54Wst1/BYJ5n f95GO3hQ+6KoRq3WTUwyxDOWq32slayTlMpk7tMyZcfGBzy0vFLNFWu11 HL2OmUPWJ1ZAXPDGRqKrutsaSfioFkQ8kcNKO5Zv5C+eGH4Gcg4ACJkUk dgCR6Kfy3N6mhd5hYa8/gprgV06/P8PkaGKcH9ZrCHFccG95mkMl4NWcQ zB6HDsxn9scG1cClPf1BYFZW5csG5t4kRIRhbm70syAl3atRfrBcqJPQU uwjVutTanh2oNMR55k7+Q1HHylDQvLv6CHwXUf4XNovKWlxNiSJNH+Urz Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="317238314" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="317238314" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Mar 2023 18:25:10 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10649"; a="656577065" X-IronPort-AV: E=Sophos;i="5.98,261,1673942400"; d="scan'208";a="656577065" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga006.jf.intel.com with ESMTP; 14 Mar 2023 18:25:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:25:09 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 14 Mar 2023 18:25:09 -0700 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 14 Mar 2023 18:25:09 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 14 Mar 2023 18:25:08 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=j0JC5/9BVNRZqYUC8l34iZT+4oAAnj7Wtt+aKgLE9wHF+esqYOQ3W3qMusE9m0AiiMzGqIG8IjqLU8Ixkta9Jni6BPqDQTXVDSxrRggTBFYCIQwsDoSYu3QtfZrlBC8sgAinFEMtBJX9WQ9aFDGBfekvRqoFH5LwIYuTgLBsZCRL04JLZMY0iyNbPzEYZGsfcsXt7TJv/CWp//y0YOuNwVp6+REWPeblc+M9UROsF8UwT7dFzA2HOJtF0S08gCCMEc74bl9iZ8ScPGRKItKe2CkJoKarl8W9JtE1+KabFzq2HONMCyafqQKCCU113D26EPscoeDFJmWFyf8cY+SQ+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vKrx8P7NIZqS5cgmjJKyM2JFXStsUvVeN6GmKJ/kHis=; b=awvrP7HQZqWaeSwJp3TIYDxoiuSaP6ELb9xqMVfxGuEoW6rgJZEorghVTGrhwKvwzJS74+pfdxuaT5Dh5oEEG32iPJRO0ixwanuSJaC1FiRphevjj4Q4nlAJCMa4W09Y/igXsq5iWZiMSwKJMC47/CVrnCxMcr9Xcyan4JacwJYgs4O1pv88+F6ubJeG4P3AbIh1hNF7H2tqtTRdhwz9ZJNFgNIe6xrPVUuEihnXJWaTty2UK/KFRu6wLBqs3AvWKhl4AfFGyrWucqZgqVrkd2gzsQ4MCXQXti/PUOxqVJZtmAKpfeNPS5jXW+juS1tGulQoYfHCgljkgLoK3s6GGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH8PR11MB7118.namprd11.prod.outlook.com (2603:10b6:510:216::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.26; Wed, 15 Mar 2023 01:25:07 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.024; Wed, 15 Mar 2023 01:25:07 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length Thread-Topic: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input Length Thread-Index: AQHZUaX3sQFXw7rJ1k6DgmnSKyk7xa77FnxA Date: Wed, 15 Mar 2023 01:25:07 +0000 Message-ID: References: <20230308100758.669-1-dun.tan@intel.com> <20230308100758.669-3-dun.tan@intel.com> In-Reply-To: <20230308100758.669-3-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH8PR11MB7118:EE_ x-ms-office365-filtering-correlation-id: c110548a-493c-44ea-b91f-08db24f41c79 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: WfArYTuRm+v3Jsbr4mWk2H6SoKkXJUjJCu0Tzy7YmjL55sDGaHGXvDI0+JvZ57BblmGcolGq5A9jXThmltHAkZRyjBMHcjcBwfrQ5ADTuJMpAbt650UBDdUBRmq4n5Eoe1/9SwW5kO4Gx86ZlrPtLv8Gnl75gVGJm8/5AN6WmZ3Z0W/g96etgLW7FddhZIRu8owZo3W1QsgEyhMmEwEondijvnE5M82OhirzLIHh1WcSswUgsOkJPdfYpgPAtEKZmzDwpTzwbGBCjhpRfpDmnNrWc5XQhbuFE78IvbZDaJKQhmau5cKBMO+vGp1Tz9Q2jKeIOpqxa32zsy5LnnFTDP1YL2N+190OPyVBmPS4c2X9GkSPgDjqmH8rL9gBDSPZBu7DXIuKWU7R1QmHZrl1zUVB8ANVGtao8CRGmpmaO8UlTxsyuLSWOuhm8bUZLYYbWpK6n90b5t7/zdNNgsmWbwvLgVD9Mh7Eu42i1TIBe2STbYiL/Wr2LFE8K/iPw2nbag7jLzw50Bg085K/7W03et0WswzSyHIVNUegxb2Q7Q1PkMiINU7EBkXJ2hkApGPoZkOPTtjWmEPkRwmaGpwEm7Z/0W2lEQ/FX0q6Nv+jPBXzQTVEfTIjvrCU3ZzbGWx0dljDb1dZyO7qE86CkQ8JNfXqO2xT88PC4oksnDQWlh4+Jx0fXcd5YI8TstBoeNJMeWXnfSiE2650EfgmyFyN6A== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(39860400002)(396003)(136003)(366004)(346002)(451199018)(5660300002)(8676002)(33656002)(83380400001)(110136005)(478600001)(7696005)(53546011)(6506007)(71200400001)(26005)(66946007)(186003)(9686003)(38070700005)(4326008)(41300700001)(66556008)(66476007)(66446008)(55016003)(52536014)(64756008)(8936002)(316002)(86362001)(76116006)(38100700002)(54906003)(122000001)(82960400001)(2906002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?UUTVYAQ04tyjmglk2iMq7upJm5T4N8QPDwF1fS8/1fuOI6rn5MEt3bKPCwE1?= =?us-ascii?Q?9qp0Rj55GhUeb2bcDStA3UzoSOzD2zx9MyevDfccF19CjRdoGNvkHVXeEuNy?= =?us-ascii?Q?5GtG41ZElxEsVu9NxaNUCvya5963BF+x+im17DYQ+rG5XYL+sRCsB+7fV2d0?= =?us-ascii?Q?lSxUsMa8W++PRjg4wX7gFq7/er9fQt0EoLmQ3+PgmjKp9ZM30fpuNcd+eUzl?= =?us-ascii?Q?HMB/Q/6WkSz3jNBU3a7AXgehywOEwPewRsZzNYBYPg4wTOXBhk7329Uosqjc?= =?us-ascii?Q?prjwmWu3Pqx4ksN82w+my+6ugN7BN4d7ZHM+7POOSmGZ877eOZ22u1Ieuy2W?= =?us-ascii?Q?8yi+T1DPu8AHQ4eL2BS9Ixtc3UmqTPmgcP+g3fQs0c5ZxpiCIe18ED9lJE6Z?= =?us-ascii?Q?fb1qz8EzoIowiDJ5mdEGyOy+b4rhFR3yxyS82fcSO7KgA2EfG4pSqcubwpqO?= =?us-ascii?Q?a3W8z5HEwBh2Ia014B5bLlVvsDP3ovA+Gc3jB5gAlNHepUS17VdbRozzyaqX?= =?us-ascii?Q?Xmewna6b3e11x0+43DPJkDlAKdmvizZlE7h8LMkBNbx4RmuuX4UybOIJDRr7?= =?us-ascii?Q?TXITyk9uoACmU+fDJUmYl3hgK9tpm4FB3Jnc7tZ5+IYjax94DNkWdetA9BTY?= =?us-ascii?Q?HFfY16RVsHcQ5QPeB6tPYSDwbv09kvUh9+hxxMsK7JrX6nfuJPZyKyvlhGXs?= =?us-ascii?Q?0tuSkvIK02eQMIztvxdUwql1rjMLaweDK8gZlIRVBUW4D70rQwk+Op3SaSoS?= =?us-ascii?Q?1jJgMs6D8OKB7J6JdxCDmMeneEJonPeWdz4Kl8Xq2TixgujS26YWlL9ciZcI?= =?us-ascii?Q?4KJruDdv5pHLE55kHWmm/jPSQQc03VtILnk9J0FdItfloXFS4i4YRaZqi9zU?= =?us-ascii?Q?UmZaMRKfcDkLlnJt+qtux01xAJ1kgbcBdmr67LvSPY1++b8Ox0DNcDqSrjKx?= =?us-ascii?Q?d/R1GIuvCjMYtIM8rzzIZN13e5E/EdjHbfWv3NAgBdgHvzMRYjqaJOiHqXWD?= =?us-ascii?Q?Jld7l08+5qSZZfkYzQex0c9X4/qZBsSO0d5bXtaf0sxUCCd57amTqrQrTSrL?= =?us-ascii?Q?2VcegV/EBLkNLWSUrNWVa8e68ThQH3YhMJFy6UGvLfqu4VPr1m43UEv6UgQ8?= =?us-ascii?Q?uNImF6b1TybSo+RC0cZv1PePjJ+MRcn1udWFKpkjCGTBPJ9d6VF1jx6QMY8E?= =?us-ascii?Q?4D0GAMfp74ddGrStXe5WELy4NrWQIK/WrGwBnyLvbB8IQ14RMZE2kA3NdGR9?= =?us-ascii?Q?Mj+QTI4MAPzfzzcjb14ufKOWOuFbgpwXsqYW+I+SHrqBvhyTSxq7funwPbmj?= =?us-ascii?Q?jBaSnQ9Up64K8/GawhzTD65EwRg6KXsO1BvA1nwVvqEtFOFCkuKbwJfpJjuz?= =?us-ascii?Q?vhhQwjp73wj/LWUKB3GV54hyRZBvY6xa5F5WPZW5RfV01o98vV7w5uCJtFFu?= =?us-ascii?Q?wUoT85Y7hZJ0SNDM99+RVjXpGxRmYQC4T4m/5CrLh21tsTv5+t1IvPj+b9+9?= =?us-ascii?Q?8N/pYk2qcj1QlB6RKfdehARCah7auNeSTiX9FYhCWXFmSoCDDGsL5Vla5lBL?= =?us-ascii?Q?kCOgsEgeU+CxdK0wnOjRNMIbjUqCjELSpboXDDDD?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c110548a-493c-44ea-b91f-08db24f41c79 X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Mar 2023 01:25:07.1260 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m9iQ8/93OBHi747d9SaXca0TbgVpCPbiWoTQflMOEsOOq/BU2w0P/ZevuQOZJd7+nED9KR8GO0cjkPI+hTeFyg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB7118 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The function header comments in lib header and C file should be updated as = well to document a new condition when success is returned. > -----Original Message----- > From: Tan, Dun > Sent: Wednesday, March 8, 2023 6:08 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann > Subject: [Patch V2 02/14] UefiCpuPkg/CpuPageTableLib: Add check for input > Length >=20 > Add check for input Length in PageTableMap (). Return > RETURN_SUCCESS when input Length is 0. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > --- > UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c | 4 ++++ > 1 file changed, 4 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > index 47027917d9..4c9d70fa0a 100644 > --- a/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > +++ b/UefiCpuPkg/Library/CpuPageTableLib/CpuPageTableMap.c > @@ -567,6 +567,10 @@ PageTableMap ( > IA32_PAGE_LEVEL MaxLeafLevel; > IA32_MAP_ATTRIBUTE ParentAttribute; >=20 > + if (Length =3D=3D 0) { > + return RETURN_SUCCESS; > + } > + > if ((PagingMode =3D=3D Paging32bit) || (PagingMode =3D=3D PagingPae) |= | > (PagingMode >=3D PagingModeMax)) { > // > // 32bit paging is never supported. > -- > 2.31.1.windows.1