From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web11.2727.1672966865396054017 for ; Thu, 05 Jan 2023 17:01:05 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Os7wEhxB; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1672966865; x=1704502865; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=15Zt3iT6BuoWvx/EGO5myIPCWHOqhLy7hqqBJM4wPp8=; b=Os7wEhxBQ69y8j8sds5U2FWjG3kmyEtGraW65j2Gs3xtf7D6m9wm0VtH LEwIfV7ldRwG42JaLUUBnPpefyT+uVrmM6yJ67fUDVKau35DhcZzji9FK ec8OMuXurPrIV/3TddPQxHiMWSzyYHUrl5y8hVQH8uWwKVmku94D57giL IZYiCgCxr86shBWJ61PafcM61rICNdl+U4thRmD0lixjNEnc9u/Nr1K5w ausr7V1LuCHN6FeYAECrMN6yLiayhn7c6zYVBA3JW8zeqUHQoTlKM970Z QpnieTkjPkZ/KPzsiLDenKWJGv6lPRrR+H5vdm8HH4SdjjzOWFgNRIofh Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="322432375" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="322432375" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Jan 2023 17:01:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10581"; a="779824992" X-IronPort-AV: E=Sophos;i="5.96,303,1665471600"; d="scan'208";a="779824992" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga004.jf.intel.com with ESMTP; 05 Jan 2023 17:01:00 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 17:00:58 -0800 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Thu, 5 Jan 2023 17:00:58 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Thu, 5 Jan 2023 17:00:58 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Thu, 5 Jan 2023 17:00:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jbUbMZhrfKHr3JiprkAISAUTZZhvo5utyhiYNPdcas3Nl92XLySlGpA0stS0vdCwhUCw1UdEFlVUAGJlTjE6NlhOg3FH+YesbeS0MEliPpJTtu6qEFojtgG38JEZ0V4oIrZM5BKgcAZZEHDbEzsHqeIaVbeHrPEcN2JM/JzyuxB1uNI/wYyijPZXavaGGoe/u/Z7aRxqhudmINzSkPVYH7vD1fjMu0w0zLmWKTSbWuHd9k6wO9ZioTsesXcs4A9t6Ht8rF0pfdHwZOvJbT3iGQoPt34L7YQre0VJjQXIwvATAHZfcMKvNfqQtWRbegXLtNtj4rP79WYqcPrV3ICc0A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cvXZOes74pYdE3FuyfXxJJC9HQhBa+tSSx3a7yqJV/Y=; b=FO6sEK/lC6BC5KS4KLRXtTXiCjCH6HXmtHcbFTivQhfkXisFppiEcxEtCIpjygyoXQ2MIf34eyBZhD2tQoHHKobZXi6rCJUyKqQ9oZ2nP5HkGjF5viPxWyPVMaIrnuWzjovC0xmKItn9QbX8hfYn9RgxtPRnFK2cGgR+6sDCAuv9CkGGOkPTltmv1VttRFFQ3IQqBwpBa8urHZ73Mia41qMtD2ClrCUXzZUtUWtmY+KZ8QaIdMLjRpHFTuDDHUA9/c4en9PTfLIvxlGhWqLWCdcCN2rBNVHftP4jf69HHj7yRvC12jl6BLzozbW0d/L2F4NO6oXUZFGJGarmk3rgzg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB6541.namprd11.prod.outlook.com (2603:10b6:8:d3::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5944.19; Fri, 6 Jan 2023 01:00:53 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%4]) with mapi id 15.20.5944.019; Fri, 6 Jan 2023 01:00:53 +0000 From: "Ni, Ray" To: "Oram, Isaac W" , "Chang, Hunter" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "S, Ashraf Ali" Subject: Re: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Topic: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition in FirmwareVersionInfo.h Thread-Index: AQHZIBFQ29MyYFVVB0+Ere1ZhXnyaK6PZ+hQgAANwoCAAB0rsIAAo/2AgABcRIA= Date: Fri, 6 Jan 2023 01:00:53 +0000 Message-ID: References: <20230104074715.1782-1-hunter.chang@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB6541:EE_ x-ms-office365-filtering-correlation-id: 363aaac2-97ad-4bf7-aba4-08daef8175c6 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: yQldYfEume1iVYb0nZkODuFFO/O1ispfokd411RN5xr1oZkzgEvPOm1O2Lrdyun1VMIcao6OtXIr8fTKcobNwaPf0SuhwygrhrVa6ed04Snxf23p7WlwMXk/SYs0cJ2RFtuCAiynWGMDQQrkJ+dqxSI0y0JvYs/EFk2DNCcMaj9sRZQYXdrPzuNz0aHPfEMqUy0mJ6PBB+eOT8Bcg/7hOs/4nGzUChm9OHDCCokBh/wHgS3dFUetVWIllXxobrfzc2akMvTPqWAVdSZKWVpELjMg7s5XEe7ZTHCjPivmwuxC+YCOMmZkUmWdIufsz4WeNJZpicFVBEVrUkQ9cJleuO7TPZZGckYVPUR3j6raBd6IqTaRlQnvX3qrp3+SFcWVUWU/nVJt2OLh2NUXqPnZAOEZTMmap6/0TbtCfOO7GANpV+56hzeG03eyUF4+a4HfO4/iMMuVNU1tUwDsO59YmO6Tg6nNAQiKXZAtHg1KoDyHTup2EbyqUSXooBYBn42o2JXxGmGkQ9Cn1ftGrhSwJ768T+1PUM7tRsmpPBPzDUHERnUJoh8wNxnSD9tqLlM05Hc8U5FeaOVYGs3Ns2uWOaPBRa26KzzD9Zs72flgESZPU2p90D0pReFAjDu1T/PD7lFlFJv9L90sz5+CKhPofeojmTu26b6v9M4Edx1OcuZaLJzqhCpdhWxY3OwTcgxVEHCKA3CmVygnMzCaImjrBUr5xTDnh4CVbSuJtp/Rnv0= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(376002)(346002)(366004)(39860400002)(396003)(136003)(451199015)(5660300002)(52536014)(8936002)(33656002)(966005)(38100700002)(7696005)(2906002)(83380400001)(41300700001)(53546011)(478600001)(6506007)(54906003)(66556008)(66446008)(110136005)(66476007)(316002)(66946007)(76116006)(186003)(82960400001)(26005)(38070700005)(9686003)(122000001)(71200400001)(55016003)(8676002)(64756008)(86362001)(107886003)(4326008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0uYLvzrdlE04tlrE0FkAsu+yDs6ilyp9U95YMPi/rC3/P+pBYS8X0G0j6Go6?= =?us-ascii?Q?8lynH2LNp9tqeDcQ+yiNPer8PWcvA4nqnBgLeosJ4Tlq51ZAxYAvY7S0Zbrf?= =?us-ascii?Q?cj9f70WHzwsrBfw6Lc/P/c/2gEIq1e9TfmSaX7r7K/nQi6lyYtIzHY9fdkm+?= =?us-ascii?Q?ago8QjUXVw5ke8PzmTsYCNRrcJhvx5bvUtpoQ2aNz6uk2ATYdnrR7g0YIpTU?= =?us-ascii?Q?g3NM9tAPPwjvtfkvMQ2zUTcK5vv8RLH8898CmKxhU64GQkCL5tntAvxkVjH1?= =?us-ascii?Q?rxGtVIv8sLIzxe+gujiMCUH4+J+KV7SoZDkO6+h1a3HTMkyi3LMsBnPjn7WS?= =?us-ascii?Q?yUYQPWsm+Wxmsop2sHRQK5jX+Mj0uc9uOdtDbRxZBtjYpjuGa+EnwJPx6VZz?= =?us-ascii?Q?+Link3Cx1FpWvW823VHVSZvCcSoKJ+ckwS+jnuzLF79BGXnzVushnWGxY5/k?= =?us-ascii?Q?hmLRweYHVbkhVBBsqEpZ0pPsQQOhYRmNqrHd7bygQz3onmpM7ePZ6zf48Yi4?= =?us-ascii?Q?tQrII5h15sGqo5pUmhAUOjZH5CT2cuAaF6qS+fJ/EJz3+lAmz9nCT86lIecm?= =?us-ascii?Q?CJwnsZ2dFksI0NnCGOQmxdHlr0grN2QiN9TNqJM7Qz/sfzeVdZ838Ddyejju?= =?us-ascii?Q?4pUTi4zuhzvr/+vk6Qc48APVqN3WKwIc5qEM08OLWlVlYyKkS16q9EDmI0ru?= =?us-ascii?Q?AfYW1LndxoME6+5b5OF/+p+JMnjTAd92cZnhCBcR1e05qKz3k56nLWM+S7gF?= =?us-ascii?Q?s0qyDJ3J8WPPDMNBl15S37cgRcwcRdt2BlURvzFp0N5TfeUVKkB5bAKNfMFK?= =?us-ascii?Q?HWIIG7AQ/lTZHDyEzMJiHE+K04wNkBfdAtQBVfbpboT+OHFbL8VagzDkAROp?= =?us-ascii?Q?8JMwZqDOTegge28N/+1i0nhaCWR6e+TUBEaQIPw29a5m/1T//yb8Yzl/kDSx?= =?us-ascii?Q?S3/AgtR7cqAV7dLpCIf6ym2WMHrqqQbIdo1rk1Pz3c1ma2hLPHjomuSyavwX?= =?us-ascii?Q?Ie6k4d6ULDDC/Zmjnje7MMQA+gIkEXXUX33Pio6+Z/OGg0JfmdQLiGKHfjdJ?= =?us-ascii?Q?HPe7+no/pEec8QTdVJD0460BocEOhCwvGFK2YPkf7tAmsv7LLX1VM3+SluwN?= =?us-ascii?Q?ul2l4PH15/zBEythRWphecniptU+ZmlyPK+ccjOvwSuaJhw+b78zifApFZEu?= =?us-ascii?Q?vIFN0tu0PKWvpOO+s3piAU2W1DEoqvrNCkXtpHCiCRuVKwsqA13rUFNdV2u0?= =?us-ascii?Q?C0av4ieD98X5HDXV0Coi1Q28cte1BtBMiOpZzk6efkxfftsHS58BzE55oYsW?= =?us-ascii?Q?ZwFJb/Vl/qrfyhJz59DGJ/Mdu8hDm/jo+ZpyGIzdIGkLbYDKJyIfL/f39MpL?= =?us-ascii?Q?6RQvTlG7i+slVLDqwCyo28esXmSyIoWFtQaePbeuvti+m2s6RhGONer2at3j?= =?us-ascii?Q?BgllvZdWv5PPSI1+msz99DATj391v2cm9xDpPkkrLCcZevjvWUiVTMTES4Wm?= =?us-ascii?Q?wvveBoUwwGp7wgTrI4SF1S604GqdKmkGF0lUgAoN2K4XxUJMt2TczWNZFZ6F?= =?us-ascii?Q?Bl0+u7s85/n6+2mj3As=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 363aaac2-97ad-4bf7-aba4-08daef8175c6 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Jan 2023 01:00:53.1807 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 4uJjRBGRSIwWKpC7SmxI3UALdXEPxUBpiSuRsmX1xWp/55aYrV6vfwBjqkLin5qQzjW8xGLh0XlKrwgxUZbrgA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6541 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Isaac, So, no public doc defines the SMBIOS entry: SMBIOS_TABLE_TYPE_OEM_INTEL_FVI= ? Then, I am ok with the new addition 0xDD. Reviewed-by: Ray Ni > -----Original Message----- > From: Oram, Isaac W > Sent: Friday, January 6, 2023 3:26 AM > To: Ni, Ray ; Chang, Hunter ; d= evel@edk2.groups.io > Cc: Chaganty, Rangasai V ; S, Ashraf Ali <= ashraf.ali.s@intel.com> > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition i= n FirmwareVersionInfo.h >=20 > Ray, >=20 > I think it is ok because this file is "Intel common definitions for an OE= M defined SMBIOS table structure". We could say that > the folder name is wrong or the whole file is in the wrong place. But th= is addition seems consistent with the rest of the file > contents. >=20 > Regards, > Isaac >=20 > -----Original Message----- > From: Ni, Ray > Sent: Thursday, January 5, 2023 1:39 AM > To: Chang, Hunter ; devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Oram, Isaac W <= isaac.w.oram@intel.com>; S, Ashraf Ali > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition i= n FirmwareVersionInfo.h >=20 > If it's not defined by any spec, it's probably not a good idea to put the= definition in an industry header file. >=20 >=20 > > -----Original Message----- > > From: Chang, Hunter > > Sent: Thursday, January 5, 2023 3:54 PM > > To: Ni, Ray ; devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Oram, Isaac > > W ; S, Ashraf Ali > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > > definition in FirmwareVersionInfo.h > > > > It is from Sipkg.dec > > gSiPkgTokenSpaceGuid.PcdFviSmbiosType|0xDD > > > > 0x00~0x7F are reserved for and defined by smbios spec 0x80~0xFF are > > available for system- and OEM-specific information > > > > I think there is no spec define 0xDD. > > > > -----Original Message----- > > From: Ni, Ray > > Sent: Thursday, January 5, 2023 3:05 PM > > To: Chang, Hunter ; devel@edk2.groups.io > > Cc: Chaganty, Rangasai V ; Oram, Isaac > > W ; S, Ashraf Ali > > Subject: RE: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE > > definition in FirmwareVersionInfo.h > > > > Which spec defines 0xDD? > > > > > -----Original Message----- > > > From: Chang, Hunter > > > Sent: Wednesday, January 4, 2023 3:47 PM > > > To: devel@edk2.groups.io > > > Cc: Chang, Hunter ; Ni, Ray > > > ; Chaganty, Rangasai V > > > ; Oram, Isaac W > > > ; S, Ashraf Ali > > > Subject: [PATCH v1] IntelSiliconPkg: Add FVI_SMBIOS_TYPE definition > > > in FirmwareVersionInfo.h > > > > > > From: Hunter Chang > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4242 > > > > > > Define a macro for SmbiosFeaturePkg usage which named > > > INTEL_FVI_SMBIOS_TYPE and initialized to 0xDD in > > > IndustryStandard/FirmwareVersionInfo.h > > > > > > Signed-off-by: Hunter Chang > > > > > > Cc: Ray Ni > > > Cc: Rangasai V Chaganty > > > Cc: Isaac Oram > > > Cc: Ashraf Ali S > > > --- > > > > > > Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVersi > > > on > > > Info.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > > si > > > onInfo.h > > > b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > > si > > > onInfo.h > > > index b30bc3f9e7..466cb8e7d2 100644 > > > --- > > > a/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/FirmwareVer > > > si > > > onInfo.h > > > +++ b/Silicon/Intel/IntelSiliconPkg/Include/IndustryStandard/Firmwar > > > +++ eV > > > +++ ersionInfo.h > > > @@ -18,6 +18,7 @@ > > > #include > > > > > > > > > > > > #define INTEL_FIRMWARE_VERSION_INFO_GROUP_NAME "Firmware Version = Info" > > > > > > +#define INTEL_FVI_SMBIOS_TYPE 0xDD > > > > > > > > > > > > #pragma pack(1) > > > > > > > > > > > > -- > > > 2.26.2.windows.1