Re: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add _PSD/_CPC/State Coordination Types macros

["Ni, Ray" <ray.ni@intel.com>]

These ACPI methods were there since long ago.
Why do you only add the related definitions to 65.h?

> Cf. s8.3 Power, Performance, and Throttling State Dependencies

What does "Cf. s8.3" mean?

Thanks,
Ray
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> PierreGondois
> Sent: Wednesday, November 22, 2023 12:50 AM
> To: devel@edk2.groups.io
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>; Leif Lindholm
> <quic_llindhol@quicinc.com>; Sami Mujawar <sami.mujawar@arm.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <gaoliming@byosoft.com.cn>
> Subject: [edk2-devel] [PATCH v3 03/11] MdePkg/Acpi65: Add
> _PSD/_CPC/State Coordination Types macros
> 
> Add macros for:
> - _PSD version
> - _CPC version
> - C-state/T-state/P-state Coordination Types
> 
> These objects were present in previous ACPI specification version,
> but are only added to the latest availbable version (6.5).
> 
> Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
> ---
>  MdePkg/Include/IndustryStandard/Acpi65.h | 23
> +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
> 
> diff --git a/MdePkg/Include/IndustryStandard/Acpi65.h
> b/MdePkg/Include/IndustryStandard/Acpi65.h
> index d79d0b2b5f9c..ec7c34e8e190 100644
> --- a/MdePkg/Include/IndustryStandard/Acpi65.h
> +++ b/MdePkg/Include/IndustryStandard/Acpi65.h
> @@ -18,6 +18,29 @@
>  //
> 
>  #pragma pack(1)
> 
> 
> 
> +///
> 
> +/// C-state/T-state/P-state Coordination Types
> 
> +/// Cf. s8.3 Power, Performance, and Throttling State Dependencies
> 
> +///
> 
> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ALL  0xFC
> 
> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_SW_ANY  0xFD
> 
> +#define EFI_ACPI_6_5_AML_STATE_COORD_TYPE_HW_ALL  0xFE
> 
> +
> 
> +///
> 
> +/// _PSD Revision
> 
> +/// Cf. s8.4.5.5 _PSD (P-State Dependency)
> 
> +///
> 
> +#define EFI_ACPI_6_5_AML_PSD_REVISION_V0  0
> 
> +
> 
> +///
> 
> +/// _CPC Revision
> 
> +/// Cf. s8.4.6.1 _CPC (Continuous Performance Control)
> 
> +///
> 
> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V0  0
> 
> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V1  1
> 
> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V2  2
> 
> +#define EFI_ACPI_6_5_AML_CPC_REVISION_V3  3
> 
> +
> 
>  ///
> 
>  /// ACPI 6.5 Generic Address Space definition
> 
>  ///
> 
> --
> 2.25.1
> 
> 
> 
> -=-=-=-=-=-=
> Groups.io Links: You receive all messages sent to this group.
> View/Reply Online (#111570):
> https://edk2.groups.io/g/devel/message/111570
> Mute This Topic: https://groups.io/mt/102732018/1712937
> Group Owner: devel+owner@edk2.groups.io
> Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com]
> -=-=-=-=-=-=
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111590): https://edk2.groups.io/g/devel/message/111590
Mute This Topic: https://groups.io/mt/102732018/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-