From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 9CA30941580 for ; Fri, 17 May 2024 12:02:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=V/o0VBDP0mXL0QVH79/hBRtns59bzPWgfIkoKkQIrgk=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1715947377; v=1; b=buKJ7n7FvabBEci4vdiRiJ8ef+qwJQdYz92lepYw858ntgO2RxHH/oW9hYR3HYmcFswF5gql PlS0cc1Y2vCD2RayCJO3n2WDbzOycpyM9uDtbQTD8EiW4Ba2NyQVl0atL9sp7SuWS/CckuOYet3 aZNmtrKC8hAIeF4jFMn5uDa1yBvmvsTFQuE5tyG7hNnj0TEX0+P8Oc0aAg6ZezgOBuzU04K1lBF QCYgvwMov++eZFIBY74pzH4sU3JAOHWWVV8SGPF3tdK5/PgMSSkJ760D2eUEzvZGM0pn1IQ+Q9U jF46ezfF/XzXSF3iYYVaj0aj+SyHBlOHZyA+7Lwxr5Nbg== X-Received: by 127.0.0.2 with SMTP id HJZ4YY7687511xfwFXZ4HwAh; Fri, 17 May 2024 05:02:57 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by mx.groups.io with SMTP id smtpd.web11.38894.1715947376555041488 for ; Fri, 17 May 2024 05:02:56 -0700 X-CSE-ConnectionGUID: g56ebsCSTRiSz6G9RjRvQg== X-CSE-MsgGUID: ZV3ksoLfQDex+5qSzsEc2Q== X-IronPort-AV: E=McAfee;i="6600,9927,11074"; a="15068674" X-IronPort-AV: E=Sophos;i="6.08,167,1712646000"; d="scan'208,217";a="15068674" X-Received: from fmviesa005.fm.intel.com ([10.60.135.145]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 May 2024 05:02:56 -0700 X-CSE-ConnectionGUID: C7F/epPVQ9KF6psliDv82g== X-CSE-MsgGUID: lLoqtySnQzC0fZ12O/6FcQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,167,1712646000"; d="scan'208,217";a="36194829" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 May 2024 05:02:56 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 17 May 2024 05:02:55 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Fri, 17 May 2024 05:02:55 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39 via Frontend Transport; Fri, 17 May 2024 05:02:55 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Fri, 17 May 2024 05:02:55 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA0PR11MB4655.namprd11.prod.outlook.com (2603:10b6:806:9d::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7587.30; Fri, 17 May 2024 12:02:53 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::41a4:c775:32e6:76a8%4]) with mapi id 15.20.7587.028; Fri, 17 May 2024 12:02:53 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: Liming Gao , "Wu, Jiaxin" Subject: Re: [edk2-devel] [PATCH 5/9] MdeModulePkg:Create gEdkiiVariableRuntimeCacheInfoHobGuid Thread-Topic: [PATCH 5/9] MdeModulePkg:Create gEdkiiVariableRuntimeCacheInfoHobGuid Thread-Index: AQHaqD+XZdbWL6IdaEKCT7jes6J+wbGbUe+V Date: Fri, 17 May 2024 12:02:53 +0000 Message-ID: References: <20240517094917.513-1-dun.tan@intel.com> <20240517094917.513-6-dun.tan@intel.com> In-Reply-To: <20240517094917.513-6-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA0PR11MB4655:EE_ x-ms-office365-filtering-correlation-id: c76ffab9-06fb-46ae-bdff-08dc76694846 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?iso-8859-1?Q?VEY8v5drZFaKxMxOGzteTKK65wYGXHe5bn4Wiapl+Muh6M9V2l8bKOMTXB?= =?iso-8859-1?Q?ogQ38MyVnB9lroEBF9WwnEuQhxOqlDAuJSqL5A61Xj5syQS3x/IMWE2W/Q?= =?iso-8859-1?Q?yW9q2ZGHqMzqcUmJYRMiDIehhwKG8xYbclSuyybR1Dzuqz0+jhOFhkruX8?= =?iso-8859-1?Q?jz3vvF+usJFpxvR9ZuVZTQaAAwKwOB5aS2/uCANxXj/VDF3utMne79JH8e?= =?iso-8859-1?Q?3hx3V9Ozcz3zFkhEBRbwpnwUtlXWRF8k/cMTqYQQAX3exEDIlquLJdeHv/?= =?iso-8859-1?Q?2JWQ2fSmIjcHBs64yG4Hm1xI7xZmJBd8ycXeBqCa1xlSx30asdMPC1LhGm?= =?iso-8859-1?Q?+Qb7Pc3I7zY6J5TA9Ff3m61MLXA4zlATW6YlvLLx7EeRKraWOXQHL/i0M2?= =?iso-8859-1?Q?r1dprvJPeLqDkb+zKJepzMevqZMMcRfBnfRiIYpvBJZff/kCNw17VmAhyw?= =?iso-8859-1?Q?6/8NGOmwY1Ex4xBs6Wrt1kTbbH+nVMuCLwCNxLorI0ezXtjD2A095Sumc+?= =?iso-8859-1?Q?hPS49HllHI0pYV4lGiMljXdL+sBgBhFDNa8OGgO90dW/YGcjk39xQBDteR?= =?iso-8859-1?Q?sGL7cWYoWaS3he7wiCMevZywfoGMvuKKY+xe8Y/USjyWG4pY9OjmOv9lKb?= =?iso-8859-1?Q?lHCLAn4bTyiFQtib9NtBNqmJIJBL6vHyDFo9cMMRhCnLbBYAUSgO5Rz8aB?= =?iso-8859-1?Q?euQocD/kb+ME8voVLUE0MZWMKbGKpDs2xSBo8CHaNYmX9qvTsJvl2gEVH+?= =?iso-8859-1?Q?tQEwOBwfqBWzDgZ0c8yo0jmb04FNzqRCJx46wkKU9IcYe/oA3w++46G42r?= =?iso-8859-1?Q?SnkZQWhYer/adBA8UEBcuFQ4KcSwh1a1a72JynkGiy5sRC3Zhj7pDT9Qxm?= =?iso-8859-1?Q?ruV+QmmFL4YU+wYYNK14uz0zNMvEyBn31jLVupjuyPlUnBdJvRhGgrx5fl?= =?iso-8859-1?Q?OPmzGWW+4JBaW3WlIs+Dn3clLAZ7e/6AOWN6iRi5MOlh8F52ed0/DMCyaT?= =?iso-8859-1?Q?JZ3W0oTcfCUJqGoJT7zTmBL8VECAbmosc5XPOyxqplaD7oFsI0XTRj5bgd?= =?iso-8859-1?Q?DivcxCfNgd5fW65hJIJqicNnYQE9tZ2+2ZeYoqLHcodTB665bsQaz/0qaP?= =?iso-8859-1?Q?JIYufk/g8YKwJkxBAxqkng0l8PtUXdXsDFmmToaOcwNFmxjsizwmeVUl39?= =?iso-8859-1?Q?MeFCFnKfCfjEefU8uzwlPezvtdN/5jKDCRTENUucepohBpK6ocVd9MuWe5?= =?iso-8859-1?Q?pQLpKMV0Se5OmpRrBx1U/2PY0LemcS+MIaWsGy5x4Pi4uGU1aVlJKJkIFV?= =?iso-8859-1?Q?LJMSRyqeZMrqhujydG6jD3hOUQrfw2fwyNwhdlSXTKNnOUe9MQFRapPv8I?= =?iso-8859-1?Q?sgV7gqcwSo9Kby4YsAAJhepBLhpS+qtQ=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?rO1SsTW3eDuWq4JsY5W31g8c9c47KG2SLBzZpQcesIoG1e0Tcid7emv4Us?= =?iso-8859-1?Q?VRJGFKvNVf1LUrTYLxwYPoJ36hmGVprk9CIwCGVPKB/x4crsjRGveELrzD?= =?iso-8859-1?Q?HxJNwhdwt604l2n7WztQCL5/EjJkXUUOLC7huOwV9fh86O+WRugfpaimEL?= =?iso-8859-1?Q?B8gXlhf9ueectvQ6QxI+rrC+AHp5iZMV6XVF0m2awQVOpjc+eDDxyAeOxb?= =?iso-8859-1?Q?PW9bgtgmTYk1DwTPhNMBMpXdKKcA+KP+rnS7aQ6gP2SuyoqeYmZjNsSIO9?= =?iso-8859-1?Q?ytuByzBfT6tb4YaHvxz5ZgpOTCHS0bfuLio+82ukZ+7fYOdq7Rn1MQ+g5+?= =?iso-8859-1?Q?2BbCZm0qSkJhQPaFh74bJ65erZQJK5/o9Js5EmyheAQDOwH4PdtNbPPtxy?= =?iso-8859-1?Q?t0k/hX4ciUGPCkXNQjrfb1N5t/bhmTYeTbuZpUEvA7cvOJ5O8Qze73Tnt9?= =?iso-8859-1?Q?4OYWPcIlQ4GzorFInGnLsXd+2kGSWLp6KY2GoBgouWbe2AUuFYP0svKxbH?= =?iso-8859-1?Q?mtCh2eVFki5ZUYGBefQHIf2g8Ql6HsELcESejBdRzpqEZc3Ik59aK1i54X?= =?iso-8859-1?Q?CRGN3vcg2mYWYntu8G2brepNNkw5NADU0VvUlJBis/181wMwCJYBhV9ywA?= =?iso-8859-1?Q?Xy4msRaWwMGtfZKfUN97nQ/Z2ZvhwsNaQAF/oSAwQNoRKrkby25THnZ/ef?= =?iso-8859-1?Q?CJkoXbKA05961HvARRYHybB5plFiWBQehEcXHfV34M3w73hg7tYunjBfSg?= =?iso-8859-1?Q?3suxouB3mJd+Wxji5f119rJErNTHdLNjTk8hxtw5xD8nIj6djYx0QOKKgl?= =?iso-8859-1?Q?7z//gOjVpbMPOFTaLQvOV4nc/rir2HPF7aHLwjfAVw282vO6hLVXanQbVe?= =?iso-8859-1?Q?3ddiPNMlYG5OnkP9JlVNFJXGSfttZ6VOrf9XMQkMSVUk5bgxUpwtK5U7If?= =?iso-8859-1?Q?TEZkWV+WB+soamWbct//1KPxVqdPgMWR1yvB9EoYCNX0oJA8KaaPIMsIvJ?= =?iso-8859-1?Q?Vu5Oexj36PSu5AWZwZ2GmzkfH1Bx88q59pEg1OGQKvPg/RCxRc3fN1fpve?= =?iso-8859-1?Q?Iz6pi4+Rs4X03AO8/5zZ27H237yXgDoyn1gWOBwnZbAdnSA/drdo0oIJzS?= =?iso-8859-1?Q?gmuul/Z2KZyOG71/yl2jeMaRPULvA2cAg5z+jWNNlfXN6OisOAZ1wUvn1o?= =?iso-8859-1?Q?TkMU7BSi0K/W8tga2yR6OPL9fmprJHzfA5OrQGgLwV6w3yC/azOrkvZ6qp?= =?iso-8859-1?Q?MkkZrycVa3PsbF4Yar8JuS9z3YfIK4eqaAJVhtauAvDZu63sZBL+US4z3r?= =?iso-8859-1?Q?L3yFFJpdAopCf3QT9Rc4ZiAmfrI/4T3gZC2BM/t0y1WksAM5CqIvVoTkBI?= =?iso-8859-1?Q?kyRYerTcrnn9/h5ue+37OPp0/16e4YBoR8of4/mmbSP0lOL/rg6hPTI5XG?= =?iso-8859-1?Q?QmyQUtxQIU8weUzJGNrZ2JZGeY26LqzmGenRDwmXJHCaFp3u143bui7K7a?= =?iso-8859-1?Q?4ElXcsRh+mz9GoR6Ok3ZL9JccqSwjMMGxV12J3MnbQHFKszmRbNyJa7SED?= =?iso-8859-1?Q?Cc2/eSnG/bgKVQh0LcAEMLu+FuIkvmgQVMXEGpL9Oih5dRjeY43VKeNJis?= =?iso-8859-1?Q?ckhcg3W+hP3rM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c76ffab9-06fb-46ae-bdff-08dc76694846 X-MS-Exchange-CrossTenant-originalarrivaltime: 17 May 2024 12:02:53.5395 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0/OeLyw4MHkVR2SUkb4u7JrQgMa20fJIBLDcnemESI04XWvyfb6Mo7h/eA9qqozIAmdEQZqYpxIlLyS73DkVFQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4655 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Fri, 17 May 2024 05:02:56 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4HZ9p889BJQhNiGHyTuY5EZzx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244BFB9103A298B6553764E8CEE2MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=buKJ7n7F; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244BFB9103A298B6553764E8CEE2MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable + VariableRuntimeCacheHob =3D BuildGuidHob (&gEdkiiVariableRuntimeCacheInf= oHobGuid, sizeof (VARIABLE_RUNTIME_CACHE_INFO)); + ASSERT (VariableRuntimeCacheHob !=3D NULL); + ZeroMem (VariableRuntimeCacheHob, sizeof (VARIABLE_RUNTIME_CACHE_INFO)); + + // + // AllocateRuntimePages for CACHE_INFO_FLAG and unblock it. + // + Pages =3D EFI_SIZE_TO_PAGES (sizeof (CACHE_INFO_FLAG)); + Buffer =3D AllocateRuntimePages (Pages); + ASSERT (Buffer !=3D NULL); + Status =3D MmUnblockMemoryRequest ( + (EFI_PHYSICAL_ADDRESS)(UINTN)Buffer, + Pages + ); + if ((Status !=3D EFI_UNSUPPORTED) && EFI_ERROR (Status)) { + return Status; [Ray.1] The GUID hob is created already. Maybe you should defer the HOB cre= ation to later phase. + } + + VariableRuntimeCacheHob->CacheInfoFlag =3D (CACHE_INFO_FLAG *)(UINTN)Buf= fer; + DEBUG (( + DEBUG_INFO, + "PeiVariable: CACHE_INFO_FLAG Buffer is: 0x%x, number of pages is: 0x%= x\n", [Ray.2] please use "%p" for pointer dump. "%x" only prints "int" type value= . [Ray.3]I think you should create HOB at this point. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119044): https://edk2.groups.io/g/devel/message/119044 Mute This Topic: https://groups.io/mt/106150802/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244BFB9103A298B6553764E8CEE2MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable

+  VariableRuntimeCacheHob =3D BuildGuidHob (&gEdkiiVariableRuntim= eCacheInfoHobGuid, sizeof (VARIABLE_RUNTIME_CACHE_INFO));
+  ASSERT (VariableRuntimeCacheHob !=3D NULL);
+  ZeroMem (VariableRuntimeCacheHob, sizeof (VARIABLE_RUNTIME_CACHE_IN= FO));
+
+  //
+  // AllocateRuntimePages for CACHE_INFO_FLAG and unblock it.
+  //
+  Pages  =3D EFI_SIZE_TO_PAGES (sizeof (CACHE_INFO_FLAG));
+  Buffer =3D AllocateRuntimePages (Pages);
+  ASSERT (Buffer !=3D NULL);
+  Status =3D MmUnblockMemoryRequest (
+             (= EFI_PHYSICAL_ADDRESS)(UINTN)Buffer,
+             P= ages
+             )= ;
+  if ((Status !=3D EFI_UNSUPPORTED) && EFI_ERROR (Status)) {<= br> +    return Status;

[Ray.1] The GUID hob is created already. Maybe you should defer the HOB cre= ation to later phase.

+  }
+
+  VariableRuntimeCacheHob->CacheInfoFlag =3D (CACHE_INFO_FLAG *)(U= INTN)Buffer;
+  DEBUG ((
+    DEBUG_INFO,
+    "PeiVariable: CACHE_INFO_FLAG Buffer is: 0x%x, num= ber of pages is: 0x%x\n",
[Ray.2] please use "%p" for pointer dump. "%x" only pri= nts "int" type value.


[Ray.3]I think you should create HOB at this point.
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#119044) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244BFB9103A298B6553764E8CEE2MN6PR11MB8244namp_--