From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web10.10007.1681207803033600050 for ; Tue, 11 Apr 2023 03:10:03 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=OMlZbpyG; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681207803; x=1712743803; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=XDhX5HrFdLxqKaLKSnyuuibdu6BYai34iFLDXEL6Qzw=; b=OMlZbpyGld3EKA/x9dSVLbdqSmSkOqcZBuk0ZmugU/Sqypk/Jky4Rhp+ h/Mc2++4jgbU6DSjoLXvzeV53kNss78rxgVrwiQT+7FYHXyyuMAzqQlAf IeHkCmcBlw7+g1IxWW9rSE84WhNU7rR5yDEiyNVe2XdiRnnDFRddt1IbI 5WATLQGs0fLifYS7WFo30erFmqdQ1WGlaZPC02S5ttJg+2/2a8AISnBPN RQnfuWtbzc6gQNxgm7oR21mYerlYolJzilfJgdcLfaRhi0Zp5URlI53df QDIrxrPGQu5e3cojXZ95EJn3LDqyCerW+aa40L1dipQMeLtJdjM0RZ89S g==; X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="408715362" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="408715362" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 03:10:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10676"; a="691099324" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208";a="691099324" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga007.fm.intel.com with ESMTP; 11 Apr 2023 03:10:01 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 03:10:01 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Apr 2023 03:10:01 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 11 Apr 2023 03:10:01 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=d5oRJUvpoJQ24qjGpnddRaM3qjaytFLh1SL/nJ+X/wb2P9aW/lZDrBn2mzcy5I+UNukU3FnHAtdNB/8fNzOPnI1L+dzqEjiQl9+0AzJir+P7UtSYooe1LQiJE7TeHA4NnflwpsGMVK+Im+rixmNHxNSh1iBO+WWofoWsguKRKMLthGfpv5QEd3F+vRmRiScET3icP+zxDni/8fu9eWNGGSTCuSQLZa+zYotlNvL8pa8rPAt5Ixte3s4zO+0pyikjYhFggJibniHHq8saLiLIL/o4MHl9x5ZtIPD+r2SvzITh7ceTVxvC4gBLrIKrmWlRnHkB9CmAiDfpIkw2qyZErg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=c4I2w/+RhsKgkYySq2qcwnXT53RlrG6IppYLg84f75E=; b=KOoNv5rElp1NbnPLtaKHc/jOuTYja9+lhNGDHnhXiRKwobz1n444uw2fwSoWZi+PpLmvtI0azGZjPRQTPnOA8u1A8RxrAVKIQLkqEsjsm0uOiiT/mxVtXzYiBJ99Kva7tekKRQJloFZqIEPOtoLsuZ1LR15mmFPhihXGZQ6WqgF8umwHC8VE2u0FScuA7Il+L6y1hEm7bejeBL2JyGmS7UADyK0hKb0IfrzznCporTy5TyR4CqkyOFyjglyCybY8qd0F/dVdvA4sVhjzSTuhCwvTp692W+rIsluJcoYjDfsJqFq6EWQ1M3IV4Ktsb2BltdslpvtfMuZ14v2VrxqCWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB7297.namprd11.prod.outlook.com (2603:10b6:610:140::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.38; Tue, 11 Apr 2023 10:09:59 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 10:09:59 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "kraxel@redhat.com" , Abdul Lateef Attar CC: Abdul Lateef Attar , Paul Grimes , Garrett Kirkendall , Abner Chang , "Dong, Eric" , "Kumar, Rahul R" , Ard Biesheuvel , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa50porwV4JMsOkGOm2Ls0nivva8l3L6AgAAHV9A= Date: Tue, 11 Apr 2023 10:09:59 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB7297:EE_ x-ms-office365-filtering-correlation-id: d894b202-999c-443f-d74b-08db3a74e847 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: IKEABkmbWUtUbYXM3dZeejFqcL6UNWUPRsMCMzXtEnUbXO8xnNrq3a5bv6nsXk1REj8igTIcFJxFyvnGG49b8I1Jr52yOOTl1B6TvGzhf9tliZjRaYzt8a1iEa5pkrwouObXYOGToM0qIrIaHlX19h7Chzd8xbsubBWbujbl2fQ9gMKOYL9Byyc0TAwJNwQBCvSiwNurw9wrFg1QzfUCY9yanwtr6vro06lj5X//KYvHRX/95xQOXt3/uJoE7Njuu72oFCzbobDpa1A9Bq5ht85xje2yCm9Om0vS1i4VxIx9882BprFKIX3A2XBYJ4Z3d/r2XHu+07fT/MzkNY5B1kbH4A7rC/cUIHHGdYNlB4psw2ehQ6bnEueop8q+Xk1TFoMICaE2f2hkP2kN8fsDc1HhUkB2YQ2BEyPEcBYbc0PJdrRlhYh9lCht6jMUVX0IGHkvIWdb5u5gCNbje8VbinywTiB+l8N/uxul7TsJxu8lRX5hUpDW3qNU92KRdTWhBfISa9ZJDiQy4CW/oO4VgBgVYC/jL664UspXSFNac/pSlrXu6RREEGKH/XDbors6UsvZrg77KBDXd/aj3kp2LGyXYBAiT9Ey74gzjIEldoGeOW7k2OSicHacihte+N3FW6QvpmqbIzxOjh4dZSOfgLNwd4n+9AR0oqFMOOGtksA= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(396003)(376002)(346002)(366004)(39860400002)(136003)(451199021)(71200400001)(7696005)(478600001)(316002)(110136005)(53546011)(9686003)(26005)(6506007)(186003)(54906003)(966005)(2906002)(5660300002)(4326008)(66946007)(76116006)(107886003)(66446008)(41300700001)(8676002)(66476007)(64756008)(52536014)(8936002)(66556008)(38100700002)(122000001)(86362001)(83380400001)(55016003)(33656002)(82960400001)(38070700005)(66899021)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?hbZ5DTx0FrTFIIzpwM58Saqu6GD9CTEwhAzEuXcO9i56OIOplSIq4lrz8sto?= =?us-ascii?Q?7aDicaRFcY/qYQU9oc3s2IzZgj7Q5am3goahRBwNqCqMKBIMtID3PLjGmo8u?= =?us-ascii?Q?IJ1DvYEkadQcBDD5rFi+OlNbwMA552dz8WUm3tizh5gnGsrnqYwZLbgo+Gf7?= =?us-ascii?Q?3FFSdSXFCZlgvOln5yYWOzkAYnYKfAYzbz5UjBIJ9GcXADyBZgYmFDnhdxbI?= =?us-ascii?Q?UZ4ZT81zO7kXv+Y+7oWUXTSZ/96IlRKRbXnFjcmA8UsC8j+3XCcVKa1l5HrH?= =?us-ascii?Q?3+4RxGJCqqNFZfgtnvPe2w/+BwKAfVqejiwerqjWRymQOi7+oUSlmDSn95tm?= =?us-ascii?Q?nGmiGCMD/HM8SVEufPmXmnqZ0OTEWrbAJpIBiwQnaFbf+o0vF9zh7yg4/P5/?= =?us-ascii?Q?cfvJBs/XunwL3n3DEZ2mdro9ITDzlI3AI+B0yKWcxbZ2hVEXKswNIpgNYbYW?= =?us-ascii?Q?/k0hT2zMx+w9UJGXnoOSPmvJL+Wq7KEVsgsqnZtmwYIe+OP7K7+jK0Nx7c3Z?= =?us-ascii?Q?/aGEEKQmrVP0CZ40JJBbjzG+8PeDS0O1rQsd50u3g6ZpJu3aXvtg8jJxa/z0?= =?us-ascii?Q?XMWNj/Sdzi8NtyXrylKxNnmQQfhpO+CxS/eIIC6YONqaYQiRlxkn/yFoUVfF?= =?us-ascii?Q?Yrrxw9sxhJli1Zo2oGrB9XFbvhMdeEqaWGtA4tz73iMjFpGj3BJxW2bQyGIG?= =?us-ascii?Q?uAbU6m/f+ItpyOTkNSJWlubwbN6cXmeGJQtRDQvaC1u2uzb2t1kLIDwnfPrO?= =?us-ascii?Q?EVuRkxIdkuiW+aqxvMW0l3zcyv6RDY0U3ttFzSCCcbsoSGVdJke7BRZ7nT1e?= =?us-ascii?Q?0X5pjm6QXDBZAYC9Ip0I8uLIhd+Am/nTYyb6YHRL0p7Nwdwozv2vWdcV9Q86?= =?us-ascii?Q?iUIUBQsP03gTV/QPUxJ7IAY771V5rOHxOEtWq1zc1+ARBN/IgY8PYI3nqFvv?= =?us-ascii?Q?wpqiVAQsVIOBxYKnIQoN70vlUCrJd4+phv7KHEklbbfYOdxHdrupUtW+2Gbt?= =?us-ascii?Q?xuKKf5CcgzVuaf6qCqF47dHz7Ourrl3LRC5HFJNbzo5YKpr9WR0pI5qElC8P?= =?us-ascii?Q?phFmf01Spi1zqQ1yzyQhPNo46oguSslSfOYqNpuExSy44NxpfLk1WE/NEYom?= =?us-ascii?Q?vsi5xLixcwYU5iRZ7IdkxufIYuOhXsWmNON47IszcEzBJVdYRrwU90oWTLCg?= =?us-ascii?Q?hhHq0pfE8/ITmjoMJfJS+O7Oh+cq40KwdPNmIsZvTbX2avNXSa1tCEvfDzC1?= =?us-ascii?Q?sjEPNSfyqSYgJodWl3uwNy43piUVm4KYlmKFTuD3fiJNRKb53ARMIk5+KaMY?= =?us-ascii?Q?efeRnmSa1JKwOPyvtXRGwALNDTDNcD2se5NnVAFqMxOX4KCzHWfFfT/9jcue?= =?us-ascii?Q?82FRKrvtYzURMg2rp7O+blQekM7gefYoJz5HvLH3gFctqp2Rc/9nQ6roxU70?= =?us-ascii?Q?De3V4Hw+E8BA7SVxSVkvuK0vT3xKGWaVpVnV/gsT4fppjoiwTf5YsFc8+Imb?= =?us-ascii?Q?MlS4e+OuXYWzoyBsjlK2ffq9m/omnbRKF06UqHemSldTDn0HCoulkQ4Iw8Xn?= =?us-ascii?Q?cJjpTQ8sWs9rm/xiJrk=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: d894b202-999c-443f-d74b-08db3a74e847 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 10:09:59.0329 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5bGCZg1nWNEgwprzrURNuM6x85XBi8uTDG/P6qLN5aX9E6bxulP+iXRJBVtIRGZj4hhXQK5kuyHa9+ZfoFTkMQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB7297 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > Cc: devel@edk2.groups.io; Abdul Lateef Attar > ; Paul Grimes ; > Garrett Kirkendall ; Abner Chang > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library >=20 > > Uses new SmmSmramSaveStateLib library, > > which fix the CI failure. >=20 > What is the exact failure you are seeing? >=20 > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf >=20 > This should be the AMD version. KVM uses the AMD smram state. >=20 > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this > has been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h >=20 > take care, > Gerd >=20 >=20 >=20 >=20 >=20