From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web10.4525.1685676691788784069 for ; Thu, 01 Jun 2023 20:31:32 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=SXzQlL1C; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1685676691; x=1717212691; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=giINnsT5T5ycs9VXcYCeDDm5AM1MMAz7vz9kUw7Lyjs=; b=SXzQlL1C36fddOTRO/lnB616tkVDt3/RzHalzyCycQ3vSKgTB03Ozam9 BEOHTmuG4jOQwITrtxku+9mhEOtMIEWHSQgv/DDg+IdILtAIZ9U1Ip5oe PCriw1OKJQDGzWVWdTJbEiHPVkt+D/G6fZ+S5+l1Vmxr/98CeZLWHKkV4 F3D8tvy59cgnCpNsB8I2lvZm/c6GC2xUSK0qJKFAY5aKBcpCwg1pFiO1A XOQ3naTeKx2Rb/M7QySRnkB3rUiIN70486GmNKEYiY/nUzXhCf/sHWqoB 7xf0+XAMuhVnS4gj6PxYSbnWL5v0cqNBzaH50vcRrd6/J5BOURkn2uvUQ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="345330113" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="345330113" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Jun 2023 20:31:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10728"; a="772710332" X-IronPort-AV: E=Sophos;i="6.00,211,1681196400"; d="scan'208";a="772710332" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by fmsmga008.fm.intel.com with ESMTP; 01 Jun 2023 20:31:30 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:31:30 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Thu, 1 Jun 2023 20:31:29 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Thu, 1 Jun 2023 20:31:29 -0700 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Thu, 1 Jun 2023 20:31:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=nsoPInKpBpmmhZpOIRvvtcsO4Qx8rgbtK4azwzS9246o+Jaolwv+C1cny8L0jRjw7QFy2Xfpp24xRZCN1WJnQtJ167B1nF7PtFbJcdMfcefcqODn7i2kgChuiC5uaMwUkV6ez9pZMVDAMFKvQvmO0NG1TtM/4GuZMkfXpvLBdcEpLdfyDdjcRuL+K7xHDBHUzrE7MsjCYE1+sPFP73VkOfwSPl9G2md/rMoqcCFl7BASO8EfZQrajAQQmgX9thC0ovpwMioxkTSTunvmB6rRGsrX32jLpvmR0d7wp35FjpH6Z7WDOn4STU0vQEEeAvm9cfBDrgAhvMyMxr+ya23TGA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NeqsXkWXp+GLvdJWJsCkTj66Yv7K5nsezVinIZ4VYW8=; b=OyDrH2Il7zIQ9dOBQknuosS57nXsD57g2VmIQiR1RkmXh0QP8PC1CMF1wRpc4k5xJ+OH1GqhqL0ywTJunsD4Xm1mTdz/IbuSkJF7NEJRwrs8MXEo9TvhPCUigMwxWlHdGSPDKu7TxvfoF96FmOkMovtNgNF09JyzjZF3yEsxo9oP/k/Syfk+LWr3vE1VkR97uwoe+hrP67TzF7NnYQW190UWHnBXf/F5mZv+sIxhwhKWsFHV07JXf9odd+NnkvxGXi+fDl0Fd/oM2ro247Hjn3BIL4xCUqmH3+oJ1bciou9WNwzsNtmxOqivJ3qjG8VPbZJRJlI+EK0DGVjqluscXA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL3PR11MB5684.namprd11.prod.outlook.com (2603:10b6:208:33f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.24; Fri, 2 Jun 2023 03:31:28 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%3]) with mapi id 15.20.6455.020; Fri, 2 Jun 2023 03:31:28 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Tan, Dun" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [Patch V4 11/15] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table Thread-Topic: [edk2-devel] [Patch V4 11/15] UefiCpuPkg: Use GenSmmPageTable() to create Smm S3 page table Thread-Index: AQHZh91im86uug/v5ECT+EO0kQN9Oq9289Vw Date: Fri, 2 Jun 2023 03:31:28 +0000 Message-ID: References: <20230516095932.1525-1-dun.tan@intel.com> <20230516095932.1525-12-dun.tan@intel.com> In-Reply-To: <20230516095932.1525-12-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL3PR11MB5684:EE_ x-ms-office365-filtering-correlation-id: a6c30064-0152-4399-c80a-08db6319d9d5 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: kfMDPtp2tjN3p5fP487ub3diDAdkiVTcPHUxzjgFoT1uKldVcyL9M+eoUQ1GqT1d6JmwIoKcPSPNQAhMRaNYYzcEqwsr5WajF7M1ws2mDLaiSka9auWBH3v/AKh1FDv2tB1+77iRUnD7/nxPJpAlHPwOiaemCrpskHkCSGc1Wm2Dgs0ieUYslFrdkd7d1V0RNSRmbOeBgD8+c/GXZCQJ6jtQn08hSIxZ3Z3zeApGCrgtfkpC09Jo3tIerDZtsNqkNw3QcrlJkiBjy6eY8GnmCjkPRT0DCw+brPfcVjNw9mccWH+W/R96yH0ovRiUz/wf+XcqLsOxg86gvp/B1VdDqD+GFKbhWGHBnMldLXeGhNBI4CqIqMLYT+KKlt3+XRqIGIZTkPGN+cWjP1X+yjTfrCasDoXjBx5Dn3VCMD89zfftf5MQ75gnMpH6vee7n1VJ0N6V9SsVarfL5R6/2CJ4EAN27P3Sqs1TANlG14I7eHOsxxYb4FfrLrJJh7oH61yJijyrYLPa6pASkgme0LzrQhg2jhs/Tybe1FHD6Gp2H1+VJ5airWlaTggVzzLuIAx5yH2JMY0VOOt4GwtheS/Mtc6vbIUP25tpKSG2TcFl2QEP1KtWNvendoOs7Q8r4fms x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(396003)(366004)(39860400002)(376002)(346002)(451199021)(82960400001)(122000001)(38100700002)(110136005)(54906003)(86362001)(6636002)(66556008)(64756008)(66946007)(76116006)(66446008)(66476007)(4326008)(33656002)(38070700005)(55016003)(478600001)(7696005)(71200400001)(186003)(9686003)(26005)(6506007)(4744005)(316002)(52536014)(8676002)(5660300002)(8936002)(2906002)(41300700001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?0PevKAxL8ygMwhYfNDnXBFkV+ZdIm6VXllFZRg5rXclJkUa79xvoC6SBUCjP?= =?us-ascii?Q?egvQV5n/UG6xQsTkt55hiv2w0JZAZo7rJKzf7qUo1kdf5zLdyw9L1hNNtbvz?= =?us-ascii?Q?hRJaAv7XSPBM1qC2UkYhcDyqlx6QUrow0ojB2UJV6GDGOyv09T8ypnRnL32o?= =?us-ascii?Q?hSriSESE87MrJaRpE2Orzp0u/VGj/SpF952ls7uiEw8yReu6WXPwpaAe6v/i?= =?us-ascii?Q?Yp6CRn/1q7YIDjd7ofg/wshU3aRW30z5M12HzBOP2IS0Yie2g/egxZ/EAIUW?= =?us-ascii?Q?tH/GZ2jAfJCCbM2OcHRTjzxcPBTOcLN6T3w+JGshJf1O86HZqVLbOu2JUw0i?= =?us-ascii?Q?kXjLG5mN9Um0lzSMspzIg8dAbqVMPqccANsNLgeDMnnkWT+KwEVw8XIixsUu?= =?us-ascii?Q?2jzocVr6aoYL0kUa9e0eCUkVQ8eQpeCbhtW+oOz2uHXV6CaxqQYRGTmhk6FJ?= =?us-ascii?Q?klRx5ecoyxeDAqFGMiNAEclPKeZLYr7yvV9SOwliUvOOWNCWV3nh4W2kkj5Q?= =?us-ascii?Q?ZEn2ujroT01iKLy+loW0YQ3D5qpmxfqYKdqHcMwW2/CfhWYkQ8yKGpOvfCoc?= =?us-ascii?Q?opmGJkWP4kfra1xF/qOfGYCC/OF5z967cvlbfShvbPKcoo8XirUXGGSw+XPS?= =?us-ascii?Q?rP1szz3fdMDTn+uCfv4T+5k7VBahkN6Vh6zJW2Q0sMzdcv7RUzdzsB+559m5?= =?us-ascii?Q?1Y51xx8Z6ZwBkfEZ6nrsqUaSlH+zwsP6L52SQRtIYR6cIxXznwQaHcMTRnV9?= =?us-ascii?Q?chH8wWJ9qgkUCJc/H65Z3Vn/nRklX0MgIYbMLMTZdqI55dnDLmNCmQkLobYv?= =?us-ascii?Q?rx40tCnzUs74N9z17TbnEPUJqQl2kREzdnj3FNgG2xpTDViwwGoA/EeRvc9Z?= =?us-ascii?Q?mRkOd1wm+ko6RzojS2EBB9IuGFBcvG70HOsimMYuvQAwjnxM36UjroZdnkIO?= =?us-ascii?Q?mkiX4AKKxk3NfS4lz8v8EbdVc2oIO4axqOyRVnv0h251rDS/DbAKfxGKvRHV?= =?us-ascii?Q?0M4XLOtGayMonuZGbqgeBc8PyE0cFv907z5Zs39lnk72PP8uiGVCpCzcLr9+?= =?us-ascii?Q?iFOrNlJkg4Wl1whLrx+1JnHxLSG37bCY3qpmMxzetv4o4Ra07TisqZAs/O45?= =?us-ascii?Q?uu8IDQiNp5ZxW/c5EvzWat4R1N/j8Qo/27t1DaYmDnVmEDBGY5aXRLeOWyNH?= =?us-ascii?Q?SIsamNlK3nhz2/SdEmCs2PKd8xkYP/qu/9vrcpVmDpzU2QUEn+dMYQuII2Rd?= =?us-ascii?Q?22hHaB++Zy+ODeVzl4qKVlypmv5BSUsU01wm31H7Fe/SLAA+dA7ErgYSyNOf?= =?us-ascii?Q?zDJYW+oWl0st6lNAcUnZRLjFsVFMSmGPddwtch9fpdMpnPsMKpSQ2AHnh2xV?= =?us-ascii?Q?iIHFx1dJwb2K3++XZ/9Hk44q4OTQMUPCQOpPiiEjarjd3TU+lRjXRCbv4yBT?= =?us-ascii?Q?rJpybaBv8LMWB1a1urIjfyyKe8Yjw8t8fRrTwy5d1Vuiz3bL1PLoPbBfjiq/?= =?us-ascii?Q?d6GFa3KhTQIFHUS8QdWfC0Ih795PeCUQGEBWZOaIg+n7DeZrrHU6oaxkonrO?= =?us-ascii?Q?jqIsy8qvEPE3GfJ7heg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: a6c30064-0152-4399-c80a-08db6319d9d5 X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Jun 2023 03:31:28.2777 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: p4ACR6QXwkn8eT66t651uTb82mUPMWTxzzDNnTMmZebOy4YCbfhL2k9Yx4xThfSy7eUkE35s83S1/v92LVoyWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR11MB5684 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > - mSmmS3ResumeState->SmmS3Cr3 =3D (UINT32)(UINTN)PTEntry; > + mSmmS3ResumeState->SmmS3Cr3 =3D (UINT32)GenSmmPageTable > (Paging4Level, 32); Why is "Paging4Level" used for S3 page table? The S3 page table is used by S3Resume module: if (SmmS3ResumeState->Signature =3D=3D SMM_S3_RESUME_SMM_64) { // // Switch to long mode to complete resume. // ...... AsmWriteCr3 ((UINTN)SmmS3ResumeState->SmmS3Cr3); ...... AsmEnablePaging64 ( 0x38, SmmS3ResumeState->SmmS3ResumeEntryPoint, (UINT64)(UINTN)AcpiS3Context, 0, SmmS3ResumeState->SmmS3StackBase + SmmS3ResumeState->SmmS3StackSize ); The S3 page table is only used when PEI runs in 32bit mode, which revolves = my concern that CPU in 64bit mode cannot switch from 5-l paging to 4-l paging. And I guess your code just aligns to the old behavior. Can you add comments to above to explain the SmmS3Cr3 is only used by S3Res= ume PEIM to switch CPU from 32bit to 64bit? With that, Reviewed-by: Ray Ni