From: "Ni, Ray" <ray.ni@intel.com>
To: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: Andrew Fish <afish@apple.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Chiu, Chasel" <chasel.chiu@intel.com>
Subject: Re: [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling
Date: Wed, 1 Mar 2023 05:11:20 +0000 [thread overview]
Message-ID: <MN6PR11MB8244C3D080911710051C9FE98CAD9@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230301045524.1044-4-nathaniel.l.desimone@intel.com>
Acked-by: Ray Ni <ray.ni@intel.com>
> -----Original Message-----
> From: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>
> Sent: Wednesday, March 1, 2023 12:55 PM
> To: devel@edk2.groups.io
> Cc: Desimone, Nathaniel L <nathaniel.l.desimone@intel.com>; Andrew Fish
> <afish@apple.com>; Ni, Ray <ray.ni@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>
> Subject: [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling
>
> From: Nate DeSimone <nathaniel.l.desimone@intel.com>
>
> SecInterruptEanbled should be SecInterruptEnabled
>
> Cc: Andrew Fish <afish@apple.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Chasel Chiu <chasel.chiu@intel.com>
> Signed-off-by: Nate DeSimone <nathaniel.l.desimone@intel.com>
> ---
> EmulatorPkg/Unix/Host/EmuThunk.c | 4 ++--
> EmulatorPkg/Unix/Host/Host.h | 4 ++--
> EmulatorPkg/Unix/Host/Pthreads.c | 4 ++--
> 3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/EmulatorPkg/Unix/Host/EmuThunk.c
> b/EmulatorPkg/Unix/Host/EmuThunk.c
> index 6422f056a6..4bbc6f32a8 100644
> --- a/EmulatorPkg/Unix/Host/EmuThunk.c
> +++ b/EmulatorPkg/Unix/Host/EmuThunk.c
> @@ -9,7 +9,7 @@
> it may cause the table to be initialized with the members at the end being
> set to zero. This is bad as jumping to zero will crash.
>
> -Copyright (c) 2004 - 2019, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2004 - 2023, Intel Corporation. All rights reserved.<BR>
> Portions copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -229,7 +229,7 @@ SecDisableInterrupt (
> }
>
> BOOLEAN
> -SecInterruptEanbled (
> +SecInterruptEnabled (
> void
> )
> {
> diff --git a/EmulatorPkg/Unix/Host/Host.h b/EmulatorPkg/Unix/Host/Host.h
> index 0c81cdfc01..ed3980c7fd 100644
> --- a/EmulatorPkg/Unix/Host/Host.h
> +++ b/EmulatorPkg/Unix/Host/Host.h
> @@ -1,6 +1,6 @@
> /*++ @file
>
> -Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2023, Intel Corporation. All rights reserved.<BR>
> Portions copyright (c) 2008 - 2011, Apple Inc. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
> @@ -346,7 +346,7 @@ SecDisableInterrupt (
> );
>
> BOOLEAN
> -SecInterruptEanbled (
> +SecInterruptEnabled (
> VOID
> );
>
> diff --git a/EmulatorPkg/Unix/Host/Pthreads.c
> b/EmulatorPkg/Unix/Host/Pthreads.c
> index ec3a38e573..d5a7c473f7 100644
> --- a/EmulatorPkg/Unix/Host/Pthreads.c
> +++ b/EmulatorPkg/Unix/Host/Pthreads.c
> @@ -2,7 +2,7 @@
> POSIX Pthreads to emulate APs and implement threads
>
> Copyright (c) 2011, Apple Inc. All rights reserved.
> -Copyright (c) 2011 - 2019, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2011 - 2023, Intel Corporation. All rights reserved.<BR>
>
> SPDX-License-Identifier: BSD-2-Clause-Patent
>
> @@ -120,7 +120,7 @@ PthreadCreate (
> //
> // Threads inherit interrupt state so disable interrupts before we start
> thread
> //
> - if (SecInterruptEanbled ()) {
> + if (SecInterruptEnabled ()) {
> SecDisableInterrupt ();
> EnabledOnEntry = TRUE;
> } else {
> --
> 2.30.2
next prev parent reply other threads:[~2023-03-01 5:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-01 4:55 [PATCH v1] EmulatorPkg: Correct Comment Nate DeSimone
2023-03-01 4:55 ` [PATCH v1] EmulatorPkg: Delete EMU_IO_THUNK_PROTOCO_GUID Nate DeSimone
2023-03-01 4:55 ` [PATCH v1] EmulatorPkg: Fix misspelling Nate DeSimone
2023-03-01 5:11 ` Ni, Ray
2023-03-01 4:55 ` [PATCH v1] EmulatorPkg: Fix SecInterruptEnabled misspelling Nate DeSimone
2023-03-01 5:11 ` Ni, Ray [this message]
2023-03-01 4:55 ` [PATCH v1] EmulatorPkg: Remove Duplicate gEmuIoThunkProtocolGuid Nate DeSimone
2023-03-01 5:11 ` Ni, Ray
2023-03-01 4:55 ` [PATCH v1] EmulatorPkg: Rename Variable Nate DeSimone
2023-03-01 5:11 ` Ni, Ray
2023-03-01 4:55 ` [PATCH v1] MdeModulePkg: Fix misspelling Nate DeSimone
2023-04-04 12:58 ` 回复: [edk2-devel] " gaoliming
2023-03-01 5:10 ` [PATCH v1] EmulatorPkg: Correct Comment Ni, Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244C3D080911710051C9FE98CAD9@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox