From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.72780.1682403261679565677 for ; Mon, 24 Apr 2023 23:14:21 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=Gui5d7yX; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682403261; x=1713939261; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ExkfM0tSCgUU/R4uuRlA9jh19JKpHExKqa1nWlIHyGY=; b=Gui5d7yXi3xeT7yJV1tpyzM+9ObC5JsvzQEWElQXUY+exApxjBqaxT3k ZA2FO5glkcCGQ8Xu+zO9M9GnBqaOJAU9cO99Il1b/o7sQ6xIzYVNjv0Vz x7cuE2HWowl3zuS3XePQqas4D/zAdSRPwN4zqwPGitLIq3JcuuHeg27L6 lcUxd/cYnO1qZB5sLpaQxzmDXTA1Yoz+5BdI559OzLkHf14ko2Pww9MBJ rfF8UKGvtlgXbRe3Uit1xXsd9yf2UwniTll6oUmNL5Hmlrj9JXjyV/hzH 54ib5LMGMXWUj0gGbeSwJqP9LIYLVvCzmszAiL36pt4J6AXu2mdJSX07/ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="335566503" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="335566503" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2023 23:14:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="643656764" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="643656764" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 24 Apr 2023 23:14:21 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 23:14:20 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 24 Apr 2023 23:14:20 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Mon, 24 Apr 2023 23:14:20 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Mon, 24 Apr 2023 23:14:20 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IMHr2JmmaIqDXDaLOKyJHQI8+zteszt6UeIW/VbNF37uAsHE0STbCUbmOo3szaCSeQjxzRECeXqjywCoAoW+d7gB6FV5YXDJeCJjUocuYO0bQbDziLJP/S81bYWA16El6mtCn7EGH0WPCXtcMI926sS0t2dJy6YC6SB4pywMQaOr8LRBwYpMih71lJh4fakCNqfrb9Peb3yDweBBRtqgVm1nDanG+TccESpvwcDjbMHDypfQPCoVrD9PAePfhy5L/Tb64f+CEfgU68FT+dFPsA57gFL2+B5zmh9HbOyzmo9TyLfoTzrQQx7IMj9f8eXYzp+7ALwVv5hM63HQSMvF8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zHcOTEPMWjbANO1LxTHb76OIj9/Dzr/HPtmm6mIP710=; b=KtpRvkV1tdpVsd7snn9Beii08dR7kM107WXIIS8oCEw5wuKMHvU05L1pxceOtRBr2yUjVg1NFZjBdTvYYG0jif2lulLtUnRpnOt5RBLw8ysp6x4ulOuAB8xIjPCJtkneQDN6Exs6Q63Euoc48hmKWOt2ZT8VdOFWfWJwD+2buvE5SQtH4IYZrrL0dvPPUurnjlP4y6H1CnpbU3beF366nsOZvc8joY4Un2yOUFy6jQpPfaqeOOsBmLHjV8APoYtge3aWQtCm9I1N4ACayTYHrCgbKjBNUVd4ndSZzWIQAWaAREeli1S1q57HgrQY3UsC/7qEyp0HxPODVJZdGMdXSw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB6496.namprd11.prod.outlook.com (2603:10b6:8:c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 06:14:18 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 06:14:18 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Tan, Dun" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann , "Chen, Xiao X" Subject: Re: [edk2-devel] [PATCH 3/3] UefiCpuPkg: Disable MTC packet by default Thread-Topic: [edk2-devel] [PATCH 3/3] UefiCpuPkg: Disable MTC packet by default Thread-Index: AQHZdzmKKYekwBu0AkeHjVpJL0HO/a87i+JQ Date: Tue, 25 Apr 2023 06:14:18 +0000 Message-ID: References: <20230425054738.2937-1-dun.tan@intel.com> <20230425054738.2937-4-dun.tan@intel.com> In-Reply-To: <20230425054738.2937-4-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB6496:EE_ x-ms-office365-filtering-correlation-id: b837151c-b2e6-49e4-cc77-08db45544d72 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: a2XxeUw4lqL70i8g+5nGTKZ1C6pqkI1ATE38KXLz01KhNyodfd1RODjc4tLSu0KSAlbEFoPip2si2voP0+oLMqLf57LTU3AyZaqWOeEgDJIqTrqhOGDsK/1my6ju0bsoUoj7Z58U2J94QXoo/0/w2wkGO5/hObLL5kGO7rsxGEztmNNzgeDV+ZtAxIHkaeEgbqEth/TZFKVyRkbKjx2W1gjHudrOM0fM4nGq9AMGgo4Bl9ofNC3R9nyZeZkn5p6Daq+e/JP450Q3tNwmAmdPnly3//3eRFwARxebYu9TnsU1wOzGL/QZorqDnK2jRivyIF/3tCiflt0cuAEbZxvV+QNDrDJLlCrK5Un4n5TAEy86T9bPMKKPp51lC2a40aNVB7YLoU5AgEyxwKZGXqkGFWrLRqaqAXfCfENOsm2Xj3erlXmqHSP3Oj9ST7FfMM2IITKBE7iEI/V0vs4GgGEhWlgf8J6T9jeiu9SkFQo+0lXj+06JsafGtsacGfw9mnMaULOJqRwb0cMcUI8p5STRp83OctI2KiYgaxAI+H9qeqiIDZiVghLqhXXgmwk7Ao8tsO3Sy8TdaS0NFyoEScgRJVtEysz+zxcncr2A1rAyvdTehRQgG9nDHTTR6kA4MFXRpuOL6hLK2UkqZqfKjHBeCw== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(376002)(366004)(396003)(39860400002)(451199021)(54906003)(110136005)(38070700005)(66899021)(478600001)(76116006)(82960400001)(316002)(6636002)(4326008)(66446008)(66476007)(66556008)(55016003)(66946007)(64756008)(122000001)(41300700001)(2906002)(8936002)(8676002)(52536014)(5660300002)(38100700002)(86362001)(186003)(966005)(6506007)(26005)(53546011)(9686003)(33656002)(107886003)(7696005)(71200400001)(83380400001);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?gKr3mYueEVQW2D6tMoQz4+jXU9WCb8IvNeWpqxa5tLU1ruXx/4SJs1SXQK47?= =?us-ascii?Q?TqW7HtVVvv0VAbGaJI+qeh7FaXwK5PvC8vGkl9JwNCXC1kJtE/eLdIryxzjU?= =?us-ascii?Q?/ZdmDArA+P9kiOpAWAn5OO/OXumqJ8XkPGEOITEzTWylOYwfZtsH72y2Hr1b?= =?us-ascii?Q?FeJwizRp5+dbmQbg9vxPqR6oXy9VcV8fliVAE+1EOmEXs0+o4CKehTcWRHkb?= =?us-ascii?Q?krJBAsVVIDjBRhfN/NUxl2r36JXG2rTfUaInecXNeryF/ognx6Wbd+QfWCNe?= =?us-ascii?Q?mOF7D/DoOSfLPT7odkDB9PTqGnuZi0/PamLG2knt/Sr6jd8XTwBe1dSTDx4C?= =?us-ascii?Q?fQmtXqhZVUChrOg8pzQEAHQOyPwKOEcsCZ6np5PY2rrff2xCkpsCe3Dry6p7?= =?us-ascii?Q?7jz0HNrXcgidrf0q9DpyevpJHJ87yFYTFGLa7NeWq3v7fVz35w1Ons2qiZXP?= =?us-ascii?Q?/ynR1hilWdGYjeQnMmSK3OUJTOIomGbRrnBCuYbM4fMnfmiq0d+zruZruhhW?= =?us-ascii?Q?oF6ZMNcRntREgCIWN5ds5BfR/JTWFxew3Wa479WwrzATs9RphqsWB3FnwQCC?= =?us-ascii?Q?Q9wmjr4ZV5t1t52TZ1uHzzNQm8JTALbZSis3zgqT+hCaEQCPmxOOz/7ZpE+i?= =?us-ascii?Q?ORnWsl0uTWsnx+slEU5OUqaRYVUVfAIt7oAZY+VFx55L/aucx5Y8ZTM0oC8p?= =?us-ascii?Q?zXPb16f04jfopMqbFHhPiKM1bUpWcbKm4LVq4Va4ZOWBoX5XZryAM8IEoQdx?= =?us-ascii?Q?4Wu+oDsqdiT4BU+lFoPvWR/bb4CuJzwcEe2BNrE+9OF4tMpSnSJkE/Gcsq3+?= =?us-ascii?Q?9VtGnb38nFhth5QNCpCAcXLGbg+WargjXOBaoYTmNap5/KiArb3yeXN6raWL?= =?us-ascii?Q?W9pB8FnW53sfuwuXlNrKooMqQHeZqrnQAp7uLGZKDbXHXlA3TCwg+bLgqqeS?= =?us-ascii?Q?lAV0zTfQ/ETR8kStJLD2D1Jb7zVrIVzy+eeFO9Ou8bc2vYDQ/V3qWcRdrowu?= =?us-ascii?Q?QfoKXcG+7zVZnCNMVbeFnUSykq5FbBvlDaIKrBaO9XrJOAVaqG/hI66FUNUz?= =?us-ascii?Q?JohdVbUHJdjtSzRkf5KUWLpXM/A/rnok6h0GhDpR4suUq+dxhj6InaqwdXrL?= =?us-ascii?Q?n4bf+fDdpY09l4IrxAmlOHSufGdp5qdoQZYFyLyY8t9zv3E6gvqNK74mt0bo?= =?us-ascii?Q?LPWFcEPD40uBYSnVso2ba9Z1gKcVeRVuwPPEoIcjAGDXxTiRcKT3UUCRk9ks?= =?us-ascii?Q?UbYpWtBoSihmXqmKJU9whJNeoS6eSdjEqoCs8BGx2nDBLEEePvxryVhlv4xA?= =?us-ascii?Q?FTALHkeWwPp1ln6ZvezcedBOA7Y85fX6XcGzdhcV1eZ9bymSZ5k6UhST4xY+?= =?us-ascii?Q?QN7+tIRxYfJUOBBCl9217MkBoBgyykg7OmbS2MvUTTGwCgGiwk48gwGpid6y?= =?us-ascii?Q?Ao1xmfgE6qBt3JsAZ5eGhaqLWGpkjSAt7XSHQ20tPalk089tlSRexZLIwBsp?= =?us-ascii?Q?759bTYXaN52ERnmp9piZPyq6YnPc0uLZ/pN8e2kTT1ihKSnVOL23jOXzEeeq?= =?us-ascii?Q?o/3cTkbf4MiHB79uo7A=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b837151c-b2e6-49e4-cc77-08db45544d72 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 06:14:18.1825 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: /BIx5tNNGncyR4CQqp72R7KRriQFW/KqWuED504JG4VoTrFhfpO2FGbFy+rYkeIUUA3JtzMTZ9EUqGDfDC0R0A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6496 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Why do you need to explicitly disable MTC bit? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Tuesday, April 25, 2023 1:48 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul R ; Gerd Hoffmann ; > Chen, Xiao X > Subject: [edk2-devel] [PATCH 3/3] UefiCpuPkg: Disable MTC packet by > default >=20 > MTC packet is not needed and disable MTC packet by default. >=20 > Bugzila: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4423 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > Cc: Gerd Hoffmann > Cc: Xiao X Chen > --- > UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c > b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c > index 1a101b7288..3f109bf29c 100644 > --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c > +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/ProcTrace.c > @@ -538,6 +538,14 @@ ProcTraceInitialize ( > CtrlReg.Bits.TSCEn =3D 0; > } >=20 > + // > + // MTC packet is not needed. Turn it off by default. > + // > + if (Ebx.Bits.Mtc =3D=3D 1) { > + CtrlReg.Bits.MTCEn =3D 0; > + CtrlReg.Bits.MTCFreq =3D 0; > + } > + > CPU_REGISTER_TABLE_WRITE64 ( > ProcessorNumber, > Msr, > -- > 2.39.1.windows.1 >=20 >=20 >=20 >=20 >=20