Re: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLibIntrinsic.inf

["Ni, Ray" <ray.ni@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 2527 bytes --]

Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks for providing the alternative solution that avoids impacting OVMF boot performance.

Thanks,
Ray
________________________________
From: devel@edk2.groups.io <devel@edk2.groups.io> on behalf of duntan <dun.tan@intel.com>
Sent: Thursday, November 9, 2023 10:49 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Subject: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLibIntrinsic.inf

Simplify IoRead/WriteFifo implement in BaseIoLibIntrinsic by repeatedly calling
IoRead/Write in C code. This can avoid calling assembly code to use string I/O instructions.
With this change, Ia32/IoFifo.nasm and X64/IoFifo.nasm can be removed. Also
source files for IA32 and X64 are the same.

Dun Tan (2):
  MdePkg: Change IoLibFifo.c to IoLibFifoCc.c
  MdePkg:simplify Fifo API in BaseIoLibIntrinsic

 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf    |  10 ++--------
 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf |   2 +-
 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm          | 131 -----------------------------------------------------------------------------------------------------------------------------------
 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c               |  59 +++++++++++++++++++++++++++++++----------------------------
 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c             | 217 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm           | 120 ------------------------------------------------------------------------------------------------------------------------
 6 files changed, 251 insertions(+), 288 deletions(-)
 delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm
 create mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c
 delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm

--
2.31.1.windows.1








-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#110949): https://edk2.groups.io/g/devel/message/110949
Mute This Topic: https://groups.io/mt/102478994/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



[-- Attachment #2: Type: text/html, Size: 5055 bytes --]