From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 89CFBD802EC for ; Thu, 9 Nov 2023 05:56:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=QAgogn+rKqF2+FxblQ6K4SLmUG0zC1V2Ju1hXDnMClI=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20140610; t=1699509370; v=1; b=keoE4Bnqk+lF6awYI1rbnBH8i3b5652tZY0fy9Sh6uNESKyG6hkAtzRrxLdZv9VIJJuoPty8 xh/ZBvRM6Mkugo9DAyFpRGcImfU5oE6n3Po7VUyWdBmwobfve71ljsZCXzYHRz7fJauM/pLkxo1 CC7ovu2MHC/0EvIWLew7U63s= X-Received: by 127.0.0.2 with SMTP id l2S7YY7687511xVAiH5qPGbq; Wed, 08 Nov 2023 21:56:10 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web10.115601.1699509369377336346 for ; Wed, 08 Nov 2023 21:56:09 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="392795583" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208,217";a="392795583" X-Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2023 21:56:09 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10888"; a="756790222" X-IronPort-AV: E=Sophos;i="6.03,288,1694761200"; d="scan'208,217";a="756790222" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga007.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 08 Nov 2023 21:56:08 -0800 X-Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 21:56:08 -0800 X-Received: from fmsmsx602.amr.corp.intel.com (10.18.126.82) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 8 Nov 2023 21:56:08 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 8 Nov 2023 21:56:08 -0800 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 8 Nov 2023 21:56:07 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MMF6N6qOqOA0EAfiZ4ikBbaelQiR/M8FozziLKsqoumrtaKPlWcS7MlQ19ROmdlKeV3o7AfvCl+E6UuWrRh/ZVhH48kSrtUtOaVZ5HhCyy8rDKiiHpS3eM5TMOiLfDgwMohYHNPp7Df8guQz8MvdzlHr+6GetKJCm2KGX9kG8zRF60MwBRgAzeq2Vb/5EzkSLRHQRweq55w0jTTOQ+IjKRTbwhJ5LQ7nBFViJwrRnfZ9Q0+j1DNCuFIIn0Z1UJcokwUPmkFE1IsRsstUGQr/zbYFoIWMon/W0h1v9qo8k55mYV8+yuH/bQCvt64vRwjWWudNIQyvOTibi9KaUaQvcA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ieunHwRpDKkZS+iJuIgXXTvyH9Ku5lPwS98mMEXQ+qs=; b=QaewW27Ea222uizr7+1Pd2tO89FxP6e9lkvoO9Dn6D/XPkkU9WRku0NBOkGs46LQOgeTnJwwdFJcnxHCD9NyUAQC1C0+PC7Mu4VJPq5DaM6V2jz448aAHb2knu0P/vma62/Mr9/XL3eBlhi6eshnWEEsrLDB71hlrrD2PnICJePxrDjddLmRuWiChSeAwETirJOCMqrtGY40QMPtIFC8K68AFohWHziV8xuzXwtVA8Rei9UUZ63DJtok93PggS/QNVUVTkSSnGlsGPW+yyDBboaEZwYh391bvpnIRkl6/30UkXPQE5y6UrjjRj3C2lRIIBb0LBAZ0PuIKDAJ1fgFEg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SA3PR11MB7584.namprd11.prod.outlook.com (2603:10b6:806:305::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6954.28; Thu, 9 Nov 2023 05:56:05 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.6954.030; Thu, 9 Nov 2023 05:56:05 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Tan, Dun" Subject: Re: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLibIntrinsic.inf Thread-Topic: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLibIntrinsic.inf Thread-Index: AQHaEreSabo4Ojv1VkuFaxn2aQRn1rBxfRQq Date: Thu, 9 Nov 2023 05:56:05 +0000 Message-ID: References: <20231109024958.1732-1-dun.tan@intel.com> In-Reply-To: <20231109024958.1732-1-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SA3PR11MB7584:EE_ x-ms-office365-filtering-correlation-id: b53442b1-5b7f-4d76-75ff-08dbe0e88ffd x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 6I2DLVin3DoqC4xJs4fz14KaOIzJGR0Jvi6kWW0MB3qY/vX3Ezt076xm5LOFNqUJMMKZjjNjkuIFj8FTeIYrlzokZK3AsWHS4j01LZ4uANaGrmT0BJRi9xIUd4C9TdqOD9PPGdkrLY2Yl+OsyRT6R1QqZcM2J1TgiqXKk806nhBogmM/pEp0b8MJ3KyqL4ubEBcAq9MezGfvALymSIPTZi3fZD9YCs2N9icWwqyP75x3LPSnGyyXjhQVdBDs6AB/wZEbEVPS7tmpe4ujAQBCFD+OBbpsiLDuAGHIQq56RC6/XpXve8e33xFYfARXVuQI7p7AgsogdlyLABykqwpzGYXYA+A6RomH0RfpPiKAt58zxjPZjV34Qd3POpadekqNYGvj7nxdhqY1MlR/afmUn2vr74d+0KBsmLbjgBw/PQ9RD0XXpof/3tAIek3hQbVmdhDI1Lsk6USWu/ToStR2sWI5sFQOoO0ad0gxItveiwbBvmha7j7tXwdKhBdTq26Xcs2IJx9OICqg8sVDzAWP9F0bQyWrSZwPjYzwuLozy9ZN6xlZ5jg7HOathuOs3Bc71hFao/NCLA+xY2yLCg9SDXIuPnQoQEIUkg+3PReHoDCQ9BJXhRk0l9AhumI5DiQtYn4yr63xPr8Utt2uxYhTBg== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?QNwiWr6MKGIm7e9f1lBrSICeTE52I+bvuXROBakSJNYRqnoguzyI0gmJzp4o?= =?us-ascii?Q?XzLKRtWsLJGzgiKrCL3CdJKI0ik0mF41l31BzjZYjAy+huG24nCvB9qzTeDE?= =?us-ascii?Q?MFZJe9egvZ3o7q/MsxNQ+iqP529RknjsLLZwmPT6Rjx/S2huvm/IXDauHPnl?= =?us-ascii?Q?c4/20LReAVCZGCO9z6eIPFQD7czyzJcezteyVqhCUr7fqruRC/lK+mxZDNWe?= =?us-ascii?Q?a7qDRodabYynWhIBWeCd2i7g13ufH9zS95B4VpmOFiJQQyddApabOZeZ2UtD?= =?us-ascii?Q?YVqeOhtIuu8m9eg7jHWDxqkUneVTe25ckKJ+Nu2V8IkAbdDN3La6YIeGtdJX?= =?us-ascii?Q?EYjotgF5DwloTaJ7qWyXTY/MKBV9zlBAbmxaeUfkFxGifGcRJNqXTFE5fr58?= =?us-ascii?Q?l+QrUw67/QLCz5rmuknaepURWclOdGYJyvdIxt7Xve5pdzygHgvetLBgF15Z?= =?us-ascii?Q?BVh5APmzJBLrnSf6xFNd+Nim/GoZn0/tu4GTPTC2OfKk44e2ZwKuAVauddvN?= =?us-ascii?Q?rpP8Iu8VyOVbKPFvEMCntHqM2N803sHQcer5lWr5UWImpxezW1dBinC0sT8t?= =?us-ascii?Q?Ylb8hKbdxK3i3q2nbJWr7egslvp8XY8VkNwBre6EYuO5JbM9ASuPKD1j1JJf?= =?us-ascii?Q?zLwk0eZHqepI07619cSSieG5bfScVp2AcUetRZQLfkDIntP045xEBBFcELGm?= =?us-ascii?Q?rNT2MIHLsG0YIq68/AO3YNBj8KSJsQQ7Gn0eQBeKM45XKdqQhsmKbbZYnQzN?= =?us-ascii?Q?hdSPdT93KJsMJzjfSJ4NAPldHwMnozznIxjErTtYMXl3ljQALQDKZ1+yZuUf?= =?us-ascii?Q?88QNYQ+CLYQYEE8Kut5Cqoytq6h44GMR/E107+1dgT8JIxndHicNgp6gKTXA?= =?us-ascii?Q?gi9GgYDLncHWXDNd1lC9rdtyC2fwY11jFAdpiFbMcrbPBweiuoG5sDv7yLt1?= =?us-ascii?Q?VatAqrnxXaXOCkWOTY7XGKybIu/GUXluaVOL9XSAB9kE/NKZpo7VbPKqNwEl?= =?us-ascii?Q?XCRjKZOL9dk8eqsJExH4FldRUpd5pziPcflyQVUQXQgKqPTg6fM1Lj2AC2iL?= =?us-ascii?Q?boTZX6eTkiWgTOsl8Y82R9PBjBpcpkz4ndFcuLXna8z00JI53ffch4LuIlQB?= =?us-ascii?Q?wd8d7AqzRHjCUq7NZ1PnCkW+Vc5PVLI+aHp+NS9ketnbCYal/LWzV/15f4Pg?= =?us-ascii?Q?zDgPqKnT3GOJZ5DxUWAI2JbbCNJ0yrrDC9bN9cralqr4Nyzg6wi6zqsMcge4?= =?us-ascii?Q?YE/5MbpwoibFHDEtlEhjobInogWdcHg13TRvqdkKW6oMLZwdH8eFuJl9YsV2?= =?us-ascii?Q?YFYWblHZ2G1l0Xjg5+DHanM4iL6850Sj+SboO90Phxau8BM2zS/iJ5uS/17H?= =?us-ascii?Q?JlJ8YZ9EGe16rC6cYZ/js9IZOLHCwwm0J9dB6I7GlK3UPLTSlZ5L/ug+Plhg?= =?us-ascii?Q?gN2rlPLDEBQHuRN9WDGKyZ5Mp1lCDZeFfpycMiC/oU8lAU4Ai9iJZTDDif9S?= =?us-ascii?Q?Mbg58oQ1KP28DAUrAKrOkVgn74IQQjiX109znsCWGlsWpjRe2Wt2jByUzmCN?= =?us-ascii?Q?UUH5/TtS0/vtkxe/+9Y=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b53442b1-5b7f-4d76-75ff-08dbe0e88ffd X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Nov 2023 05:56:05.5716 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 6IdMhK1OOMHmWxPaY+lbTJx253koqkOMufIayX5S8ZGFznUJXXciTg1liYeA7tcIYzcgGxkMOau3PVIFoR0Iag== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA3PR11MB7584 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: loWxVqB4TRPiwRxLmA0P0Ec5x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244C5DD47A1DCE4A9CC8A3F8CAFAMN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=keoE4Bnq; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") --_000_MN6PR11MB8244C5DD47A1DCE4A9CC8A3F8CAFAMN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks for providing the alternative solution that avoids impacting OVMF bo= ot performance. Thanks, Ray ________________________________ From: devel@edk2.groups.io on behalf of duntan Sent: Thursday, November 9, 2023 10:49 AM To: devel@edk2.groups.io Subject: [edk2-devel] [PATCH 0/2] Remove string IO instruction in BaseIoLib= Intrinsic.inf Simplify IoRead/WriteFifo implement in BaseIoLibIntrinsic by repeatedly cal= ling IoRead/Write in C code. This can avoid calling assembly code to use string = I/O instructions. With this change, Ia32/IoFifo.nasm and X64/IoFifo.nasm can be removed. Also source files for IA32 and X64 are the same. Dun Tan (2): MdePkg: Change IoLibFifo.c to IoLibFifoCc.c MdePkg:simplify Fifo API in BaseIoLibIntrinsic MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf | 10 ++------= -- MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | 2 +- MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm | 131 --------= ---------------------------------------------------------------------------= ------------------------------------------------ MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c | 59 ++++++++= +++++++++++++++++++++++---------------------------- MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c | 217 ++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm | 120 --------= ---------------------------------------------------------------------------= ------------------------------------- 6 files changed, 251 insertions(+), 288 deletions(-) delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm create mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#110949): https://edk2.groups.io/g/devel/message/110949 Mute This Topic: https://groups.io/mt/102478994/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244C5DD47A1DCE4A9CC8A3F8CAFAMN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks for providing the alternative solution that avoids impacting OVMF bo= ot performance.

Thanks,
Ray
From: devel@edk2.groups.io = <devel@edk2.groups.io> on behalf of duntan <dun.tan@intel.com><= br> Sent: Thursday, November 9, 2023 10:49 AM
To: devel@edk2.groups.io <devel@edk2.groups.io>
Subject: [edk2-devel] [PATCH 0/2] Remove string IO instruction in Ba= seIoLibIntrinsic.inf
 
Simplify IoRead/WriteFifo implement in BaseIoLibIn= trinsic by repeatedly calling
IoRead/Write in C code. This can avoid calling assembly code to use string = I/O instructions.
With this change, Ia32/IoFifo.nasm and X64/IoFifo.nasm can be removed. Also=
source files for IA32 and X64 are the same.

Dun Tan (2):
  MdePkg: Change IoLibFifo.c to IoLibFifoCc.c
  MdePkg:simplify Fifo API in BaseIoLibIntrinsic

 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf  &= nbsp; |  10 ++--------
 MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsicSev.inf | &n= bsp; 2 +-
 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm   &= nbsp;      | 131 ---------------------------------= ---------------------------------------------------------------------------= -----------------------
 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifo.c    =            |  59 +++= ++++++++++++++++++++++++++++----------------------------
 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c   &nbs= p;         | 217 ++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++= +++++++++++++++++++++++++++++++++++++++++++++++++
 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm   &n= bsp;       | 120 ----------------------------= ---------------------------------------------------------------------------= -----------------
 6 files changed, 251 insertions(+), 288 deletions(-)
 delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/Ia32/IoFifo.nasm=
 create mode 100644 MdePkg/Library/BaseIoLibIntrinsic/IoLibFifoCc.c  delete mode 100644 MdePkg/Library/BaseIoLibIntrinsic/X64/IoFifo.nasm<= br>
--
2.31.1.windows.1






_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#110949) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244C5DD47A1DCE4A9CC8A3F8CAFAMN6PR11MB8244namp_--