From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id F3999D80D40 for ; Wed, 26 Jul 2023 08:03:52 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=T7OVzVl4hyN/pmbBMR6Y20qt1Arj2EbYsH/8OO9r8HU=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-Mentions:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTe nantHeadersStamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690358631; v=1; b=wWqgT1WLuaXAzeIMuqoQqSJMVlyqcCf9CwhZnElkNe/dfSPe9jp55Ze+TowXiUSy7aFrcBmM bG89mmmvwN4jg9rcOOcI1VHFF9ViR4Oqc2QdD0O1oAPpWU8n2WTeDCP0mVC8fFduOtf2aS3Uvmh nIRLSVpUnWl2wIdHUStNjCW4= X-Received: by 127.0.0.2 with SMTP id YH3dYY7687511xOvVl45J9hh; Wed, 26 Jul 2023 01:03:51 -0700 X-Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web11.6374.1690358630605635229 for ; Wed, 26 Jul 2023 01:03:51 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="352849213" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="352849213" X-Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 01:03:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10782"; a="726422130" X-IronPort-AV: E=Sophos;i="6.01,231,1684825200"; d="scan'208";a="726422130" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga002.jf.intel.com with ESMTP; 26 Jul 2023 01:03:46 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Wed, 26 Jul 2023 01:03:45 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Wed, 26 Jul 2023 01:03:45 -0700 X-Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.169) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Wed, 26 Jul 2023 01:03:45 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T0sYpj1q9iG7dH1kQd2V/d1lxsuCJaUnyJD6qgsmfd3tjIPrh1Xwi7wTSX14s+cHYtI1rpUPJ/O4wwyHe6Aw5xP7EdoZcGjxmmAZM4GOV96OKKgEwt0Rn6zGDfT/tmPu1jSuOqeetnxVJUmyp504FF9zmMN+PzbrXxtcTqIpywrzbXVd7uvn0N5aKVrKp3lPR3iPtuxU4hhgSL2BpcHA7srsWLr9M8qV3nzV5UmXdFR1r96bW6928dgxbupdeiVK/kuTjrm64tHOMLki2TVw1/EAJiC8amDs70z4hFc6Y3cWITcjC0NqcA9AQInOpnJXH5dAArbqCbwChnReaPMy7w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1FimYuWKLw3cdTN6HlZvdpaf+22YKWmYonNP3EDG3cs=; b=DONNE77cyohyQxjnDS4YR7uIIvDKErsJiIfjhHO60Lkkh32oZGymTb2T070QirGIoe2MSUo5DDWgHoFlztVCqp7Q/SOgIADRu9Qpl4cHYjdQMr9iyX3tf8v3t5PwthGh+mI/WauXenvtcxeOEdcUD/MZL430JP/O8QCGHpnD3nue+HtddJzuqHzA3zx7ywGmiJCLxQWcBm9+GZKLnJtdOoImDRJBuVcQX3apD5PcA1CCpEx4Ul9a3qk9YJwxSYoyu0w/GspTIyn2E/UmCaL1bdZ7sc4ZLdb6hsXrJDQ9w3u5HXUOhZvSx8EQpSePRCnVdiSJrRno4QswE/r9Cuvcog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB7479.namprd11.prod.outlook.com (2603:10b6:510:27f::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Wed, 26 Jul 2023 08:03:36 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6609.032; Wed, 26 Jul 2023 08:03:35 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" , Tom Lendacky CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality. Thread-Topic: [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality. Thread-Index: AQHZv5YJ6tykN0Za/kWfUp0bysQRsq/Lr9EQ Date: Wed, 26 Jul 2023 08:03:35 +0000 Message-ID: References: <20230726075126.5836-1-yuanhao.xie@intel.com> In-Reply-To: <20230726075126.5836-1-yuanhao.xie@intel.com> Accept-Language: en-US X-Mentions: thomas.lendacky@amd.com X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB7479:EE_ x-ms-office365-filtering-correlation-id: 3406655b-937b-465a-bc71-08db8daed01e x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: +Ykx6G0qOagBYgmg1vp+YxiUO7WPoipmIMdnGyaTZ060VQqlhsQiLFQ+gNovxZAW32QJlsnXfgyGq/HrYq1kGYxhl14p6xt0OzUjSywz8nVp9wyHmLnhnaqzZ3MZ1CPJjseabXH749E6NrZUaGjRwVZXP0t/sX2NsRC40G/R+dwrz+rufCjTisTnAdmkQigdHJq434nJQjDYgntqlVm33hRvJdnwKTzXtJrJUw49sNkaJIPJ35IVB5z/9i43izT338nBS8AXVork+WSnpwma5WQ0kzggOrypNHNKvxsFOqULv+4nZQA+i27HaQ29M8NmkRfcqW9YPSY4FPd0ziECnC5q5Dd23Zxsb2mG1+0csTiRuHwiQ3K+Xeb5Y/9Gsi6tANVwhMlNeKXhJYK32VIoCi1sAv1vblmeSo+7O9bQAYopbzPFT2mFRrZkxYxQeSK2eich/ScTeD12ke8vPSOdS0eZzSRV8BPBMjwgaUfsP7q5YM1Xiw6EUW0mVt4A/HCmUZ1rOWLRi4vFrOv64hj6/vWM1GsaVJSIZEkhqkow6sgOp8Tz3il+CitwbJzhiBNQySk2Q3qvZ904IhkFyC/HBNDNuvp0Vbxj55zJWc1BWJiIinY/dkv35I/BcEYzNNoT x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?N6eawXlkkBc7A9JANuuVfecl0Ys3boNv6+YQfqYMvHE85dD3I/U1kxwL2VZB?= =?us-ascii?Q?4Wnl+CuKeXpWp3egQ6HnZ/JWEUo1LzL5CpIdgT5WOcBnbF583H+J08Uc0GpV?= =?us-ascii?Q?HWXdNz6thcJDnpDQ6zmkYKDEoSw/CNvWoD9uWlO4twBC2b5OIekXcpOtqRvB?= =?us-ascii?Q?+aeG0NTJqOLUlHsTwusAtRgfFC9vX0KQYXu1n1o0AAXV72KrbF0W2G9HfkQ/?= =?us-ascii?Q?DvPNar1RXDD1mcgQmaKhwhqbo4n/LZPX7LyeIhzbZNzxnaRTJQzYY7ma60eQ?= =?us-ascii?Q?EtfXindoOYvW0pmj8m7ih7XmndC/pCm4rYXWyy24NcJ4RWsZ7Mdb3xAuesf6?= =?us-ascii?Q?wYwiNQK58Dyr9kR77i4fwJwqO21i/7fIXSidzZZfCd/KojG4EoKKgvVr8fZV?= =?us-ascii?Q?3w2bDk/5722hpJYgJd2ipDLR1OpWL3mKeoqYmCstxnPc3pFj6gDGkD2ZVUwu?= =?us-ascii?Q?ZYO0EQGbCdtSmWgKkFd2LzSzH5ucUYu2hr1U6nhjT1Gp5W8muVApuT4i9d3S?= =?us-ascii?Q?jYAyFTqSaxda7YzGrdELQTE9BTR6eMs6X9S7JdwtevLSMQxd7G7Gz7QNPQfl?= =?us-ascii?Q?B3Fn0IrD7byBkDDtSY91EcTvBCCjr7wJS77M1LufRMglFCqD+708Ezj0bIc2?= =?us-ascii?Q?E2kYguuPv84UHBydVzOtaNlEuvrXfs0QHlrjAY4u2pi+oK5mzwbQ/uwvgl8X?= =?us-ascii?Q?Mr2brrrSCOZRrdXpBReWHaRW2Pi+CB67Mi9hSyUJQS2lDP55Insimav5Jb0c?= =?us-ascii?Q?umzgI8gqv6S3DghuwML39Sl2VTMV++tE7GmMSgzS58AZG4zGoaoOL9sZlxnb?= =?us-ascii?Q?D7WSMy9ilzlzY3wO80S5F+i+GkKu5WpW+tJiKq0Gd4U1qkkqk6lQAXfDiJnw?= =?us-ascii?Q?ftmHZgcSKSm6hwqaLXm7KvBeaUeX9xERSzf8R0xx9ZnqjlYuoUxTbUQvp+sX?= =?us-ascii?Q?cjA3imtSkm4MOvq4e3jkcAF0zPhzErdT22shYdt1agAEjdAZJWWs4dG6Rmtf?= =?us-ascii?Q?Iol4QroQuTs41mWy+G4579o0A9l7uNwnECDmuj+DcY+cytsZzRZEAJmv5TS1?= =?us-ascii?Q?sZTE7YTcgVEPGNYgnSl/n6c+pQ+lfMZZZSoGOiGj/64WxiwIQf5NyVZ/P0U+?= =?us-ascii?Q?w2NoADFrFY2PkuMUfi7kdVoSyh7AI3pQwPrnv6rHoygFyCPf5GsrO4bekAwN?= =?us-ascii?Q?YZkvvQHHlAt2Cy1+WPeZMYl/BO4VBJaqwlClrFnla1E4ksCe0vvJCzt8BJoE?= =?us-ascii?Q?Ql2Ny8BseX0XpdmBiDPw+a3qshiMizus/YqhZOtufmCztgUl6lY4//nLqLJS?= =?us-ascii?Q?Lf/sncXShcNdCxK35wihR65JTzMbo4VguKyUfexHmFckhbbHxh7XLX+jgHab?= =?us-ascii?Q?tSytikfG+0NfJ9dwjisX+DEdIa7Nax448vnWE2QrF2tD7SBcQppassFh36ty?= =?us-ascii?Q?HK7PnsM9VwguCMhSWNYHpUaJRVpDLTGdvnNOO7xQmNnKiNcJLSSkLPG8UTE3?= =?us-ascii?Q?Kn76YgCKpXI/XLjmM5QqcKGg1egyqVkRXMUh1FHxpNZbJSnir2cZIn8YFGE6?= =?us-ascii?Q?PYaeMs2KQ/XP1zZ4uI4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3406655b-937b-465a-bc71-08db8daed01e X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Jul 2023 08:03:35.8482 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T3CDN/Ta/6k/ikpjcYG0wNO/gH5BSMQF+hY/HjmIWOc7CmGk4Z/T5Cnnk4T+tx7ERZvKAnGBywxgXtja/qvnUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7479 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VogZ8PIkGi4B9KKZfl9b2gHXx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=wWqgT1WL; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") Reviewed-by: Ray Ni @Tom Lendacky, can you please comment? > -----Original Message----- > From: Xie, Yuanhao > Sent: Wednesday, July 26, 2023 3:51 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul R > ; Tom Lendacky ; Ni, > Ray ; Xie, Yuanhao > Subject: [Patch V3] UefiCpuPkg: Decouple the SEV-ES functionality. >=20 > The purpose is to fix an issue where an exception occurs at the start > of the DXE phase by applying the following patch series on INTEL-based > systems. >=20 > UefiCpuPkg: Refactor the logic for placing APs in HltLoop. > UefiCpuPkg: Refactor the logic for placing APs in Mwait/Runloop. > UefiCpuPkg: Create MpHandOff. > UefiCpuPkg: ApWakeupFunction directly use CpuMpData. > UefiCpuPkg: Eliminate the second INIT-SIPI-SIPI sequence. >=20 > This series of patches makes changes to the way the APs are > initialized and woken up. It removes the 2nd time INIT-SIPI-SIPI and > introduces a special startup signal to wake up APs. These patches also > create a new HOB identified by the mMpHandOffGuid, which stores only the > minimum information required from the PEI phase to the DXE phase. > As a result, the original HOB (mCpuInitMpLibHobGuid) is now used only > as a global variable in the PEI phase and is no longer necessary in the > DXE phase for INTEL-based systems. The AMD SEV-ES related code > still relies on the OldCpuMpData in the DXE phase. >=20 > This patch decouple the SEV-ES functionality of assigning CpuMpData to > OldCpuMpData->NewCpuMpData from the Intel logic. >=20 > Cc: Eric Dong > Cc: Rahul Kumar > Cc: Tom Lendacky > Cc: Ray Ni > Signed-off-by: Yuanhao Xie > --- > UefiCpuPkg/Library/MpInitLib/MpLib.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c > b/UefiCpuPkg/Library/MpInitLib/MpLib.c > index 737e03ffc5..e7054adbcc 100644 > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.c > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c > @@ -2160,7 +2160,10 @@ MpInitLibInitialize ( > // APs have been wakeup before, just get the CPU Information > // from HOB > // > - AmdSevUpdateCpuMpData (CpuMpData); > + if (CpuMpData->UseSevEsAPMethod) { > + AmdSevUpdateCpuMpData (CpuMpData); > + } > + > CpuMpData->CpuCount =3D MpHandOff->CpuCount; > CpuMpData->BspNumber =3D GetBspNumber (MpHandOff); > CpuInfoInHob =3D (CPU_INFO_IN_HOB *)(UINTN)CpuMpData- > >CpuInfoInHob; > -- > 2.36.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107265): https://edk2.groups.io/g/devel/message/107265 Mute This Topic: https://groups.io/mt/100366586/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-