From: "Ni, Ray" <ray.ni@intel.com>
To: "Xie, Yuanhao" <yuanhao.xie@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Tom Lendacky <thomas.lendacky@amd.com>,
"Laszlo Ersek" <lersek@redhat.com>
Subject: Re: [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function.
Date: Thu, 23 Nov 2023 01:23:49 +0000 [thread overview]
Message-ID: <MN6PR11MB8244C8B39AFCCF95C099BDA28CB9A@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20231122060834.3467-4-yuanhao.xie@intel.com>
> VOID
> -ShadowMicrocodeUpdatePatch (
> - IN OUT CPU_MP_DATA *CpuMpData
> +DumpMicrocodeRevision (
> + IN CPU_MP_DATA *CpuMpData
> )
> {
> - EFI_STATUS Status;
> + UINT32 ThreadId;
> + UINT32 ExpectedMicrocodeRevision;
> + CPU_INFO_IN_HOB *CpuInfoInHob;
> + UINTN Index;
When DEBUG_CODE is disabled, above local variable declarations will
cause build failure as the compiler only sees the local variable declarations
but cannot see any code that references them.
So, can you remove DEBUG_CODE_BEGIN/END() from DumpMicrocodeRevision()?
Instead, you call it using following way:
DEBUG_CODE (
DumpMicrocodeRevision ();
);
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111638): https://edk2.groups.io/g/devel/message/111638
Mute This Topic: https://groups.io/mt/102744601/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-11-23 1:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 6:08 [edk2-devel] [Patch V3 0/3] UefiCpuPkg/MpInitLib: Eliminate redundant microcode loading in DXE Yuanhao Xie
2023-11-22 6:08 ` [edk2-devel] [Patch V3 1/3] " Yuanhao Xie
2023-11-23 1:18 ` Ni, Ray
2023-11-23 1:18 ` Ni, Ray
2023-11-24 3:06 ` Yuanhao Xie
2023-11-22 6:08 ` [edk2-devel] [Patch V3 2/3] UefiCpuPkg/MpInitLib: Store MTRRs settings only when CpuCount>1 Yuanhao Xie
2023-11-23 1:21 ` Ni, Ray
2023-11-22 6:08 ` [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function Yuanhao Xie
2023-11-23 1:23 ` Ni, Ray [this message]
2023-11-24 3:02 ` Yuanhao Xie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244C8B39AFCCF95C099BDA28CB9A@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox