From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 8651AD8018D for ; Thu, 23 Nov 2023 01:24:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mNcT/GTQSQqRa75bzb6pbf1KaaejndFWI+ex2sgedfw=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700702641; v=1; b=m20qNF+Nf0p2hhECgfjnzPTk80/iuHn8Kv/SEmghInvxqmZ9UccVpMqlzmfySB1yakTe2xxu dHcB53J+AE/9RcG5BYkWzxga0Nk24FYdzS8CqXWPiopKp90FdKB7+ekrnU+ahUy9rfvzC6RvPJn HGnjLjwtvxfTjw266XwdVkKc= X-Received: by 127.0.0.2 with SMTP id 3hSzYY7687511xdwrJjpJFck; Wed, 22 Nov 2023 17:24:01 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.115]) by mx.groups.io with SMTP id smtpd.web10.82177.1700702641329334056 for ; Wed, 22 Nov 2023 17:24:01 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="391948490" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="391948490" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Nov 2023 17:24:01 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10902"; a="1098634798" X-IronPort-AV: E=Sophos;i="6.04,220,1695711600"; d="scan'208";a="1098634798" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 22 Nov 2023 17:24:01 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Wed, 22 Nov 2023 17:24:00 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Wed, 22 Nov 2023 17:24:00 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Wed, 22 Nov 2023 17:23:52 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eitpzsG2oO7txH2EP3ttUuZsotvpvVe7Whf/VbXTWhx9SFV6X+V3BdPeZD/6XOCqqi/j0dQq6F1XPQ7ZojhQpyTRT4dbcy/ixJdk85bdkzLpC+gsMEWQUHKYq+GZWY1jhmT4Lg61dpfSxENI85SGRoRjAz1iYgM8jPOBP2Oq0XYXAiwwNty3zerTpi0q9bU0Uwg3XwMwc/BkcLfyUDCkJLheGwrXHgRa0J6u2TteErEnL6YzqFYvnE+psrmE4W3Z7hohQNDbmdZzG7oiyjJBUWhFttGmUr/OG3HWw0tNC4JEggEcDnYUrVrrgXOy6V1+9YFqNOQ5EJPPHtJnb3p+Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TvoPvjYauNMWpfd0KqRnW3/ijO7ffE0xoXF1k+vqPUg=; b=WVNwz4suXClSyS17PmBt3fVaNO8F5FQlxMmtgB2oLVyZ4dTAxeAL6eM4NYRSOslRPja0jXkPv+iPFupR/xmgZx9aWvxym4wgClxbHVJQqduX5ZDPxsrr7/VITm19eyCjdN8cwU54hsrWdDcRjZILnyWPzPnJooHeuu6IfAsTIRAXiYnZMkxSGx4CKhqhIlgXl8R4Tn13Tc5hgc920Q616XwU55Y7QRBDYQ95T6T2ZYdpWYo5hj5Pf2n0dLvcU1FxyvlMs7HzeTTrStlrOlNhFBNKNqu/IiIwvAq1y0gcBSHbcXKi+oSgQLvvxC07dNaD43TF2ksTZTt/yRwUioMBSQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB8203.namprd11.prod.outlook.com (2603:10b6:8:187::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.18; Thu, 23 Nov 2023 01:23:50 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7002.028; Thu, 23 Nov 2023 01:23:50 +0000 From: "Ni, Ray" To: "Xie, Yuanhao" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Tom Lendacky , "Laszlo Ersek" Subject: Re: [edk2-devel] [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function. Thread-Topic: [Patch V3 3/3] UefiCpuPkg/MpInitLib: Extract Dump Microcode Revision as function. Thread-Index: AQHaHQpojFMAT6/4nEWYFa3EXRJmh7CHHHnw Date: Thu, 23 Nov 2023 01:23:49 +0000 Message-ID: References: <20231122060834.3467-1-yuanhao.xie@intel.com> <20231122060834.3467-4-yuanhao.xie@intel.com> In-Reply-To: <20231122060834.3467-4-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB8203:EE_ x-ms-office365-filtering-correlation-id: e05263aa-83ed-43d0-3411-08dbebc2d8ba x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: suwZtl+NMDkdA5h256ovGY70XO9OO5xB/8jTU6IllhWH2/zrVdY8glqceXyiRweFTjSwZJHXQxj0Ixj0DJBg9Ohx3wKqpUvoWz4kfYWM5OCNOegbtVSoqRi5qDEFFdOHNpnFOisuqCRgl8zaJKkcTyATKKtZzaaGt5SlBeXZMKQxX1j+t/1qLtOn0svkuX2Hszx5BIQ1HfU4eW+qGLvpxDRv2GMIvjxiZjB1UqjsOHdWk6MoqsKo+/wBvkBxfH8rjaOLrEoVcYn81G1pQYKd1vGTnIthSOKWUTsE1tdnc5phpvXJTLHPxqyd9rAouu/EOUCVzQntEVeN/WNBtvV+s5zW7t2eUU+fEaxWmOeDTSyDrYicy1mpJGKRxBWmrHgk4SD+XZwD9Clmh6cJyspAZosgMmaJ7qJZbxNdK/0kBKZAQRkAwFD1JiUnKMZqSXE6QrCLH7kqpCVYxvoleRMVwEfHygQcLG9CwH6xGKntOQveCKXzu8t7+M68e07CctU5FkxcBiu8wN0aO7LgXSbDEgW2t3UUR41ihE1wRaQdjtFbir2HZMK0BHMJhItAtZ1L67AaZAjTq0kNzxDKOrVDU4c+zByRxoIOTrEpMusnrgKdGc/h770klHBcQmReWrnf x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?D9KbTtA6R7flCRsyblPqFoHR6kVJsr8x9Mm3fUQ4hNuH3Nd9cHE9676zaLGF?= =?us-ascii?Q?NstEvqMj7gBObcbF9/KCrKQVxiq8vvy8dlBSm+dmrYf78Y9aQyXcR7TZE9+r?= =?us-ascii?Q?3Fv9iA2YbjlaLZPgVZhyBps/LXQxZv55sYyUl8LciHCgm6XH/tL53yDpJIvc?= =?us-ascii?Q?2gv26+UV4TfSBfJLBZPKe+zFfcTCmKsJi57UejDmUb+/KCByk798bWc3cn90?= =?us-ascii?Q?yi3ztaIViaQtoHF0lGbXXZtZXDENcFC96KuzUnGbs5GZecK6Mlb1vQZ3m8PM?= =?us-ascii?Q?BU/UxmRE0WDWmEWvqXhK2PGv5YBm4isI8oVRbipT1DLoFM5z0fFuIgxAUOwt?= =?us-ascii?Q?c0zkrjmY13zY5bphNXMHd2LgvbDlY/c3xVc4KSu4Ziay+G+n14SKQH4fBc/8?= =?us-ascii?Q?eJvEmG3UECQWgC705b2xzE/HYWFD9SysxxBB+uPWfl5xXxtQeMT2G/ZiexRu?= =?us-ascii?Q?JvTbp24da3udS/PO27zPb+HcR/DpuPthOZGyYYNoEj4WzAXJp6WXcWEyjRTd?= =?us-ascii?Q?KMCvySGRE6s/VnmLMNzIaiAeOh/S82lDbGY6E/sjiYm87K+ScoB6KWzbKLmW?= =?us-ascii?Q?oh5sA84LMqDi2C/UVXwx9AlOwfPYKp+IlnWHSZFrmqxqa4FOfrw6qoMR4yV0?= =?us-ascii?Q?2Zh3z1Nzo2tm9U68zWXQNCLCtq9t40oYraGMZ7eta/1NNIyplZE2qUPU1AqZ?= =?us-ascii?Q?DImDLHzevMfdO4jvFYLoOyGnhxTVNaiEBY2DCFyINkGHABIb8hj0dVO2aQCJ?= =?us-ascii?Q?gtdASdoZqlbZUH5PYwGohc+IpYUyaXhfRy+rdssBogJoiax3wppbv8Pg7QV9?= =?us-ascii?Q?5/xLzBmr+8+t3vm67y6XImeBNh5/S3e03OJc3DX/x4jdYzeZwud5InACOygt?= =?us-ascii?Q?qweFyJivTdjP8wGyhHmzRJ+N1ICF59ZJltyyRfIeXS32CkW715L1XdeC/Nbe?= =?us-ascii?Q?qRgIGgV8PIw3Z0zxvGH79DRLmAhPWKO1HKV0ETHx4ZISV2lGiQdR4lwEwS8Y?= =?us-ascii?Q?4PIYP7DY3w5XPKY8/xNUSFtl8z/1CNDLPV73WRNoxxc66lpdHw3P74YlHAx0?= =?us-ascii?Q?hvDUXw9Gkd/JUsw8PveCVR8VvjVslppa78e47t38x1PIVlo9+I5jIbsmvgyY?= =?us-ascii?Q?CzTOZCI1YTeaF1apPl1eFeVNxpasmuOo+Ts+tQ4Q6ZtADajet/Def0HAlLNY?= =?us-ascii?Q?HaPmpdlcLFGXN/o1hEVH3MKEjFrB1KsoSz6YWfLO9S8FS+9w7vXER6Eor4yq?= =?us-ascii?Q?FoF/CPiu3osMhhZBS95ort1N3ftiMnpaYOBTExWxF4Bv078QSRkG8Usrv5ri?= =?us-ascii?Q?ISvfOAQL2bEbnr9yMZiU6Ee+cGoCmR0x+4yj4UfwEJEveDWjB1OC+6GYndUf?= =?us-ascii?Q?ZISHwy7fuc5zJjCMpJhw5QOyszB64Dom9fUnHuHagRpfDo1a0QYti35tJ5Jt?= =?us-ascii?Q?y1PA/7W0AsmLc/xlqLAdOE6EDpZiUtDfJuHPv27xsKC+vhCFzzdsWYLUNRR2?= =?us-ascii?Q?KICleQkK0xcmTeFuzDc1GKuPNEOzDsYQkin6i4kUkqJnbYKxlT0SejQJlqfm?= =?us-ascii?Q?akxwxXSkCFXZdQadoBU=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e05263aa-83ed-43d0-3411-08dbebc2d8ba X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Nov 2023 01:23:49.4707 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: yjbNBEpSAJZiwIt2+I3ZiEvaVyb+3t+jasu/cOkDuDq+LJFRhLOP8QwL466Alr0ZyMB/VTQLFDM04Qui0SDjTw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB8203 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YSoUcMUxnHlNFe1MKLhK8zmix7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=m20qNF+N; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > VOID > -ShadowMicrocodeUpdatePatch ( > - IN OUT CPU_MP_DATA *CpuMpData > +DumpMicrocodeRevision ( > + IN CPU_MP_DATA *CpuMpData > ) > { > - EFI_STATUS Status; > + UINT32 ThreadId; > + UINT32 ExpectedMicrocodeRevision; > + CPU_INFO_IN_HOB *CpuInfoInHob; > + UINTN Index; When DEBUG_CODE is disabled, above local variable declarations will cause build failure as the compiler only sees the local variable declaratio= ns but cannot see any code that references them. So, can you remove DEBUG_CODE_BEGIN/END() from DumpMicrocodeRevision()? Instead, you call it using following way: DEBUG_CODE ( DumpMicrocodeRevision (); ); -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111638): https://edk2.groups.io/g/devel/message/111638 Mute This Topic: https://groups.io/mt/102744601/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-