From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E1991941295 for ; Thu, 25 Apr 2024 05:51:29 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=q2Pz8z5sgTO/qbcHc7+cggZcZkIC8+KU04iMWTGRozc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1714024288; v=1; b=QnlDAxEwL9/WfuXVcfA4Xdt6nNVbiPe6KjbJa4mPCZWUKqw8Wpy9SHgr0cQodIEYjmAH497C ixKtfK3qcD1b8nlNJk84cU/UV8NPLQnXuqwken2a6J9P24c2bpYMcDLF/CXmiv/fNlvCBdck1So e8Qz7gKpjPLc4YP3tVQg7zTgfu3qFASq8MxkbvIep7E59ElMJaDjBUJQ6L3wscMlUVFZkUb/0fI DEqntgB7nke1QKBi3tHAYybmr8A+yb0mnsblTOg/dNTEfOxs5PImDjlFQ4VpqcVra/lQeQVtxui cgaMV+XB+fH50aN2PLpHazx9nsOkPAgyAjncj1yUORPYw== X-Received: by 127.0.0.2 with SMTP id Mb8UYY7687511xzfF7dK7UVi; Wed, 24 Apr 2024 22:51:28 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.20]) by mx.groups.io with SMTP id smtpd.web11.10326.1714024287657270628 for ; Wed, 24 Apr 2024 22:51:27 -0700 X-CSE-ConnectionGUID: CbAa7xQXSx+0eoKyPqz7VA== X-CSE-MsgGUID: HU9HZQ7OS9uQhf0okTwIsA== X-IronPort-AV: E=McAfee;i="6600,9927,11054"; a="9514718" X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208,217";a="9514718" X-Received: from fmviesa007.fm.intel.com ([10.60.135.147]) by orvoesa112.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Apr 2024 22:51:27 -0700 X-CSE-ConnectionGUID: mM/vQqqsSQimoJ9zkNJ1nw== X-CSE-MsgGUID: tQoZhYkEQeqv5BfrJk9AiA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,228,1708416000"; d="scan'208,217";a="24991165" X-Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmviesa007.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 24 Apr 2024 22:51:27 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 22:51:26 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 24 Apr 2024 22:51:26 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 24 Apr 2024 22:51:26 -0700 X-Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 24 Apr 2024 22:51:26 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW6PR11MB8365.namprd11.prod.outlook.com (2603:10b6:303:240::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.21; Thu, 25 Apr 2024 05:51:24 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c%7]) with mapi id 15.20.7519.021; Thu, 25 Apr 2024 05:51:24 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: Liming Gao , "Wu, Jiaxin" , Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH 2/2] StandaloneMmPkg: Initialize 'WillReturn' variable Thread-Topic: [PATCH 2/2] StandaloneMmPkg: Initialize 'WillReturn' variable Thread-Index: AQHalsrTCoio8q4XIUudHSkZeQfuErF4e4yp Date: Thu, 25 Apr 2024 05:51:24 +0000 Message-ID: References: <20240425044059.244-1-zhiguang.liu@intel.com> <20240425044059.244-2-zhiguang.liu@intel.com> In-Reply-To: <20240425044059.244-2-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW6PR11MB8365:EE_ x-ms-office365-filtering-correlation-id: ae65f2c9-ace4-4d5d-7ba3-08dc64ebbde2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?UsHYbLtbJwJUTwOjOB6cS4lsZ39tALrNH+Uh3Mx3ZKVwhao8+gvVnpyJ/0BG?= =?us-ascii?Q?0EN7JQt/4bPpkI1GTSRb/IUkIkqYiB/V3OLkEvciNWESsIWS6x+u60/M/MEp?= =?us-ascii?Q?vxNN4OyuD4APuR5yInYGAGVWRNuBUyg2ln5XQyfyKxdYuSa1GUnmYGmqNhlJ?= =?us-ascii?Q?7nadesvLEuxgMCkt+AEFLL8Mil5RX9aYZynoasVykXQQcq4YYYYqS+Yz34ML?= =?us-ascii?Q?0JOKJhCw6KAjHP3YLBj2KtQrVn8BrSqkWPrmlgR0YwekO6wsOfLgzoCTWUJl?= =?us-ascii?Q?qE6iYBgaUlyjnKfbRFNFU+YhaUwZgqgmJWlevQIBV4Q6CR1k8YoAohB3h6dx?= =?us-ascii?Q?XH2VX0NkV9/9L7lkXK4IFRIJeQSirV2H4lcoHJeHSO965OfOtJ4Z+wo7Uc1w?= =?us-ascii?Q?g2dRg5CAL9fIkWICbnwXj+8aAME930uSe7PLfl72BqDxozg7m4ZsH9oijsw/?= =?us-ascii?Q?gBa1Du6CNs5hVZt+JNZ+Nlck2V76uPeUedO09Jw7Ve+4X2WmHpi4hc27yzl+?= =?us-ascii?Q?3RUYUJfiX2jU1uHcoz4rDZMa9XEIDVeH+PX660HA15kWAm/pPk2RO7q+lFzt?= =?us-ascii?Q?tznELR4/OrWvM9rPeLV21Db08NmNqSaNENatpMNu60MtPt8c/a5UKJM7S5Li?= =?us-ascii?Q?3UR7hm05vaQ+gGTVKB2kVDYpMjDL1hjJowBIgIFon41XevDycgk4M9LZKzEc?= =?us-ascii?Q?mZoK8MbQhUZbGxyrlpE8m+ELfbSfDT6ly9AigNKOp+Z8tJb70SbKkxKWFyQS?= =?us-ascii?Q?ehAqUUjE0IK2k8AEAZC1QY0mvAB30cWD0gh5zLQLcJrYh6FFQIn42PUraxoO?= =?us-ascii?Q?ljZnyTl8uXpci+fa/kYjfIxvxH+hr6+psgSH7mO/KMJmAWGJZbPSRArXnyN9?= =?us-ascii?Q?VnNdg8F9OIkD0JmSpOiarFEDI3odB+8wihjGB8JhnYEuR0EXTIpqDUxa1sfR?= =?us-ascii?Q?0gjgyDKDPLqayP3GteIKOdiHpKDO2JJyhiVpUzE734yHlatXHA6Vo8uzNTtL?= =?us-ascii?Q?c0Obph/zkwGqbAqha+Gyiv+qWsPCjGxBqT+NFqJTjhN8FJ7iGDkM/B5c2fZt?= =?us-ascii?Q?2d/viGQj9tJvBPJhzMuXn4iuo0NXxTc0n0NlQX5JdKHY0doAlfRZyVO5JTiz?= =?us-ascii?Q?qdKEq2JxDOlQbqgjRCgTZg7uiP76E7+hlj8JfPXsBurobdcjsC5lE2hlvZde?= =?us-ascii?Q?tkhx/RuVumxqr+QFQg7kQbf0kcj1DwIEc1Cf4SitbwQE0xm6wl/Ihs+6KB/k?= =?us-ascii?Q?u8fk/zHHDiYXCOJP/j+ofbixK0H3ZoQ8DVjvsr1lvGdUSQ1I6g17YykZwzqF?= =?us-ascii?Q?MrYyOJibxpNmGII95nvUTTTBnNoefOliFwk1ZAKDYVvCvw=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vPttm8Gww3/pHGMrrLmlgYOW5M+14m4VETxVze2hnBnUzDTdaQYcJfLpXlnD?= =?us-ascii?Q?35HBPQLnuWLMH4EWQqjPoxcnxLMaZW9oRb1mTfAbTEkx+zXxp6bGt5tJg1OA?= =?us-ascii?Q?Ea9BxyJUDfh3yxqfddI74VwgG5Tb0LMeOl3NEHRDjJa3/5c8y5go/jZ4i9KO?= =?us-ascii?Q?v4zON6JRiHfQeIkM5w+qnRAfucKy64XkEsjZgVCDqiltMx86Ij+Lrr+GN0pk?= =?us-ascii?Q?oWtJmcD09TB5xY6xdCJGYFhobLFqmoscQA1/G3jhwqob60SE/1EuiqUY/c4y?= =?us-ascii?Q?/AprKxFZU+QkP5NnjY93XlPSjpKjA+5Eurrj6OFuVmoeDLr7j/nibC0uQXFL?= =?us-ascii?Q?LlTvmy31H5FIV3kpk/9sao7Hn18t52d9nLF70aT5AWMFPSgo0NRBM1ZqrjDV?= =?us-ascii?Q?ahUOZO1qtPOKQ6wHvRbJ3dRExcRjwjTOld4dJoA7CJsflZ/SqWefnWCXowUu?= =?us-ascii?Q?xofsLDqcet8J1ZyJHk+Vp/9o7cBvQzHcbG29V3nI30D9iUGrf7Dnk1B6k+Al?= =?us-ascii?Q?2X/r+/UmLGqJIjXX1QkZhDXrbuF41SnG4JhV7vyJvhynoylZmgGhNJfx+dMe?= =?us-ascii?Q?Iwlh8oP9ivxh12NZXokGSKDBn8H6KDZCQOp8UA6o2wckqxlF+rc2pE3xot/K?= =?us-ascii?Q?Fhk3DAS1x6dtd2zXkvj6q7WUiY+AFs+CdRVfoTPnFDvmUFc0mEWUsd5VPoN0?= =?us-ascii?Q?ohaSGKdszziq3Dsolh6s4/IFemtl7m8xZ5voDrbJ6eSOg0G/gDPN88ipgWP/?= =?us-ascii?Q?mRElMj5Fxy0b5r9GHesStMICgC+hFIw0yxIwY9bHDjZzt3FWtsk8HIUV5bl6?= =?us-ascii?Q?nlLBC7vgAjx6U0IsrUKMqEzuVL82a7XltvLSMIVOTrlbYLo7nkAhsPOiX7GP?= =?us-ascii?Q?Z3189oHh/mDWt2OiqUR+M7E9OUliDroZjNg2XVmXfHtdBdI2y9M0pfALzP2b?= =?us-ascii?Q?R0yd9LPaJCPpYLjYFuE8900RxfkGv91vbWGKc1GmUaliFc+X6c8x2XhB7K5F?= =?us-ascii?Q?H/NBS4QrCc1ZpVelgMIawA3bYU3MOl5qQ1a9eqEukkaVY7+r18FcuqA2woMQ?= =?us-ascii?Q?Gpfse1L65saFQcqVctSugZdP3nZCqTXibgLWqv3h2ng+WUrmcq/KPJ2n6Hu1?= =?us-ascii?Q?ecc/HNXMRPKwrVNSLHSUvk9CoRSW629OSuXmY+SKFLa7sJL2fePbDbZ0+/Rk?= =?us-ascii?Q?wpCOrOTNGwf+b0mqPq2q3UftLPmq93yhw48g84TnRT1vPkybXIOPXA/H7RHm?= =?us-ascii?Q?yB8Id3Gji+FReCH1DM2KNp/AC/xZMv1pD3X+cfihpPcTagkNME3N+QOv7LsO?= =?us-ascii?Q?lDO5e36ih6FnHBqV9Sg02QwvUCvDfmPnnAuyTYGVnrNzEGBp/AQYfIkomU6l?= =?us-ascii?Q?6J+m+86eY/rqKmQIXPd+Cov3P3kXCOUfS5nQjkjBEn158snUHfskFrEZonrg?= =?us-ascii?Q?bwqu3QcgfZLg8UULgcH1U69G+l1AXVQ5IU2B4gAswVLknP2/M/BHDMbwFAch?= =?us-ascii?Q?NUq3E/ClovIywnAVa4HSKr6BL0Kyi8zWNOqcmHLd8AJUjQ6KfEsvOiJrz2Cp?= =?us-ascii?Q?YtbN+ztWNvejONnvW2o=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: ae65f2c9-ace4-4d5d-7ba3-08dc64ebbde2 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2024 05:51:24.5324 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: oB6aR5/9p5tDYabL6Zdrqj0UbAFyq4Iuw1Pbl6UoIKxOCK5wjk8FwL86GBLST8vJAUINXA7SkbGROgL06g4UKw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR11MB8365 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 24 Apr 2024 22:51:27 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: opdjjbs6dSa6sY5MWgeDta0Sx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244CAA42FDB6845409C40F08C172MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=QnlDAxEw; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244CAA42FDB6845409C40F08C172MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Liu, Zhiguang Sent: Thursday, April 25, 2024 12:40 To: devel@edk2.groups.io Cc: Liu, Zhiguang ; Liming Gao ; Wu, Jiaxin ; Ni, Ray ; Laszl= o Ersek ; Ard Biesheuvel ; Sa= mi Mujawar Subject: [PATCH 2/2] StandaloneMmPkg: Initialize 'WillReturn' variable The local variable 'WillReturn' was being used without prior initialization in some code paths. This patch ensures that 'WillReturn' is properly initialized to prevent undefined behavior. Cc: Liming Gao Cc: Jiaxin Wu Cc: Ray Ni Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami Mujawar Signed-off-by: Zhiguang Liu --- StandaloneMmPkg/Core/Mmi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c index e035245c87..fb205df490 100644 --- a/StandaloneMmPkg/Core/Mmi.c +++ b/StandaloneMmPkg/Core/Mmi.c @@ -174,6 +174,7 @@ MmiManage ( EFI_STATUS Status; mMmiManageCallingDepth++; + WillReturn =3D FALSE; Status =3D EFI_NOT_FOUND; ReturnStatus =3D Status; if (HandlerType =3D=3D NULL) { -- 2.31.1.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118268): https://edk2.groups.io/g/devel/message/118268 Mute This Topic: https://groups.io/mt/105725160/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244CAA42FDB6845409C40F08C172MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Liu, Zhiguang <zhi= guang.liu@intel.com>
Sent: Thursday, April 25, 2024 12:40
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Liu, Zhiguang <zhiguang.liu@intel.com>; Liming Gao <gao= liming@byosoft.com.cn>; Wu, Jiaxin <jiaxin.wu@intel.com>; Ni, Ray = <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard Biesh= euvel <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.= com>
Subject: [PATCH 2/2] StandaloneMmPkg: Initialize 'WillReturn' variab= le
 
The local variable 'WillReturn' was being used wit= hout prior
initialization in some code paths.
This patch ensures that 'WillReturn' is properly initialized
to prevent undefined behavior.

Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Jiaxin Wu <jiaxin.wu@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Laszlo Ersek <lersek@redhat.com>
Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
Cc: Sami Mujawar <sami.mujawar@arm.com>
Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
---
 StandaloneMmPkg/Core/Mmi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/StandaloneMmPkg/Core/Mmi.c b/StandaloneMmPkg/Core/Mmi.c
index e035245c87..fb205df490 100644
--- a/StandaloneMmPkg/Core/Mmi.c
+++ b/StandaloneMmPkg/Core/Mmi.c
@@ -174,6 +174,7 @@ MmiManage (
   EFI_STATUS   Status;
 
   mMmiManageCallingDepth++;
+  WillReturn   =3D FALSE;
   Status       =3D EFI_NOT_FOUND;<= br>    ReturnStatus =3D Status;
   if (HandlerType =3D=3D NULL) {
--
2.31.1.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118268) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244CAA42FDB6845409C40F08C172MN6PR11MB8244namp_--