From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mx.groups.io with SMTP id smtpd.web10.73797.1682406224346975089 for ; Tue, 25 Apr 2023 00:03:44 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=kH4kiijZ; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1682406224; x=1713942224; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=ZuWkTdKfyzqdweS+0byZnQiFOdWd396hR8cBEBfdhUk=; b=kH4kiijZt+CrTjm03RhU+/7cVw1tWYzT0Bk/ru0p8BpoqksNaf8OGvQT wVhu9DVdi9lzAaSFWbiotmw/6D9knf5QfjjpzKf1XTP6mADV7J4w9ouac SzTppzn+HWFzqAo74YsbfiPLbIT5vL5fMHdndhxtiXhv8rV9JvqDz7XWT tuSSuKasillCUsIuz2X+YOuW5n/OczyMTf7P5VS3ugdJqocVEPserP/5m 0UqmiPPbYovZUWAmB+WRtTObW4c5BY+YE1PYSth2p74qO64D84nQhPuUi aytJnN6EoplzHu4NNVZmmnQ+IcD8AugWCphfVbNcQBm/x/5ta3acnlKWt Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="330893721" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="330893721" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2023 00:03:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10690"; a="939652038" X-IronPort-AV: E=Sophos;i="5.99,224,1677571200"; d="scan'208";a="939652038" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga006.fm.intel.com with ESMTP; 25 Apr 2023 00:03:41 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 00:03:38 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 25 Apr 2023 00:03:10 -0700 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 25 Apr 2023 00:03:10 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.177) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 25 Apr 2023 00:02:53 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=a856shNKyb9DEGfgleIoRAbmawJe6vZnwZS5r1D3ExPjpOzYRomqRygcpN7PweX7oP6GeY2v2N/IIx5hef/6Ngx7fZv+xCq5ur03FA3Y3VbRwwjrxSFKLfYoZZYAGr1OHO6UscvG4bL0hFu8SVDqCSwss2HhTBqKAkzcvxQxxN27BJdPJ/orDSIrMOD4kN9sAT9ylUhPA2+9UecEjDBnPmLQi11YnXrFONfCxESOVzonAzLMuNAUhIqLfCuaFJSlJPPuMFS86iDJLo6GjuYtYpwt1pXgi55PKYibbIBe744oxPag30bX1IybwHRv/b1u4rqRwWuSieeMFzocgwQxjQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RKxyjEu6xtxFziemlXfFwOusmlhBckaK15m7KUdeMxM=; b=dMr5VaG00gXqlYfltsWWXoXWznkVC2Epbn9mnOS+vAJtDnyTx1ZOy7Qk6s3lIrXE3fraH61S3+Ao/uveu3/LAxy8fk4fc4BioLDmmqOx6RSDFab0f83HQUD9F570nb6LetG/NNKruxIUVjSNNtP6b5Be7y0J9FthhogKLn9no6uyELy7KW/CjYeeWs9BvW6zfWdR49km1sRJlw46+p5OGdlF3M3v5NwrLyYAhpLmBoqGGkpdS0Rz+UqRB19ND89nM6Mp2C/mAoNJ2TZ4YZmw7aVJwq1ftBgPAX6z/gQIZFOQDd5A9EzmnhIbVhjs7u5Mg93dfZp/WNkQd4CEdkAFyA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH0PR11MB4952.namprd11.prod.outlook.com (2603:10b6:510:40::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Tue, 25 Apr 2023 07:02:51 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6319.033; Tue, 25 Apr 2023 07:02:51 +0000 From: "Ni, Ray" To: "Liu, Zhiguang" , "devel@edk2.groups.io" CC: "Desimone, Nathaniel L" Subject: Re: [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD PcdSimicsSecPageTablesBase Thread-Topic: [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD PcdSimicsSecPageTablesBase Thread-Index: AQHZd0DXvYjq4acxdkCWFRifGLqVZ687mWWg Date: Tue, 25 Apr 2023 07:02:51 +0000 Message-ID: References: <20230425064003.2037-1-zhiguang.liu@intel.com> <20230425064003.2037-4-zhiguang.liu@intel.com> In-Reply-To: <20230425064003.2037-4-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH0PR11MB4952:EE_ x-ms-office365-filtering-correlation-id: 5de3f860-408e-40fb-052b-08db455b15b9 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: SuSXT41luJkO+pVfAOBdfZ+dhdpQ2L175nt/Cq4ooX7u2iFU/zleyDSklAp4/fQ36ZakxL3nHQzeaq8RJPIEHhX9H3DiuP5a3AQiMU1lb7R+G8xQxMfgDtMfyxxIG5wLoNuT+HxtytpDK/8G8tuPzDtc/bTPK8ut84fqcdKrTGcNOcwrE3CyWstaPF9UuhDuBIr5+LviKq01ve8w/pYQrPMUr/jizSCS6TjpChCqjYjPyaA4z8n5i5upjGDVIZkdjxvg6DqTb0NJuphiXH7zO7uV56PAGWH8zpvFF+SvLnBNqPw8oQY/80oqYHnZz4UWT3U0YL8A7FEJLVy4MOf3dfLm7HzlhQm6scX97odxo2jxlUk35w/6H4yNQH90BmmRqRz/aA+Wp2p5U+0Uhp4K1KnT6BdXVglzl0LL2Bfjj6IdVOhqEuxy/8fAXw6AjfVpdZECzHsUSXLlFyf6G7v2+rwDKpKPkxTonOaCn88R1Z4WaOrL9CfA2W9fa8ZNoYUxGNEQfFSZmTqwr0cACL9dT/INb6OxiDND93A4z7FOKOAYAZ4Eob5VbPmMvcVmosOuerlk3dmbSe/GhFDLGL75cyWwwuQMIWQxLqB0B+5ZeDvznMV9GW3Y/0y2FhqEaUfj5WMfWKKndLh6vRqyJ++tNQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(39860400002)(396003)(346002)(376002)(136003)(451199021)(107886003)(9686003)(53546011)(6506007)(26005)(38070700005)(55016003)(83380400001)(186003)(82960400001)(122000001)(38100700002)(66946007)(478600001)(76116006)(86362001)(66556008)(66476007)(66446008)(8676002)(8936002)(64756008)(110136005)(52536014)(5660300002)(71200400001)(7696005)(41300700001)(2906002)(4326008)(33656002)(316002)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?CpEgZFPfqGNXY7/BLZCjvihb13ZxFqNhKP6XyGAxNTBCLysMJsIOsgrUiVsm?= =?us-ascii?Q?+k0cGgOZx6i4JgqclkYRHrn32kS93HQwRj9lMZaS5EluBcuPSH7BID8oKLbh?= =?us-ascii?Q?fsytj2yMnd8LNfDOsjrrFiHn/9wAtHaduTuqi6HZFzCyYLz7rlm8d0e1gntB?= =?us-ascii?Q?rvbEjcIst/CTFyEWtDbwtaCoIRpLqJvJ3kJDD52KlYlBtd2bwZ/SneGg8f7A?= =?us-ascii?Q?zyC/i832Uy+CUAr27/YL12eo5YfW+9pdF54aLe5/eUhpS5G8hg+Woj5uuxNa?= =?us-ascii?Q?xwq5JQRtQ1yo74nWKwrxeABeKP8HaMlTdP8mgOh8S0W3A9ijDPqZfXHF+jFh?= =?us-ascii?Q?FK4r7mgIsxjaa0lDSpL9/asg0nUqAz7bAElPxHi34g21nJ83exEpeBu24K4C?= =?us-ascii?Q?ESxtaCBWybPBrR/wRmUPGqtdGHbJoxxQLbqLoklodMKfwD1SViPIlxOzfxhe?= =?us-ascii?Q?qRqatjeIXZWyj3WzMKiiWlDHgPC+SHpWsVtBaXrENbNacskS2yYmnuKe5DEw?= =?us-ascii?Q?IRejfddE0b1JKM7wjIP6ShFfTzNKABsrMYtXr+uZRVMOZ2F4I4SkbPLfmXQI?= =?us-ascii?Q?y8qSeVgXEsuAmyNRPLQ5KY62eiJYAzZIm0BJYwZcfK3c2yB2KoitTY8icb6k?= =?us-ascii?Q?UQorV7Z1/XgG2x9rIvoB9dltwiTsSVd8DeUYdY5rsaLIlqKQNZpL6euS8o3c?= =?us-ascii?Q?kJJFdo15MzObt3ZSGE9lQ3W+Y0rgxcm3SAoZNjg5E2TSHEs4qK8jxDavUhRw?= =?us-ascii?Q?d7/EXfYBcytlgi9co05Hq/qr8iwaFNK0tKGnGWf4ZR4f2aBshJiqRz7L2JQM?= =?us-ascii?Q?cmPLHZ4+gqJHUtNF/nubyR6aqbiK7fYVLDXJ7zE2tfHk9N7c/kWpf957hwLf?= =?us-ascii?Q?Tjlk2/brbYYXBZuaMtaF5I7B+OFQOAeWR7SuPAWiCd/APON3JwO4voZL6+MW?= =?us-ascii?Q?u/+tGWUMSDCyeG3HBrzU+IHAU3QeeuP0ftIrnklINBtbQpa02CSunzZQihB5?= =?us-ascii?Q?EfkaefyNUp1Q92MUXKJ4/+G16CDxAmeXdbsPGeg0wPkXSpOhw4Z0zF1VMd9n?= =?us-ascii?Q?moZtcc+cxpUEEssQ/H8Y0S4DE2jmd7LnU0FmCpRrvkl8B35d9jnoO5LcCOom?= =?us-ascii?Q?Oc27cg9c0JAULzIg4gyTn08abxbFb7KOdEq7em/95/xw6qu0wbhwnJtCxygt?= =?us-ascii?Q?29W9o6zlLBg77dEkwV88zat6Fn1Fvsvg1P7T7uoaWC3esuoWjvbY8RyLQX6b?= =?us-ascii?Q?9oQEE5Ro11hyud49ny2Waq3Ts/cziei3qORcpLSBqaIuRNQGDDiqe48xYzlV?= =?us-ascii?Q?NiyO2yUBz7qAlyw+D5STOStSYSkOxSHG8gCpLmfthZhifAwHxHHzOjaza7wu?= =?us-ascii?Q?kzXlJ+Y3tDdGAHmjx3fVDabDKwCaI3TBCrF4jyTFlhXjGxaJXKt+dWT2X991?= =?us-ascii?Q?0I2dolWVOr4GVf/bZnKGwzpdd15tcbg0j30OoF+hE7gZ8ivIYkAqDg/fplcy?= =?us-ascii?Q?7Ew6uVc9ktyE8DBDHOnInIWuqJpolXrjSucFVpEcsZA7yOA8dQ1ANBG1nWz1?= =?us-ascii?Q?3rKhGZ/+MiORAnZ+BVs=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5de3f860-408e-40fb-052b-08db455b15b9 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Apr 2023 07:02:51.1524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5TsRNFZMTDhUJhdDqNvMGTSVKsmOZMtDsQqGey4OsEGrW/X3zirc1zbcucszE7MjFZHsN/A8CaBj73LeeYkYrg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4952 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: Liu, Zhiguang > Sent: Tuesday, April 25, 2023 2:40 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang ; Desimone, Nathaniel L > ; Ni, Ray > Subject: [PATCH 3/3] SimicsOpenBoardPkg: Remove unused PCD > PcdSimicsSecPageTablesBase >=20 > Currently, for 64-bit PEI, pagetable is created in reset vector and > stored in SPI flash. No need this PCD now >=20 > Cc: Nate DeSimone > Cc: Ray Ni > Signed-off-by: Zhiguang Liu > --- > .../SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf | 3 --- > Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec | 1 - > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c | 8 -------- > Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf | 1 - > Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf | 1 - > 5 files changed, 14 deletions(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > index ccb7fe7e59..a74c355e09 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkg.fdf > @@ -79,9 +79,6 @@ ErasePolarity =3D 1 > BlockSize =3D 0x10000 > NumBlocks =3D 0xB0 >=20 > -0x000000|0x006000 > - > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|gSimic > sOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize > - > 0x006000|0x001000 >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase|gSimi > csOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize >=20 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec > b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec > index 421c464023..e8aefdd893 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec > +++ b/Platform/Intel/SimicsOpenBoardPkg/OpenBoardPkg.dec > @@ -38,7 +38,6 @@ >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwSpareBa > se|0x0|UINT32|0xd >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFlashNvStorageFtwWorkin > gBase|0x0|UINT32|0xe >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsFdBaseAddress|0x0|UINT3 > 2|0xf > - > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase|0x0|UI > NT32|0x11 >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesSize|0x0|UI > NT32|0x12 >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase|0x0| > UINT32|0x13 >=20 > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize|0x0| > UINT32|0x14 > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > index 6b572b38a8..39e879e922 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.c > @@ -759,14 +759,6 @@ SecCoreStartupWithStack ( >=20 > AsmWriteIdtr (&IdtDescriptor); >=20 > -#if defined (MDE_CPU_X64) > - // > - // ASSERT that the Page Tables were set by the reset vector code to > - // the address we expect. > - // > - ASSERT (AsmReadCr3 () =3D=3D (UINTN) PcdGet32 > (PcdSimicsSecPageTablesBase)); > -#endif > - > // > // |-------------| <-- TopOfCurrentStack > // | Stack | 32k > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > index 1de3d012a7..af1c0f2b55 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SecCore/SecMain.inf > @@ -62,7 +62,6 @@ > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsPeiMemFvSize > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize > - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress > diff --git a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > index cdc30ad582..49f441fe9d 100644 > --- a/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > +++ b/Platform/Intel/SimicsOpenBoardPkg/SimicsPei/SimicsPei.inf > @@ -65,7 +65,6 @@ > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsDxeMemFvSize > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsLockBoxStorageSize > - gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPageTablesBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamBase > gSimicsOpenBoardPkgTokenSpaceGuid.PcdSimicsSecPeiTempRamSize > gEfiMdePkgTokenSpaceGuid.PcdGuidedExtractHandlerTableAddress > -- > 2.31.1.windows.1