From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by mx.groups.io with SMTP id smtpd.web11.12628.1681217376921633005 for ; Tue, 11 Apr 2023 05:49:37 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=IVxSrXrx; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1681217376; x=1712753376; h=from:to:cc:subject:date:message-id:references: in-reply-to:mime-version; bh=RQb8tRRP2um9WqHAmhSidYKk3pVy9uhAQeOoNEj+mzM=; b=IVxSrXrxqxcBiZjU/pojE3zP3HbvOmVDM44i6HC5mGByPR55tt1IGNgD 2R80pBDAn6lu28LjfgqyNJq6x3bQIKUJpAv7qXfTl+Ti2inmqBSqZ4QPX kfDL+0gC98yI59tQAgMkV98179dvfqo9ywYa6QTOa1F5UbXJI2291hpi7 FMetQmdBDQzeTfUEdUOB+clnqDGGEYJ72wDNA6Ue5h2m5siAOWFAAfKd1 fQgQsn9CmoMUDAguE7JXXzNVK9aAGuVy9HFdmMrNXFzvkzZhiUqDwuxHP riufRV8kKuxZ1pEyL87Z2S/fmBXTXLGr6Y1e4yPh9jR+jSrg9a5EEsUxl A==; X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="406432099" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208,217";a="406432099" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2023 05:49:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10677"; a="812555366" X-IronPort-AV: E=Sophos;i="5.98,336,1673942400"; d="scan'208,217";a="812555366" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orsmga004.jf.intel.com with ESMTP; 11 Apr 2023 05:49:35 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 05:49:35 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 11 Apr 2023 05:49:35 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 11 Apr 2023 05:49:35 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 11 Apr 2023 05:49:34 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NvXtDQ/KIigvwFz5NB5EhByuulYvywA/MP6nDtQG7gU9SpxZ9TGjGN52ncEiHjwvqlh9GuuNmXrNlVpa+4W3/rpp2Q/aotaiFs+NqEeDsSJe+8R9ZcEcqUw4EABRxN2MkgcXx41/bg8Nj+O/JgbWbElZYrugSwtTVlOsJUJdrB5CBNUHXVk1ErV/K/eK4LPrbMyYRDEL3OnNLn14fCR51pDTXMLhrb0lGrMMztnzns0yyxotml/Z8KzFAZ4iox9MzT+AMYUdfLOvc8IKW19UtG+7DTx83QCbDJXnAnFKJ3dg0H/mW5d/WFDkzmnCd3zbmVh/QK5Z5ZTO5ch4ZkK8Aw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7WyCrWNfAz8lw8Y51TnnYCj1753cBWrCCY/DNDGa2yI=; b=GsZujYLS1Hu5V/9/IysI3qY9iSMBb/BAwF5hJl9cLxrqzZZp/W7m2RheLFC/7XfOsFr4lBj3wYp/pC6o40s7i+2toutVkIYGM3FbW8zihlOLZaszmDmM5z13sbyNLLq1da3EvTR9ZGcleN+cVrC2+DMCo042D56ne+VFIP/cmmQnae2Mh0xrdpvC4Q0xKSmdAuFBEg5JZVG5a6gGOJ/3mK13qCNvMMxjqSP5mpE21ozi0phGeflVqzu8/KIPr4o6i4xTMiZuzjiHAb7lHCYPL8buTFnlYN3+1Kcv7Frrzy2LQGNBAe+kC04DIfq4ZdQaWVcPrKqS1qJnf9Xfn1Fu4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM4PR11MB6066.namprd11.prod.outlook.com (2603:10b6:8:62::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.36; Tue, 11 Apr 2023 12:49:27 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6277.034; Tue, 11 Apr 2023 12:49:26 +0000 From: "Ni, Ray" To: "Attar, AbdulLateef (Abdul Lateef)" , "devel@edk2.groups.io" , "kraxel@redhat.com" CC: "Grimes, Paul" , "Kirkendall, Garrett" , "Chang, Abner" , "Dong, Eric" , "Kumar, Rahul R" , "Ard Biesheuvel" , "Yao, Jiewen" , "Justen, Jordan L" Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Topic: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib library Thread-Index: AQHZa50porwV4JMsOkGOm2Ls0nivva8l3L6AgAAHV9CAABL5gIAAGcH3 Date: Tue, 11 Apr 2023 12:49:25 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=True;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-04-11T11:15:40.0000000Z;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=0;MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM4PR11MB6066:EE_ x-ms-office365-filtering-correlation-id: bfa64c0f-6384-4404-2d5d-08db3a8b2ea1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QJW6EFlSkuijDDjYXwjSAI69p4JA9n7KVi47JAqswajSU+rY692RDm8cf4E27+sV0ZMR5AreZpPLLlJ+gF0W62ZNieFDcEQ/sK7w22OOKc7HMMFgtyO6X8MbCl0j5R4fuDRSBjYCbrlGcbePu7eDYjoXWmnhCpSinnqZ8k7WAkxwzGaYup8OSlREX855nu0jcavpcFmNX/6g/6uHmdaRBKaeKVFbLbwCdgamodNFhpdJv7Q+a5jPIcXl8xE7kgXa3UuYZuasysfTpgEGSM1RtE7zpxRbN7N14B+TWftmlwC35aMcFrlwwVuZNCfU7OVDzERzetc6Epslj9oR53x4HMCTbwvgcmQMdOBGX1kYvh6eH+Ob8SIO0LEAeJ9sKm3ZQ/AbGz3zNVYVbGkmLs/XQH+f+TIm8LzVnjsha1Hv5KzsEJkSajvuP1AdlvCHTT0S7umMFjC3u8zSt2CAKJYHi6MB+t6lgAS38D9+RdgIrnF0GLM0DYde9DvTRUtc05933xP2QwTIQp7iA7F6Dg4MhJ51rjyApP8lNX0LNd2lKlb8rhA+kgsedLX58xIgVHdkiU6syLSWFu/RPkKzA4HCOSPgDPnyCvlV4bfHVHInqV7TR1W7zmNdUVBEzOHMuFwfLmOUjxKfQ8s4bDxuQ3FC7zk2yNtdKZ/YhhiqqlLfP1k= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(136003)(366004)(376002)(396003)(39860400002)(346002)(451199021)(66899021)(478600001)(7696005)(71200400001)(86362001)(55016003)(33656002)(83380400001)(38070700005)(38100700002)(122000001)(82960400001)(166002)(107886003)(2906002)(966005)(19627235002)(6506007)(316002)(110136005)(53546011)(54906003)(91956017)(9686003)(26005)(186003)(64756008)(41300700001)(8676002)(4326008)(66446008)(52536014)(8936002)(5660300002)(66476007)(76116006)(66556008)(66946007)(213903007);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?VEWQkeRl2aE/At2F5AhoLsVcF3wfXgUwAXnCOYQ3/3RTHWNPllL18oRsTcCH?= =?us-ascii?Q?KdBMCP3VUPrYQdgKhak7vc/S86hJ+X4meApwTW3fbgBkE+v9yn9XG7ywMoYT?= =?us-ascii?Q?frZVOdofs3teHlydi+M6/keh3xzl4Cla9diJbvPQCecRDwaKJAnAlN9V74Zz?= =?us-ascii?Q?WHRjW2a8/mqZ8jvaOHIgQukMnT6KnIS7p/9dZBBhXLyusSZ9czRJr1WH6uMk?= =?us-ascii?Q?WBFN/eooNXCEmDZ7+Kx2JCJha2R8CZ/MaXM3EIDIWnOq1R50wLsiGBjOek+s?= =?us-ascii?Q?E+BpduugyPlwYjTKLFWqv+ic07WvBj6czrcG9lPt4eY80XRWSFelEZamjSoJ?= =?us-ascii?Q?91oViQbBLkSYQ9YLWs8OhWYz8Fl6Ix2nNHpp32D2JirkpdkF1y7o7wCqlJtR?= =?us-ascii?Q?PIaOuLPmNCdUKYGeNJ7kQF+m4P2bewV3Im1UfgY2q2IqUfbq0b2iNl++KqnP?= =?us-ascii?Q?6caIqbHAysxEIiu69iv+LC0rJOUUZeGC1HNCdtPnkcQCZ5HPSXQMRtRJKkNX?= =?us-ascii?Q?vs5apOjB0jztfzyJfMItBhOdtjlXPNh5ygQlcyaphdPqPD3CobnfMuBaM5Nc?= =?us-ascii?Q?OiAgKbZiALHHyrU8ZUc5Y/DTSRBRUk/zQ05zrY00+LLgUNm7KoVgz4j6lkxk?= =?us-ascii?Q?/fj2YL4/it1XLJL5+TbeS6KDkEbrhGOmFo1QzFJp96ItHzDQbNVmHADKEXys?= =?us-ascii?Q?tnLB8wCWA9p/soYIrdIGszIxgg0nM0fighx7FNiZ0lNff2+Dxykkn1/JpA/V?= =?us-ascii?Q?2mVfeI1XmU409xr/ANsK5FUuinPPliImXrWMZ8Vnn5APF9mV/a4LmwldhTLX?= =?us-ascii?Q?/uF8JlMhAraUejsbb3a3KxTErplwxMBulGPE4SsSLAgHt/w5GaXnObndwIGx?= =?us-ascii?Q?wDO/lpfyMiz06+jS4F3H2bTcg3FxKw97rh1hjZLGHQgq7P5I9qAYhz//bGAR?= =?us-ascii?Q?CzDEMnzXLFVR6Ip6hU49uo7jJwea1h0qtmwoYethtxtO132bohodtiPyu/3z?= =?us-ascii?Q?F660gx+2fEa1es4sBnSDurciBkF30JGW/gww3TF16zAkpb+taQ+dd0JixgRm?= =?us-ascii?Q?IRX+q0+hRuAPzZWt/duUc6clUnWwYTS7zRUMJJTbpNG6gRF0cUTQA6OSGapy?= =?us-ascii?Q?fcEJbpLo4lmlQaXiovANeRndd9AoBP8yzn/8h+crGRZqQGcM6xwvwxitRGqR?= =?us-ascii?Q?XAGi9Nh3r8eJ3hnRuq/xgUHlIrkQ6m0iu6PKDpAaZK0o0S3G5EouxXC/DvGP?= =?us-ascii?Q?6sHJBVRNnXCH4JoyIU/3Alt+adCrQnBqkimD3HPzk8P5xtS0j8NuD2RvFoII?= =?us-ascii?Q?SMuvHgdmk3HyRW7bjgZI2gM+JkOh/Pk1YadKpvBPlFfeJwzc1jsOSn/HVsfP?= =?us-ascii?Q?J3yh/OKC0I3Xc5+4NvlWiB4wsUWm0eAlaebYEeQsEkVM6zE6EJsqyexpwXFo?= =?us-ascii?Q?DWzTe/9FHiNxMit0CzXGLtnECHQTsfCZ/eSOZkhyK2Clq05qa25HvuZZ1KVI?= =?us-ascii?Q?jyQpbCOg9l3nLm8w/jMIev258ootZOUUtsZ4J97P7Nx4BJFAelDzDsTGjywh?= =?us-ascii?Q?vDcwnjq1OXsiZ17ZGUxRdku6x3SdTCmRV+zGx4yLh76XaQSeTExiS1UcbALl?= =?us-ascii?Q?Vg=3D=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bfa64c0f-6384-4404-2d5d-08db3a8b2ea1 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2023 12:49:25.9637 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MMDSsnAOx8GoNffVJG9YraWv5BxlrRK9OQ9ubrQ+nv7uMHQ5lknzY+MkyKOJH9lnrQMdSE2pHDlTS6dVAJ+f3g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB6066 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244D0024F3DCBAADC6E3ED38C9A9MN6PR11MB8244namp_" --_000_MN6PR11MB8244D0024F3DCBAADC6E3ED38C9A9MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable yes thanks, ray ________________________________ From: Attar, AbdulLateef (Abdul Lateef) Sent: Tuesday, April 11, 2023 7:17:03 PM To: Ni, Ray ; devel@edk2.groups.io = ; kraxel@redhat.com Cc: Grimes, Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Kumar, Rahul R ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L <= jordan.l.justen@intel.com> Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library [AMD Official Use Only - General] Hi Ray, You mean directly call the SmramSaveStateReadRegister instead of be= low code from edk2/UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c ? Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, Width= , Buffer); if (Status =3D=3D EFI_UNSUPPORTED) { Status =3D SmramSaveStateReadRegister (CpuIndex, Register, Width, Buffe= r); } Thanks AbduL -----Original Message----- From: Ni, Ray Sent: 11 April 2023 15:40 To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Late= ef) Cc: Attar, AbdulLateef (Abdul Lateef) ; Grimes, = Paul ; Kirkendall, Garrett ; Chang, Abner ; Dong, Eric ; Ku= mar, Rahul R ; Ard Biesheuvel ; Yao, Jiewen ; Justen, Jordan L Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding. Gerd, I am asking Abdul to directly call SaveStateLib from CpuSmm driver. I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Tuesday, April 11, 2023 5:43 PM > To: Abdul Lateef Attar > Cc: devel@edk2.groups.io; Abdul Lateef Attar > ; Paul Grimes ; > Garrett Kirkendall ; Abner Chang > ; Dong, Eric ; Ni, Ray > ; Kumar, Rahul R ; Ard > Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L > Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses > SmmSmramSaveStateLib library > > > Uses new SmmSmramSaveStateLib library, which fix the CI failure. > > What is the exact failure you are seeing? > > > + > SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel > SmmSmramSaveStateLib.inf > > This should be the AMD version. KVM uses the AMD smram state. > > Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use > actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove > OvmfPkg/Include/Register/QemuSmramSaveStateMap.h > > take care, > Gerd > > > >=20 > --_000_MN6PR11MB8244D0024F3DCBAADC6E3ED38C9A9MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
yes 

thanks,
ray
From: Attar, AbdulLateef (A= bdul Lateef) <AbdulLateef.Attar@amd.com>
Sent: Tuesday, April 11, 2023 7:17:03 PM
To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io <devel= @edk2.groups.io>; kraxel@redhat.com <kraxel@redhat.com>
Cc: Grimes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett &l= t;Garrett.Kirkendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>;= Dong, Eric <eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@i= ntel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@= intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveS= tateLib library
 
[AMD Official Use Only - General]

Hi Ray,
        You mean directly call the Smram= SaveStateReadRegister instead of below code from edk2/UefiCpuPkg/PiSmmCpuDx= eSmm/PiSmmCpuDxeSmm.c ?

  Status =3D SmmCpuFeaturesReadSaveStateRegister (CpuIndex, Register, = Width, Buffer);
  if (Status =3D=3D EFI_UNSUPPORTED) {
    Status =3D SmramSaveStateReadRegister (CpuIndex, Registe= r, Width, Buffer);
  }

Thanks
AbduL

-----Original Message-----
From: Ni, Ray <ray.ni@intel.com>
Sent: 11 April 2023 15:40
To: devel@edk2.groups.io; kraxel@redhat.com; Attar, AbdulLateef (Abdul Late= ef) <AbdulLateef.Attar@amd.com>
Cc: Attar, AbdulLateef (Abdul Lateef) <AbdulLateef.Attar@amd.com>; Gr= imes, Paul <Paul.Grimes@amd.com>; Kirkendall, Garrett <Garrett.Kir= kendall@amd.com>; Chang, Abner <Abner.Chang@amd.com>; Dong, Eric &= lt;eric.dong@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Ard Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen <jiewen.y= ao@intel.com>; Justen, Jordan L <jordan.l.justen@intel.com>
Subject: RE: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses SmmSmramSaveStateLib= library

Caution: This message originated from an External Source. Use proper cautio= n when opening attachments, clicking links, or responding.


Gerd,
I am asking Abdul to directly call SaveStateLib from CpuSmm driver.
I don't think SmmCpuFeaturesLib should be in the middle of CpuSmm driver an= d SaveStateLib regarding the save state access.

Thanks,
Ray

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of G= erd
> Hoffmann
> Sent: Tuesday, April 11, 2023 5:43 PM
> To: Abdul Lateef Attar <abdattar@amd.com>
> Cc: devel@edk2.groups.io; Abdul Lateef Attar
> <AbdulLateef.Attar@amd.com>; Paul Grimes <paul.grimes@amd.com= >;
> Garrett Kirkendall <garrett.kirkendall@amd.com>; Abner Chang
> <abner.chang@amd.com>; Dong, Eric <eric.dong@intel.com>; N= i, Ray
> <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com&g= t;; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Yao, Jiewen
> <jiewen.yao@intel.com>; Justen, Jordan L <jordan.l.justen@int= el.com>
> Subject: Re: [edk2-devel] [PATCH v8 9/9] OvmfPkg: Uses
> SmmSmramSaveStateLib library
>
> > Uses new SmmSmramSaveStateLib library, which fix the CI failure.<= br> >
> What is the exact failure you are seeing?
>
> > +
> SmmSmramSaveStateLib|UefiCpuPkg/Library/SmmSmramSaveStateLib/Intel
> SmmSmramSaveStateLib.inf
>
> This should be the AMD version.  KVM uses the AMD smram state. >
> Also: OvmfPkg/Library/SmmCpuFeaturesLib should be updated to use
> actually use the new SmmSmramSaveStateLib library, and once this has > been done it should be possible to remove
> OvmfPkg/Include/Register/QemuSmramSaveStateMap.h
>
> take care,
>   Gerd
>
>
>
>
>

--_000_MN6PR11MB8244D0024F3DCBAADC6E3ED38C9A9MN6PR11MB8244namp_--