From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4DBD87803CE for ; Fri, 28 Jul 2023 07:27:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lCQYJ3UoLDisI94pzEksi3s7k+Ti6jlMX6/ombo1Xtw=; c=relaxed/simple; d=groups.io; h=X-Received:X-Received:X-IronPort-AV:X-IronPort-AV:X-Received:X-ExtLoop1:X-IronPort-AV:X-IronPort-AV:X-Received:X-Received:X-Received:X-Received:ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:X-Received:X-Received:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:x-ms-publictraffictype:x-ms-traffictypediagnostic:x-ms-office365-filtering-correlation-id:x-ms-exchange-senderadcheck:x-ms-exchange-antispam-relay:x-microsoft-antispam-message-info:x-ms-exchange-antispam-messagedata-chunkcount:x-ms-exchange-antispam-messagedata-0:MIME-Version:X-MS-Exchange-CrossTenant-AuthAs:X-MS-Exchange-CrossTenant-AuthSource:X-MS-Exchange-CrossTenant-Network-Message-Id:X-MS-Exchange-CrossTenant-originalarrivaltime:X-MS-Exchange-CrossTenant-fromentityheader:X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:X-MS-Exchange-CrossTenant-userprincipalname:X-MS-Exchange-Transport-CrossTenantHeaders Stamped:X-OriginatorOrg:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:X-Gm-Message-State:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1690529274; v=1; b=A5vqbTE4SbLEffPFx91yAufpu5jHAPXltV9ON6YJS103Vl2m+Q3CgNhFPoYoX2LmMJxWZeD0 EjcdGKLni4RwrxjQ/o3JfFJCSS10JlgJcXlg4UCCq25UA9+Ge9QnfUSpMjSl9A5H51ssFFvnCor uJYbh+/Q0AIySBi2shh6eRnc= X-Received: by 127.0.0.2 with SMTP id wZ8OYY7687511x36qBVT7WAL; Fri, 28 Jul 2023 00:27:54 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by mx.groups.io with SMTP id smtpd.web11.27715.1690529273367979670 for ; Fri, 28 Jul 2023 00:27:53 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="371231138" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="371231138" X-Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 Jul 2023 00:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10784"; a="730632652" X-IronPort-AV: E=Sophos;i="6.01,236,1684825200"; d="scan'208";a="730632652" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2023 00:27:51 -0700 X-Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Fri, 28 Jul 2023 00:27:51 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27 via Frontend Transport; Fri, 28 Jul 2023 00:27:51 -0700 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.27; Fri, 28 Jul 2023 00:27:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oErjF9uqa7H4lhJUXrtTGuUoBsd7nVowZ5FYQ9KRHEFwManOXM9XVyrm92xDLps2hFrsm0Uj+6QtwjBffo7KkUcS28pCOBeU6pEXj7YSQJJYO90gXVNdCYyYDlmEtC8ZmD5vspshYldRsid6AEqPWIDAQuKEM64yQjwbSuO0XW9mS2cR0pjpd8e2v3IU7p6Cgko0WlokPMkDnYSTzChE7ml9ESs4IuaWpUDVaHSolsa+x48Pgg1ybgmli2C/u064jl5Gy8z+IM37F8o5IlW3XPwGhv9O1D+TPj6ymvdH2FQi1B9ptLQoBlwjP9+13P7FAguVGIqoplUB0prWIyh9dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Vj61fVulA4iBcSORSgu0Podyqv7GK+aFUniJfLzq7ec=; b=jJjbkxKoXoby+kIxTiwZMm/jNdISKCuBhC45MXsXWnXbo86ytrpFI7LHF1WHOjaN3t7gxqHdWT0AQqphd6/dEkNu9y5UhdZXdmaSVGqreL1ebsc1yI8j3mGxwzjrtTVGmvUz+QulvgFJZRZVQvIUaDQKJvONO/9C9zy/WNn2Z9TNOEI3NS2YEBAu+Oznzu7gf+sl95txCfwrkEWbyapA9GAPx4oMk1hagXITtBfoKimcbNrbKHnV+h4prJFThw2r1G5Z4kv63NPaLlyA0pC2a1xY+GcOn+f9+E4ddUd57vazI8TLKzS5Qk8Q8tZoYHz2BKaNaiFRWzOnyPOfXu8nYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DM8PR11MB5608.namprd11.prod.outlook.com (2603:10b6:8:35::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.29; Fri, 28 Jul 2023 07:27:49 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::bf9a:54ca:d270:59b%5]) with mapi id 15.20.6631.026; Fri, 28 Jul 2023 07:27:48 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Tan, Dun" CC: "Dong, Eric" , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c Thread-Topic: [edk2-devel] [PATCH 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement for CpuS3.c Thread-Index: AQHZwDEIAGympLACH0WhrW/1hym816/OxQ2A Date: Fri, 28 Jul 2023 07:27:48 +0000 Message-ID: References: <20230727022040.1910-1-dun.tan@intel.com> <20230727022040.1910-5-dun.tan@intel.com> In-Reply-To: <20230727022040.1910-5-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DM8PR11MB5608:EE_ x-ms-office365-filtering-correlation-id: 46a01197-613b-430f-3937-08db8f3c24e7 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 31+OY7M8OknMNgxaxXchcB6Ny2uODnAmRX+30CtWgqWtOi0k24nnmpF5DzT76bGTyEA1r5w1O9HokESaty/JZTMrXQMBqo7cfszTP8Rcc6wdN4Zc76Zz5NfrBA3sgMtf3vXcYlEob3TodI7maNuSaCF9Qsw6GYUFDaYe+daDtQjmc/EkpT1sN1jBSp0tY2X5QXIKiTT5eIkkzX3suTVhLdVJ4JyM4QJdO79zTpI+0Sacdoo0u/NYD5rG8LyYrveVvZv5wzbCqP846WS1TLJSIXYPlmpUuR9G+dZvNWsO/+LPfEsFLdLzYjPYrwePGNMoRknomZhK6xFLrTVOQl2ltZHBn3xhVZ+Yycgb97iTCU54LGAW4chTlT1+jcJV4PW4wLzDA8TwabfrZ+UqVl+vUSOZNOUZIFO2kwXJ13xfAoBDYC4GPrK9yfSQrHQEqy86HqQyzpnElcA2G5vUDaW1UgFb1jp3y4mrPpffgYPpo3kSptH3u+tif5iOu7CWmR1EwN08SmEuKPswisgQDUjgD8haRHDNz4XGbhg+xPSVOvTaIueTad3epSDFSkDHsm3ePDXipQrafuAYgHpLuQIACiVKcOqFHRtru6ivxnLCkXU7G7ReYshw5YT+a6sHH27n4IW76LEPGmT5gvFQ5CtnbJza7kDh4aYwXgk+hN2nMvw= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?vy6c9lobHNNR05LZBl9ss4YrYYORWObP6YP0ZTbzfj1OFxbfSdfHqIsgwnoZ?= =?us-ascii?Q?B1/nrfJJNg62rPBiNzyKY1ilrEBa5D/FZvy7ApkD4L7J93NW3IH2OxhU+Zro?= =?us-ascii?Q?BermovamdWtHKhUbkKL1ZC0MqC3MKpfmP3JQQ4ERKzqG5JpzDKt0VbtjDdMC?= =?us-ascii?Q?AeXyzoEKoZpyIj7Jr1ROoIcvmj3ri1VE+BxowcOjjzqjASB3SwpAuJkmM++2?= =?us-ascii?Q?lqZAolzFEaF1bQX6HL4BqoD53SRlewCB08hd8m5MUUBc8Md1PkWa9YMqHi2R?= =?us-ascii?Q?dKwR+l6aEJ0IfihE4edHTwR5d7deiO64FFuqRQaRugDrm544GipZEcMfWjAF?= =?us-ascii?Q?4VK+TxLtXhkLb+zzpa5V29uDg1yKO0dopJhEdE+11CCY4TVsLfmeC/TFCIrF?= =?us-ascii?Q?jhMrMp2mxf6Oop9jH78qQp2ywDhzbr/A9PuoGNZ5q9RyK2DAamm/7hujaTMg?= =?us-ascii?Q?2JWLQldPhq0DAx4lC2q1M8b5IXoIXzu2e51+NIpAZ7Kbd9XFFHpYOw3FdCjK?= =?us-ascii?Q?7KSPg3naGEwPwko2DLewWrlwkwlRs3VeX6f4P1775TtHHGriZZhxpj00EJdF?= =?us-ascii?Q?voVB24T/6bReYnIVykD8R6S3sIxNXebmoSSlbsnjrMj6S0ocPLprO5I8P3Jw?= =?us-ascii?Q?SDjbVIX6HT/02EiQOFtRcjr+iPjxuvvbvyH3gvsWDQL4j6BR71CrhOl0AssH?= =?us-ascii?Q?o+z8SLKGL8tKhe1iwxS4JlP7dOVQ7BJysiNn5Uo77dx7LOfIN3i3w0UmkA4D?= =?us-ascii?Q?EmeM9t6P8UTsV5FhMqZO1s8njsbl2u10yjxCD6LPPNqwtSX0919sSLEIc9AD?= =?us-ascii?Q?nWdMUVwlaIXfQphHYofJ4/sHVt2VdyhLjN5FDPqgzATHe/LxzxfiLirTZ0nY?= =?us-ascii?Q?29rKaRfCWP0tb7FIIYEfMQd5J9LfUZ3KmBhGY6vov0+Z8FLg8aaU175qKsAU?= =?us-ascii?Q?mbEG5Xjmj+u/kViwNqih7Q1CN7g7evmA8EMkigqK4gMGVt38dUD1qgH99wFP?= =?us-ascii?Q?W1Hgso1pYYOqkGq0Yny0DvP/XtHUW/8CUdjigs7TjlczmfGsUv7yj9oKzKTt?= =?us-ascii?Q?RQ5PMmpRZgBHe6YkZXeCXqXid6pDiXwD0KpEA0xL3T6xQXagecRMDais7bwy?= =?us-ascii?Q?WWpT15WwUQ2Lgo7afbJhXvK5ABBEhvpbBrIeOHgdiPZVwB0Xhbh6TlqNgEYa?= =?us-ascii?Q?14Bx4Z9uhrQh6/JkMwVnQXOEGhmmDWafYEnsNTQ748lpTwukNbon7+PdFL30?= =?us-ascii?Q?QNaSfILLxz/ZGd5czoe7oG9oQM3XBPTairWjlQKKBuu7LmH3lmenALZxuLxq?= =?us-ascii?Q?0ZMOQNzjktSQnpVvejQWuq2pMsDaGywTd+Lil3IOHLhfq3fKZBbk7xzNeyOu?= =?us-ascii?Q?p0j+4oWC2I3FYkRjTpJmHDXuU43H6FLX/+gGpz0ApPmfGlhtApuBvwS3fJOv?= =?us-ascii?Q?Lo5eNIJUrpSy4CJUG8TLcnSUEsaP3bgCHKUE7QWHFGNPix+64PlyX3obCdTW?= =?us-ascii?Q?fAuz5MN12lYrMy608sdK3jjh8aZBDQXkWLKUBSQuuOIPu46jtC4ThKZUSjiy?= =?us-ascii?Q?ep7BYcTF6G89dQpR+Lg=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46a01197-613b-430f-3937-08db8f3c24e7 X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Jul 2023 07:27:48.2939 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Pb4bL0XA7RECSAqoH4hw/qKwGj0tia27mgUOaEd1kMuYR3L3YoTL/zEf5frcoMBlPuSzFjqFmr0RmoWDuaD1dQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM8PR11MB5608 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4WoEMuxEtEe8nJSeqTTe7lOfx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=A5vqbTE4; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io 1. mInitApsAfterSmmBaseReloc assignment is done in different places. It's s= et to FALSE before BSP/AP initialization, and it's set to TRUE in Initializ= eCpuAfterRebase(). Do you think it's better to only assign it to FALSE/TRUE in InitializeB= sp()? 2. ASSERT (mNumberOfCpus <=3D mAcpiCpuData.NumberOfCpus); is done in multip= le places. Do you think the assertion in InitializeCpuAfterRebase() can be removed= ? 3. Do you think if InitializeAp and InitializeBsp could be implemented as a= single function because I found that they are doing almost the same thing? > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of duntan > Sent: Thursday, July 27, 2023 10:21 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, = Rahul > R > Subject: [edk2-devel] [PATCH 4/5] UefiCpuPkg/PiSmmCpuDxe: code refinement > for CpuS3.c >=20 > This commit is code logic refinement for CpuS3.c. It doesn't > change any code functionality. > In this commit, abstract the function originally executed by BSP > into a new InitializeBsp(). Also prepare the AP StartupVector and > send InitSipiSipi in SmmRestoreCpu() when mAcpiCpuData is valid. > Or only InitializeBsp will be executed by BSP. This can make the > code logic easier to understand. >=20 > Signed-off-by: Dun Tan > Cc: Eric Dong > Cc: Ray Ni > Cc: Rahul Kumar > --- > UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c | 110 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--- > -------------------------------------------- > 1 file changed, 63 insertions(+), 47 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > index 0f7ee0372d..d2e2135d08 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/CpuS3.c > @@ -627,6 +627,7 @@ PrepareApStartupVector ( > mExchangeInfo->BufferStart =3D (UINT32)Startup= Vector; > mExchangeInfo->Cr3 =3D (UINT32)(AsmRea= dCr3 ()); > mExchangeInfo->InitializeFloatingPointUnitsAddress =3D > (UINTN)InitializeFloatingPointUnits; > + mExchangeInfo->ApFunction =3D (VOID *)(UINTN)= InitializeAp; > } >=20 > /** > @@ -647,27 +648,6 @@ InitializeCpuBeforeRebase ( >=20 > ProgramVirtualWireMode (); >=20 > - PrepareApStartupVector (mAcpiCpuData.StartupVector); > - > - if (FeaturePcdGet (PcdCpuHotPlugSupport)) { > - ASSERT (mNumberOfCpus <=3D mAcpiCpuData.NumberOfCpus); > - } else { > - ASSERT (mNumberOfCpus =3D=3D mAcpiCpuData.NumberOfCpus); > - } > - > - mNumberToFinish =3D (UINT32)(mNumberOfCpus - 1); > - mExchangeInfo->ApFunction =3D (VOID *)(UINTN)InitializeAp; > - > - // > - // Execute code for before SmmBaseReloc. Note: This flag is maintained= across > S3 boots. > - // > - mInitApsAfterSmmBaseReloc =3D FALSE; > - > - // > - // Send INIT IPI - SIPI to all APs > - // > - SendInitSipiSipiAllExcludingSelf ((UINT32)mAcpiCpuData.StartupVector); > - > while (mNumberToFinish > 0) { > CpuPause (); > } > @@ -714,6 +694,54 @@ InitializeCpuAfterRebase ( > } > } >=20 > +/** > + Procedure for BSP to do the cpu initialization. > + > +**/ > +VOID > +InitializeBsp ( > + VOID > + ) > +{ > + // > + // Skip initialization if mAcpiCpuData is not valid > + // > + if (mAcpiCpuData.NumberOfCpus > 0) { > + // > + // First time microcode load and restore MTRRs > + // > + InitializeCpuBeforeRebase (); > + } > + > + DEBUG ((DEBUG_INFO, "SmmRestoreCpu: mSmmRelocated is %d\n", > mSmmRelocated)); > + > + // > + // Check whether Smm Relocation is done or not. > + // If not, will do the SmmBases Relocation here!!! > + // > + if (!mSmmRelocated) { > + // > + // Restore SMBASE for BSP and all APs > + // > + SmmRelocateBases (); > + } else { > + // > + // Issue SMI IPI (All Excluding Self SMM IPI + BSP SMM IPI) to exec= ute first > SMI init. > + // > + ExecuteFirstSmiInit (); > + } > + > + // > + // Skip initialization if mAcpiCpuData is not valid > + // > + if (mAcpiCpuData.NumberOfCpus > 0) { > + // > + // Restore MSRs for BSP and all APs > + // > + InitializeCpuAfterRebase (); > + } > +} > + > /** > Restore SMM Configuration in S3 boot path. >=20 > @@ -814,43 +842,31 @@ SmmRestoreCpu ( > } >=20 > // > - // Skip initialization if mAcpiCpuData is not valid > + // Skip AP initialization if mAcpiCpuData is not valid > // > if (mAcpiCpuData.NumberOfCpus > 0) { > - // > - // First time microcode load and restore MTRRs > - // > - InitializeCpuBeforeRebase (); > - } > + if (FeaturePcdGet (PcdCpuHotPlugSupport)) { > + ASSERT (mNumberOfCpus <=3D mAcpiCpuData.NumberOfCpus); > + } else { > + ASSERT (mNumberOfCpus =3D=3D mAcpiCpuData.NumberOfCpus); > + } >=20 > - DEBUG ((DEBUG_INFO, "SmmRestoreCpu: mSmmRelocated is %d\n", > mSmmRelocated)); > + mNumberToFinish =3D (UINT32)(mNumberOfCpus - 1); >=20 > - // > - // Check whether Smm Relocation is done or not. > - // If not, will do the SmmBases Relocation here!!! > - // > - if (!mSmmRelocated) { > - // > - // Restore SMBASE for BSP and all APs > - // > - SmmRelocateBases (); > - } else { > // > - // Issue SMI IPI (All Excluding Self SMM IPI + BSP SMM IPI) to exec= ute first SMI > init. > + // Execute code for before SmmBaseReloc. Note: This flag is maintain= ed > across S3 boots. > // > - ExecuteFirstSmiInit (); > - } > + mInitApsAfterSmmBaseReloc =3D FALSE; >=20 > - // > - // Skip initialization if mAcpiCpuData is not valid > - // > - if (mAcpiCpuData.NumberOfCpus > 0) { > + PrepareApStartupVector (mAcpiCpuData.StartupVector); > // > - // Restore MSRs for BSP and all APs > + // Send INIT IPI - SIPI to all APs > // > - InitializeCpuAfterRebase (); > + SendInitSipiSipiAllExcludingSelf ((UINT32)mAcpiCpuData.StartupVector= ); > } >=20 > + InitializeBsp (); > + > // > // Set a flag to restore SMM configuration in S3 path. > // > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107373): https://edk2.groups.io/g/devel/message/107373 Mute This Topic: https://groups.io/mt/100383962/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-