From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web10.7296.1683685373596359342 for ; Tue, 09 May 2023 19:22:53 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=XVRifXL5; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683685373; x=1715221373; h=from:to:subject:date:message-id:references:in-reply-to: content-transfer-encoding:mime-version; bh=IvqxoMiDuEthSolkJ4QnRNzgEiyi9xTzHoMLO30h9Ww=; b=XVRifXL5Lpn2WTln8DZdrHErfEOw+8Ds6ojWXsDJx/B29+uGfR2KJRnA BmNT08A4bi+Qc4uFQv/ERI6JBam1PStfWqE6ZDGtAZYGD6wJj7GO18t8e hox0yHJsnEcjjStg9pMhlJQmz4FyiwlD/h3LQ6chBNC7mIHRJ8Z15+VJW B0KAGjfJvNEZnjBOZSbDepb8IlEs13nZOoRc4Cg5awMBIIdp91n7lySAu FWnM11CXiA4PDiFqpZ9VouJsH4wsLcmFvamK4G1MySZj8I4HsuAet4L8S qYPyq1jlA8G46cQYPVH0WUDfa3HfEZQh9XgC0o0e/LwWVruEKEqlfcPlk g==; X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="347573988" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="347573988" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 May 2023 19:22:52 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10705"; a="731986856" X-IronPort-AV: E=Sophos;i="5.99,263,1677571200"; d="scan'208";a="731986856" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orsmga001.jf.intel.com with ESMTP; 09 May 2023 19:22:52 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 9 May 2023 19:22:52 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Tue, 9 May 2023 19:22:52 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.168) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Tue, 9 May 2023 19:22:52 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=od8YTk8dzLzwvbji1ahaXZKCZoiANyamb44umJOcKkRPhfL+ingieA1dHbaSQyg6kq28kkS56YlFXqkBcgr2fimxvmGyevPIhAJunuVt7jsgOEqfDbgUdJ7vk9htG8nAlVbIlFQiZ32Xx21+X82j2a7SnsW0/8KUPFOjQsHV6SjnD+2OhhXVd1Vlj3Nt0hvZbpbzyvkn7Ko+f9K20DfM/wZB/QBbzO3lGMKsEplGq19r8kgGrI12NEuiNwueWWSVnx0+mYErF1E5IanVjjzorSwwWqMJUT7JGcHerCOBvO145CQKHdZ41tHPinQw8bBHhtNwxinF2RQzEjpBo8b30Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BrvoUuXWIsmBGFPh+zifiONk91gZaOxG4vfCiURfAmU=; b=Liz1DuXuGk/1P+o6fg04BnXxMEZxkDLGYkgau05eDWs5nmalPCfc9gVZHtw0W52hXl/t2knaCDgPf4+7jE+Vla5HSqMNbEibgnRcpRA9ZD7oV7ORYCI4HMlFHeA42i6JWSpaeVcpeH4XO3ZVUUyZkNMypFyCcdH3Otrg8VJWabfrfadOLSbEFSg4zJbRNrafW4AZuWJyofGBhCoBQVYeovd5CN7POirxI+nwgiplbGW5rSzv/aIfkuEVahHRr8T88/FiWB3C14eTAdPqcH1ohb3Of3sM4Fo3Wabu0b4SQfdh7QaO/gkTWx4KYLkVfWnHUJ1XMC/BsUTF3rSBP04pGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB6522.namprd11.prod.outlook.com (2603:10b6:510:212::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6363.32; Wed, 10 May 2023 02:22:45 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6363.032; Wed, 10 May 2023 02:22:44 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Liu, Zhiguang" Subject: Re: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging Thread-Topic: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page table creation, and support 5 Level paging Thread-Index: AQHZgYVIiTA0J/Zp0kK1gUQS3ybGk69SyY+g Date: Wed, 10 May 2023 02:22:44 +0000 Message-ID: References: <20230508081504.1067-1-zhiguang.liu@intel.com> In-Reply-To: <20230508081504.1067-1-zhiguang.liu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB6522:EE_ x-ms-office365-filtering-correlation-id: 5b161b99-be6e-47bc-6203-08db50fd703a x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: pB8CTrHBR8K/qb79f5nTVCByBGg9AMJk5fa/TflIzZRMSPObUM+LDbtt87QfLfHNSct//h6JKzZsaytQII9rxxKeYKx2BWhS4mAs8hbHCr8th3CBycTXFmO6j7zkDxV5ZTJ9shHL21+Wzvme+3AJ+tnyUmM7t7YaKhqUYdVClQulsr9y57JCWUE9Un+oCFpvj0DG4iX0Cb+jS5mjJn/gunIfJgVVbXZ5FxsCQ2Wtx3YZRtt9LLA3FcPTGSZQdDWcw0FkNaAvwS5HgtILhPt1pntoq1UX80eCo5IKlk9DZ+TmyD0MR9o0ghKczSuuC9CM1RHkDh3ChArFPF85h10DM9uUln2sSLzJFkAFQpAoDlQyr51Jeztb2RFlruIYW8AXH0iF0/gM1siljGLqhHO9ISNInUZlEcpCJlJ5QkDeuhLTgTLJ/SaM0Y3KKFjQJ1FBvzOv7D6cnucEqFTH7Y6Vh2DFIIIkAagfdA7GkeTPjw/qoq9zPRrklGw2taPx9oDz3B9hZj2+b/I6H0J/OColi/A73d8stc6sERy8Cs/rkbtoFptG9fZYHt+1EeHmuxDd+wqRZJdiudjfOXPRe1JvV4QKcwdRb5fkonzNgYWpzSQd1Hbt79hyLukb+SiDlnIz1PfjaonCH73z+NrgwbH4IA== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(366004)(376002)(396003)(346002)(39860400002)(136003)(451199021)(5660300002)(52536014)(19627235002)(110136005)(8936002)(7696005)(41300700001)(316002)(966005)(8676002)(71200400001)(26005)(66899021)(53546011)(66476007)(64756008)(478600001)(66556008)(6636002)(9686003)(76116006)(66946007)(66446008)(6506007)(2906002)(83380400001)(186003)(122000001)(82960400001)(55016003)(33656002)(86362001)(38070700005)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?AzCpgSuRVMO782nmQz3VAbC3uPZWNDuO2f4tyICXA9gvyq8+oMVG0gPk3R3s?= =?us-ascii?Q?IBYBzoFiGCxG4EDgDkTPgbu+Jzi6azvwMbND/4efOPNtmnbJoZ1GfcZ9UdoU?= =?us-ascii?Q?Wms8nr/SEQNhOsmmwgaxRYjdrJcSJy16HSapHym4CLr5Hr4N4EdPJlDnPPvD?= =?us-ascii?Q?atw0VmRwAamhuAOjzNsBcy1Ypoop8U1FLV0E6Pg/FBkk9lK9lB1b0LLPPueo?= =?us-ascii?Q?HICK8V+wmrmI8l1T3rgsOBK4aYkw7AhRLuatRFOYsp0V+zvlgMu/5eUNvfpD?= =?us-ascii?Q?ejrIL+s46GAavdu3G3HUWgwEhyT5K2udLU3ApA69m26hxowGkrAm1bviGNrz?= =?us-ascii?Q?i11qWNS7VOyQEsIycmuWja16ldN5xhkF2vXPzrFYmGRrIfdnxtY9wHEzWO4Q?= =?us-ascii?Q?aMMfdWX0rWF0YLGhuukmVPNWdCS5yZ+mHlqlqzRb4Y9lSU5E29buBriyz2sD?= =?us-ascii?Q?PlcK8pDhJoHGkDrJ6fLGQTcP70rk8iYn4HmLBYRL/ofeUPofg5hAsfd75YIH?= =?us-ascii?Q?/iVH+JF/ZW1niSqdOwb12Klk3cdwEzqHKuoAuZfWq2lbNfO72JGbcRopKGmG?= =?us-ascii?Q?WzEKrCYZ4mtV+JpU1w25On12iFEqZfXYXsieyws6Hg3FigKsFYahsKKM04Tk?= =?us-ascii?Q?91u+xutpikg1pBNXxsHBGwttkUdyl1wpgAGuoUAzx0hYVpDhPFNJ7CQAXnk6?= =?us-ascii?Q?+uj0GDkrcwnY2zvdxcrfZb/OmzGr6tVDejnJFULIOig+UTwsxItVtKFLUnsb?= =?us-ascii?Q?oVdPKxYy7+2LdZ9+TqapRbEIeeIit0nPkky59SFoG3YNnNCcyfAH4aIqpz36?= =?us-ascii?Q?BBL0YzE1NhAQw1gXM+TdfM8BNoGVuuInQN4gMwAY1CyNd6PIyrT0pL5WLt3X?= =?us-ascii?Q?ea5TeyNz47S5q8EadKK9tXAon9rV7QH0pSuT6Hz+MrmOY1yunAFLrn5Mr6Ad?= =?us-ascii?Q?KzUuFuBehEY+DnhRGtq05uX7t8poasJI0+NXVv9lHrxhQjXPn5IfIjUSHxHW?= =?us-ascii?Q?9ocur7c8uGIEw33Q5fXNnpLgHnawZZKJ2BnS9xpoINN8y8lH9s0dsgCqtolk?= =?us-ascii?Q?mjm+UUhubeLilP31DhnUgzeqc71AQjwB2jiRCBJAZMel8OozOXafu3nxTZaY?= =?us-ascii?Q?eRJNxKZePj9NSrRLmUyWAIGGSE5TDi0G8O9AsaNSJmIVlygCzFRplsVjmQnM?= =?us-ascii?Q?lw/WB1mcA8mxmlO7PQ2YdnCzrxx09tTQ2GUoq7LpfUvnyKktOlPzqb2zrJYv?= =?us-ascii?Q?6x3iDHUiKBgkm0RfyFQhg8DmTb3giwtb4e/aZrXQbF+YPoBPlSYlt3ZG8+2f?= =?us-ascii?Q?+/b4I3jOvBaXyJ6igGJ6smJhqJ4M8KjE7zQGuS8t0aLO8QBVsOB53t9L7jNh?= =?us-ascii?Q?zzzo/e9+5djHTGpXo8q/aLKvqc00iyDYjoUr13FAC5nqoExnYWacwoVgBL+7?= =?us-ascii?Q?GRwFoaScJma4fW9g+u+iLJPofkvN/av+Xz0wwW9LTc6Ycq8RwU4/mBDNCFbK?= =?us-ascii?Q?uUQgujmMW4m3PdSBeRAr3N4WdnyT4YPX86STxosCh5f/+4WD8JIMV7xpT2ls?= =?us-ascii?Q?8FZzJnlrv8HbYBFqQfI=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5b161b99-be6e-47bc-6203-08db50fd703a X-MS-Exchange-CrossTenant-originalarrivaltime: 10 May 2023 02:22:44.2428 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: kqITev1HUUsAjoQ9YtpsJmOw2YOJZDEV+IkuMeL0b9hJuNT0EF7e76cwnB+4jpvtpBfAZII5XxIutYWCwPq6mQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6522 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Zhiguang > Liu > Sent: Monday, May 8, 2023 4:15 PM > To: devel@edk2.groups.io > Cc: Liu, Zhiguang > Subject: [edk2-devel] [PATCH v5 0/5] UefiCpuPkg/ResetVector: Refine page > table creation, and support 5 Level paging >=20 > This patch set simplify the page table creation code, remove some > hard-code, combine files and support 5 Level paging. >=20 > V4: > Refine comments and update below macro names: > PG_NLE -> PAGE_NLE > PTE_2MB -> PDE_2MB > PDP_1G -> PDPTE_1GB > PAGE_BLP_ATTR -> PAGE_BLE_ATTR >=20 > No code logic impact >=20 > V5: > Update below macro names: > PDE_2MB -> PAGE_PDE_2MB > PDPTE_1GB -> PAGE_PDPTE_1GB >=20 > No code logic impact >=20 > Zhiguang Liu (5): > UefiCpuPkg/ResetVector: Rename macros about page table. > UefiCpuPkg/ResetVector: Simplify page table creation in ResetVector > UefiCpuPkg/ResetVector: Combine PageTables1G.asm and PageTables2M.asm > UefiCpuPkg/ResetVector: Modify Page Table in ResetVector > UefiCpuPkg/ResetVector: Support 5 level page table in ResetVector >=20 > .../ResetVector/Vtf0/Ia32/Flat32ToFlat64.asm | 25 ++++- > .../ResetVector/Vtf0/Ia32/PageTables64.asm | 24 ----- > UefiCpuPkg/ResetVector/Vtf0/Vtf0.nasmb | 9 +- > .../ResetVector/Vtf0/X64/PageTables.asm | 93 +++++++++++++++++++ > .../ResetVector/Vtf0/X64/PageTables1G.asm | 53 ----------- > .../ResetVector/Vtf0/X64/PageTables2M.asm | 60 ------------ > 6 files changed, 118 insertions(+), 146 deletions(-) > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/Ia32/PageTables64.asm > create mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables.asm > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables1G.asm > delete mode 100644 UefiCpuPkg/ResetVector/Vtf0/X64/PageTables2M.asm >=20 > -- > 2.31.1.windows.1 >=20 >=20 >=20 >=20 >=20