From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mx.groups.io with SMTP id smtpd.web11.9679.1678231419917405442 for ; Tue, 07 Mar 2023 15:23:40 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=G/fbYzc3; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1678231419; x=1709767419; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=e6ubZbnJWunVIIsyXP50xJvo6SwHSpoocCiCfP7JcHA=; b=G/fbYzc3whUWgviOllEsD6KBSwSUyaUOFhrHvZHKmFfUBKFe0r0pnjwl jRFAXN9uEnmLMhw+2j5lsEl83YfarVIzH+Jto03Kmwo2/XdHJtWl5zP29 NPOPQSBHo63aEJjH8gzFlw+kEyl7PeNLxjxK+8VujI3XS+E92+KFeRHy3 sKdreB3QbJ4XKTrEmQd9Q3tU+kbWJjjdZ7LNnc2a/FInIEfMEp8Qtd05Q ihdcDOC0yz+IL0Ng2DXJk69GSANtkpACV1x3158wySuoBtXHSGBJx2DoL 97Y7E2hRE0PpUSuse/una/VZySNYBo8hDoYqa7JOqLmhjekETmXbfJjpe w==; X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="316401921" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="316401921" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Mar 2023 15:23:39 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10642"; a="679126966" X-IronPort-AV: E=Sophos;i="5.98,242,1673942400"; d="scan'208";a="679126966" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga007.fm.intel.com with ESMTP; 07 Mar 2023 15:23:39 -0800 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 7 Mar 2023 15:23:39 -0800 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 7 Mar 2023 15:23:38 -0800 Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Tue, 7 Mar 2023 15:23:38 -0800 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.170) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Tue, 7 Mar 2023 15:23:38 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HIcm/EW3DYj50uaF6AOS9cN+wpF9pVY07Pd4HFqSsUnNRhBrw4a9UTjkHqVxAN9zNwEt0WTv2kV76ga23kafrkQ83oWXXdXeV6UuCBnPlaMHeVvWi0YurRIrDs4JvtP9JYmdQH3bZ4KodBM3Hw7NInnFodeekSDt1u9NaTA2wKlCPQ1G4QlwGO8hyb9vlqttsh9ns5e93lDPSEjhnpGJvEp+aYr9nEEq4QzzPcnD2ymCkNuRfREi5pWGBg1yH4PzMJ1LLHPOhQ6nKg5Fw1yrWbIDFWElxkRpoq1JU4ywPxi6k0SiR/bOoaepionjZzq0YCmRXHuZG5NSrPw/PfEd9g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1yNukF3sBdYcWzpSxKgk8qEuZy2ZiA50BophvoDej8Y=; b=OugmsKHnxgpjgO1bg7fVE4drKi8JF5r4t0H3x7B1A+zWk4Gmk3tGqeS5mghaoyAovGnn1BdX8pXrbH8P+55jb4OVvTYzd7/5HSbyNmDgkmotGVn/z7KOXUjRtFWnqeK7eEOXn6COhd0y00xdnJZZJ5k8CxgvNGSwNfGgSCS9kvkmFtVD0vmjOQEdvAVXeHg1jQ5xOjOCMWlu32t4fuIEVtYggSt3qZUFeJ8vF4r+iumwKV5M8mBe10/THWabd54ByIP161VecnO63padxk+PGNry4UhhbKh+mbiSPFNDyIbl4tdpJSa5eZ9pTWv3AhTyzpJPd7NPnrK6NuUvi8De3g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by SN7PR11MB8068.namprd11.prod.outlook.com (2603:10b6:806:2e9::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.16; Tue, 7 Mar 2023 23:23:35 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::e342:cbf5:6c57:e8d6%9]) with mapi id 15.20.6156.029; Tue, 7 Mar 2023 23:23:35 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Reyes, Darbin" CC: "Narey, Jacob" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix exception Thread-Index: AQHZUUp7WCGUIE2uYEWRhFX5OGSo867v9GHA Date: Tue, 7 Mar 2023 23:23:35 +0000 Message-ID: References: <7649d8fa34ad6b7f893fdd49efd4c3a7f2125fb6.1678229331.git.darbin.reyes@intel.com> In-Reply-To: <7649d8fa34ad6b7f893fdd49efd4c3a7f2125fb6.1678229331.git.darbin.reyes@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|SN7PR11MB8068:EE_ x-ms-office365-filtering-correlation-id: f6ad15cc-fc37-42aa-9e4f-08db1f62f980 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: i7VhS6EP0IWJXPb6HbOUT2+SxsbvW8RBAulaPLB9FdPBQvAmKYZ+8IUlesFiMFsZnsAUcbQouYEBeQfZZM72r8UUqkASMr/Z49uF/zNPznQfoaBduSkRQ9vZPV4OG5TALAZgDMilCxYKvlf9VY1IKIWLPw5pdPPdVo6t1TQLnMOaDoSZIC2YkUNQV2AemU8OpigSNeP8A/JV52XGRovHiK3i/Wf3Qn1HoVCh+An9KKMW6d/CTgjfYv3Pp9wA6rDu59UQtQC69g9TPFgo0eP3W6NCHqr/M9r3SacK9YkgClHCKOhgm6Z+iKoUdoniWDTSFbCAs1NzjCzUne98LTTQ8E1Wbe5VC+d1BuEFqwDx5sqZ64xiAsjTafYm3pNa7rmuvLJqQPJj8Mu7TZdOmxSWwCNbdV6svldMK9cagk59F/uwJ8sVWgNk929KqYO67sODeAT5yMUt4OTVia0dPZriK2cRyAiFUDTJss8JYczmAqq78k3jue6SlF/0IHUU8g6g1L52IoDRN1H/dCU3MxoFeKIXdFt5w52h6M7cNieu1wrCFmtfclOS2zqgXWbbjGvGyFTimyatJqJJokoAj66Fz0TSjSOBgu2TSaRiJSasiYhxqnRlq+fJFvRIkyB4KZovrji8HSrF1Znzyzn+y3sl3yKGsVfiEniJmPu1jT3k89iB8YWf3ELjPZjzoLA97JNPHp949idat3U0jOHimFXyQ9fJacbEp9M9oJMSNpJAlFo= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(136003)(39860400002)(396003)(346002)(376002)(366004)(451199018)(110136005)(316002)(6636002)(33656002)(107886003)(82960400001)(122000001)(26005)(478600001)(6506007)(53546011)(66946007)(4326008)(2906002)(38100700002)(64756008)(66556008)(66446008)(66476007)(8676002)(76116006)(55016003)(66899018)(41300700001)(86362001)(71200400001)(8936002)(9686003)(83380400001)(38070700005)(186003)(5660300002)(52536014)(966005)(7696005);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?x/rYNsbzVq9xRxUgPCNL/J4+tm2apmdOtvXmMeQSzntjFH/Ww4EcK4XSAjOn?= =?us-ascii?Q?3Zd92xzoDonuHMdIZ/Ghaw9nO9KwOacArVsmCfOViNkxb/xOq6qX+6esct2U?= =?us-ascii?Q?8DyNXH+XBznCsQBYHJqRU16BnEknhpqJzD2B9GHKQjCfxeJBklvXtyieKzFt?= =?us-ascii?Q?oUhlPhGYRTRJubyOXcl0FVVE1d48S+/x1OznU48a9QnHv3KE8tylRE1IvJ52?= =?us-ascii?Q?toSDXmc+8AsJCxSRCYijVOK2zkjwd+xOb1xPIXoIbTLgEoYOorhFhq0keXf0?= =?us-ascii?Q?5UNUbnQtCiNdmadgp1wLx4s1WTKcuV4E7Lchm0EZ79XHvPpCZFPwnHJZA7j7?= =?us-ascii?Q?7KJ1jaIShz5xaZ+pbpFzMWADz3T8y/IBvF2jO7RJQIuJ2KayK+LR6va9IbIS?= =?us-ascii?Q?JYiqYMRrznfaQf2afMFiwSaHbNXkdQB/H+/vs6h96YJLjFrvXFjoWICECDlb?= =?us-ascii?Q?oOCCltszBy5vaWxZvywqYSDQwqu3ndsGFWwCJUwHHp7FiyK+zZlwK8XwxnAZ?= =?us-ascii?Q?ZjVXcQ2nylfaTgPb8ait3qiIyzDh5FYSzLKzWzXes53h/ReBhev469u0q8rH?= =?us-ascii?Q?04XaNpJoPe1oBuyapsYji1K62yLtbF0yKUAtSzDGjrKIyCgIAU6tFcVDbsxN?= =?us-ascii?Q?mcUiIS2BfFgR12MFXjbh/bUQOIyOnOkQu3P70/nUpGh08LWltiuAgBymTXaH?= =?us-ascii?Q?tt0NJYTkK8v+rswngksomHUYjAJfvFNv+e61/awfgY95zvs2XsKttc1usp1F?= =?us-ascii?Q?5DSGfycgYVoAhqqthHRxXuUa6JphPySndz8FT80LxujCez5CrSUBUULzWJ6v?= =?us-ascii?Q?xcyBcJll5Qy5shlrUJh5hW+YsZ561X8LsF3SoAd8+JJMwWOdxRUgg8lxnNnz?= =?us-ascii?Q?4hFx0BXXDW1lmVzJxz320pmaeqWMHkplb+ReCT3G3vLuP83H9/DzUIAw4Txe?= =?us-ascii?Q?p+RTUKDnKg8qy3zrfMWSrKacBEey7PMfeeXAHF9H4W/3OrAh1KS0ni3M8JtM?= =?us-ascii?Q?16DDMqv7PY+6JbwCm0p8PbegB/hVXlc4nR6lACoI0LHX7Bz7r49Kcmx3lmhR?= =?us-ascii?Q?sqUU+2mVNjIM+Bgc16fJDhOcqSqn6SxUm50XUDLAScqim5Rz72Cfzdi8Wg+w?= =?us-ascii?Q?xmm3HU3suWXXezi2ySm8NLS+cW2aCiurPaGEO17PYlsVVouA0dbSC9O3PPe8?= =?us-ascii?Q?deYUELH+KhYjzgvsiJ0TWblayCHxza49W/ZvecKMvj9VjROYSUrhfIOb//NX?= =?us-ascii?Q?cuFoahYgNpscOwDeF6D0evrXQF+LQe+jIw/lzhlWO+n7Rhoe54QGemv0dY4D?= =?us-ascii?Q?ZOqvXQOI0eRZ33XU2MPc961JIEaBCfguxEylDMFmJ5minT2HCYt+z9hX6KWK?= =?us-ascii?Q?PeeFhNddI9rpzu4Qe5xWZX7ObJTLioQ2QSOTXxRMU56WxTg92ZzowTEi9YZb?= =?us-ascii?Q?8yPhMQD7w9BdVjpbG6SJY2TJE4t5WcGWmBV4622Qo7aV6YKtyjNZuOexvhd6?= =?us-ascii?Q?U58wVfgfRE+1rXkBcO8c9Kl1XLfkBi4iUPICEbV1qMy8Qat2TaZ2YcZDgncG?= =?us-ascii?Q?/eKyTRVkCYhe0HnQJq0=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f6ad15cc-fc37-42aa-9e4f-08db1f62f980 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Mar 2023 23:23:35.5644 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: sixgOiQP//0Ch6/9ZKLiAb652lrgv1M5RD5BmdgxbhueGf8zbzt/9jlcGOzJWuXoX/guw8KE4ecqoOtrzj0d4w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR11MB8068 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Great fix. I am wondering why this bug was not found earlier. If Status is 0 (Success), #PF exception would occur when NULL pointer prote= ction is turned on. If Status is 0x80000000_x (Error), #GP exception would occur because an add= ress with only the BIT63 set is an invalid address. Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Darbin > Reyes > Sent: Wednesday, March 8, 2023 7:04 AM > To: devel@edk2.groups.io > Cc: Reyes, Darbin ; Narey, Jacob > > Subject: [edk2-devel] [PATCH] UefiCpuPkg/MicrocodeMeasurementDxe: Fix > exception >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4360 >=20 > An incorrect format specifier is being used in a DEBUG print, > specifically, a variable of type EFI_STATUS was being printed with > the %a format specifier (pointer to an ASCII string), thus the value of > the Status variable was being treated as the address of a string, > leading to a CPU exception, when encountered this bug manifests itself > as a hang near "Ready to Boot Event", with the last DEBUG print being > "INFO: Got MicrocodePatchHob with microcode patches starting address" > followed by a CPU Exception dump. >=20 > Signed-off-by: Darbin Reyes > Reviewed-by: Jacob Narey > --- > UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c > b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c > index 762ca159ff..5fd3b3365c 100644 > --- > a/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c > +++ > b/UefiCpuPkg/MicrocodeMeasurementDxe/MicrocodeMeasurementDxe.c > @@ -238,7 +238,7 @@ MeasureMicrocodePatches ( > TotalMicrocodeSize) >=20 > ); >=20 > } else { >=20 > - DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with > status %a!\n", Status)); >=20 > + DEBUG ((DEBUG_ERROR, "ERROR: TpmMeasureAndLogData failed with > status %r!\n", Status)); >=20 > } >=20 >=20 >=20 > FreePool (Offsets); >=20 > -- > 2.38.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#100818): > https://edk2.groups.io/g/devel/message/100818 > Mute This Topic: https://groups.io/mt/97461560/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20