From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mx.groups.io with SMTP id smtpd.web11.3031.1684980672333375726 for ; Wed, 24 May 2023 19:11:13 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=RApfDaJy; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1684980672; x=1716516672; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=h151Ig2KEL7snJDKkYsaJ/viVracW+7U1rHX5se2ffo=; b=RApfDaJyoe/OhOtUIkCKKAHd8rzjWNTnI9/fbnT0W3IubCN7UaRgFuQc 5iOjoH2j668dC7cVhv+f6h4gcdCgqop9HygjIqnpyaabO1GVdl1+hG1SE Kw3FAdS5WIGrTcNZkGTYJ78JwtoJ1fSL+8u1tl4hi+ibf3OAROC4UnZCN FytLjBbDFfLqgy/MqdO46jluG4VA6mr3iNvFLNRVWqH8D4SzX5WqDtFZF js6NJSCbSMxYuw2wOXaVIP8mRk+Xv4oqz2Xm5JfThjJ06oPQYM+ALPhIz XYVM+P47evPlSvv6mZqyQS8wrr2l1/BvVFAq9o4QQb0ijjoyNYVsJP2Dk Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="382000778" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="382000778" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 May 2023 19:11:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10720"; a="1034784347" X-IronPort-AV: E=Sophos;i="6.00,190,1681196400"; d="scan'208";a="1034784347" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP; 24 May 2023 19:11:12 -0700 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 19:11:11 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Wed, 24 May 2023 19:11:11 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23 via Frontend Transport; Wed, 24 May 2023 19:11:11 -0700 Received: from NAM04-BN8-obe.outbound.protection.outlook.com (104.47.74.47) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.23; Wed, 24 May 2023 19:11:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=KloCqhn/WQccEebEhr6OIem9+yWH0W6iPEPHBRSR8SzgoH+N7ja5aiZ+TigDMEJF8kxzksDxsaGhNnTtpXCWGwqPiC53nOuhFk3dlj5kDJM87q6Dj4D3S9ADdHKPNHQuEIqqP9wM+Ir/RxSzvhy/ZnMS7diN5QvxehTA+gT/u7NuqUdjE5gBJOFI3h3iIxb2R+81hec6aItOYlbb5nFXHu9frrovZLCQzQWdDL4jqSHWdk/8u8XnLOXabfqm+1Kld6tUQcyfBOWJ45HGdP50DQQiIRRSCLRK8vPMXThW7pFvrfqa0F2vE2/Lc7Ne6KEezXPWOpOHd8wWOX8TPvUqHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0s25whTNxFWJwsgXeRDBg+PZMRNLUzGTXRAfBztndtQ=; b=OpUa77s7mzR0IOcrfnfEJnxtaSMPl/ELq6N5AfhXZTBgkokYEwqge+LK/bXJ/uhSo5V4xKYuoT5JUV7lbqtkCCGSyYEcvlJwynN6wWMizAtksIo6rva4S7NaYBOc1FRRcaJ+sP8Uvqsk6azdHnwz5K8Ny/xuI9bdB3Bmw5gmAFp0dn+G8jgywq54IeG68RK8dKq8cStS7x9Wlp0FwKAnWnvp/tAY25QqE9F6XsbI6A3/xEMsWt0DO3oggOzP/4HZMF/WhXjAo0MpA3i4+1Vhikcq5pkpPR9oJihiz3ONK4zSdG+I6GrUkiuLgnijCGCoQIZ5VwgJAo1MbgD7PvPUpg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by MW4PR11MB7056.namprd11.prod.outlook.com (2603:10b6:303:21a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6433.15; Thu, 25 May 2023 02:11:08 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::892b:b8e6:bab7:635d%5]) with mapi id 15.20.6411.028; Thu, 25 May 2023 02:11:08 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Ni, Ray" , "Liu, Zhiguang" CC: "Desimone, Nathaniel L" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH 6/6] SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging Thread-Topic: [edk2-devel] [PATCH 6/6] SimicsOpenBoardPkg: Disable DriverBindingSupport perf logging Thread-Index: AQHZjjttI6OcmUw8Yk+Se0KTLUwcYa9qP9VA Date: Thu, 25 May 2023 02:11:08 +0000 Message-ID: References: <20230524122852.2047-1-ray.ni@intel.com> <17621422F0AEB994.8048@groups.io> In-Reply-To: <17621422F0AEB994.8048@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|MW4PR11MB7056:EE_ x-ms-office365-filtering-correlation-id: 46253dba-79da-4ffa-cc0f-08db5cc54d74 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: eQDg6LWqvCa7i/liyjexLyyFR7NgPxMqix9+EOLswrwFEdzj4i3yNIXJPAj451GBYYXvb07ljpINO6AV2ovEW1XKp3ACvOEmMHCOcKtzILSSxJ7w6w9JGx9EBgLK8lTNNy7+O0gLJ/PZFcHN7pN7G1dIkFvwoOLTtWE1lglyoAM0Us+3xmYhg9SpsO0V9WoQgexy1jWTO9pqfFCR8ddczsq5xr7PmGt3ZwiQ90PsJ3T4AGOlTIpHt3hsdp2lRtbDPPUws08L/o2klc6wilZnSSgPfSPbGzRL8TWK2nMkXr//P7vMidxduWBKdCyxId5rfolD6771DF1qS9YTDJoeNEcAGxVtXrO3aGc/OIC7L5Hu8u9366G4G3sm6VYppn+KYh0gYmRMwgQGX5gIULMNUDnAwfVE3Ke8419yaJLvPSC+z4lqS+/LA0D1j7Z//K+xAyncz4tj0jVoBW7X55g+Xa7Rgm+aBDwJQh2T23lCTVsne6etTdjyTmiwgIHuDI/OcZmCwm3OVDnYFtzULlbSJ4C7KidPvu9pOhabSwUmegIo68xT8MIMhB76IfTI+JKaGwe9a8bJ4jAOtNePfwKjHftOpvQtMrpW7cT+MCO84+lqwQh5e70a7kxqlRli4Rj+1nui171ZhgP7Km5QGhPVTQ== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(346002)(136003)(39860400002)(376002)(396003)(366004)(451199021)(5660300002)(52536014)(19627235002)(54906003)(110136005)(478600001)(966005)(8936002)(8676002)(41300700001)(7696005)(26005)(66476007)(66899021)(53546011)(6506007)(9686003)(71200400001)(316002)(66446008)(66556008)(4326008)(6636002)(64756008)(66946007)(76116006)(107886003)(186003)(83380400001)(2906002)(122000001)(82960400001)(55016003)(86362001)(33656002)(38070700005)(38100700002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?3Capva1apw3JrSQwPESg/jJQJoNPd9JrIOUESAiOTa03HCG3lbfvJx7TLFXi?= =?us-ascii?Q?Abkrm/rVqlUQiBXMFZZRA8llq+HKH4Bx+6rZkGlVzUb0vK8GXZHl6EGi65hT?= =?us-ascii?Q?iBdOKEiFLZoWCuHrHQZHRzUKSKCgHs+7UIjPxHHAP/Djzrt4lZeB8kJDjnS2?= =?us-ascii?Q?LHoF6VAFnI+jXsdj4GNpvdtVag6IfVNbLg3DSDLxiGGsxxsq+J4dNT4E2bWz?= =?us-ascii?Q?Yib1Tu4GUt4N+Y1bb3NPI02s0ZL90Ad0GTmsfhzLTQnDsv72xNZuz77p1e9g?= =?us-ascii?Q?0oil2K374iFwkvVI5Cj/8VN/bgX8yOq93YHD7wHk5MrVJ3J/TOYsj1oKoFt5?= =?us-ascii?Q?Kg9MRKXWVfumlfHEyvOtWFLS0uav3ZjO6VRz/Tw7cW3c047R25sg/ZpGOJz9?= =?us-ascii?Q?Vrrg4An6qil6cSLhSfYysIZhgkd4AsWXfVSHyqNJCIZ68CaM9d/i/pkWJmhc?= =?us-ascii?Q?owrjRuInAap2jE25MDzXJg6hCveD1lXxpnmfaZwcO0hI+knQa9p81aeK+zi+?= =?us-ascii?Q?MmS2FtKHU65QWD/hIE3u05yogK2gHytquOVzl0VF7/Z/CGa2Fpb/it+oMQ3e?= =?us-ascii?Q?81nVGm1OH1ASMpsGlzQ5VAPnsOXYQmwHaenqLhk/AoUbopAk/6IZ8R/zfH6l?= =?us-ascii?Q?Ao9goP4JHqUc+ipVvBvbQJwHUoQQuFtsZM7fOvKan5oFwurUsgd5UXPNEczl?= =?us-ascii?Q?E4Yre1/WQRaX1hLBFfNsmoHxgncwAtgmGUAa28IgZ73iv1Tn0KHJJKfknJQX?= =?us-ascii?Q?dEIgduUPAPC7lDcjjlujFiHO/VSa8L/cU7mIuJWZV2A8GQsXFG/JveGvIz2y?= =?us-ascii?Q?uXM3jA/sgSzGC4k8F4JanhOSyI0cVMgSw6521Cqf3R0uiWbC6tgJJ+FQx32A?= =?us-ascii?Q?v/pUnM1dYnZB0uI4/iBTVHBCeEm2u48Bq5vD7j4uHUVSan78fpM70UjX6knH?= =?us-ascii?Q?iRLqPgnqEEqLlUbTFd5b1SgJnofXxzel5eCAPzJwItLsSt2bGodpr6BZyO5U?= =?us-ascii?Q?Q1rZ1xbKB0ZKkaDM20AodpfkDzLftMf/oudjsfHpDmEMkbKVeBQISoqT995H?= =?us-ascii?Q?aX8esZzskx+lcJNsrOgck0zwgADeBchzAoBHwLIWbc0UxdceNMU5RfB8LDVe?= =?us-ascii?Q?wyaiM0KN6FzbAtkd5ZWrepJpwvF3VnV92dNKyd3LbATXtDEv+gAn546JImKy?= =?us-ascii?Q?zf/UuE+XSMb3vu/Yu0jVbB7uR1yH3Oy5q6DNPeSDnV81GSYKyu+CTEgOOEo7?= =?us-ascii?Q?bEWEG3IrRvzYdflvMOGQ4i3QNTzmY6fF1mO/6Zn9rv+ZYurx5E0+oB1PGS8X?= =?us-ascii?Q?+uXAciaKCzjw0NRT6u5n1oE2X/RtjenyNLeWggBSv5NI26gibPbgLdL2L2aM?= =?us-ascii?Q?CH8JBR+GVzlM5BQ3W5KZYK55FE/pwyjrF2DOn7SRA7uCHs305U37181iYDxL?= =?us-ascii?Q?OEP78KqGiwd0Nz2kZPkgH3C1u0ZWnq3+/kihnSlrKUn0pIZhiCzCti2bDs8b?= =?us-ascii?Q?v7OF72kGF9JNkS7yoEiZUbg/UYxvtwsNsv3HYjqzGuENEurO5UmXp1xDphVK?= =?us-ascii?Q?cP54QW4Tmh7rYAPrcNc=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 46253dba-79da-4ffa-cc0f-08db5cc54d74 X-MS-Exchange-CrossTenant-originalarrivaltime: 25 May 2023 02:11:08.0685 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: QLiwMqnmc3a2c7VnKwtLRj6R4JCFdMkZDTtG+9js8i487rSNvOkBQ4Ez3Ed4N3+GgeZWYTOaZztgpP2am6iT3w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB7056 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sending to correct address of Zhiguang. > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, May 24, 2023 8:29 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Zhiguang Liu > ; Kinney, Michael D > Subject: [edk2-devel] [PATCH 6/6] SimicsOpenBoardPkg: Disable > DriverBindingSupport perf logging >=20 > DriverBindingSupport() is called lots of time during post. > If it's also included in the perf logging, it's very easy to use all > the FPDT table memory pre-allocated at EndOfDxe because the > driver binding connect process happens after EndOfDxe. >=20 > PcdExtFpdtBootRecordPadSize was added for holding the > perf-logging records after EndOfDxe. But the DriverBindingSupport > records are just too many. For example, SimicsOpenBoardPkg has > to set this PCD to almost 100x bigger than the default value in order > to hold all the perf-logging records. >=20 > Platform developers are usually not aware of missing some records > after EndOfDxe because those records are all about driverbinding > support/start/stop. But if we add more perf-logging inside SMM, > those SMM records will be missed in the final FPDT table because > DxeCorePerformanceLib collects those SMM records at ReadyToBoot > event. Since the FPDT cannot hold all driverbinding records, it > definitely cannot hold those SMM records as well. >=20 > So in order to hold all SMM perf loggings, either platform should > set PcdExtFpdtBootRecordPadSize to a large enough value, or > as what this patch does, to disable the driverbinding support > perf-logging. >=20 > Signed-off-by: Ray Ni > Cc: Nate DeSimone > Cc: Zhiguang Liu > Cc: Michael D Kinney > --- > .../BoardX58Ich10/OpenBoardPkgPcd.dsc | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) >=20 > diff --git > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > index b6672d1a78..6b969ab1f5 100644 > --- > a/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > +++ > b/Platform/Intel/SimicsOpenBoardPkg/BoardX58Ich10/OpenBoardPkgPcd.ds > c > @@ -132,7 +132,16 @@ > gEfiMdePkgTokenSpaceGuid.PcdMaximumGuidedExtractHandler|0x10 >=20 > gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0x0 >=20 > !if gMinPlatformPkgTokenSpaceGuid.PcdPerformanceEnable =3D=3D TRUE >=20 > - gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0x1 >=20 > + # BIT0 - Enable Performance Measurement.
>=20 > + # BIT1 - Disable Start Image Logging.
>=20 > + # BIT2 - Disable Load Image logging.
>=20 > + # BIT3 - Disable Binding Support logging.
>=20 > + # BIT4 - Disable Binding Start logging.
>=20 > + # BIT5 - Disable Binding Stop logging.
>=20 > + # BIT6 - Disable all other general Perfs.
>=20 > + # BIT1-BIT6 are evaluated when BIT0 is set.
>=20 > + # Enable performance measurement but disable driver binding support > logging. >=20 > + gEfiMdePkgTokenSpaceGuid.PcdPerformanceLibraryPropertyMask|0x09 >=20 > !endif >=20 > !if $(TARGET) =3D=3D "RELEASE" >=20 > gEfiMdePkgTokenSpaceGuid.PcdReportStatusCodePropertyMask|0x03 >=20 > -- > 2.39.1.windows.1 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#105235): > https://edk2.groups.io/g/devel/message/105235 > Mute This Topic: https://groups.io/mt/99107262/1712937 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: > https://edk2.groups.io/g/devel/leave/3759105/1712937/893644498/xyzzy > [ray.ni@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D >=20