From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id CE9F4D800C4 for ; Tue, 21 Nov 2023 02:08:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=lRPxnRWfWxrZfdye6jcUzCV3g22fHsd6Rt58k+j1z3w=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1700532524; v=1; b=AGqbjrWMq8+dSKHadvaFsopxtamUR6gKtTPeph2hj+7HgIkJ4iiY9bi/NgPgY5bXI5g93r6L 9QSdsLbHLIUPaaMbh+mlYWIcT4QX7QbxKC3peswa1i28Z3JFPCvTuS0ub74WeF7oCi7chGFz09V 9kgsgv1eYWjceHHWLmAe8N7Y= X-Received: by 127.0.0.2 with SMTP id c3xtYY7687511x3FleArKzeb; Mon, 20 Nov 2023 18:08:44 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.7]) by mx.groups.io with SMTP id smtpd.web11.25582.1700532523991841047 for ; Mon, 20 Nov 2023 18:08:44 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="13294394" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="13294394" X-Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmvoesa101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Nov 2023 18:08:43 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10900"; a="1097903557" X-IronPort-AV: E=Sophos;i="6.04,215,1695711600"; d="scan'208";a="1097903557" X-Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga005.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 20 Nov 2023 18:08:43 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Mon, 20 Nov 2023 18:08:42 -0800 X-Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34 via Frontend Transport; Mon, 20 Nov 2023 18:08:42 -0800 X-Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.57.41) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.34; Mon, 20 Nov 2023 18:08:42 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TEo2FGQeMawMNfCONCmw3cNClkvOv9wGulJJnoVIioVJydBH6PUXjNwQAgqJNf1QOiUr+hi46h+8+YPpW7+EHmf795XVy8YqbSRjdIEw2n3ZkWtXKgCGOFQxu5Vahj7IaYaUDBRfM0gQqZz7VDO5XfCPVBRyGRrEp1FgAoH85UL289/bkJsw3TmRw9NW1PS6lXeT7JNOqDoBX9kC23ZxoIb5BdAEUcZgEG5KTBgr1lhmMQLv1vb5FwpROrys4Z1HfcZ2JdW9F5PwQiK84hU5+zKEk38nzHwW4Xwiny00KESlDT7XCaoVW9ybU6U5VazZqIJT43/rN6FqrztmpBcYXA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=djWdtpGMFGR7BwVVAMCEfIJe5JUb6B4c7Ty/pAinW4E=; b=nHUK+amwLX7GeK2G/LopWsjpXA/DdydYZs1DwJLtO7vHGYRPCLATr+rlxZDkSTtNwvzmHp8Zw8hhTEn7iZqOi/WDbuBDpfju/ItwNjjskba5TZ0768Pr8TskZ5C99wS68X2HnW37DyIiMbr5QNVho7ISGyKEia26ffsdJ7x9svANp8gg0qAJSaTCVv5n6VampmIJ4I3ZuLibgP/KXCWyL7XSB06d+xKakQ7ouSsXF5t1sM61v6JyZ8Ezmi2WIth2nXrlhQfqe76gzz2rAIl8YMNmctuOUrfIo7mXsSIPkjxUrt2vHUzKzNPA6S87Ns/VgXi2E8OBEBsFiVL6zVgr+A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH8PR11MB6925.namprd11.prod.outlook.com (2603:10b6:510:227::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.26; Tue, 21 Nov 2023 02:08:40 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7002.028; Tue, 21 Nov 2023 02:08:39 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Xie, Yuanhao" Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove the duplicate loading of microcode in DXE. Thread-Topic: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Remove the duplicate loading of microcode in DXE. Thread-Index: AQHaG2SJQkO/hiRMU0uD25bcM5i83bCEBzTQ Date: Tue, 21 Nov 2023 02:08:39 +0000 Message-ID: References: <20231120034551.2018-1-yuanhao.xie@intel.com> In-Reply-To: <20231120034551.2018-1-yuanhao.xie@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH8PR11MB6925:EE_ x-ms-office365-filtering-correlation-id: 0a3a8254-9329-44b1-eaf2-08dbea36c774 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: gEGguxc7Mo9h7cN55PDzU/ZsFyxeaR4+ZTow8lGV9K7vVpHMlcPD6ojJQ150S9fDs310ydY8Mjz6/UKzQVnMRTVHFtLTg3CLDxlgmzGuL2OvY7OQtpTjC6FLFNmzMHDQajPnUR7FNcbEy3AgyXAN3uRlAaLBFtRPLTUHD/9rQg9alSvhoy40J5Ht08R1Ku6zOkTZSghETdOKhuhOKecuOZbSW+MlrnS/Is7rGgkkAojQ5rXPyFOiMPc/qR1J1sLI2ag9ReO8HC1FhHw6jwOBKBL8UM08iRk63U2HQvixfjqEedMy+KeB+ITHfMco/pnW96IySvQkS4oFau4+NeF2lKFeepi1unLKirtk+sy8ZwhgWBa//Z04jxd8q/RWoS4sBO9NvV1qO5U7HuRCHIvmyYVFyfEiuPUR5PWFdhVI+BDf3OPdRxvpfdSydk95srYWk9p2DZUdJa8N0pZfRjsjNc46gAnqYjE4ZUoNO7VMQhBZCJ9sMckyET4ytqDyG43sz4ytAqRAWO2nKeBu1y6OPpfiEhEt47yC68WJAK97Aj8pmM6uZ3ETDT5Fuj3R5m4XxKqejsqxyPOO1Khvi2Q97pD/oRGI1ceuAbp8TqpEHew/TAbxvzqRXFRR4pZZvhKv x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?A3WngOP1IgzcbhUtspDCKsBX89o8c7MSmgOIffE4GfOvBkhFad02WEP0CUtq?= =?us-ascii?Q?GI7cvj3kA1RYzG4EfvrHOwZ6tqKh88Zk/al73I97o6yoNvpG9JUzU5I1Ky7a?= =?us-ascii?Q?jats/sX/6ZATp6CAA8shj2XR8aXfAMX+bCrdnUtL3loORGrjhcVTFdAXdy8I?= =?us-ascii?Q?0oFcCt2yi2I48wUe9touRZNT9Sa0WYzwcmzW2Y8DuuBl8s1qZaYZ9oAjGJ9q?= =?us-ascii?Q?yWX4fyFUW8quLz1GMk1rjSOoc+UqLfz7L6bzhPrOhHY+TYGIZIRt4wg3y+zt?= =?us-ascii?Q?U45/lAdFnb1E33oLTlJxF3BWwOPB4Th/84J8xSE91WOYsrWuuwtwJjD2erOR?= =?us-ascii?Q?E+1J2Js2ARvoRbwatuCuEJeEhqxieWryUDA1qK8gDqr6CyPi/gCu7TKnL6zL?= =?us-ascii?Q?mPV/MEXzz3kV3Mtr++CBkZTinN0aNHb9+YPOOo3rUi+BRTFyzxqK+0mw3fm1?= =?us-ascii?Q?+QVqhlr+bbS2Xcer1EdS9C+f59dmKaOmCAfwGliUPV4KAsffRpXYvJlosN0Y?= =?us-ascii?Q?+kwswx10YtHyHMm6rVr/sqTXoNT04Lh8fAbhCTxfyJtZTObS8IGoyh4/tSxi?= =?us-ascii?Q?BgdFq42uRgPYHCUMUSQDv+3aF9/of20eOIcUXxeNtC+WG8n+EkvEjCTVsP4+?= =?us-ascii?Q?uKh+YF3jb4IJ1gm9Cd9Amepmi4Rw4W1MofwDiEygt+0af7N9OADPF6CXZmIO?= =?us-ascii?Q?3ua1I6+nWmjcxKvZPgWTcMund7Jf7FQ2EUQKOFEcgYQtmkpmtfjkUbccPCsP?= =?us-ascii?Q?yhYEiXu2VGsOyWVc7ahU0WjPKE7RIBX7iAeBp0wnMbNUm+UH5n3UOITSxDqH?= =?us-ascii?Q?iMb/gUbVjNIWMSeYnkSNPt9lZT3Gsauo2mx5qSm8YcZdgsWxn8ID15LYaqSf?= =?us-ascii?Q?iVFcfEIGZUxoVvfpP9cw0CfKI/f7Cua3OLI06vlZmrpfIYsluMh2KpYrvG5l?= =?us-ascii?Q?8UKzGH6YUmp2c2yJHV7IXGpx+RD/iYlXmeqXJN9CV9GbGD6Ov9mwW+50ixPy?= =?us-ascii?Q?nwlg6VG8KPu+LuIqLP74C5jeS2Bp8wP0DKTmtpj1A0SpG/xR63DNklqhY8nk?= =?us-ascii?Q?B2ZOCqlAjjlpEaDArdEMvkQMNmiKNEXWPbzrMP8XW14q9SKVqGZ4dYKDl5zJ?= =?us-ascii?Q?7dovympKVHg9NlxttjdgQoT6qWKAJhdILCq+Z4/qDpndb197YflBhNe/GuWl?= =?us-ascii?Q?brP9C+a9HV792PI/VH4BSu3hzFmGF0pWTY0471MOaOGvl+Te/J+M714Fzyng?= =?us-ascii?Q?pIvpnnXOoNH72PB2oyojd0W/IfVMq+K3acsOrqu95sG4URa2T7dGZRLMQ6qp?= =?us-ascii?Q?Jv4dUavERZUISv0eeIg25xh8WU5BdNoPf4ubARM6qsJic2hL4TsNZ+NqkKji?= =?us-ascii?Q?HCT3HPGyMZKqkA6HxKyF1jk+x6ZUm534xww243S5r/HShAYzzPQbl+nbWPMg?= =?us-ascii?Q?KhDtePoIs/AU+WXyMwMszXF68+SENe1L2jGF51u1T+P/jb3XWFRknUwGCDze?= =?us-ascii?Q?tbVfrVYj7IrXIBzg5xjdm94ar6V2hU0Ml5DAcoSQkuYAgSE8xan06V85TB2q?= =?us-ascii?Q?cRthUQy9MrYhN5O6hw8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0a3a8254-9329-44b1-eaf2-08dbea36c774 X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Nov 2023 02:08:39.8257 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: m/IgHxX4gVllpGKnGD2OmJWgqRmnOFAMGZLAb0RzEW76/Vks3CvDy+Gc9RggL2I4N2fObJ5Z2PawA3JXCCwejA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6925 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: QBwOU7lYl4wo8NhMYxJIXjjNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=AGqbjrWM; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}") > + > + if (!GetMicrocodePatchInfoFromHob ( > + &CpuMpData->MicrocodePatchAddress, > + &CpuMpData->MicrocodePatchRegionSize > + )) > + { > + // > + // The microcode patch information cache HOB does not exist, which > means > + // the microcode patches data has not been loaded into memory yet > + // > + ShadowMicrocodeUpdatePatch (CpuMpData); > + } 1. The microcode HOB is produced by MpInitLib PEI instance. So the above code running in PEI phase cannot get the HOB. We could simply delete it. The microcode HOB has multiple consumers, such as some code that measures the microcode binaries. So, even MpInitLib DXE instance doesn't consume this HOB any more, the producing is still needed. > + > + // > + // Detect and apply Microcode on BSP > + // > + MicrocodeDetect (CpuMpData, CpuMpData->BspNumber); 2. Loading microcode in BSP is good. Can you move this function call to tog= ether with WakeUpAp (ApInitializeSync)? I think it could make the code more readable. -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#111498): https://edk2.groups.io/g/devel/message/111498 Mute This Topic: https://groups.io/mt/102701619/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-