public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ni, Ray" <ray.ni@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
	"Wu, Jiaxin" <jiaxin.wu@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Dong, Eric" <eric.dong@intel.com>,
	"Zeng, Star" <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>,
	"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process
Date: Tue, 21 Feb 2023 09:12:20 +0000	[thread overview]
Message-ID: <MN6PR11MB8244D9CA9370F45F642FCC0A8CA59@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230221084854.ckcwtl4tt3onq623@sirius.home.kraxel.org>

Gerd,
I also don't think some Pentium processors still use the latest edk2 code.
Can you create a bugzilla for the request?

If @Kinney, Michael D doesn't have concern, we can follow up on that old code removal.

Thanks,
Ray

> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Tuesday, February 21, 2023 4:49 PM
> To: Ni, Ray <ray.ni@intel.com>
> Cc: Wu, Jiaxin <jiaxin.wu@intel.com>; devel@edk2.groups.io; Dong, Eric
> <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>; Laszlo Ersek
> <lersek@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>
> Subject: Re: [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process
> 
> On Mon, Feb 20, 2023 at 01:14:33AM +0000, Ni, Ray wrote:
> > I expect Gerd at least acknowledges all patches for UefiCpuPkg. Following
> three haven't got:
> >  * [PATCH v9 3/6] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data
> >  * [PATCH v9 4/6] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base
> Hob for SmBase info
> >  * [PATCH v9 5/6] UefiCpuPkg/SmmCpuFeaturesLib: Skip SMBASE
> configuration
> 
> I still think it is worth cleaning cleaning up and remove both code and
> comment for i486 and pentium processors from the last century.  That
> should reduce confusion of the already complex code.  But if you insist
> on not touching the existing code, so be it.
> 
> Series (for post-freeze merge):
> Acked-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> take care,
>   Gerd


  reply	other threads:[~2023-02-21  9:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <17443983D6ED8995.20300@groups.io>
2023-02-20  1:06 ` [edk2-devel] [PATCH v9 0/6] Simplify SMM Relocation Process Wu, Jiaxin
2023-02-20  1:14   ` Ni, Ray
2023-02-21  8:48     ` Gerd Hoffmann
2023-02-21  9:12       ` Ni, Ray [this message]
2023-02-21  9:45         ` Gerd Hoffmann
2023-03-06 11:13       ` Gerd Hoffmann
2023-03-06 11:43         ` Ni, Ray
2023-03-06 13:20           ` Gerd Hoffmann
2023-03-10  9:19             ` Wu, Jiaxin
2023-03-10 10:01               ` Gerd Hoffmann
2023-03-10 10:17                 ` Wu, Jiaxin
2023-03-10 10:29                 ` Wu, Jiaxin
2023-03-10 11:19                   ` Gerd Hoffmann
2023-03-13  5:50                 ` Wu, Jiaxin
2023-02-20  2:37   ` Michael D Kinney
2023-02-20  2:57     ` Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=MN6PR11MB8244D9CA9370F45F642FCC0A8CA59@MN6PR11MB8244.namprd11.prod.outlook.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox