From: "Ni, Ray" <ray.ni@intel.com>
To: Gerd Hoffmann <kraxel@redhat.com>,
Tom Lendacky <thomas.lendacky@amd.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
"Michael Roth" <michael.roth@amd.com>,
Ashish Kalra <Ashish.Kalra@amd.com>
Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned
Date: Mon, 13 Mar 2023 08:31:35 +0000 [thread overview]
Message-ID: <MN6PR11MB8244DF1A5FFD0829F427EE458CB99@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230313080020.z7vdonl4wonlp3hq@sirius.home.kraxel.org>
Agree with both comments😊
> -----Original Message-----
> From: Gerd Hoffmann <kraxel@redhat.com>
> Sent: Monday, March 13, 2023 4:00 PM
> To: Tom Lendacky <thomas.lendacky@amd.com>
> Cc: devel@edk2.groups.io; Dong, Eric <eric.dong@intel.com>; Ni, Ray
> <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Michael
> Roth <michael.roth@amd.com>; Ashish Kalra <Ashish.Kalra@amd.com>
> Subject: Re: [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA
> allocations are not 2MB aligned
>
> Hi,
>
> > // Allocate a single page for the SEV-ES Save Area and initialize it.
> > + // Due to an erratum that prevents a VMSA being on a 2MB boundary,
> > + // allocate an extra page to work around the issue.
>
> A reference to the erratum (web link or erratum id) would be nice here.
> Also swapping the order of the two patches might simplify the other
> patch which happens to shuffle around the code this patch has just
> added.
>
> take care,
> Gerd
next prev parent reply other threads:[~2023-03-13 8:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 17:03 [PATCH 0/2] SEV-SNP guest support fixes Lendacky, Thomas
2023-03-10 17:03 ` [PATCH 1/2] UefiCpuPkg/MpInitLib: Ensure SEV-SNP VMSA allocations are not 2MB aligned Lendacky, Thomas
2023-03-13 8:00 ` Gerd Hoffmann
2023-03-13 8:31 ` Ni, Ray [this message]
2023-03-13 14:15 ` Lendacky, Thomas
2023-03-13 8:28 ` Ni, Ray
2023-03-13 8:45 ` Gerd Hoffmann
2023-03-13 8:47 ` [edk2-devel] " Ni, Ray
2023-03-13 13:42 ` Lendacky, Thomas
2023-03-10 17:04 ` [PATCH 2/2] UefiCpuPkg/MpInitLib: Reuse VMSA allocation to avoid unreserved allocation Lendacky, Thomas
2023-03-10 17:08 ` [PATCH 0/2] SEV-SNP guest support fixes Lendacky, Thomas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244DF1A5FFD0829F427EE458CB99@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox