Re: [edk2-devel] [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid BspIndex typecasting

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
> -----Original Message-----
> From: Wu, Jiaxin <jiaxin.wu@intel.com>
> Sent: Tuesday, February 6, 2024 3:58 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Laszlo Ersek <lersek@redhat.com>; Dong, Eric
> <eric.dong@intel.com>; Zeng, Star <star.zeng@intel.com>; Gerd Hoffmann
> <kraxel@redhat.com>; Kumar, Rahul R <rahul.r.kumar@intel.com>; Kinney,
> Michael D <michael.d.kinney@intel.com>
> Subject: [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid BspIndex
> typecasting
> 
> Use MAX_UINT32 directly instead of typecasting from signed
> to unsigned value.
> 
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Zeng Star <star.zeng@intel.com>
> Cc: Gerd Hoffmann <kraxel@redhat.com>
> Cc: Rahul Kumar <rahul1.kumar@intel.com>
> Cc: Kinney Michael D <michael.d.kinney@intel.com>
> Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
> ---
>  UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> index e988ce0542..71d6b0c6d8 100644
> --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
> @@ -694,14 +694,14 @@ BSPHandler (
>    // Reset the tokens buffer.
>    //
>    ResetTokens ();
> 
>    //
> -  // Reset BspIndex to -1, meaning BSP has not been elected.
> +  // Reset BspIndex to MAX_UINT32, meaning BSP has not been elected.
>    //
>    if (FeaturePcdGet (PcdCpuSmmEnableBspElection)) {
> -    mSmmMpSyncData->BspIndex = (UINT32)-1;
> +    mSmmMpSyncData->BspIndex = MAX_UINT32;
>    }
> 
>    //
>    // Allow APs to check in from this point on
>    //
> @@ -745,11 +745,11 @@ APHandler (
> 
>    if (!(*mSmmMpSyncData->InsideSmm)) {
>      //
>      // BSP timeout in the first round
>      //
> -    if (mSmmMpSyncData->BspIndex != -1) {
> +    if (mSmmMpSyncData->BspIndex != MAX_UINT32) {
>        //
>        // BSP Index is known
>        // Existing AP is in SMI now but BSP not in, so, try bring BSP in SMM.
>        //
>        BspIndex = mSmmMpSyncData->BspIndex;
> @@ -1654,11 +1654,11 @@ SmiRendezvous (
>              //
>              // Platform hook fails to determine, use default BSP election method
>              //
>              InterlockedCompareExchange32 (
>                (UINT32 *)&mSmmMpSyncData->BspIndex,
> -              (UINT32)-1,
> +              MAX_UINT32,
>                (UINT32)CpuIndex
>                );
>            }
>          }
>        }
> @@ -1852,13 +1852,13 @@ InitializeMpSyncData (
>      ZeroMem (mSmmMpSyncData, mSmmMpSyncDataSize);
>      mSmmMpSyncData->CpuData      = (SMM_CPU_DATA_BLOCK *)((UINT8
> *)mSmmMpSyncData + sizeof (SMM_DISPATCHER_MP_SYNC_DATA));
>      mSmmMpSyncData->CandidateBsp = (BOOLEAN *)(mSmmMpSyncData-
> >CpuData + gSmmCpuPrivate->SmmCoreEntryContext.NumberOfCpus);
>      if (FeaturePcdGet (PcdCpuSmmEnableBspElection)) {
>        //
> -      // Enable BSP election by setting BspIndex to -1
> +      // Enable BSP election by setting BspIndex to MAX_UINT32
>        //
> -      mSmmMpSyncData->BspIndex = (UINT32)-1;
> +      mSmmMpSyncData->BspIndex = MAX_UINT32;
>      } else {
>        //
>        // Use NonSMM BSP as SMM BSP
>        //
>        for (CpuIndex = 0; CpuIndex < gSmmCpuPrivate-
> >SmmCoreEntryContext.NumberOfCpus; CpuIndex++) {
> --
> 2.16.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115153): https://edk2.groups.io/g/devel/message/115153
Mute This Topic: https://groups.io/mt/104194205/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-