From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 189FAAC0DAC for ; Tue, 6 Feb 2024 08:56:28 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=V/SALjpWXo9YGO8xfv7+T+2L4R2mhmVd6tAQKz8tbBk=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707209787; v=1; b=Z8aa64laSIr0RMrcsoJWPiLAJTShgzt3rESbDjtXdVKCdEfFRlIKqaD7oDtuUcLPU041nCR0 up7fx6u9WvjQxFpZ2cRsTv4mVL19jiGVWXO1S89VzKrccuNDIwC9fFpUbXBGJIEwRUjxe82DeQT Sed36zKcb7wwCeLClq8BO3S8= X-Received: by 127.0.0.2 with SMTP id Q5ngYY7687511x0hh1ylqjjw; Tue, 06 Feb 2024 00:56:27 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.20]) by mx.groups.io with SMTP id smtpd.web11.17572.1707209787068976252 for ; Tue, 06 Feb 2024 00:56:27 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10975"; a="395121476" X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="395121476" X-Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2024 00:56:26 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.05,246,1701158400"; d="scan'208";a="949513" X-Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by fmviesa009.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Feb 2024 00:56:26 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 6 Feb 2024 00:56:25 -0800 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Tue, 6 Feb 2024 00:56:25 -0800 X-Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Tue, 6 Feb 2024 00:56:25 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HuOZNGvH+yNrLIKO7BUsugwQJrPZ7p3IyaDnqx/RJLGlWsAyjKL/vTlIJlOmCLlZJrkXWOZ/tImy1X6wKXbdGgFaf/JHoM5nyW3BBzubX1Geyqs5/va1z1GAgMq/6hGqNk9X+88h15T/xrIh5C278a3HdRCDJFb5otP0stPdH80xlQsaqZVhcRF70RE69E+5qKuk+XzL/4UEerE7nqsCO+SsMCgJv6kAqbVNjgkHVTWGntxNOcHiZPorEh77zlBlDNs+0oZg8mJ6CuTsvF2ZIE1v7pnfwLbHQkFk75kVQpS2O+Ja3AIRb8/tW5srFfCSKau5rK1srtoj7aMcAa85Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OgFinQVRTke/Nqab0YsIgjnlHQsV5exD/4i4QF+Pv2I=; b=dpGuPWmFNt4RaLBjvVrU8NuAiToq5E9hRawOW1LsLwc9uvtlAXYit3Ovbu1iTi3GuRNx1+YZfOG5jh3w62tZ0Zf/gd4tHmcjVXkWfKoeDWo8ToCB9Xc0zBIB5iEfJQ+7e+BQ1BnVVY2ZZTwNjt06rGy1eJ+9Q/AOQGJww/QNIjrKdzMDepJT8/UDJ8WWwty57s08E//zS76aZcN+Zz6V7hCx0Fh2o95sRzL/9KPqcpoZjt2g06x3pc2uZ+YvDc7tC6VoJy0yMoFc++8jw+/oHJ15dDHuGP52m4pMFNaHuJlbBXlJ/CqahmyVDrKIs1WNjaDgd4zjr6T31JgEPn0WXQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH0PR11MB5444.namprd11.prod.outlook.com (2603:10b6:610:d3::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.36; Tue, 6 Feb 2024 08:56:18 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f4e6:157c:2058:8b1d%4]) with mapi id 15.20.7249.032; Tue, 6 Feb 2024 08:56:17 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Laszlo Ersek , "Dong, Eric" , "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" , "Kinney, Michael D" Subject: Re: [edk2-devel] [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid BspIndex typecasting Thread-Topic: [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid BspIndex typecasting Thread-Index: AQHaWNI9Rsv0t/hkJEuALqsd5H0kgLD9AwKA Date: Tue, 6 Feb 2024 08:56:17 +0000 Message-ID: References: <20240206075804.15152-1-jiaxin.wu@intel.com> <20240206075804.15152-2-jiaxin.wu@intel.com> In-Reply-To: <20240206075804.15152-2-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH0PR11MB5444:EE_ x-ms-office365-filtering-correlation-id: 9abe060e-2124-4944-97e6-08dc26f17b37 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: 5BkTV/XNteYdZ/T4OqYSTy1j5RE902ziRzFRqIR9/d35IHeOK49KaUvAHBIfN7OegtNNBq17yU176iuyh4emkJR3qHkESmULmhgX4SpJ5qOiBbKiXYjLQzfBVehHgZ0dSMudP4xRoJ4KVqhAOFVSxGDpISa5CohT5F7B6qgvar1SwixJiHaFqfEM1+fnMSDXvhn4FmpK2iphlCp0mqxBk0Y3s5zymuJBxH+ARwHn0cHFcHXIrOdGIrTNf/XRNNPclPk8VTLjTZ6SOZnHEmKPzxOWvczPXshW6/4lnVA6khhbUSgqdyEUR8GXWXGH+d0badYm5t+cbeX3WdEu2fHdRYYbLHBUkmVDNi2Pab8CRmoiqF9Qdm/D+tpuLZGk6HonEQT0wkmTBZyNgrXr4Wab4w9fbl4wowFmvEoeWG0sEjIkX1wZi8jfOtKaSSlv1Nb/oNVoy8Eo6willy4luov/ZUo9qk8ZMewoHYkg2cEtQQ6sSyI0zPtMT+VFezXFI3Pfbmtym56WSsd/yVTp4kI7hdNhLPFBd39zvnFVsA4KskW4scXe6VF2brGMntX3Jm8wZ/YDNyVMyr4Qdr6WsApUBDr2ck+s+JQ0rKeKV6vRy3NwLrlisLQA+A36oWQgp2e4 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?e8V7wtfrSBSu/0vThWii+cLLAfTISHutU9tRIUUA4vnengOGI4/mRTFVFekh?= =?us-ascii?Q?DfNsFf/zz4ulmaAq6FQMX5fT8pZZV7bl4Jp9XlXTKUO3rbrGw54VrePlvmAK?= =?us-ascii?Q?RikZUfN0aKaCVmtf+lN4Y3IFRNLQprjImHDHKSH4ts+//V54bUJy9uoTPeev?= =?us-ascii?Q?/N6KJO0cgLrROSNJeJVYQz+HUqhe/XlLyRxSZHkxXMIDlvUMSjMENU1pbqrQ?= =?us-ascii?Q?b1Qo8XvH80293W15RdAMPLn5rGeOTewcecrXlVomoWSo6BZDz0HauVZe0GIA?= =?us-ascii?Q?bOs70jmlkMJxoNWXcr+LZloF0Q0eOYE3N1TP3yYPEhPxf1tzEHmyT3cd7H0k?= =?us-ascii?Q?3gp6yhTWaszf/WY190NUvl0aTAqcLT+FYhMN4gn3cN640xQvOsC2A8Shh0G1?= =?us-ascii?Q?aeN+vvIbE99EKWXYzIT/bhLzvcZmT0TBO3em8aDN8vudVYebwZXNJH09Ikq9?= =?us-ascii?Q?+dKcBp7XgZqoXqxdNe0LQOw0RE+c4IVEes0R/RoHes8F1I3Pjyi29llw03BM?= =?us-ascii?Q?hXQ+LWFJmS3d7DpqcQxzF0cDHR9bBV0rb/OaIbG9SxJXIb5qr8ANanN52Q80?= =?us-ascii?Q?bpjc6BHji5eskjLZJl1TA9Ma9TQel2P/U0P7DlZJh34iRyVn+ynsmZDOrkf/?= =?us-ascii?Q?EWBJUOd40TpcWI9p8GNtxPZy7QJMx4YgncbXKwKHVyQyMCKkf0dsGNEsH5Hn?= =?us-ascii?Q?Y01SGYEJIOeYqT8IDibHqDKL37zN2Sgo62G2tXsGt/eZL3o3mj85vZ51euQA?= =?us-ascii?Q?fcMWCW7i8Bh7vw9ke37zWkCd/lUz5Y8glU4bG5j0WOhEkOce7I0y7S1RAC4x?= =?us-ascii?Q?V0M8owv6gVJytVFLmZX1Idn+Pr8m+GyVe/wV1ZDilHOiejyHqWx8kLMw1PFI?= =?us-ascii?Q?UWnnF3RqnwTdO/cYv/St266gbrg1ya0ZLVKyTphJAjlZgS/cJ7yUYyO7H+Jo?= =?us-ascii?Q?LWt3QZ1w6d0j19Fbu927zXlycEzuX28mh/xvM85VZMFNXAJhq2n5H5n5h0Zl?= =?us-ascii?Q?C7yqeLA1ar5fsKTCMdXcEke+7HLJmt0XO50jgfnbyTz9WQtNTpDWAyRAHDcu?= =?us-ascii?Q?5BXu/al0soHbZLWeMDBHhOn1N7NuESyBjLzhJEjbhATNS3u2Fq+gomsL6xr4?= =?us-ascii?Q?n5+kchZYKi45VKebRYMcO3DV3spRaQds3CZlN5uPkJ2/+MnzhQ2eEXwFcmyg?= =?us-ascii?Q?lXYV3n/GEw9ZKgSMTP29fRaWYwWnU6FaKdWXVbicbr7BvoNNhAyfGmH8z5pb?= =?us-ascii?Q?HlCdjpLnD0rxLqEYnvc8jiYR1xB9PNQ8qm7ouKedrVKfTITknl5+UT9YQY51?= =?us-ascii?Q?P9H/rqA9Gz1amh9eYpz8GUxpvbiMn0Pu08NFgbJ7epcAZCmbQSjdIxohECHw?= =?us-ascii?Q?o8Q3t7G95d5rC1Kd+wL87tW0u9YgFnDlb+QM4uwme2pXyLWs6O/xFwmO9DUT?= =?us-ascii?Q?gFrmeFguQrAln3rOs+yZuN/amCEcFqcm6m1BJass7B43e+KGoS1rz9fKtjAp?= =?us-ascii?Q?5FzrubtO1f6jisErHzFTaZA2S3m5r9donbCp3yVZpHod78vu8RYDjddQXPue?= =?us-ascii?Q?H4m0crrDxpQj+DvYEt4=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9abe060e-2124-4944-97e6-08dc26f17b37 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Feb 2024 08:56:17.5625 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ylzAeQ4uTRwyGOP+fQhLjfFmy95K74aRbCxVq134EezelAjs8YTdVtbtrAfDvgeEQoBFzTGnYMLmQ78hR8c2vg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5444 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ozKJkKXRXHecWqSxOgOqatFax7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=Z8aa64la; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: Wu, Jiaxin > Sent: Tuesday, February 6, 2024 3:58 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Laszlo Ersek ; Dong, E= ric > ; Zeng, Star ; Gerd Hoffmann > ; Kumar, Rahul R ; Kinney, > Michael D > Subject: [PATCH v3 1/2] UefiCpuPkg/PiSmmCpuDxeSmm: Avoid BspIndex > typecasting >=20 > Use MAX_UINT32 directly instead of typecasting from signed > to unsigned value. >=20 > Cc: Ray Ni > Cc: Laszlo Ersek > Cc: Eric Dong > Cc: Zeng Star > Cc: Gerd Hoffmann > Cc: Rahul Kumar > Cc: Kinney Michael D > Signed-off-by: Jiaxin Wu > --- > UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) >=20 > diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > index e988ce0542..71d6b0c6d8 100644 > --- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > +++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c > @@ -694,14 +694,14 @@ BSPHandler ( > // Reset the tokens buffer. > // > ResetTokens (); >=20 > // > - // Reset BspIndex to -1, meaning BSP has not been elected. > + // Reset BspIndex to MAX_UINT32, meaning BSP has not been elected. > // > if (FeaturePcdGet (PcdCpuSmmEnableBspElection)) { > - mSmmMpSyncData->BspIndex =3D (UINT32)-1; > + mSmmMpSyncData->BspIndex =3D MAX_UINT32; > } >=20 > // > // Allow APs to check in from this point on > // > @@ -745,11 +745,11 @@ APHandler ( >=20 > if (!(*mSmmMpSyncData->InsideSmm)) { > // > // BSP timeout in the first round > // > - if (mSmmMpSyncData->BspIndex !=3D -1) { > + if (mSmmMpSyncData->BspIndex !=3D MAX_UINT32) { > // > // BSP Index is known > // Existing AP is in SMI now but BSP not in, so, try bring BSP in = SMM. > // > BspIndex =3D mSmmMpSyncData->BspIndex; > @@ -1654,11 +1654,11 @@ SmiRendezvous ( > // > // Platform hook fails to determine, use default BSP electio= n method > // > InterlockedCompareExchange32 ( > (UINT32 *)&mSmmMpSyncData->BspIndex, > - (UINT32)-1, > + MAX_UINT32, > (UINT32)CpuIndex > ); > } > } > } > @@ -1852,13 +1852,13 @@ InitializeMpSyncData ( > ZeroMem (mSmmMpSyncData, mSmmMpSyncDataSize); > mSmmMpSyncData->CpuData =3D (SMM_CPU_DATA_BLOCK *)((UINT8 > *)mSmmMpSyncData + sizeof (SMM_DISPATCHER_MP_SYNC_DATA)); > mSmmMpSyncData->CandidateBsp =3D (BOOLEAN *)(mSmmMpSyncData- > >CpuData + gSmmCpuPrivate->SmmCoreEntryContext.NumberOfCpus); > if (FeaturePcdGet (PcdCpuSmmEnableBspElection)) { > // > - // Enable BSP election by setting BspIndex to -1 > + // Enable BSP election by setting BspIndex to MAX_UINT32 > // > - mSmmMpSyncData->BspIndex =3D (UINT32)-1; > + mSmmMpSyncData->BspIndex =3D MAX_UINT32; > } else { > // > // Use NonSMM BSP as SMM BSP > // > for (CpuIndex =3D 0; CpuIndex < gSmmCpuPrivate- > >SmmCoreEntryContext.NumberOfCpus; CpuIndex++) { > -- > 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115153): https://edk2.groups.io/g/devel/message/115153 Mute This Topic: https://groups.io/mt/104194205/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-