From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail03.groups.io (mail03.groups.io [45.79.227.220]) by spool.mail.gandi.net (Postfix) with ESMTPS id 25DEED8067E for ; Thu, 11 Apr 2024 08:25:10 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ct7j4/u6cdIYY2RfTeOnpJiK8NEnBfMsi3n0tcxzHi4=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1712823909; v=1; b=IkxfULc3eNc/S9DTKyVez4Noxqa+wgZVOTXhBFdAb/Uty+nrPiBOH2h9+atwGiLMJg2r8RLI pkF1FyOb9dJH/i42pazQzt5mWrwZaa6US/8TrdkiQKlFstxAgAYreVWiUCqQ1kHvlIXwh3t/eCr MKFEQ4UYcq6rnOXFZv/GGrdZMRr8Yo6ptJU/JZdi9mAB5rFaQ5Y/+KJ7/LTY+wuANKqvCv59zLl 2jVZoFQ0LejskYCAoXh2aesfIEG+WzG8iguMM5uFFyjEx3bcUIiATeIJwzCXcuJTb5JpAJI+qiO ICy6nMbsw/7J8PTaLqec0J167r1bvjJbPr6ZixxwnxWXA== X-Received: by 127.0.0.2 with SMTP id NyhTYY7687511xbQ0dOv6bWV; Thu, 11 Apr 2024 01:25:09 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) by mx.groups.io with SMTP id smtpd.web11.12509.1712823909163827146 for ; Thu, 11 Apr 2024 01:25:09 -0700 X-CSE-ConnectionGUID: vGikL+U5Q2Op7juRFAVn3Q== X-CSE-MsgGUID: kNzpAmokQxeouJ0j2K34/Q== X-IronPort-AV: E=McAfee;i="6600,9927,11039"; a="8398184" X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208,217";a="8398184" X-Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Apr 2024 01:25:09 -0700 X-CSE-ConnectionGUID: Wc9CFTO6RWuqNYWYAOF2iQ== X-CSE-MsgGUID: wwkMW3/nRLSFoYgWEpQ9tQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,192,1708416000"; d="scan'208,217";a="25484318" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by orviesa003.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 11 Apr 2024 01:25:09 -0700 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 11 Apr 2024 01:25:07 -0700 X-Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 11 Apr 2024 01:25:07 -0700 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 11 Apr 2024 01:25:07 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB6496.namprd11.prod.outlook.com (2603:10b6:8:c0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.10; Thu, 11 Apr 2024 08:25:06 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7430.045; Thu, 11 Apr 2024 08:25:05 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: Ard Biesheuvel , "Yao, Jiewen" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v1 12/13] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase Thread-Topic: [PATCH v1 12/13] OvmfPkg/PlatformPei: Relocate SmBases in PEI phase Thread-Index: AQHai08ZkydKmGYTVkOAnAu76ZaZo7FivFS/ Date: Thu, 11 Apr 2024 08:25:05 +0000 Message-ID: References: <20240410135724.15344-1-jiaxin.wu@intel.com> <20240410135724.15344-13-jiaxin.wu@intel.com> In-Reply-To: <20240410135724.15344-13-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB6496:EE_ x-ms-office365-filtering-correlation-id: e959b981-d1ef-44fb-b792-08dc5a00e452 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: o44VVLNAJV/yFEMzDj04UntJ3+ShRsHU5ODfCkdeAfRM85ASj5Rg2sbVb6lQZz6P+z6LKAaIsD/i3H27yyG3sWNhMNenMAb/SKYTYdcSLvRFKhea718irJgc4CURlq//vK9ZWaoFE6iIloADqx2BOMLzwcy4/D46V2JkubJSc0CACkoZU47+Ugh+/KOTH+8alI0XmfIFjXGauHXiBDdtgVfKguE9BHDYk4NOPb5i7G1r3eEnnqKmIbMkQ/BCxmUXKeYm8cHHd8CXik5dkSU/r1VSa/ebx07fglyuWdQqMRnud6VRj7A6igwB1SxyAC12AILxw5LgOryMkkMSxZrC6m4oPSpGKuXRwzijrhJg5QG/Ut0wKsquhBDmT8v546EPnACGYkjRCHSEJkqfaQtcI3WDY9f/S+X9tYErLfB0QXOJiXVRHWNSC7WibiiMtuV2wy0aRaxyDbSYPR+nl1dU0zz4rOun7o/55hF3F9jjcbA586gO1nXfC1XveccDQOsetxhlD8y3ysnWiHvdSMxqWHE95znxt8fh9avqwdBvJetRAJJeFI5pe7M9Fxvu1Vgbd3Ou5QysnOAIu8T3ElM2UwnneArzhoc1mtyNinpu3Su/RaqYYEjDKReJKXOUG8T6XtiC1qITpiMa66zAR88GYo7rTvAQt3Gi4HIDYZgDVvKePrM9PcyU2DeOBvNM+fMLw2GlzeTr27jwppZvmBxBOZltvKpiTSYgyJl531+dzNA= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?iso-8859-1?Q?g9HoNkYvfd11ze3uv4iHVzekMx8vYBbVXwka8MUIMZVC/n4C+mDnlv+q1k?= =?iso-8859-1?Q?CrnpZtrqDAqy7wQnZz8xemLhnyQNMpqCCPNEUBa6ntSJNjGS0Ub8le6RQJ?= =?iso-8859-1?Q?Wk+GhhvvYQCLICaFQExsTPbwU4beiNnxqHjU8+b/mD2321Qv/tHZLByJQS?= =?iso-8859-1?Q?d2wEgQTDXnfAzvz8a2r/L7bbQD7yd6xgq7QfFlyPNT17DAPSCnjVTw/STD?= =?iso-8859-1?Q?NECffDgmvHCwVfFvu5oMVOetO/XcJRpY8gs0r87dwJHbnxg7l2E4wHkl1c?= =?iso-8859-1?Q?E8TDFEDT2blcGIu8M306sREBw26DaXKPpcEkiFWX/j3dvJDma18S5X7jBI?= =?iso-8859-1?Q?UDUel0vze9SHFz440K9zVaeGYKYqFn8an4owmACEzEEdwGwGYZlcuTZFtb?= =?iso-8859-1?Q?MLtx691u1SlV59y/rr7MqC0lQj9mQBqTPwLGB8qQmJy5tq8TVvLk6Yu8W/?= =?iso-8859-1?Q?1Yo84KlDKsIvamwH/tR/YrG/l/13i9szhjo4y38zvmL9gJJuCDU1APdHpc?= =?iso-8859-1?Q?gdHTU1Z9pSZsD8y57nm6vNNZ04G4Xz0jGT6tkilLDmG1CfZ3DwydfVx4qP?= =?iso-8859-1?Q?UvBWHYUYER5V86LdWRp7mooGf+4B457wNm41f8yNZuJJlFpeng5K8SJJDv?= =?iso-8859-1?Q?6/XRiddxNOaiWDX9FRI3AI9/6QC9w/+wV6YejODh0QFBaVWVBbU0hyplp1?= =?iso-8859-1?Q?eOGK1jDxpqZXIB9iTswLDjx3i5yuHRZsUpTrK7jfpfLW2BmoIj3iC7aWka?= =?iso-8859-1?Q?EDbcwOmNNeghLq0Zy1JCxJbmF9Qlb+4uJBryg4ssKXI04I9AAQmzFA01SR?= =?iso-8859-1?Q?JF9sooPgIeRSQRdbBF8EiCt7tHM05uh0FynrNfPL2UZl7jH1Cce7I+7gHR?= =?iso-8859-1?Q?xGqD8EOt7vyG7x90ZYzN18Eu62ZVSVxpk250sQr+xjpln1PdaQcR4ZGWsZ?= =?iso-8859-1?Q?mOyJjliLdyoFRqBsNxZtAl9dsU5Qi5yhlgp9E5IZEdxkvSDkuvGTCanFgI?= =?iso-8859-1?Q?XjRmvEIJjJAV4nTq7kYyZMy/l2QBrNnp6jHqUBv3qMamc8z8Q7sFRuD9DS?= =?iso-8859-1?Q?S9A+YYcfqQvgVVEgfmAuRfnOwddSa+mHvXveq8U8JqTgy5tIDkGHqoZzbL?= =?iso-8859-1?Q?V9fKqOyzjV5O6md7L79bVmfAe8ydvd+4qnGC/X+LNUO02Gx9UDS6UjlC7d?= =?iso-8859-1?Q?DPO5gmdjxYT/6ZabQ+IraKM4sZsd7txbczwxu+h9BCgDQbauVD4OtczRci?= =?iso-8859-1?Q?UJ4Yvce7J2enOn6J4arI4S8zMZP6g69mLpCR5BSgDkDcT27lD9GbTz3Qs6?= =?iso-8859-1?Q?KtfqdIwAPvmpxk5BowLZg5oM0n1gZLTIkY21F1zO614X1Pw73x7L4WGhkx?= =?iso-8859-1?Q?Ttjuw/5Q/5DzHICx1ehjs/ESgobfRv2GN1F/CL9phHZEalAJ3xoexo/JMo?= =?iso-8859-1?Q?HUQfuj3dN6wOilMufmyj8OYsh947l1Hx6hbiJVbG4V8435P2fNo29UefdL?= =?iso-8859-1?Q?RRLRS9QQCqTrkqDDI5XRBM/9PKfA8x/W4XdcmRyy/9g4Tk7wLt/M5NZftj?= =?iso-8859-1?Q?DCBbiHQqjdEbGb1kof+QkWp12M6ghtfa0BjWXHRfbKKmWCLgsZGnG9yEz/?= =?iso-8859-1?Q?ATK3XoFB3l4tM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e959b981-d1ef-44fb-b792-08dc5a00e452 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Apr 2024 08:25:05.6524 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: byQ+W7zDomKCJdUsELLGMo3I9GV1En3FAvKgcXpXouTNePf/A/gWYEwCqSZEQ6b18nbLgaYTeH1e6dqjY+/aWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB6496 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 11 Apr 2024 01:25:09 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: YNdTSsx2ir5JxgVR2gIpl4p4x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244E2F33BE392669010BB1E8C052MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=IkxfULc3; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.227.220 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none) --_000_MN6PR11MB8244E2F33BE392669010BB1E8C052MN6PR11MB8244namp_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable +STATIC CONST EFI_PEI_NOTIFY_DESCRIPTOR mMpServices2Notify =3D { + EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK | // Flags + EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST, + &gEdkiiPeiMpServices2PpiGuid, // Guid + OnMpServices2Available // Notify +}; + +VOID +InstallSmmRelocationCallback ( [Ray.1] This function name is confusing. It's like installing a callback wh= en smm relocation happens. How about "RelocateSmBase"? + VOID + ) +{ + EFI_STATUS Status; + + Status =3D PeiServicesNotifyPpi (&mMpServices2Notify); + if (EFI_ERROR (Status)) { + DEBUG (( + DEBUG_ERROR, + "%a: failed to set up MP Services2 callback: %r\n", + __func__, + Status + )); + } +} -- 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117625): https://edk2.groups.io/g/devel/message/117625 Mute This Topic: https://groups.io/mt/105442006/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244E2F33BE392669010BB1E8C052MN6PR11MB8244namp_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
+STATIC CONST EFI_PEI_NOTIFY_DESCRIPTOR  mMpServices2Notify =3D {
+  EFI_PEI_PPI_DESCRIPTOR_NOTIFY_CALLBACK |   // Flags
+  EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST,
+  &gEdkiiPeiMpServices2PpiGuid,     &nbs= p;        // Guid
+  OnMpServices2Available       &nb= sp;            = // Notify
+};
+
+VOID
+InstallSmmRelocationCallback (
[Ray.1] This function name is confusing. It's like installing a callback wh= en smm relocation happens. How about "RelocateSmBase"?



+  VOID
+  )
+{
+  EFI_STATUS  Status;
+
+  Status =3D PeiServicesNotifyPpi (&mMpServices2Notify);
+  if (EFI_ERROR (Status)) {
+    DEBUG ((
+      DEBUG_ERROR,
+      "%a: failed to set up MP Services2 cal= lback: %r\n",
+      __func__,
+      Status
+      ));
+  }
+}
--
2.16.2.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117625) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244E2F33BE392669010BB1E8C052MN6PR11MB8244namp_--