From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"abner.chang@amd.com" <abner.chang@amd.com>,
"Wu, Jiaxin" <jiaxin.wu@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Zeng, Star" <star.zeng@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>
Subject: Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE
Date: Mon, 16 Jan 2023 05:38:23 +0000 [thread overview]
Message-ID: <MN6PR11MB8244E7172D52338C941C5A508CC19@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <MN2PR12MB3966EE123234F721DB12937EEAC19@MN2PR12MB3966.namprd12.prod.outlook.com>
> > + //
> > + // If gSmmBaseHobGuid found, means SmBase info has been relocated
> > and
> > + recorded // in the SmBase array.
> > + //
> > + mSmmCpuFeaturesSmmRelocated = (BOOLEAN)(GetFirstGuidHob
> > + (&gSmmBaseHobGuid) != NULL);
> We can have this code and mSmmCpuFeaturesSmmRelocated in the SmmCpuFeaturesLibConstructor so this mechanism
> can be leverage by other vendors.
Abner,
I guess you found this logic is useful in AMD flow.
Let's keep the current change as is and you could refactor the code later to present a full picture how AMD flow is like.
Thanks,
Ray
next prev parent reply other threads:[~2023-01-16 5:38 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-13 15:30 [PATCH v2 0/4] Simplify SMM Relocated Process Wu, Jiaxin
2023-01-13 15:30 ` [PATCH v2 1/4] UefiCpuPkg/SmmBaseHob.h: Add SMM Base HOB Data Wu, Jiaxin
2023-01-16 1:39 ` Ni, Ray
2023-01-13 15:30 ` [PATCH v2 2/4] UefiCpuPkg/PiSmmCpuDxeSmm: Consume SMM Base Hob for SmBase info Wu, Jiaxin
2023-01-16 5:21 ` Ni, Ray
2023-01-16 5:52 ` Wu, Jiaxin
2023-01-13 15:30 ` [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Wu, Jiaxin
2023-01-16 5:23 ` [edk2-devel] " Chang, Abner
2023-01-16 5:38 ` Ni, Ray [this message]
2023-01-16 5:46 ` Chang, Abner
2023-01-13 15:30 ` [PATCH v2 4/4] OvmfPkg/SmmCpuFeaturesLib: " Wu, Jiaxin
2023-01-16 8:12 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244E7172D52338C941C5A508CC19@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox