From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web10.160064.1673847518740144850 for ; Sun, 15 Jan 2023 21:38:39 -0800 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=G5YAHfWx; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1673847518; x=1705383518; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=2/DsdTfCk4m+A/e8iSV9VQs18iNGsQ+6TLqgjjAAJWk=; b=G5YAHfWxwfgKWl8NlhM1wtudybELw3pQcUf6ulIESf+a2EQaMRYAdrFq dcTqrMB5q30QM7Y8MGPV9bN8Ixfjh0gnrmg6vZTtPZbcjghuhVWhnUkDC 5pEP1phj3ZxArSH48A0HRNjn2a+xMnKYpxjOVXrNQzOkGHP18higx84D8 3Sx32QAhQTKyeBP1I6rllqkkqujPPhRGzEMW2ab12hsToZ/C28WrGVnYQ uc2PssoZqp0pa38Qe3syuglY+ot7Wal8hUhkEbg2lupWt8FNwgbmL871a T2dRlmx8QPNK9yJiPeXSmy3v9k4D+T+K8KbGIQ/cddYP1O3egeplSaVxp g==; X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="410636350" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="410636350" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Jan 2023 21:38:38 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10591"; a="782783577" X-IronPort-AV: E=Sophos;i="5.97,220,1669104000"; d="scan'208";a="782783577" Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by orsmga004.jf.intel.com with ESMTP; 15 Jan 2023 21:38:37 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16; Sun, 15 Jan 2023 21:38:37 -0800 Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.16 via Frontend Transport; Sun, 15 Jan 2023 21:38:37 -0800 Received: from NAM04-MW2-obe.outbound.protection.outlook.com (104.47.73.172) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.16; Sun, 15 Jan 2023 21:38:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lOctEgqiDWClWKv6g3YK98v6Sq1Om2gEIdFFx4ZtfwNngSgcsYMtO0TdKbNkuBA7H5Ytw1z0HoLi2g1y4bSm/fK5CNDhnNdhqWfeSATjtbEFPZDgoUXpaQ+VhLzbur/ZcJ0X1WNK6A9Mbk8rrrxdfpBdT5eBbGMztGs1wPZ6M+ItOnXVCWiWUF5reSKpZBjOprJsdb3kGyWPgVdErPygtOq+4y7WeoIWa451I++uQ23N2gQTLSZC94l/q7bHMBrtHWJ0t0hlltJk3hycj9zx0EL4PWEUE3yGs/hgdnUG+3/dHKT+13kNOrsqY7EqXkO1bhtivjQ4o4j/cLVZFhAVHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/tfeDP34+Rprye2ojM8ZL749A491YgnihmeIiH+UMcU=; b=Ae+xKe3O7STz9LDKljwge76AP6E5yYPluDTQ+ltywUaFn8yrMR2zW5qj+zZ63Dnk+oRZMuFBmL0aYGHZyGYZAiElrBpkKB9hSvgLPfJiClS1+bLXRFhZQxZDkSSvjt59UJ2RDYHKAbRRMUdZ2BLzbrP9LDcb2hZVR23oHOC4dtPzdTw8iiWKVHlPiO/1VeswKjo2ZsTZs1jpXTRhljr4nytk62+GJwUMWLjEctqnfqNDqKhza16tVOsaKzioQotC3Vb/VtpOGNiIasSqu5f80cyiMToteThX2uley+ri/MxcdfmfttFNgrJrIYDpqbCe1XeQ1I28eU/oQb7MJabuKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH0PR11MB5612.namprd11.prod.outlook.com (2603:10b6:510:e7::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5986.22; Mon, 16 Jan 2023 05:38:23 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::f890:e4ec:e2d8:5831%3]) with mapi id 15.20.5986.023; Mon, 16 Jan 2023 05:38:23 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "abner.chang@amd.com" , "Wu, Jiaxin" CC: "Dong, Eric" , "Zeng, Star" , Laszlo Ersek , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Thread-Topic: [edk2-devel] [PATCH v2 3/4] UefiCpuPkg/SmmCpuFeaturesLib: Skip to configure SMBASE Thread-Index: AQHZJ2QK05JcKz55Ykq2lfij99LDWK6ghoiAgAADneA= Date: Mon, 16 Jan 2023 05:38:23 +0000 Message-ID: References: <20230113153045.13060-1-jiaxin.wu@intel.com> <20230113153045.13060-4-jiaxin.wu@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Enabled=true; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SetDate=2023-01-16T05:23:24Z; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Method=Standard; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_Name=General; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_SiteId=3dd8961f-e488-4e60-8e11-a82d994e183d; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ActionId=d40d9736-64b6-4145-a2dd-d80de2ca4b66; MSIP_Label_4342314e-0df4-4b58-84bf-38bed6170a0f_ContentBits=1 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH0PR11MB5612:EE_ x-ms-office365-filtering-correlation-id: 0e17b9d8-ae37-4a34-4300-08daf783e256 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: tCqRYqNBMzuEF+P2pIWfCt1ANdQs7tbJHUWY1dt+iXb/c7w2YwC1HnheuKbK05DkURcE8du7A/jnwjdpBQXz1AUrcl3GPY2wY2XOrE5pziCfOTlYxN7LU4+gA2J6McpPSE8TpvpzpNivVxR2Dl2E8PnmSatGivqSAy1TYSV4Q1JKcvY4jXO+J7w3frZ1g508Rc9tl+HzoRTf3qi3vaX/b9pejLOdQ7to45TnIks5P1ijavsqEMNoLWXcKJW1kZupsWhtX9CXWgGnabLprO7JECvXIfPjnlfnv8l8JPd3BJhoOMkFZDNYGWQrxEg9nxVD1yztQ3xwwl7TB1OWtB66gaq0qovNiynL7KlT6FCl0y4xSsXxe1fRhXKDbV6fkGraWkF4hX1F6bEwEXvuA15wBVUuFHvmdfM49gHppodHTOhpbug2u3g/VGwvZH6lLpizXaVcyVDkqFdHI+eVYmaMU3n5ARw0+NrvS/zEG9gAJDYRIYaaQzgLZJP6nGeWKBNazQ7BrtdBenvx01tLuzqDQDsn9W+66zf8n5ZjGN3NLqq35t79sOhLvrvkxpFQknzdJHRweb/6rr37Q8Oo0vgKBGdNH8zXNOcgiyNVqib6YsEFkzE/JE9qTOwsdyJfsisIUqG8uBhxCXTv0kmABl2iTFOsMqGuatlVFUrumtSTqixe6dfy4Y0Kb/G3ZlisM+meW0FXWziYP6LW1dAbyol7/g== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230022)(366004)(136003)(396003)(346002)(39860400002)(376002)(451199015)(71200400001)(33656002)(107886003)(7696005)(66446008)(478600001)(8676002)(64756008)(4326008)(76116006)(66476007)(66556008)(66946007)(41300700001)(6636002)(54906003)(110136005)(316002)(55016003)(82960400001)(38070700005)(38100700002)(122000001)(6506007)(26005)(9686003)(86362001)(4744005)(5660300002)(186003)(2906002)(52536014)(8936002);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?4l887UuIeRi7mLAqNsY8/NR0ep+/Mu8RiM/mfDvPe7p3Mr3IwAI9xgzMnNyh?= =?us-ascii?Q?q5BSJuGV3ixUHJahf0XQwxCcQH4dNmezhp7WB9o6BQ4zOWgUgf0pmkcb2K7k?= =?us-ascii?Q?cZLJMTzKpCMV0UcYd7XfRSofTezuDDO0LwnTd1k1imQZE+jdjhETaR+/vQ+b?= =?us-ascii?Q?HLEeRoAuPFT8TnRmy9j+X+Ekj/RWRla/6NtIn9fTIgE5DO7ByIfdj0IGvwhB?= =?us-ascii?Q?mgKFBRHGh4eS2gArJMcF/jZfbn7BR8ugNA/XY6zhiwAOt2zFDdzk/LgnbkQ3?= =?us-ascii?Q?qyGtB31JNhJqLHqpkotzsMacfpRvixHaCf/7Cs9gZ15a9KP5JGikwZ4G4RHL?= =?us-ascii?Q?/dGp5s+64Wuhi1Jb+h96WCZiFGWn6atFPMNUcbyRTX0I/oE8/0ragDyfZM9C?= =?us-ascii?Q?C5SyiT9/9pCyK4dXdCcwg3YkjvOg2kzbdTX3UFF1voAoyeCpUlH4zs2pBrBG?= =?us-ascii?Q?FeyU7h7FdnFYSGswQoxQnlcftWnXoAScAQs/doptCNw9agxLP8AVxOZJioGb?= =?us-ascii?Q?aYm9eAnob0r3R3oL8WLiq0xMH1eAkYF5yc9Tzxl3xC6+1xTCd7Qfbr40S6BN?= =?us-ascii?Q?u/DOqGseeN5YX4BUPRPVJewgyDEVtZ2fuMrSDO7Xq5IR3D7QqfwVlOtyfkcP?= =?us-ascii?Q?Xo0flR0Am5POnvE60qyqGVfE9XaNIaNPLjdOtY6NO2xIp7GPBQ8m4XoHcDpl?= =?us-ascii?Q?4arNxzbX9Ih3xf3mlMpjuNCiBuNBZ0erZ7R6eOIsB8msDHbnTgXzz0WNBSWu?= =?us-ascii?Q?Si/JS6+o5K+LztHRfUuAZ1SWnNWJT2JeKFEQ6J+ITgGrtTj5tiWTY3aPgD11?= =?us-ascii?Q?z83SeMZYrfjNE4b9CI/cTXrxdEFDK0XqFj/tTWaLdOvLuX5SY9aLVQfwuQ7/?= =?us-ascii?Q?NCZiNsda23/9YaUQEVvKRUKpZC69Vsgs6tgCwrEInVcXXY7cfmW2zkt9z1g9?= =?us-ascii?Q?qNGm1mYS+sMuRUqclep8Er9uAYYXalWJO4HNugJ0GF8fLaDKE/prKCqVzkfz?= =?us-ascii?Q?KTcgBM3/ndTY/K5hx40JC9YplXoix0gekpt5OOiUEK36IznZWioDOiiNV9R7?= =?us-ascii?Q?BknPipKsApa055vV5IJMDAsqEjtJS7xXmPcfRf/+TEkDz13EOf3uiCBTaqwz?= =?us-ascii?Q?IE1HY5FHNQFrNYNIOIOKJ6RKY2F5mEiwn5lz7g5cnQkJh/tqHIBEQpcRSNf1?= =?us-ascii?Q?cnMaBxvBvcntO4CSkmnjOL9lX84NnR+q4mWUZCfRbds51Z+z1yzZC5wzqaTE?= =?us-ascii?Q?5Np8RfkwUYF5bZOKcxzWWKCi0zRnudSQ/HbDgHD7uhp6wuGF6G8x+xOij/nH?= =?us-ascii?Q?wNsGhDRRecoSZoHZyQreYZ2l8MG01IqLD6uO1kubK5HS8o/PTnTQYo5v1dHR?= =?us-ascii?Q?00H7mg3UljKZ/npj5jp3jJcg/3YeFliKDHqFsrto5ehxiFJDzXydLfW0iXZs?= =?us-ascii?Q?U+LXsi6cFpuwbMSZxiKQ5jvt6Sm9A5Vgf8AIQjg2H8SXq8RTje6PE8uZD+ut?= =?us-ascii?Q?m4tb5vKvdZfRqVwlfseBkbgrANQYocYVvmG3WPrxKVCPGfZEWWSrPy5E1RPD?= =?us-ascii?Q?hq4CKlpgpYvkN3eox8s=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0e17b9d8-ae37-4a34-4300-08daf783e256 X-MS-Exchange-CrossTenant-originalarrivaltime: 16 Jan 2023 05:38:23.5801 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: E1XJ2jqM0Jlenl3xmBZmRS9IjzYgk+qirm82RZUad4QObVDudSZrvcqfX+R+rwWsVrN3X50KCQdnvO2RkCCdXQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5612 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > > + // > > + // If gSmmBaseHobGuid found, means SmBase info has been relocated > > and > > + recorded // in the SmBase array. > > + // > > + mSmmCpuFeaturesSmmRelocated =3D (BOOLEAN)(GetFirstGuidHob > > + (&gSmmBaseHobGuid) !=3D NULL); > We can have this code and mSmmCpuFeaturesSmmRelocated in the SmmCpuFeatur= esLibConstructor so this mechanism > can be leverage by other vendors. Abner, I guess you found this logic is useful in AMD flow. Let's keep the current change as is and you could refactor the code later t= o present a full picture how AMD flow is like. Thanks, Ray=20