From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id E773CAC0BEC for ; Tue, 30 Apr 2024 05:33:11 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=Qg8re6TuwmrpfD4d31sX16RAqk3LFyDmaZ3SxDSljMc=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1714455190; v=1; b=gc29JnzVuJpJmIZK0fmCHtHAj3RR8tm4XdBvPUkxhUkeqHmtBRWbiEpGL++FepwN+EGcmTMF 3SOP+262Wy4kacM7UxveEYPqgSd3R+ZGSmpqKmswr+/fRI1P+SCbxVkZ9IftDhbWFes8gRJANOz XH05cecKOewWZ8PcOpY7a6/sM1GhvzclJLNNAeTCIOnVWP68JYv3lLC5ZVlcahIEi99w8m+naVJ 17cwsEn1DN8GLGMY0r7rjbg+0SBuV3NOnNr67CAnkVvrysQoBSjatWMgcvBAfA+mG9+uM1KEfiN Rd/jk1hEXF1IG3Z7KxI/T7XkVuiMd83IYgVLn/1k9UQLQ== X-Received: by 127.0.0.2 with SMTP id jLb6YY7687511xGtohMYfA6u; Mon, 29 Apr 2024 22:33:10 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.9]) by mx.groups.io with SMTP id smtpd.web11.8396.1714455189662652594 for ; Mon, 29 Apr 2024 22:33:09 -0700 X-CSE-ConnectionGUID: rCkw1acYT06nPpSY5UV/VA== X-CSE-MsgGUID: Qf8x3XaUSEu09eIo1vue4Q== X-IronPort-AV: E=McAfee;i="6600,9927,11059"; a="20828067" X-IronPort-AV: E=Sophos;i="6.07,241,1708416000"; d="scan'208,217";a="20828067" X-Received: from orviesa002.jf.intel.com ([10.64.159.142]) by fmvoesa103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Apr 2024 22:33:10 -0700 X-CSE-ConnectionGUID: OmC8DQpVSDq2xhmZWH8j9w== X-CSE-MsgGUID: V9cL7xrrTBqQx2g2PSdYKg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,241,1708416000"; d="scan'208,217";a="57217443" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa002.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 29 Apr 2024 22:33:09 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Apr 2024 22:33:09 -0700 X-Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Mon, 29 Apr 2024 22:33:08 -0700 X-Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Mon, 29 Apr 2024 22:33:08 -0700 X-Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.40) by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Mon, 29 Apr 2024 22:33:08 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by BL1PR11MB5253.namprd11.prod.outlook.com (2603:10b6:208:310::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.34; Tue, 30 Apr 2024 05:33:06 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::8774:81a7:c5b7:5c2c%7]) with mapi id 15.20.7519.031; Tue, 30 Apr 2024 05:33:06 +0000 From: "Ni, Ray" To: "Wu, Jiaxin" , "devel@edk2.groups.io" CC: "Zeng, Star" , Gerd Hoffmann , "Kumar, Rahul R" Subject: Re: [edk2-devel] [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport Thread-Topic: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSupport Thread-Index: AQHamfaH/6TJB3yQSU6gDLEPwRoyqbGAS8BG Date: Tue, 30 Apr 2024 05:33:06 +0000 Message-ID: References: <20240429053140.3400-1-jiaxin.wu@intel.com> In-Reply-To: <20240429053140.3400-1-jiaxin.wu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|BL1PR11MB5253:EE_ x-ms-office365-filtering-correlation-id: 028fdf87-22c7-450f-f0ea-08dc68d703ab x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: =?us-ascii?Q?gv5QHILMB+0MWRfZcObOxCEswx7uwiDqJ6nhUxdvZY85OlfbE4yR+2bT8iUr?= =?us-ascii?Q?AjpCkXLdG20kL89nSILj7U+JfkZCZ9aSEnEe13QUh1kVnwdomJ4JLPs/qWS8?= =?us-ascii?Q?TWDQv9mbw57HGkeEnxjjwFhvELjyxJ6daxejLHDH663wTe6kvMxRfRch6HS/?= =?us-ascii?Q?oCmPMlMF4FlufEmzhQd3XivFbNUhn8Yh8wyC1/v4V2NOL4vBkuocEzt8/1pZ?= =?us-ascii?Q?zfczO1WiK+y3H3ywAGWSicNFYHKy62/53yM5y2a0grs0oFwSVsQkya3YyMvc?= =?us-ascii?Q?X5XdNdg2tP+fsOwYG2grGTJni4Epdy8h+S1lxpyZI6npcPCeoT4qI0V3F8qz?= =?us-ascii?Q?rvijfFj6AmA/rbMPjCCfOYIo5teafucHMwECWgT47Qi1Hx5KvjEM0W0TTi6J?= =?us-ascii?Q?KrQYL8jcwkEhMIy3mn4NWDNffkzLi1skQewx2ABUVfS6a+IUR15daseB0GBv?= =?us-ascii?Q?W0FlMDUfySF3rcUKsFnhCEWs45HW9EbEp5XUSgm0FKyweEDNyErddgzqquBP?= =?us-ascii?Q?14/ONQ8SNjPZZqWf2BH6NBa3uxynm4mkFQipDSgJCOO3wUyae0sMYt7h7D7B?= =?us-ascii?Q?puXexN/tZRWpLeuqgy60L4jHKRW7XI++ZWo5HTVKJdQGzOigvXAT754pMvoH?= =?us-ascii?Q?D9oUKBbS4wUZir3Z6dbfNNsUViPu4EaIStWirUoGbRlbhBESvbSjHAw0592q?= =?us-ascii?Q?6To5L6WdzmkFem0qdlS3vFcWgQ9kTIPOLK6D59UixmITFomvhDSBtbbVp/Zs?= =?us-ascii?Q?g0haMPTR6/CW5oEahI/vv99O8Ddyjdbtyv5dq400U/Z268dLiTGe8jK1uH2u?= =?us-ascii?Q?C5w2H5tJC+DOZl5doZ+aFBRXZcPjYzPVsRYoSo+dutpvl6/pBpF+JBmhDtfk?= =?us-ascii?Q?njVaUimvmhHLOkMVaGA6/5Sq4zdwB6J83XvVuJn0vc/QVmeRnl8MxDd1vUY+?= =?us-ascii?Q?pXChHgUF6Zvz0dHtiM2t0O93HbYeCkugBWlOZZnrcsbxajE0AM70fYYJOwpu?= =?us-ascii?Q?UYJuoP4F9BY2q5fXnxs2G+1DoFpp9s05FZpolsYG8/l63T/mk0PXtzFwWrVH?= =?us-ascii?Q?+ntcQNgRwqQ40u3zoBaAqG36U19iVWNZ0pdaq4EScUthjV64/3ya8ydxiZVi?= =?us-ascii?Q?kKxKWFPbH/r+0ZHBfne9bc/8v54OAN9tW1Nr7jWEa5o5di0GAVCgIQGGSNBx?= =?us-ascii?Q?9zGmQQwPrvZtELhfhYHujUUxBuGFw4umFN0EeCKFAaauDjLpMz4ggJD//j0k?= =?us-ascii?Q?TogHWXbAUO+nw9u4Vz++DI9oLGT60+KrRQS2rXv3Uxt5nrfNy2+xvOk5kNau?= =?us-ascii?Q?Fm/bb0mmBHOdaf1nEPcjMoqEci1DJpshypeT4TBukNfsmg=3D=3D?= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?xm1lu+A76oMokYmhDeBIO4hzQ2aBuIEL2QgSJ8v2DSw1rXdg6qwMVvmPuc/V?= =?us-ascii?Q?tVCPjFX42GdoVwgUShm7ds0sltebuc/kxDB+i26inB1xC6RCcuRS7lQz7nDD?= =?us-ascii?Q?ysSR93TJ93A8xRh+dZbbiLLwgW4t9lXMjCpdjolopXcsN6j0ae+GS2Bcek8F?= =?us-ascii?Q?kcI2J75BfXL4gOXMcPMXsNEOVs70kZ+46Npcm9X/cLryQ+g2rtljp/PLm5KT?= =?us-ascii?Q?XJ+tfiBFob1qV2dVJLx9cLi1QOU6c8BMuy9EGuGquis1zsIpYSwjQjpw3yeI?= =?us-ascii?Q?0dPgtMYV4/7gPlA737Cgs2ySBGyvOOhR8n2/6WOzoL0Q58eiig4CTarHm/9q?= =?us-ascii?Q?xuU2uYMJkPABtb5/Rs77bxKqy5ymezWjH0iHr+UjGw16GlOOFGYn5d7NXnlP?= =?us-ascii?Q?lCYno8+r9NRU77b4Y25PvJj1PtNEYG80qIxojxi9fmnLzZXiSaqpyMjOqctF?= =?us-ascii?Q?4H0FZdOfKhflCF6s+v0maMndosZoaGMQqzB6EwQq51s9Roa4Gss8VTS3alyT?= =?us-ascii?Q?T4R29AgVhCdavsiwz88Z/KPi7FHV6ClSe/Ba7qJy9qR4e/u2UEeURBwL9TOW?= =?us-ascii?Q?ogLKESziOKVFKJCPFs9K0v4gi75KFJuCWlok/KwgxxceqpnfYfeBHGBDC+SS?= =?us-ascii?Q?n+Pf0x0ta66wFBt4k1MSM0qqIipqL1fb7xGgmhDA82HhSeicyjpIz2/YDI1m?= =?us-ascii?Q?dAPWoXoZ1R54FTzV+y7B4XldvjNevu3oKtn8fi9rTzIXJEXaBa6j0BKiDGAE?= =?us-ascii?Q?nqQyS1XHQpgM7pu9soy5AXT149VW047JC++I04YA7vyI/9zsgp+ADQf7LuCP?= =?us-ascii?Q?QYHPbsj6+GPL/xzIvsHZIF+xj7pc4w6AeWl4XtWY7QxAdmgt6/aWAHrSh5QY?= =?us-ascii?Q?JRfvR+/zkBmEy6/qwSPxbKiOlT1XfMGD7nEA0kRsKEHEc9jF8nkOqEKb0T1D?= =?us-ascii?Q?kOQWwmmCzNxhdk1rmDqJ4ysItJdbmPz14G34y/tVxOk/NgT4UzyNecqqAbDW?= =?us-ascii?Q?TIbjaOZvOHvuJxS5yY5GvpwtuOl6w7PK6mlbd4LaRuSdLVmhK6gcBjVpWj38?= =?us-ascii?Q?b756Z25sok0iG7UQbxRl9a+06xVpMSge7PlzmH/4o4CQdH2y3JBM5BInsT5C?= =?us-ascii?Q?gVB02zxA5cwG7DEQJN/rqVzVEx2gWiwXeTAgE0WJeyxvyeMTtiwmiXq2px8f?= =?us-ascii?Q?VPybXDL18bc39fM0dHBEuZhRBObWYx335o3HhuUBkFM8a4w1EV0v72SXKzgj?= =?us-ascii?Q?rGjYUCrZ4u8zYwoRCYLlp/61D69Y/wSM6GwT+xxtqtrFhjTXL1wUqge90bz6?= =?us-ascii?Q?jIA+/l9pCUCeW2EKKxbmsqwTORBXIwjnRoy68Rau2/IURV3Dfn9T8xnPGigM?= =?us-ascii?Q?kJB6NhBrReZaFIP007WV2sljclgqwi8zQoPtN/n6WeBXENJyVZueFo+pnpRV?= =?us-ascii?Q?APlidJgA4mtY3pXjhIQGBMKnCEyAphT6dgMmA6B0RFFqLUENUCut9aId1XZg?= =?us-ascii?Q?EHj0ZagdtYQFSk7yMzzToRViefX5bRulkhLYyo8YAbbSg30gz/+qT58RqoAD?= =?us-ascii?Q?hA07tj+dyRyPg2GE1AM=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 028fdf87-22c7-450f-f0ea-08dc68d703ab X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Apr 2024 05:33:06.8253 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0Ps4/P1ziLE5rwcaa+JqRi9ex3qE1WP9Yt3qniaGDfG+7nyUynomHaQT4t3dk5ce1yYvIOyyNVVR5edFdvEhyQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR11MB5253 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Mon, 29 Apr 2024 22:33:09 -0700 Resent-From: ray.ni@intel.com Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: VVN83vSXgoWB88snoXd4Mme3x7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244E7883D8300A33F2B9C018C1A2MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=gc29JnzV; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244E7883D8300A33F2B9C018C1A2MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Wu, Jiaxin Sent: Monday, April 29, 2024 13:31 To: devel@edk2.groups.io Cc: Ni, Ray ; Zeng, Star ; Gerd Hoff= mann ; Kumar, Rahul R Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in LmceSuppor= t ProcessorNumber 0 is not always BSP. Debug message based on 0 of ProcessorNumber is incorrect. This patch is to clean the debug message in LmceSupport directly. Cc: Ray Ni Cc: Zeng Star Cc: Gerd Hoffmann Cc: Rahul Kumar Signed-off-by: Jiaxin Wu --- UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiC= puPkg/Library/CpuCommonFeaturesLib/MachineCheck.c index d8b070d9f1..cb569769a1 100644 --- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c +++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c @@ -1,9 +1,9 @@ /** @file Machine Check features. - Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.
+ Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent **/ #include "CpuCommonFeatures.h" @@ -287,13 +287,10 @@ LmceSupport ( if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) { return FALSE; } McgCap.Uint64 =3D AsmReadMsr64 (MSR_IA32_MCG_CAP); - if (ProcessorNumber =3D=3D 0) { - DEBUG ((DEBUG_INFO, "LMCE enable =3D %x\n", (BOOLEAN)(McgCap.Bits.MCG_= LMCE_P !=3D 0))); - } return (BOOLEAN)(McgCap.Bits.MCG_LMCE_P !=3D 0); } /** -- 2.16.2.windows.1 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#118406): https://edk2.groups.io/g/devel/message/118406 Mute This Topic: https://groups.io/mt/105795776/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244E7883D8300A33F2B9C018C1A2MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Wu, Jiaxin <jiaxin= .wu@intel.com>
Sent: Monday, April 29, 2024 13:31
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Zeng, Star <star.zeng@intel= .com>; Gerd Hoffmann <kraxel@redhat.com>; Kumar, Rahul R <rahul= .r.kumar@intel.com>
Subject: [PATCH v1] UefiCpuPkg/Library: Cleanup debug message in Lmc= eSupport
 
ProcessorNumber 0 is not always BSP. Debug message= based on 0
of ProcessorNumber is incorrect.

This patch is to clean the debug message in LmceSupport
directly.

Cc: Ray Ni <ray.ni@intel.com>
Cc: Zeng Star <star.zeng@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Signed-off-by: Jiaxin Wu <jiaxin.wu@intel.com>
---
 UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c b/UefiC= puPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
index d8b070d9f1..cb569769a1 100644
--- a/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
+++ b/UefiCpuPkg/Library/CpuCommonFeaturesLib/MachineCheck.c
@@ -1,9 +1,9 @@
 /** @file
   Machine Check features.
 
-  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.&= lt;BR>
+  Copyright (c) 2017 - 2024, Intel Corporation. All rights reserved.&= lt;BR>
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
 **/
 
 #include "CpuCommonFeatures.h"
@@ -287,13 +287,10 @@ LmceSupport (
   if (!McaSupport (ProcessorNumber, CpuInfo, ConfigData)) {
     return FALSE;
   }
 
   McgCap.Uint64 =3D AsmReadMsr64 (MSR_IA32_MCG_CAP);
-  if (ProcessorNumber =3D=3D 0) {
-    DEBUG ((DEBUG_INFO, "LMCE enable =3D %x\n", (= BOOLEAN)(McgCap.Bits.MCG_LMCE_P !=3D 0)));
-  }
 
   return (BOOLEAN)(McgCap.Bits.MCG_LMCE_P !=3D 0);
 }
 
 /**
--
2.16.2.windows.1

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#118406) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244E7883D8300A33F2B9C018C1A2MN6PR11MB8244namp_--