Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv.

["Ni, Ray" <ray.ni@intel.com>]

Reviewed-by: Ray Ni <ray.ni@intel.com>

Can you kindly update the PR to add the Reviewed-by? I can help to set "push" label after that.

Thanks,
Ray
> -----Original Message-----
> From: Xu, Wei6 <wei6.xu@intel.com>
> Sent: Monday, December 18, 2023 9:37 AM
> To: devel@edk2.groups.io; Xu, Wei6 <wei6.xu@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>; Ard Biesheuvel
> <ardb+tianocore@kernel.org>; Sami Mujawar <sami.mujawar@arm.com>; Ni,
> Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in
> uncompressed inner fv.
> 
> This patch series already got "reviewed-by" from Laszlo. Could anyone help to
> merge the changes? Thanks a lot.
> 
> Thanks Laszlo for reviewing the patches.
> 
> BR,
> Wei
> 
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Xu, Wei6
> Sent: Monday, November 6, 2023 3:53 PM
> To: devel@edk2.groups.io
> Cc: Xu, Wei6 <wei6.xu@intel.com>; Laszlo Ersek <lersek@redhat.com>; Ard
> Biesheuvel <ardb+tianocore@kernel.org>; Sami Mujawar
> <sami.mujawar@arm.com>; Ni, Ray <ray.ni@intel.com>
> Subject: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in
> uncompressed inner fv.
> 
> V1:
> This patch is to fix the issue that StandaloneMmCore fails to detect
> uncompressed inner FV.
> PR: https://github.com/tianocore/edk2/pull/4943
> 
> V2:
> Based on V1, fix some other issues
> 1. Add Missing object size checks before casting pointers to header types
>   a. InnerFvHeader = (EFI_FIRMWARE_VOLUME_HEADER *)SectionData;
>      This is introduced in V1, add the size check on SectionDataSize against
> EFI_FIRMWARE_VOLUME_HEADER
>   b. Section = (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1);
>      Use FfsFindSection instead of FfsFindSectionData to avoid pointer
> casting.
> 2. Fix potential memory leak issue that ScratchBuffer is not freed when page
> allocation for DstBuffer fails.
> PR: https://github.com/tianocore/edk2/pull/4965
> 
> V3:
> 1. Separate patch per individual issue fix on patch V2.
> 2. Fix one more issue: Limit FwVol encapsulation section recursion in
> MmCoreFfsFindMmDriver().
> PR: https://github.com/tianocore/edk2/pull/4975
> 
> V4:
> Patch (1/4): Move the declaration of MmCoreFfsFindMmDriver() from source
> file to the header file "StandaloneMmCore.h"
> Patch (2/4): Handle the case that ExtractGuidedSectionDecode()'s decoded
> buffer is identical to the data in InputSection Patch (3/4): Fix the issue 'Section
> + 1' migth be a wrong address for InnerFvHeader if Section is
> EFI_COMMON_SECTION_HEADER2.
> Patch (4/4): 'Continue' if an EFI_SECTION_FIRMWARE_VOLUME_IMAGE is
> found, do not look for an EFI_SECTION_GUID_DEFINED again.
> PR: https://github.com/tianocore/edk2/pull/5004
> 
> For the recursion logic improvement, Let's do it in other patch set in future
> after this patch is committed.
> 
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Ray Ni <ray.ni@intel.com>
> 
> Wei6 Xu (4):
>   StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion
>   StandaloneMmPkg/Core: Fix potential memory leak issue
>   StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong
>   StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV
> 
>  StandaloneMmPkg/Core/Dispatcher.c         |  5 --
>  StandaloneMmPkg/Core/FwVol.c              | 88
> +++++++++++++++++------
>  StandaloneMmPkg/Core/StandaloneMmCore.c   |  7 +-
>  StandaloneMmPkg/Core/StandaloneMmCore.h   | 26 +++++++
>  StandaloneMmPkg/Core/StandaloneMmCore.inf |  3 +
>  StandaloneMmPkg/StandaloneMmPkg.dec       |  5 ++
>  6 files changed, 103 insertions(+), 31 deletions(-)
> 
> --
> 2.29.2.windows.2
> 
> 
> 
> 
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112633): https://edk2.groups.io/g/devel/message/112633
Mute This Topic: https://groups.io/mt/103235459/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/1913456212/xyzzy [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-