From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4A816AC0C83 for ; Mon, 18 Dec 2023 05:02:26 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=LjwhsuF3jhtdFJH7/JM3d9mEl+P8vA7SseTlrQTUXkA=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1702875744; v=1; b=S2nePTg9ivIi/AoFKgRkK7TW/aTgnrcQ0DWdj1we25yuHznmcTnUpoDMcsjbsEuiR0GcSvEm CDhHzKA3QXIuDMH8JQPVtWQzAr686M/pWS5vEM4MEzkw8ZJxH8j4rGPjVzYe8rSSVGScN+LPiDp aSYFvrYohOadhlg8btWtQGoc= X-Received: by 127.0.0.2 with SMTP id AkMLYY7687511x626SddFhp9; Sun, 17 Dec 2023 21:02:24 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mx.groups.io with SMTP id smtpd.web11.36030.1702875744135960213 for ; Sun, 17 Dec 2023 21:02:24 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="481641772" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="481641772" X-Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2023 21:02:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10927"; a="866077885" X-IronPort-AV: E=Sophos;i="6.04,284,1695711600"; d="scan'208";a="866077885" X-Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by FMSMGA003.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 17 Dec 2023 21:02:22 -0800 X-Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Sun, 17 Dec 2023 21:02:22 -0800 X-Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Sun, 17 Dec 2023 21:02:22 -0800 X-Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Sun, 17 Dec 2023 21:02:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=b7nRklF9vHPbs7DQW+SE0gSZzF9cgTrxvB7u+jZpCnyuIasICSbltqmmm9/CQmWgRpbWCRxPQwI4HDjFjxpdPyHafYG88xK7dXbqSIP6dMb7HuXw3r4ZCblLN4g1Wnaz/UVYEkxG46n+1rl6NfjCRYg5YDTWuxAAtFMVrWjtfAzWB+XpdoG9WC7eN44Q4mXbDjIKaHaHXK8fVdQIWcjL0USgjokBvxGDL8DliAPfxm5ympsRIfu4vKgbirakf12pnlHp465R7QzU116TXY9M1l22XKMdZUBs3qzVOulR6hADSdiCBDUuBSobFdDBkXMZd1CNqa5JmTUoLTt68NOXww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RCJdtPg2Jm5Y+83eXVCVJzdFznaixycsuzIbqxBPqMM=; b=fTfaQf8jsomm2VklUjSj3xgrTrWl7Vq9FXbSL5ojAMun2x2qOdbbcXPIqU5VZXQ/sjhEleuztGWmMvie53lRusIsfjNXOtEqG/06GgefUUgq9FwEVo/WTVGyuiS4IDuEkeMGgLeYJf4N4l13TOVztArjTs42eUL/NENkVac8Dhn4k0OaSkDqIAD+kSAhEhRsGwvVwT/goYyAAsqoe170N2IkzRFYQhQvscs5miA54i6UNxT9bHjlDas5w1d1b54jT2CeGXJosPkt9VokAYN4rdOs/5yzrtRNhPpqnPth+oup3eK3bJ+GJro43tsU7JcLUxVaPu2hBZTTTnBk+NXBGg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS0PR11MB7623.namprd11.prod.outlook.com (2603:10b6:8:142::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.38; Mon, 18 Dec 2023 05:02:12 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7091.034; Mon, 18 Dec 2023 05:02:12 +0000 From: "Ni, Ray" To: "Xu, Wei6" , "devel@edk2.groups.io" CC: Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Subject: Re: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Topic: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv. Thread-Index: AQHaEIbAQ+ydnPBFckqS3kgqJ1W9b7Cugv9AgAA6TyA= Date: Mon, 18 Dec 2023 05:02:12 +0000 Message-ID: References: <1794F968339CC3DE.12603@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS0PR11MB7623:EE_ x-ms-office365-filtering-correlation-id: 135d3876-41e1-4a46-c4df-08dbff867ed1 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: pyC1KfCfG7LTWAhjmMObl6MEUpu++c+7O4KxNmAMz76V+NzXkdgNgGODbB3hh4EEil5Kq2QY38AYYLgfmotJg5HFfDkJbuLMcg38Bvoj9AOvXjXYUx3BBzAKHSGJspWjfS7+QD41uiTNgIMQdH8UH/hgqAedBXl+7wFPFbwgmPFRJ+TWCL61VhKhJLifR63wZwYQXS0BHgkrcKQ+c1JSMHv8ox7ybc/67I4V6H8KycDfQriRAsu4+ObNwcPVsjx2ppFhdvHmG/xdlNuPvIBdjfynShQisTIyMazTC9ByaEjmcoZ1ul8dcIeFbxqXZfvqhwDieqW1MvvqEvq2xkEW5ETMOQoLvenl+NcBrcBg7yawji2LcVUisMf/I4IaVBfK6mM5NX/VvclKauUt2D3r9oqNoyvG6NVC0cYVwfixXiluwpVcMkgRB5ZMbLd4Z3piqwOwbu/SJhney+rTDUODLnX7+0R2OOm6KPvKq9AZpdPJc2Z+SAPJ44Ox92ieHrfG3iFmJ1VV9JCI73JjPS6XNyUd7LHKqvWazKEYrGNbHPRGPfZeSeQJLcbSfdbbkRtmGl/055tCBVN1O+HGI23QI7LzITu9CVDHcfCSRsbrbf9/k44EJ5bXHwDmWisXNovu9fvszj1Hf5if7EU0Qmrg3w== x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?z7KSoC7UZFmtjtPDwe6CiR6KXBIK+M5gM5W7OhBme3N6jO99SAQSofWb6ug7?= =?us-ascii?Q?UJmEp/N6lykfBxvjBR3akc/UnY3Bb+F98Y+08j0WDWRBjbp4SDUP2bfkHGFe?= =?us-ascii?Q?vZV1zggWgJyh0tZi0h+Jq4yc3nxSS/kkP3Ul8YHUmyWdvZqM1K8cDinQaCCl?= =?us-ascii?Q?UZbGODqzrj8engLvgFTZ5VBiOHs5oe4s+rmyPfgYHAz0KECNlNw46GgPqix8?= =?us-ascii?Q?AN1+09OCrzfWMBB6vHGYAU2qeTvWEQNCvnrqubeOxMeNrGE8v3OKTxjGqJze?= =?us-ascii?Q?OJNtZ/C9PnrGih6jPCs8nsfN99+f4w+PkyJWmjWLlFYoOIsMMEm73NPQ4xTb?= =?us-ascii?Q?AdDcl9twqlAUwBykpUiiEd+ZDmY5gSS6Xu9h/OoDdJLNvxTPGVi5tKyz4Pla?= =?us-ascii?Q?TPriG7tojZewbXBFX39FqYXbsQ03WyPE2zPXADCTDg7i+rf42qPTPv49s1H6?= =?us-ascii?Q?gM8IggthjAWsgAro13s6yMSFDIpDsys8gihOoBXg3jczvcMlh7HQA9f7uzB1?= =?us-ascii?Q?yRuJdO+ZeeEZS8uMWu7Ax9yRWRIG+yrzKiD54FJTW+me5ODMaM3pJPxMjnLJ?= =?us-ascii?Q?n8HtX7XMlcb4nSecEOsEtNONxIIOD5jyUTPKNHtl1OqhpawhUdMWjeF4I9QT?= =?us-ascii?Q?Kn8kqeMzIVX2TwglcmxwnxYqnTSof69a1Jv5AqnIWT+q6KCij9gine6hh6tz?= =?us-ascii?Q?JFq0xUyL9fxj8mjyUeuCtwqkZhlBjHubHz4XDhCCTBhpnuw6xcBJ7CvQthxy?= =?us-ascii?Q?TenEPw4wb2qUm1MBsRLUVbdvCZhMRSQKMiultEiVZVgCrH+D6nEP5AMgZQ52?= =?us-ascii?Q?nqK0oXL4kid0SfxfgeZ4m5KxHavcS9OYFC9lNaCLnXGxR7onVFD695/Tr3h6?= =?us-ascii?Q?fjYsVLMf8nuUuOvrgrPvJuakHu9QmoyKu60ygFl8gKLz9H6oaFxkBpEYLMpZ?= =?us-ascii?Q?m4c67CjWMphuoghGaWfmoyx+lK+70gPqkMl0ollGos5dmuJBmCMe7zA8Hoav?= =?us-ascii?Q?yUOHOk4lYWcDtj0t/K35oGbpMM/vl8a1g5DshJ98ZCC5Wq5a+FikCEwIGI38?= =?us-ascii?Q?/XXS7mXo0bRWhBUzsBYBhd52f4Vq1Ht1VOSYdbAZ4WCdpZRCQB8cTOb3QE0t?= =?us-ascii?Q?JDcYnSb3FCyW7ssBpmhFWZnRdlnO22ixphVWZznR3/OLeBONf88fVzbZCg+T?= =?us-ascii?Q?0XA+heXbvxNml/71E7F4PY7f42qZOy+oXJxtK89W9PzJeeYLAwTpZ0a93Wdu?= =?us-ascii?Q?6HKXkvMrdN6RadSSrv/E7Y8ukj/XfGaCnNaF1m2Wlt/ty3LMjLoeUx4WRbKV?= =?us-ascii?Q?83UFSNCfa/stzPWJ8UKp127Vhx/yLlvHFnzJzxO7vvS0WiMIc1QlnbrfqBr0?= =?us-ascii?Q?npqXcZ/DdqVMjET0bPnc2AsncO9+cg5ActOLLqUHyF/TNxjK2dsnBULTF607?= =?us-ascii?Q?qIJp1FDW/LRc+dMaQ7iOfaQyng7qszGmf/H4TIbHTfZi0cuy/r0ciWaeS8bG?= =?us-ascii?Q?jSEMmdrJvrU1PpCbxFts+5nNGYhrsRPrd2WuSQTGT4XRLJrPmLvrf/azMAcT?= =?us-ascii?Q?KLLftbaBXdheCke5NTE=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 135d3876-41e1-4a46-c4df-08dbff867ed1 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Dec 2023 05:02:12.1061 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: AeKqlzEYqfZbXsnrNmq1WeyDeT9Tfbvoa7byxunK6+vIicn3v86lOuj0KB55HcBN4zfy1eOyyxmDtyaY8nOF+Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR11MB7623 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: rd5XUDBNESYpv4kWGI75NEQyx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=S2nePTg9; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Can you kindly update the PR to add the Reviewed-by? I can help to set "pus= h" label after that. Thanks, Ray > -----Original Message----- > From: Xu, Wei6 > Sent: Monday, December 18, 2023 9:37 AM > To: devel@edk2.groups.io; Xu, Wei6 > Cc: Laszlo Ersek ; Ard Biesheuvel > ; Sami Mujawar ; Ni, > Ray > Subject: RE: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers i= n > uncompressed inner fv. >=20 > This patch series already got "reviewed-by" from Laszlo. Could anyone hel= p to > merge the changes? Thanks a lot. >=20 > Thanks Laszlo for reviewing the patches. >=20 > BR, > Wei >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Xu, Wei6 > Sent: Monday, November 6, 2023 3:53 PM > To: devel@edk2.groups.io > Cc: Xu, Wei6 ; Laszlo Ersek ; Ard > Biesheuvel ; Sami Mujawar > ; Ni, Ray > Subject: [edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in > uncompressed inner fv. >=20 > V1: > This patch is to fix the issue that StandaloneMmCore fails to detect > uncompressed inner FV. > PR: https://github.com/tianocore/edk2/pull/4943 >=20 > V2: > Based on V1, fix some other issues > 1. Add Missing object size checks before casting pointers to header types > a. InnerFvHeader =3D (EFI_FIRMWARE_VOLUME_HEADER *)SectionData; > This is introduced in V1, add the size check on SectionDataSize agai= nst > EFI_FIRMWARE_VOLUME_HEADER > b. Section =3D (EFI_COMMON_SECTION_HEADER *)(FileHeader + 1); > Use FfsFindSection instead of FfsFindSectionData to avoid pointer > casting. > 2. Fix potential memory leak issue that ScratchBuffer is not freed when p= age > allocation for DstBuffer fails. > PR: https://github.com/tianocore/edk2/pull/4965 >=20 > V3: > 1. Separate patch per individual issue fix on patch V2. > 2. Fix one more issue: Limit FwVol encapsulation section recursion in > MmCoreFfsFindMmDriver(). > PR: https://github.com/tianocore/edk2/pull/4975 >=20 > V4: > Patch (1/4): Move the declaration of MmCoreFfsFindMmDriver() from source > file to the header file "StandaloneMmCore.h" > Patch (2/4): Handle the case that ExtractGuidedSectionDecode()'s decoded > buffer is identical to the data in InputSection Patch (3/4): Fix the issu= e 'Section > + 1' migth be a wrong address for InnerFvHeader if Section is > EFI_COMMON_SECTION_HEADER2. > Patch (4/4): 'Continue' if an EFI_SECTION_FIRMWARE_VOLUME_IMAGE is > found, do not look for an EFI_SECTION_GUID_DEFINED again. > PR: https://github.com/tianocore/edk2/pull/5004 >=20 > For the recursion logic improvement, Let's do it in other patch set in fu= ture > after this patch is committed. >=20 > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Sami Mujawar > Cc: Ray Ni >=20 > Wei6 Xu (4): > StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion > StandaloneMmPkg/Core: Fix potential memory leak issue > StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong > StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV >=20 > StandaloneMmPkg/Core/Dispatcher.c | 5 -- > StandaloneMmPkg/Core/FwVol.c | 88 > +++++++++++++++++------ > StandaloneMmPkg/Core/StandaloneMmCore.c | 7 +- > StandaloneMmPkg/Core/StandaloneMmCore.h | 26 +++++++ > StandaloneMmPkg/Core/StandaloneMmCore.inf | 3 + > StandaloneMmPkg/StandaloneMmPkg.dec | 5 ++ > 6 files changed, 103 insertions(+), 31 deletions(-) >=20 > -- > 2.29.2.windows.2 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112633): https://edk2.groups.io/g/devel/message/112633 Mute This Topic: https://groups.io/mt/103235459/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-