From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 5F874740035 for ; Fri, 22 Mar 2024 01:21:48 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=VhAAHW1eNh4iNbK30VLZNBrBdBCk1HinNhHwU1u2wMs=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:msip_labels:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type; s=20240206; t=1711070507; v=1; b=imYBSO4qRRvGG5ZQlA7R/zCYMMO1brQmyMj53POeR546E/78UWJXLV7AJeOn7p/xxiwPSfUL GJj3ATCcRqgtERp3UydOIpCoejHZba7LqhCGA7wpdR+Onh4IxuPMc7vaNyi3jWWNQxLrOdusKw3 airvS1EI6joc6esz2/0tI1/vcTBdSKt5FlJhknrG2r1AcIac+mYJKLJJsr0zLeEqCZDApn6h05L 2JIlBsSjTZRPmsBg4sCfpyNtUiz8jxJFU7G5MpS68vp6RlHAOEHoCHmoSH6KlUv9wSZgx0Z8zG0 oZg1/WANkrVDcj6I6Q0sKFCVgKj53hSBATGuUKQ6iyVrw== X-Received: by 127.0.0.2 with SMTP id GTwqYY7687511xQizOktNAl9; Thu, 21 Mar 2024 18:21:47 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web10.2932.1711070506351169757 for ; Thu, 21 Mar 2024 18:21:46 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11020"; a="16651457" X-IronPort-AV: E=Sophos;i="6.07,144,1708416000"; d="scan'208,217";a="16651457" X-Received: from orviesa005.jf.intel.com ([10.64.159.145]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Mar 2024 18:21:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,144,1708416000"; d="scan'208,217";a="19447572" X-Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by orviesa005.jf.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 21 Mar 2024 18:21:45 -0700 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 18:21:45 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 21 Mar 2024 18:21:44 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Thu, 21 Mar 2024 18:21:44 -0700 X-Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Thu, 21 Mar 2024 18:21:44 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH0PR11MB5062.namprd11.prod.outlook.com (2603:10b6:510:3e::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.11; Fri, 22 Mar 2024 01:21:42 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7386.017; Fri, 22 Mar 2024 01:21:42 +0000 From: "Ni, Ray" To: Chao Li , "devel@edk2.groups.io" CC: "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH v2 02/13] UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files alphabetically Thread-Topic: [PATCH v2 02/13] UefiCpuPkg/CpuExceptionHandlerLib: Reorder the INF files alphabetically Thread-Index: AQHaeqKd0I10cWmvuUChN8Yu0MtMNrFC9+Hx Date: Fri, 22 Mar 2024 01:21:42 +0000 Message-ID: References: <20240320084152.268323-1-lichao@loongson.cn> <20240320084243.274599-1-lichao@loongson.cn> In-Reply-To: <20240320084243.274599-1-lichao@loongson.cn> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: msip_labels: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH0PR11MB5062:EE_ x-ms-office365-filtering-correlation-id: 8526195f-5087-4447-d913-08dc4a0e6e95 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: Lrrk+vTwGKBaqo+znos1Eb7CLQQ2cZTxLQ2kQYcDL6xLY8dWN7hZiXcVhvluXPkFQmak8Wi3yo5s7W0gFSXCUM1B2SUrPsSNXGE5dFKQTtZ0OIvqTSmj3MnFe7NIxDIuLGBWl5YOKHJjnlAvDtN4C2+TSawh1gwBOF1IfVxCdSSXGLzFcG1D2S3APK0sV2F66Hosaentv8OzTeSMbD1xTV2W4Kg4++z0EQerUc89tiGRKiN26K4l4A9zRfOwIoqGedqiM6XhfsHJPH8TysqK4+A/3cZuKbVBuxe/64HXYupdfni70EdA7v90c7SJdoMeKNSLrvIxTz1yG5EH2Ujg2jtlt6Fy5LilrhapWzI0rMrtDnWpfjBKydV5aYtJ3dFoqLyXXUP3KInXhJXoe2z1xIeTAN7DhiZVhFPqdQp7dHO9z8mVPA8sA4CK1vrCoJs7qoa8IV5ajhKAeYZ9B9UCYsc4aSb0xGvr0JMrjUxIFqZ8APS0sc6ezXgemklE3iFia4ScIOOaEm35PXG5ulmE0uQz2IAezx/Uq16V0dDmFtPwC8b6QgFFBSbwy4qnWVNl16zFv/yr5r3e1ocZdwxbRzdCL7QqwqxAjVryvlJtSG0Ql2uDspkISLTXWqNrSbstlDzXhDetzKRbcBUYBjMLulH8avt5gIAX2BFBu1GeGDQ= x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?cfZUFGtV9vgtu8gcLz5z/XrZk/CFVa/Ow3w4Qoz3B8LhdVErVI325EVQywZc?= =?us-ascii?Q?D5lD/csAfgaTm4I2Bym+p60O7PNSYdo4SABG6tFuiL4yYC7dKzlfyFmoVLM7?= =?us-ascii?Q?LV1Z1K6Uz7Ts+9mX+WXYPCuXile9hmtmYqCKPgjthuqVXBznI5M28toPgQSV?= =?us-ascii?Q?Zu6d9cBcZljnY1OdiryMqwcO58ai1alBymO5DCj0ENF15MLv4eMhhOf9xA/I?= =?us-ascii?Q?T1x76JZnMw/FQu7tWDyUAPTE23C6hHZncA17dL4Cd5zNkOEpqIRqYDDeHuGx?= =?us-ascii?Q?EbeCm92NjcONtsz8bBWHVCobk2drA1m/+XygbPgKG3SPKDLMbtFMwF+80WnA?= =?us-ascii?Q?Ro6w//QQ/Uh+SLkHOs2QmA6Dx08QjSBqdW26S4R7B9/nmxV3iwJJ/XRoazjW?= =?us-ascii?Q?ZeenVmJOZfF4aq3jyQsTdr6nnTbKLwR0MjWjvyzDMK4yXsWaPAadxOBP+Ijk?= =?us-ascii?Q?6LEDp0OtYud6Ow3HdipkP0JMIPHFaTQBo1MUH3VAe1iyrykiieyz59SYwukP?= =?us-ascii?Q?rX7yJ6aB2I8uRVmo4G4t8Dxl/qK6YqC/Uq7Yi8+0ekIyQDAel9jo9IyL7rAD?= =?us-ascii?Q?nmWAr0Y9COnAiON9fM/ZB/tUW5HuBI1TBoB3AA6+Tv5t3xT+ibmR7aYxZt8O?= =?us-ascii?Q?qj/YlxXwcQKa8B7KmRBgJK+TsaNIK18OovxweV5PD0jFSX2qP8TYgYMbEiJz?= =?us-ascii?Q?oQQAr6Y2EX6A/bjfUAoDCDgKmcyooSq4jjK9IO+WFnfy9jYFou/yJedfpyjJ?= =?us-ascii?Q?vA33cDWu7qL76ZZ/9JdhMb1OKx/WV9WjK+8/fMgoDKu0CVN9Ckf7fbGBO+8e?= =?us-ascii?Q?ae06GAwzn5oI/sy4VvcWkd1w6KkG2a+3yXVdTvqOH2fTjED8SK1gjObuLA9k?= =?us-ascii?Q?yH0uGJum2YI3V6hDf5QQD/vYV3tLCxu/6DRcSQ1jaGWy8FcezQa6bUq9orBf?= =?us-ascii?Q?4+NW+dqxSpu3xL5izdrnZ8tkSGE8L9Nu/pisO16CsFi5y/jaDw5fsseQWCc0?= =?us-ascii?Q?Sh1MrwtrKQLhXh4zFLTcNV7V8LSwLphfrbcIdc9CO4asKO3iNHmcYRSAuasT?= =?us-ascii?Q?kJid85XCYnZNxrsweD+KajFTMQKYJI+sNkjhpShBrCwHWA3U0/iTrTZ8wdQu?= =?us-ascii?Q?q3jfMO6Ss1sUfL0oijFQSPG1yhTcak6OTI3nZKDDvW+dpe4M8gCjsVfp/hWp?= =?us-ascii?Q?UKTCycRNqNCDxnhWeIStmIm5/3l9oQlAlfzsQXUzRy45Ce9KtnYAgE2dB9Bg?= =?us-ascii?Q?nJXs/IGdUX4GFyaupoqav8PoUnbrbeJzeXZUXJYXJfDpvj6sojwjelaUjuPd?= =?us-ascii?Q?WnrpNJCEDtIvMqYP6WnySqAEsZYsFTINVG2Y3/i5/YNLh4Jb6Ty58dHtJmUn?= =?us-ascii?Q?+6sPnPw20j1jsnZcS4kMTfvh7QzySArk6YV0e5bOvPKWIW9xPFwtl9xNARIl?= =?us-ascii?Q?e1zwEgHLmMLe9vYJXLDYCd7jAZKNotxAYzwZkRWXXrnI9uERYtIsyZwZ2dzc?= =?us-ascii?Q?CUQMHQsWSRTGCJWHU50s3OPo8HhCHubLEm9ml3x668BoNM9qBBkIx3sP+o43?= =?us-ascii?Q?BLk9OSX+Y+nHpZSCdL8=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8526195f-5087-4447-d913-08dc4a0e6e95 X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Mar 2024 01:21:42.4472 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: T+C3mwRiCy2loroN0Nyc9JWblnkYKOrVnaegXK5LxTwdpnBn11TZilfI6Gb3f03Xf5dON814B3RZK1mKcTjKkg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5062 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 21 Mar 2024 18:21:46 -0700 Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 9GNcmwiRvJUZIDSCuQG7u1uRx7686176AA= Content-Language: en-US Content-Type: multipart/alternative; boundary="_000_MN6PR11MB8244EAE57C2E377FB1F949858C312MN6PR11MB8244namp_" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=imYBSO4q; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io --_000_MN6PR11MB8244EAE57C2E377FB1F949858C312MN6PR11MB8244namp_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I feel that ordering alphabetically may break the logical groups. For example, below two might be placed in a reverse way. CpuExceptionCommon.h CpuExceptionCommon.c But luckily, you didn't re-order the above to make .c above .h. So, you are not simply ordering them alphabetically. Nevertheless, the current changes look good to me. Reviewed-by: Ray Ni Thanks, Ray ________________________________ From: Chao Li Sent: Wednesday, March 20, 2024 16:42 To: devel@edk2.groups.io Cc: Ni, Ray ; Kumar, Rahul R ; G= erd Hoffmann Subject: [PATCH v2 02/13] UefiCpuPkg/CpuExceptionHandlerLib: Reorder the IN= F files alphabetically Some of the order is not in alphabetical, reorder. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4726 Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Chao Li Acked-by: Gerd Hoffmann --- .../DxeCpuExceptionHandlerLib.inf | 20 +++++++++---------- .../PeiCpuExceptionHandlerLib.inf | 16 +++++++-------- .../SecPeiCpuExceptionHandlerLib.inf | 12 +++++------ .../SmmCpuExceptionHandlerLib.inf | 16 +++++++-------- 4 files changed, 32 insertions(+), 32 deletions(-) diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandle= rLib.inf index fdbebadab9..aabcabff0f 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf @@ -22,21 +22,21 @@ [Defines] # [Sources.Ia32] - Ia32/ExceptionHandlerAsm.nasm - Ia32/ExceptionTssEntryAsm.nasm Ia32/ArchExceptionHandler.c Ia32/ArchInterruptDefs.h + Ia32/ExceptionHandlerAsm.nasm + Ia32/ExceptionTssEntryAsm.nasm [Sources.X64] - X64/ExceptionHandlerAsm.nasm X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h + X64/ExceptionHandlerAsm.nasm [Sources.common] CpuExceptionCommon.h CpuExceptionCommon.c - PeiDxeSmmCpuException.c DxeException.c + PeiDxeSmmCpuException.c [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard @@ -53,14 +53,14 @@ [Packages] [LibraryClasses] BaseLib - SerialPortLib - PrintLib - SynchronizationLib + CcExitLib + DebugLib LocalApicLib - PeCoffGetEntryPointLib MemoryAllocationLib - DebugLib - CcExitLib + PeCoffGetEntryPointLib + PrintLib + SerialPortLib + SynchronizationLib [BuildOptions] XCODE:*_*_X64_NASM_FLAGS =3D -D NO_ABSOLUTE_RELOCS_IN_TEXT diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandle= rLib.inf index 3bcaff5c5f..3a11516e32 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf @@ -22,15 +22,15 @@ [Defines] # [Sources.Ia32] - Ia32/ExceptionHandlerAsm.nasm - Ia32/ExceptionTssEntryAsm.nasm Ia32/ArchExceptionHandler.c Ia32/ArchInterruptDefs.h + Ia32/ExceptionHandlerAsm.nasm + Ia32/ExceptionTssEntryAsm.nasm [Sources.X64] - X64/SecPeiExceptionHandlerAsm.nasm X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h + X64/SecPeiExceptionHandlerAsm.nasm [Sources.common] CpuExceptionCommon.h @@ -45,14 +45,14 @@ [Packages] [LibraryClasses] BaseLib - SerialPortLib - PrintLib - LocalApicLib - PeCoffGetEntryPointLib + CcExitLib HobLib + LocalApicLib MemoryAllocationLib + PeCoffGetEntryPointLib + PrintLib + SerialPortLib SynchronizationLib - CcExitLib [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard # CONSUMES diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHa= ndlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException= HandlerLib.inf index e7b1144f69..f8e597d86d 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf @@ -22,15 +22,15 @@ [Defines] # [Sources.Ia32] - Ia32/ExceptionHandlerAsm.nasm - Ia32/ExceptionTssEntryAsm.nasm Ia32/ArchExceptionHandler.c Ia32/ArchInterruptDefs.h + Ia32/ExceptionHandlerAsm.nasm + Ia32/ExceptionTssEntryAsm.nasm [Sources.X64] - X64/SecPeiExceptionHandlerAsm.nasm X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h + X64/SecPeiExceptionHandlerAsm.nasm [Sources.common] CpuExceptionCommon.h @@ -44,11 +44,11 @@ [Packages] [LibraryClasses] BaseLib - SerialPortLib - PrintLib + CcExitLib LocalApicLib PeCoffGetEntryPointLib - CcExitLib + PrintLib + SerialPortLib [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandle= rLib.inf index 27f0b96fa9..cc280a6ee7 100644 --- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf +++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf @@ -22,15 +22,15 @@ [Defines] # [Sources.Ia32] - Ia32/ExceptionHandlerAsm.nasm - Ia32/ExceptionTssEntryAsm.nasm Ia32/ArchExceptionHandler.c Ia32/ArchInterruptDefs.h + Ia32/ExceptionHandlerAsm.nasm + Ia32/ExceptionTssEntryAsm.nasm [Sources.X64] - X64/ExceptionHandlerAsm.nasm X64/ArchExceptionHandler.c X64/ArchInterruptDefs.h + X64/ExceptionHandlerAsm.nasm [Sources.common] CpuExceptionCommon.h @@ -45,13 +45,13 @@ [Packages] [LibraryClasses] BaseLib - SerialPortLib - PrintLib - SynchronizationLib + CcExitLib + DebugLib LocalApicLib PeCoffGetEntryPointLib - DebugLib - CcExitLib + PrintLib + SerialPortLib + SynchronizationLib [Pcd] gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard -- 2.27.0 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#117020): https://edk2.groups.io/g/devel/message/117020 Mute This Topic: https://groups.io/mt/105041087/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --_000_MN6PR11MB8244EAE57C2E377FB1F949858C312MN6PR11MB8244namp_ Content-Type: text/html; charset="us-ascii" Content-Transfer-Encoding: quoted-printable
I feel that ordering alphabetically may break the logical groups.
For example, below two might be placed in a reverse way.
  CpuExceptionCommon.h
  CpuExceptionCommon.c

But luckily, you didn't re-order the above to make .c above .h.

So, you are not simply ordering them alphabetically.

Nevertheless, the current changes look good to me.
Reviewed-by: Ray Ni <ray.ni@intel.com>

Thanks,
Ray
From: Chao Li <lichao@lo= ongson.cn>
Sent: Wednesday, March 20, 2024 16:42
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Ni, Ray <ray.ni@intel.com>; Kumar, Rahul R <rahul.r.kum= ar@intel.com>; Gerd Hoffmann <kraxel@redhat.com>
Subject: [PATCH v2 02/13] UefiCpuPkg/CpuExceptionHandlerLib: Reorder= the INF files alphabetically
 
Some of the order is not in alphabetical, reorder.=

BZ: https= ://bugzilla.tianocore.org/show_bug.cgi?id=3D4726

Cc: Ray Ni <ray.ni@intel.com>
Cc: Rahul Kumar <rahul1.kumar@intel.com>
Cc: Gerd Hoffmann <kraxel@redhat.com>
Signed-off-by: Chao Li <lichao@loongson.cn>
Acked-by: Gerd Hoffmann <kraxel@redhat.com>
---
 .../DxeCpuExceptionHandlerLib.inf      =        | 20 +++++++++----------
 .../PeiCpuExceptionHandlerLib.inf      =        | 16 +++++++--------
 .../SecPeiCpuExceptionHandlerLib.inf     &nb= sp;    | 12 +++++------
 .../SmmCpuExceptionHandlerLib.inf      =        | 16 +++++++--------
 4 files changed, 32 insertions(+), 32 deletions(-)

diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandle= rLib.inf
index fdbebadab9..aabcabff0f 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeCpuExceptionHandlerLib.i= nf
@@ -22,21 +22,21 @@ [Defines]
 #
 
 [Sources.Ia32]
-  Ia32/ExceptionHandlerAsm.nasm
-  Ia32/ExceptionTssEntryAsm.nasm
   Ia32/ArchExceptionHandler.c
   Ia32/ArchInterruptDefs.h
+  Ia32/ExceptionHandlerAsm.nasm
+  Ia32/ExceptionTssEntryAsm.nasm
 
 [Sources.X64]
-  X64/ExceptionHandlerAsm.nasm
   X64/ArchExceptionHandler.c
   X64/ArchInterruptDefs.h
+  X64/ExceptionHandlerAsm.nasm
 
 [Sources.common]
   CpuExceptionCommon.h
   CpuExceptionCommon.c
-  PeiDxeSmmCpuException.c
   DxeException.c
+  PeiDxeSmmCpuException.c
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard
@@ -53,14 +53,14 @@ [Packages]
 
 [LibraryClasses]
   BaseLib
-  SerialPortLib
-  PrintLib
-  SynchronizationLib
+  CcExitLib
+  DebugLib
   LocalApicLib
-  PeCoffGetEntryPointLib
   MemoryAllocationLib
-  DebugLib
-  CcExitLib
+  PeCoffGetEntryPointLib
+  PrintLib
+  SerialPortLib
+  SynchronizationLib
 
 [BuildOptions]
   XCODE:*_*_X64_NASM_FLAGS =3D -D NO_ABSOLUTE_RELOCS_IN_TEXT
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandle= rLib.inf
index 3bcaff5c5f..3a11516e32 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/PeiCpuExceptionHandlerLib.i= nf
@@ -22,15 +22,15 @@ [Defines]
 #
 
 [Sources.Ia32]
-  Ia32/ExceptionHandlerAsm.nasm
-  Ia32/ExceptionTssEntryAsm.nasm
   Ia32/ArchExceptionHandler.c
   Ia32/ArchInterruptDefs.h
+  Ia32/ExceptionHandlerAsm.nasm
+  Ia32/ExceptionTssEntryAsm.nasm
 
 [Sources.X64]
-  X64/SecPeiExceptionHandlerAsm.nasm
   X64/ArchExceptionHandler.c
   X64/ArchInterruptDefs.h
+  X64/SecPeiExceptionHandlerAsm.nasm
 
 [Sources.common]
   CpuExceptionCommon.h
@@ -45,14 +45,14 @@ [Packages]
 
 [LibraryClasses]
   BaseLib
-  SerialPortLib
-  PrintLib
-  LocalApicLib
-  PeCoffGetEntryPointLib
+  CcExitLib
   HobLib
+  LocalApicLib
   MemoryAllocationLib
+  PeCoffGetEntryPointLib
+  PrintLib
+  SerialPortLib
   SynchronizationLib
-  CcExitLib
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard  &nb= sp; # CONSUMES
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHa= ndlerLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuException= HandlerLib.inf
index e7b1144f69..f8e597d86d 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SecPeiCpuExceptionHandlerLi= b.inf
@@ -22,15 +22,15 @@ [Defines]
 #
 
 [Sources.Ia32]
-  Ia32/ExceptionHandlerAsm.nasm
-  Ia32/ExceptionTssEntryAsm.nasm
   Ia32/ArchExceptionHandler.c
   Ia32/ArchInterruptDefs.h
+  Ia32/ExceptionHandlerAsm.nasm
+  Ia32/ExceptionTssEntryAsm.nasm
 
 [Sources.X64]
-  X64/SecPeiExceptionHandlerAsm.nasm
   X64/ArchExceptionHandler.c
   X64/ArchInterruptDefs.h
+  X64/SecPeiExceptionHandlerAsm.nasm
 
 [Sources.common]
   CpuExceptionCommon.h
@@ -44,11 +44,11 @@ [Packages]
 
 [LibraryClasses]
   BaseLib
-  SerialPortLib
-  PrintLib
+  CcExitLib
   LocalApicLib
   PeCoffGetEntryPointLib
-  CcExitLib
+  PrintLib
+  SerialPortLib
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard
diff --git a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandl= erLib.inf b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandle= rLib.inf
index 27f0b96fa9..cc280a6ee7 100644
--- a/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf
+++ b/UefiCpuPkg/Library/CpuExceptionHandlerLib/SmmCpuExceptionHandlerLib.i= nf
@@ -22,15 +22,15 @@ [Defines]
 #
 
 [Sources.Ia32]
-  Ia32/ExceptionHandlerAsm.nasm
-  Ia32/ExceptionTssEntryAsm.nasm
   Ia32/ArchExceptionHandler.c
   Ia32/ArchInterruptDefs.h
+  Ia32/ExceptionHandlerAsm.nasm
+  Ia32/ExceptionTssEntryAsm.nasm
 
 [Sources.X64]
-  X64/ExceptionHandlerAsm.nasm
   X64/ArchExceptionHandler.c
   X64/ArchInterruptDefs.h
+  X64/ExceptionHandlerAsm.nasm
 
 [Sources.common]
   CpuExceptionCommon.h
@@ -45,13 +45,13 @@ [Packages]
 
 [LibraryClasses]
   BaseLib
-  SerialPortLib
-  PrintLib
-  SynchronizationLib
+  CcExitLib
+  DebugLib
   LocalApicLib
   PeCoffGetEntryPointLib
-  DebugLib
-  CcExitLib
+  PrintLib
+  SerialPortLib
+  SynchronizationLib
 
 [Pcd]
   gEfiMdeModulePkgTokenSpaceGuid.PcdCpuStackGuard
--
2.27.0

_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#117020) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--_000_MN6PR11MB8244EAE57C2E377FB1F949858C312MN6PR11MB8244namp_--