From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 00F9CAC0A96 for ; Thu, 14 Mar 2024 02:52:30 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=28AEwqUSXfAQfHbd+09IsEIP40q4G8x5Gdt8z3sG1Co=; c=relaxed/simple; d=groups.io; h=From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1710384749; v=1; b=TfCbNDFRQNVLexepgVnrPKhypzzU2qyUXWVPkf8guDkOiqwvVrF5u8GeueE+4ss4olaVVyBo rOtG/lgnkpqboEpc/3MRs73JlJl/LCn8Xj+khrMZCFFG8YM6pcnpBCmKpv8KFHQyyItLGsgJ81T F0d+8RPMX8zrPPkU1VfL/BSm+90RqnCI2VmIT66/ODhoDibgEKO1yMQV+6mkVuE3puIWGGI/iTR QZoNu6e0cpxvXS7KgxyYQZZXjPr76lR13AgBy6aU6J4p852rhUFf71OGBXpco5bSPdMrbLPkeJE qNF8nDboZf1cyen/WaPaJrtHKQ8c7THDdSp1Ej+uwwCvw== X-Received: by 127.0.0.2 with SMTP id nyRWYY7687511xX1Bcy5Izaf; Wed, 13 Mar 2024 19:52:29 -0700 X-Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.11]) by mx.groups.io with SMTP id smtpd.web11.2575.1710384748381685435 for ; Wed, 13 Mar 2024 19:52:28 -0700 X-IronPort-AV: E=McAfee;i="6600,9927,11012"; a="15745445" X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="15745445" X-Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by orvoesa103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Mar 2024 19:52:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,124,1708416000"; d="scan'208";a="35274438" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmviesa002.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 13 Mar 2024 19:52:27 -0700 X-Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 13 Mar 2024 19:52:26 -0700 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 13 Mar 2024 19:52:26 -0700 X-Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.168) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 13 Mar 2024 19:52:26 -0700 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by PH7PR11MB6977.namprd11.prod.outlook.com (2603:10b6:510:205::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 02:52:24 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::2c31:82b7:9f26:5817%5]) with mapi id 15.20.7386.017; Thu, 14 Mar 2024 02:52:24 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Lin, Du" CC: "S, Ashraf Ali" , "Chiu, Chasel" , "Chen, Gang C" , "Duggapu, Chinni B" , "Desimone, Nathaniel L" , "Zeng, Star" , "Mohapatra, Susovan" , "Kuo, Ted" Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Topic: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit() Thread-Index: AQHadbPuOBI9mxiD7UOgHXonf+rulLE2icxg Date: Thu, 14 Mar 2024 02:52:24 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|PH7PR11MB6977:EE_ x-ms-office365-filtering-correlation-id: 500f0d34-e14d-4cb6-e224-08dc43d1c715 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: qb2o8Hl2sVXrDOMp45xKGypQBs67fpuX0RpgnsACxctnbggFc6Y/ZVUjlh3ySHky/lzOBFEDyWwOjvI54YvKN8HUXoh0sKhP9bAGk5vskdE+MOwJVLeVrBMvq/FtYmZEw0SKLB3N90rMlqjY4GlOxaZR3GMwQUlakwD5KjBTMTsw31m3Rkvq9CUhqH/0yc8NdLfe9hCctEyViO5BF3BEkM6k7dMYN/6xgoVGc2M3AtRQ1jJIQrvV4CyxKVEPqDZSqTpnrSX+loAv0prLzDFCDJVVH6qp+lWkeAQd+ocd1sz08WtAwHaEWPl1hXhmbDwr6vRAy/47d4qLdwwhXLwzAN1megOeDAtcMIPFMNiniDG58kNNslIbTFKQ3SkGGzVgSBrDL9sZTB/7GO8/2NS75p/dcWnAc8zRhJ/wOKDnOX3WKqksMQMYZBVmaqQCO2g76D/lsAItazqNQk6O75pdsBZKll3bhw49y9M4EABIpi0GMRYRf5a5q5qpmHPfHieADaX8enivKO7NtROudIV9zHHjZknTmr7frDoPCIdL1pSB5t7jjKgTBPZ1xT12WlFofCbDmV9H/7jzHpys1bNnQy4rY3iZEWH1omGj6bsiVP6JTvPQRGXAUd8FpU0qS1AIsw35LiFj4bN955Clh/s6HRWvwpNt2vlACOmeCcofuoMD720I1blcgdl77+94+xjR x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?1aoOHJKj890cPRtE7Oa0yGJ1DLJkQm8/GFu6XYiIFxSYpWETRYSZYBv1SzIC?= =?us-ascii?Q?xwV9piBRgM4yvoDng6+vF2R9ZNBpC5pgL42zz/Hup0SMrHlDKcO7A6LJi60G?= =?us-ascii?Q?ay0cIerErTnAkd4oT1fx3Z8tIP6IWOMXR3+hB2O+4AHGS439ToFhvbUS3AsN?= =?us-ascii?Q?7eqYDAjWhzhou7dHAOQgUjAYTZValzx3f8YHsuU3P+4TeHZCicG6uZaS5Kgk?= =?us-ascii?Q?gMNscb2MZMw9noyk21v9fb6OjpiV0aSjVMrH7hXgBshkjZuF/s5IX9XXawp6?= =?us-ascii?Q?fM2jgxdhEyVUZiE5M7bZEX8iBOLSWvL7qNvkNtT+p+9x7jW191IQ10CgJPYj?= =?us-ascii?Q?VCvBk8taDpooVI60ov1wRSI5QdSVs5ycQplgM9SqlN9rGNFypsDstLD3tC7s?= =?us-ascii?Q?fBPjXy3Gmr5HDbT3HTxCPBWtkVpt0iDqo/e49gqsIwz13mS07ZZ8FCOin1oJ?= =?us-ascii?Q?dWoph+aZBdc1u902R088oTQiK52dXDzMCwtbCNUzviAcYzweMWlrZg4X8Ij1?= =?us-ascii?Q?9xMv3FeyLGJxiTG6pYC7N9f6JDrBqQ321dDswZFB5UeExO1SEqINsSIUpR5e?= =?us-ascii?Q?ToSeLBt9DaLG8Wgb+xqKBqu+8x/YEqA2RSu+L+NhsOdrW38HhPBNaUure796?= =?us-ascii?Q?jcdSb9TslaX9BV2WkFwC9klhQP+1ttTsEBsqfqh9kmhJYLFWmBk8Z2/jKgck?= =?us-ascii?Q?vSyjOJng7Pvy0YiaALmvIrX42NwfP/DKdkx8ogOUFkD+Lgp/xd2EOEWqywee?= =?us-ascii?Q?Y3thIpM/X0BeJuHFb+KQyzwUsIeYLWON+DCgTJy867rcWfr6p0F+jfWcxeQD?= =?us-ascii?Q?E/UVjwJxn67PUhblklrlNjyEqHgOQK0k1sGcPOBznNECFNuE4mad2/vmi+jl?= =?us-ascii?Q?k1ScMORhGSsaiKsLVkXH5d+WiBgdH8Cso7JCZnCp9RzoYQfuWfbTb5z4+VoR?= =?us-ascii?Q?DJi+atYxfg6Z4oaQFi+zHXRRKNP9eW+uMr9FxIEQLiB/EdfcWZbASufhZhnd?= =?us-ascii?Q?sMInIUtLLstYtIxMsP3Z4DYazx+2JVOwVN0NC9VOHb5UWBM7pgSi5r8tt2+f?= =?us-ascii?Q?ElZznctpaP6+KYV3/8AQqhesdrcaxGxSwL/872M5TTj3EcOomCwA2l9xQY8g?= =?us-ascii?Q?T6msHFWnL/bubnszRGdPUZFgPOAHWfymozdbiBX4bJ6ilRzhQDcMovhG7FdB?= =?us-ascii?Q?0c/q+hkJGiaeHIg5M6DMgpy1mMf/bwitSTnpFxSzygViR80oMrObj8mqBAEy?= =?us-ascii?Q?E8FpLzRhi49184xmW6V+JARSC0aJF/FHw9HSFKaGlvhLmwXkFR9P5YiX05K+?= =?us-ascii?Q?GQ4014zDioaNPHiIeI3W7fydgc29VoQW2sBUZGOPPL9fmJ1BE8nVAbPA0CiK?= =?us-ascii?Q?GMUHxVDy/F9pg5R2ov7X7jEykGkk0fVF5l1Zv2mpr4P5SNiGNbCHp2IX+x0C?= =?us-ascii?Q?r1fcu4CxTZz9dV8ncTiZoD9tFnw4yyeDuHLy20c7XCXFEaixRRROhPR23rM1?= =?us-ascii?Q?2g+DnNV5DhmZ9NjBcIB1GizGaZuJjlMO8EcK+81IdAuGMbhKeaiGYb/uWEGD?= =?us-ascii?Q?HonTMp4Fbl5LIWc2N5E=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 500f0d34-e14d-4cb6-e224-08dc43d1c715 X-MS-Exchange-CrossTenant-originalarrivaltime: 14 Mar 2024 02:52:24.6886 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: cFlFwJq05tfSxfufuYZTS0qvAspSzc1C2rdM6RUiggjNltp4PBfAQDiYFEwcn04BG7cC6JpNnqlE8EXyJIg2uA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB6977 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 13 Mar 2024 19:52:28 -0700 Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: RcI5FCgMQlx4C4wUaeo4E8cNx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=TfCbNDFR; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Ray Ni Thanks, Ray > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Du Lin > Sent: Thursday, March 14, 2024 10:02 AM > To: devel@edk2.groups.io > Cc: Lin, Du ; S, Ashraf Ali ; C= hiu, > Chasel ; Chen, Gang C ; > Duggapu, Chinni B ; Desimone, Nathaniel L > ; Zeng, Star ; > Mohapatra, Susovan ; Kuo, Ted > > Subject: [edk2-devel] [PATCH v2] IntelFsp2WrapperPkg: Error handling of > FspmWrapperInit() >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4701 >=20 > The error handling of FspmWrapperInit() is limited to ASSERT > statements only, which only works in debug builds, but not in > release builds. > Fix the issue by enhancing the error handling of FspmWrapperInit() > to cover both debug builds and release builds. >=20 > Signed-off-by: Du Lin > Cc: Ashraf Ali S > Cc: Chasel Chiu > Cc: Chen Gang C > Cc: Duggapu Chinni B > Cc: Nate DeSimone > Cc: Star Zeng > Cc: Susovan Mohapatra > Cc: Ted Kuo > --- > IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c | 8 > ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > index ba0c742fea..7f1deb9542 100644 > --- a/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > +++ b/IntelFsp2WrapperPkg/FspmWrapperPeim/FspmWrapperPeim.c > @@ -197,12 +197,20 @@ FspmWrapperInit ( >=20 > MeasurementExcludedFvPpi =3D AllocatePool (sizeof > (*MeasurementExcludedFvPpi)); > ASSERT (MeasurementExcludedFvPpi !=3D NULL); > + if (MeasurementExcludedFvPpi =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > MeasurementExcludedFvPpi->Count =3D 1; > MeasurementExcludedFvPpi->Fv[0].FvBase =3D PcdGet32 > (PcdFspmBaseAddress); > MeasurementExcludedFvPpi->Fv[0].FvLength =3D > ((EFI_FIRMWARE_VOLUME_HEADER *)(UINTN)PcdGet32 > (PcdFspmBaseAddress))->FvLength; >=20 > MeasurementExcludedPpiList =3D AllocatePool (sizeof > (*MeasurementExcludedPpiList)); > ASSERT (MeasurementExcludedPpiList !=3D NULL); > + if (MeasurementExcludedPpiList =3D=3D NULL) { > + return EFI_OUT_OF_RESOURCES; > + } > + > MeasurementExcludedPpiList->Flags =3D EFI_PEI_PPI_DESCRIPTOR_PPI | > EFI_PEI_PPI_DESCRIPTOR_TERMINATE_LIST; > MeasurementExcludedPpiList->Guid =3D > &gEfiPeiFirmwareVolumeInfoMeasurementExcludedPpiGuid; > MeasurementExcludedPpiList->Ppi =3D MeasurementExcludedFvPpi; > -- > 2.44.0.windows.1 >=20 >=20 >=20 >=20 >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116726): https://edk2.groups.io/g/devel/message/116726 Mute This Topic: https://groups.io/mt/104919472/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-