From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Tan, Dun" <dun.tan@intel.com>
Cc: "Dong, Eric" <eric.dong@intel.com>,
"Kumar, Rahul R" <rahul.r.kumar@intel.com>,
Gerd Hoffmann <kraxel@redhat.com>,
"Chen, Xiao X" <xiao.x.chen@intel.com>
Subject: Re: [edk2-devel] [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP
Date: Tue, 25 Apr 2023 14:09:47 +0000 [thread overview]
Message-ID: <MN6PR11MB8244EE6CFF9E18B6CEAB249C8C649@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230425090524.3027-2-dun.tan@intel.com>
> + if (ProcTraceData->EnableOnBspOnly) {
1. can you please add comments here to remind reader that
this is also the first and only time ProcTraceInitialize() runs?
Similar comments in the next chunk code.
> + MemRegionBaseAddr = (UINTN)AllocateAlignedReservedPages (Pages,
> Alignment);
> + if (MemRegionBaseAddr == 0) {
> + //
> + // Could not allocate for BSP even
> + //
> + DEBUG ((DEBUG_ERROR, "ProcTrace: Out of mem, failed to allocate
> buffer for BSP\n"));
> + return RETURN_OUT_OF_RESOURCES;
> + }
next prev parent reply other threads:[~2023-04-25 14:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 9:05 [Patch V2 0/2] Update ProcTrace feature code for new requirements duntan
2023-04-25 9:05 ` [Patch V2 1/2] UefiCpuPkg: Update code to support enable ProcTrace only on BSP duntan
2023-04-25 14:09 ` Ni, Ray [this message]
2023-04-26 1:28 ` [edk2-devel] " duntan
2023-04-25 9:05 ` [Patch V2 2/2] UefiCpuPkg: Update PT code to support enable collect performance duntan
2023-04-25 14:13 ` Ni, Ray
2023-04-26 1:27 ` duntan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244EE6CFF9E18B6CEAB249C8C649@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox