From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C602E7803D8 for ; Wed, 6 Dec 2023 09:55:18 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=ZikXHhPYUo23vBOEK76pi74zQtywgLnVBXxUlroPYqM=; c=relaxed/simple; d=groups.io; h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:CC:Subject:Thread-Topic:Thread-Index:Date:Message-ID:References:In-Reply-To:Accept-Language:MIME-Version:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1701856517; v=1; b=LMNGASuMCzvHhRAkzrzDrjHlJ3WupNVbC8iTqJ1MPO+2JAsf4QeCKQhxE40tZm77WFBRkB+f MnHG6QbzVajzkB3n2FrI21KrWL0Y0uf5ZAcNnNzybdTLGDp4jToqPCsfyK4cCD2QOpJokOoiQRn /xVaORpGtt8Lm8S/Jy9HEHLk= X-Received: by 127.0.0.2 with SMTP id UjebYY7687511xybuLx4hiVU; Wed, 06 Dec 2023 01:55:17 -0800 X-Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mx.groups.io with SMTP id smtpd.web11.28060.1701856516696827506 for ; Wed, 06 Dec 2023 01:55:16 -0800 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="392904302" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="392904302" X-Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Dec 2023 01:55:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10915"; a="1018516479" X-IronPort-AV: E=Sophos;i="6.04,254,1695711600"; d="scan'208";a="1018516479" X-Received: from orsmsx602.amr.corp.intel.com ([10.22.229.15]) by fmsmga006.fm.intel.com with ESMTP/TLS/AES256-GCM-SHA384; 06 Dec 2023 01:55:16 -0800 X-Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 01:55:15 -0800 X-Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Wed, 6 Dec 2023 01:55:15 -0800 X-Received: from ORSEDG602.ED.cps.intel.com (10.7.248.7) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35 via Frontend Transport; Wed, 6 Dec 2023 01:55:15 -0800 X-Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.100) by edgegateway.intel.com (134.134.137.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.35; Wed, 6 Dec 2023 01:55:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HUAsgbD3ZWzsnnF5CniIQtu526Lkwbpc0nEojwndELbQCANNZgSeZ97TNex342kUD5GgCOL+VpxmgxoXGSg6PwZdEq1ElCJ8gHM4YIWbzywSsahYGiBiIilvXmY69CWa3Q1+2kJW1WD+KZQTb1WPv5NOjxc1sQWPduGrPLzcfWQXTHL1I9jFByOvuhKoBw2OQRou3mvRnPiw2eq/4jelFoS8ba14UIfth6fv5zpK8Hgy6hwRieVxtljgJcYWuLApac5lGbbz4CpN/w0MU2ZrKYfessQ4Tb6A6NDCh6P6pSZLIcbz2VyzqoOA+6DP+EcUo9weqBK6QpJKCv/CyzORbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rQ3ejYoIuKTF13GNRvcD7nJEXpbMovPyRP44PKdHBUE=; b=J5H6MFCGIENc9L890APOpAodkZvVHxyZ45vL4JHZTtViANMFdyv5FAUXpi3aGOfT3POApdY8b1Yp8MzU5Y/kAvM4qgv+7SzjDbO03aoKBtmxejfzJzT0qbC3PQj5PK69dJzKbTyK9weHCVcGEeRC4KeYtpZ1rBovQjY9kbaXU1zY2ELNYjDg35cPhpSJNbyQfnxEJyDR/6PqruvTUkxpdjBQVzK1Y4dryJ7ET1GzYXKF71eTWTeqOr5ifezT9iKM5k8hBMoOJ+lOTKerA7QeqUVc5UWYq4DoBqP5YT7DvKfxWUX90hzPyvlWfDjCMWkoLgmKMTYtTyFGpr4RcdN/xQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by CH3PR11MB8776.namprd11.prod.outlook.com (2603:10b6:610:1c1::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7068.25; Wed, 6 Dec 2023 09:55:12 +0000 X-Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::b614:1f5e:8b0c:9858%4]) with mapi id 15.20.7046.034; Wed, 6 Dec 2023 09:55:12 +0000 From: "Ni, Ray" To: "Tan, Dun" , "devel@edk2.groups.io" CC: "Dong, Eric" , "Kumar, Rahul R" , Gerd Hoffmann Subject: Re: [edk2-devel] [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe Thread-Topic: [PATCH 3/6] UefiCpuPkg: Consume MpInfo2Hob in PiSmmCpuDxe Thread-Index: AQHaJz7RGa6jjpG2MkGGLZfxXJAGj7Cb/d5w Date: Wed, 6 Dec 2023 09:55:12 +0000 Message-ID: References: <20231205054900.926-1-dun.tan@intel.com> <20231205054900.926-4-dun.tan@intel.com> In-Reply-To: <20231205054900.926-4-dun.tan@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|CH3PR11MB8776:EE_ x-ms-office365-filtering-correlation-id: 7e7ed00a-139e-4449-3fe7-08dbf64170ca x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam-message-info: ZMt7Tg2OdSEYpAA+BSe6bDk8BYD8K1SVIkF/sF759bseC4YPZYdRLoPL0GVQlnaXmCgi0OfvTx4XK7ua9NFRKI+O0J/k/SVfS4zlJopUnIAySOVWdckJsLiXpvb4oIDYYCnrxJfNfQDk/ROIs51WARyQVPvsX+Dt4hC3KndEUaQALYqfMgSsIyOLmEYzmm43ROAAZ0NfM6z0Ed4smDSx6uIXAXhQPo+MBQAVs6TUyLb2nxEoLUvo1EnTETMbIOhhwNV0NMoSIjguRIugS6qgPDyTNBSVVJgXChg+ZcVkgU0XtfBhzH+4Xz47Fc83023fthzOksSA3/UENPz7YNfuHNNIbNMM5nknBWxalv2v8ATG3Xu/RgbHQhruNkXUhRVmRXGicvy+9D2JfkGS5wxkn+HKyzY2/+9KBvMjkmueXwg8SqQbMHCzyD0bfdlUxtmZrBWVjNMq9n69Qg4TWBWvbAl8XuSz/6HSTf0qufnYiZQS8wMzLXllSjatxjUBXMOGTU1dvJIv1VEDg5h8TFrJ9Cj3MPmfur6IdYR30kOEFTPS/jsHdpJFhwymE2ujouyt/BI1OtrPLJK+JFoQe6DleMy1gRG0QHlhydFSWNxiRoyFLeZg+3NqkujUCMg3bRg9 x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?EPup0Pp8aepNLiNxFNK8FJSIw/+YmNSmIzbnJpNcYlIUVkagMBOOrgxhUvA7?= =?us-ascii?Q?eZY1PglI0iMUTJsam9SCtb9zFqKKWyghH2zKFl2i6Cl9boTWWqOR8LC5F8q4?= =?us-ascii?Q?P25x3jL9GrphmrpQdbwNEAd/8DS6M1tGsFZdO3+dCQAzvQjcvRK/6meNwyUa?= =?us-ascii?Q?Vt9AuCvWtbIjgXjgI2frD4cnUQn+kYtrMpcmdSybWxhKNAUgh52YK2mlgJsg?= =?us-ascii?Q?JJ4tK+N9aQbcYdurTIRlsEWQdSYYagtXj51L74FD5x5RCpgK8bARwC7+v3vY?= =?us-ascii?Q?tWo7Yv9b/ZrMP6xoFt5TgYEjTjSL0eB6IenvXiTaz2dSbEDZijioR0M08vuq?= =?us-ascii?Q?kWNEoMMGP9BsWeCsHj6Jl5b1ne+8QAQMBIBiNdrSXdV/sf7rHc+kU7YnGzbL?= =?us-ascii?Q?cdkJwSxo/Y1eACd3ryErQtYDcF0oJCHxHHwCJoLXpKxbeBM6lEJlP3WOWgeo?= =?us-ascii?Q?8lLtL8ANnNY3sIWq/JmObjsRyAnCfWkVZlTxPPMaRuRur9Es+/uaLilKyx6K?= =?us-ascii?Q?JTtJb2YBEpfEtr93ZHcoIMZCt1osv5cuDbLmNOKPvnkbSFtCA1a9+7PJXefQ?= =?us-ascii?Q?90yWI7VR/UPp5PrnLC/0XI56Pw+ZrR0rt4CQZTEVuuwKFbiIWB1ar12Q5f7I?= =?us-ascii?Q?V9Wws1INBaLlV8C7OtlmZ+Pca1zuW3GFsUBNP8CSohJqtFtzC6RHIpoj8G15?= =?us-ascii?Q?LnUJCoHqMiJZJ41lFWV0Fo4+gCl8UCRKvV6oIxiH541BLBItJFIbTxoteeBK?= =?us-ascii?Q?PVHxXqs+xide7gRYxo7lzroJ82J6MSH2XwKGWGOCGDDuR0YbAdTHSUvsQYwK?= =?us-ascii?Q?hW7EVDuPaUu2e8ZolJ4mKavms6W87k+Ws6oNrmbj5bPDbKb0QA2DAj+w3UGc?= =?us-ascii?Q?T6lGcOY8JGr/6C5Y+QQQHNEYGyQS9www9igT8q1JeXNVUK1kStgxn5a+DG4v?= =?us-ascii?Q?5Kq8Q4pLaQaeO1KwBhphDkOLEeYjbFxdgNGvqlHPGFyN9gJG7TqX4/A41w9L?= =?us-ascii?Q?vvEjIhr7eWs6PS/SzQ10tqQgM8v174D0YW6yIlGmx7LzjYIj0ktceC7ZEDr+?= =?us-ascii?Q?qBnxmf1TxGuqOb4C/Al0PCe6I7x/i9avmx1mkMWiX736YNCeDAfmBj8b+FuJ?= =?us-ascii?Q?pHhWAs8LgXRDHMWdv2j8rB3qp9kgNq9dqKk+EGEZaYfGKPZrVjXG22iFp8tq?= =?us-ascii?Q?fH6zkDoLZq4gS4DdAgQj1yAeCeNGWCkOsskq2/UEypEwnoDCGUTzoK2FZcSS?= =?us-ascii?Q?Y4pP9MeoyyrQs2J4P6f/a1QoIxtsh2Th/4hqEU+48fURcr+P8qIzBj6Jz6Um?= =?us-ascii?Q?ZLUb3JNPeOjtNO8C91BJ1XATxI0QdD8Swh/82+E/B07LxkIpEkgyv+//lAXD?= =?us-ascii?Q?vSh5EjBxpQ5NE3iPmjI0SQSZbr0sdu7sXNuSLRhiwA1X3z3zqm4n/yhazYt1?= =?us-ascii?Q?XW0oeLbLiaGOZUO/KcWvicWs5C/dbXlsjPfZoQoMh4jSHT9t+yOzDfq4/ByU?= =?us-ascii?Q?GWgJKUfLyhUEg4Vh2QET5qI85CypFycd9lxfjN5AX+ux0gszKY5Vtf5gvZKu?= =?us-ascii?Q?ERx3V7VLJWT7v1Aw00w=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7e7ed00a-139e-4449-3fe7-08dbf64170ca X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Dec 2023 09:55:12.8453 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: jAiYmfPVVzWRkJNb5LF4644mMPRYA2D+NgZ0rB/1EVnOxB/xXP7w6iyx5b+Sd1c1zk0BnLeOtTJ6NMMqyluIOA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8776 X-OriginatorOrg: intel.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,ray.ni@intel.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 3DaeD0G7p6eneVHVJlNLR4WAx7686176AA= Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=LMNGASuM; arc=reject ("signature check failed: fail, {[1] = sig:microsoft.com:reject}"); dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=intel.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io 1. The function name can be "GetMpInformation()" without mentioning "FromMp= Info2Hob". > + EFI_HOB_GUID_TYPE *GuidHob; > + EFI_HOB_GUID_TYPE *FirstMpInfor2Hob; 2. "FirstMpInfo2Hob". Please remove "r". >+ FirstMpInfor2Hob =3D GetFirstGuidHob (&gMpInformationHobGuid2); 3. Please update comments to explain "FirstMpInfo2Hob" is to speed up the 2= nd while-loop without needing to look for MpInfo2Hob from beginning. > + > + ASSERT (CpuCount <=3D PcdGet32 (PcdCpuMaxLogicalProcessorNumber)); > + *NumberOfCpus =3D CpuCount; 4. There is no "return" before "*NumberOfCpus" assignment. So, why not remo= ve "CpuCount" and directly udpates "*NumberOfCpus" in the while-loop? > + > + MpInfomation2Buffer =3D AllocatePool (sizeof > (MP_INFORMATION2_HOB_DATA *) * HobCount); 5. MpInfomation2Buffer -> MpInfo2Hobs 6. Can you move "PrevProcessorIndex" assignment just above the "for" loop? > + for (Index =3D 0; Index < HobCount; Index++) { 7. Index -> HobIndex > + CopyMem ( > + ProcessorInfo + PrevProcessorIndex + ProcessorIndex, 8. &ProcessorInfo[PrevProcessorIndex + ProcessorIndex] > + > + *ProcessorInfoPointer =3D ProcessorInfo; 9. If you let the function just return ProcessorInfo and NULL when failure = happens, will it simplify the code? >=20 > +[Depex] > + TRUE > -[Depex] > - gEfiMpServiceProtocolGuid 10. The depex change means that CpuSmm driver could run before CpuMp driver= runs. Have you verified if CpuSmm can start well even removing CpuMp DXE d= river? -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112106): https://edk2.groups.io/g/devel/message/112106 Mute This Topic: https://groups.io/mt/102987139/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/leave/12367111/7686176/19134562= 12/xyzzy [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-