From: "Ni, Ray" <ray.ni@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
"Chiu, Chasel" <chasel.chiu@intel.com>
Cc: "Desimone, Nathaniel L" <nathaniel.l.desimone@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings.
Date: Mon, 20 Mar 2023 06:03:07 +0000 [thread overview]
Message-ID: <MN6PR11MB8244F101513FC8DA77FCA0088C809@MN6PR11MB8244.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20230317172050.1228-1-chasel.chiu@intel.com>
> ASM_PFX(FspInfoHeaderRelativeOff):
>
> DD 0x12345678 ; This value must be patched by the build script
>
> - and rax, 0xffffffff
>
> + mov eax, eax ; equal to and rax, 0xFFFFFFFF
Based on the discussion, we know "mov eax, eax" clears upper 32bits of RAX.
But this code looks very confusing. Is there any other instruction that can do the same thing?
next prev parent reply other threads:[~2023-03-20 6:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 17:20 [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings Chiu, Chasel
2023-03-18 13:04 ` [edk2-devel] " Ashraf Ali S
2023-03-18 22:07 ` Marvin Häuser
2023-03-19 9:07 ` Ashraf Ali S
2023-03-19 9:36 ` Marvin Häuser
2023-03-19 16:57 ` Ashraf Ali S
2023-03-18 22:06 ` Marvin Häuser
2023-03-20 6:03 ` Ni, Ray [this message]
2023-03-20 7:31 ` Pedro Falcato
2023-03-21 23:05 ` Nate DeSimone
2023-03-22 0:17 ` Chiu, Chasel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MN6PR11MB8244F101513FC8DA77FCA0088C809@MN6PR11MB8244.namprd11.prod.outlook.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox