From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by mx.groups.io with SMTP id smtpd.web11.7738.1679292195373749278 for ; Sun, 19 Mar 2023 23:03:15 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="unable to parse pub key" header.i=@intel.com header.s=intel header.b=QeaptiTa; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: ray.ni@intel.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1679292195; x=1710828195; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=K9QoZjwL1BFO721d5wErSfIwERjlC2R6nFhvhWxi6Yk=; b=QeaptiTarJw7cCiJTQrvDsgaeG77CkHonJnFoXtFOikliRBphashsrUY s8ClJfYUDcd7111ruxQJ4veSCy/yOex9B5RaX0ibYwDkWf3xWn/U25LrD 4uAB/5LttEJZPEyTBBuoOls9mccVXOZNtEscPAvYrsb9La/hiB8glZMyM cZWa2PJ/U2fEjhtF9iDcdi8JMOrqfrIO8iGIZSzJIm+M0H2/b9HMUZGix R6hjjaFUHqzrlDhC2w6dsocRgWxjP8kGlgP8VoUiDKf0ynLja3RDtwVMA 4wSKGu8lUi4xCoOmxTRX0AL8DBvTgC4n9c8fahOuJtzCqF5mRdRl+NQFk w==; X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="340940178" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="340940178" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Mar 2023 23:03:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10654"; a="631001291" X-IronPort-AV: E=Sophos;i="5.98,274,1673942400"; d="scan'208";a="631001291" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga003.jf.intel.com with ESMTP; 19 Mar 2023 23:03:14 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Sun, 19 Mar 2023 23:03:14 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21 via Frontend Transport; Sun, 19 Mar 2023 23:03:14 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.21; Sun, 19 Mar 2023 23:03:14 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=moXGOB7W5sjlf3y9Jl8g3W+9AO+Pqtqwt3TJg6fVNlClXAQ2zoxJ9p8AdKhJEZCSns0ra1yV9djY68OckTsTqwbtOX8hTbQC/qgiR/rIjkfub9jcl3pqFvzg+/tEjT63U7SEAw2OZcy262GPSaxQ5CArq43hJfDKh3GXABtfNWmNAvdGLQlNkLubzF9dSFZoHVwwztqmwQ/Wx0U9FB6UBtZj/PL7Q1oahi7nN16KwTk6HKThgqC/Y8pSvlUCk/SfHB4Ex30of9ZIfUAko++p2CMCxAklkHdszBobIYHjbj8WoYnOYMZgvVeP4kN0lKQxdTju02lS5XCEgM2uJHEOyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/g4XzKrkTI7xtdEvqSKSjbnikbSpNlYadkBiQfYa3TU=; b=mW/UXpr6vwvEHA59+eaWNYgCuMkjbfGU8AfAUANU+2YXyr06M2nasRmMdBLsd+AS22CGu+iP0Y+WWFbgC4uPcmz59rsUlfUJYn391vMKb9N8mN1OBEzmPQPxH+y60puNbhXfcgFmkaqeVDa/7gSPjAH/lQT5nWbYIFqPJn7EfjrvZvnr9dCAO2xH5s6MdKIJpBywr0Ytddo8IAWW2jhjPmhTRIOzPoeaxAG+2iggqp+uZs7v9HBRGbel4ShwWFK94GTi7bF0MktQeUwcV3Vk/FcCZLpt7JxPYjh0+llv3WQmapE8AyqTyxNMuOsV2OC5PpKj0EFrIZdd/3uB+WevLw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from MN6PR11MB8244.namprd11.prod.outlook.com (2603:10b6:208:470::14) by DS7PR11MB6040.namprd11.prod.outlook.com (2603:10b6:8:77::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar 2023 06:03:07 +0000 Received: from MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69]) by MN6PR11MB8244.namprd11.prod.outlook.com ([fe80::ae07:e96a:4a24:8a69%7]) with mapi id 15.20.6178.037; Mon, 20 Mar 2023 06:03:07 +0000 From: "Ni, Ray" To: "devel@edk2.groups.io" , "Chiu, Chasel" CC: "Desimone, Nathaniel L" , "Zeng, Star" Subject: Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Topic: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fix NASM X64 build warnings. Thread-Index: AQHZWPTh5yeUJ9poVkenY8vq1tC0Qa8C6ABw Date: Mon, 20 Mar 2023 06:03:07 +0000 Message-ID: References: <20230317172050.1228-1-chasel.chiu@intel.com> In-Reply-To: <20230317172050.1228-1-chasel.chiu@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: MN6PR11MB8244:EE_|DS7PR11MB6040:EE_ x-ms-office365-filtering-correlation-id: e35238b3-2bc7-4721-832e-08db2908c6c2 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 3+oeXtegALInK/9/Lhf3gHV1+7C/LrJ6DJLErdKS2nIxiTc31ffvKczWHjYXW3I2WPrl59vlNPOtRkWuzz2GLki8dRDYJthX3B3ydpKNHitY/8v5rlZETKQTGb0eLjTgozecwF1oCNOi3GxfvkIlVFYdZ7d9xjQYjxRbhCKj/T4EqrWhQODvxSycxlXoQjtWGwn8KRmwKo401pQFyEizRFSHLLVV92QZLpmZ/iyPgdGHu1KjCNfCKOvaDjVw238dqyzoeYWCg4E+hTUtvoWUfhXTu5hEXYuVrGq7p2m5AelszeiqP6HGjzb2wsgovnl9ys0Rtk+naYNyAcLMRMQDXdPN3ggj35ohsc3cF58jNF7X5Jls0FqcRYWJuvK38YzzmklqiW0YHjz7AsSlruuzUfjXcSLG0d1YWnXtLE7WnjRk15aF5ua/+8F+IwlJXbD7FJgFK+KUn5QQezOGmaWpQnjrID3qlzooIAGmO8nXnUL+rsxk7s49Tx5C2oDNIXhR5PoO55Sh2WeuqJIpDz/hRAfcLPlEZDSPPRl8Z3DfMONzNPJ5Ww4P3U5N+I5/KhOodGrwLoXGgnqCjEOhjI89VWof5FsnYqBID6QHu2l3GjTIXGQzb7E+YunNO684s1LHuu2kJCtXnJ4rnKrizALkJjdkF8T90x35RRqmiGg8eke/7f3/l7pGlAEce/YkZcZooS6Fyk09ygbS28xQnh6aEg== x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:MN6PR11MB8244.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(376002)(396003)(136003)(39860400002)(366004)(346002)(451199018)(6636002)(110136005)(316002)(478600001)(54906003)(6506007)(5660300002)(186003)(7696005)(26005)(9686003)(71200400001)(33656002)(107886003)(122000001)(38070700005)(38100700002)(55016003)(86362001)(2906002)(76116006)(52536014)(8936002)(4744005)(66946007)(4326008)(82960400001)(8676002)(66446008)(66556008)(66476007)(41300700001)(64756008);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?ewIyyL9yddCtl0eLE9Pw7Oi46jz8kV//cMOYMjqgUR2ZvoUHDN5FtzOCzx+K?= =?us-ascii?Q?gokWmpBae8RjP8pKAi4KKAxhYUm9aQW3pUDbZOlMkLzGaxlW9b5h7SXo1Rhv?= =?us-ascii?Q?gntja104L1MOiyiQHZPNXiRiEksP6sqI5jdfOfeI+AZLZ+DzudNF3QDh9rKU?= =?us-ascii?Q?Qn29mzSELdI+4WM1cPtUCfLeFivw9zB5KvLyg/IgWrgncA64XyUKkehpJ+UG?= =?us-ascii?Q?S6DDfGq21tqjbQap3AKGLADTYRsKW7axvxqvH1w1B29mtY3AeWnLA0v3Xk/b?= =?us-ascii?Q?1u3iCOCGGks08yx8ECdx6LB9gyyXXjDfaZH4oO5sUpxxiD9lsl9nOfxIIgeH?= =?us-ascii?Q?yKR20xm5cL7Xh983PHhzfozIZvW/SB7q0tm5dfMFHJ5CmHr6D6ME5W/Vzx6R?= =?us-ascii?Q?rSMHtMYWR5uqd0GuIlTZgON8qYUP0sgjOZidNMqb7ztFxG87Vzs+d2PblpJG?= =?us-ascii?Q?Pb8Fvi1u84JjT39CsA0+xQazEnQQQoJ3DFl2AlSS8NtqCNrNauL6TF3kkYNI?= =?us-ascii?Q?01uzOGwAD4u1d25hIrVO7Cn0bwx18wNruCStzizHlXp9w+WYLOVKoeS+JjLm?= =?us-ascii?Q?jwVUQl8K2YNwApHb+AadNBPduQ3hsALEmf/vMlfl6k3lQdFD8JZXlbxI2Jbi?= =?us-ascii?Q?GFZokKrqLXoJduxGtgptHMg1SsSM4EAjhrokQZTfhEpu3tfkB04E5b4JdSrq?= =?us-ascii?Q?w+m6FyJuppcVhgIbsXp/fv6vL0SUtUIsQrTsg2nGQ/VQm7KOaYPk6eHzdNv9?= =?us-ascii?Q?D4JvRaeiWB22ix8i0QMZ6lbxXGZbcgJoqB7yB3wJpM6WjO/LSnqRPV/G5Z+Q?= =?us-ascii?Q?Pao0fD5f1RflmCq8iXqfUzqlXV78eh01CJ3DhAsHVwypThiHsfNtaej4k7SS?= =?us-ascii?Q?a41GW1vcfSABhbdW/+PaAYL9M1+3cf1Jx+2g4bil3KFM+gUYG/WN4jsCqmjj?= =?us-ascii?Q?pcHjmxtPJikMjLqi4FuVlkUccvGeBzv+UVSp0UzUjJu/4M4jzeX/MHTEN7RP?= =?us-ascii?Q?PkDm85VstxnYBbgzwPM4IH7yQmSApKCs33l3yukdIWyJikVYxBpZJ0GOQPK1?= =?us-ascii?Q?I/Sdgfe5K/ON/eFOR5qJq9efm1JYPyfTMlBN9fdEjd+3qr4/1BMWZsj4hba4?= =?us-ascii?Q?obECGr2fI46SuD4SOd9M+D8bxTBELH+noqhiaxZD8W3+pYDEF1AL6wad2teG?= =?us-ascii?Q?mkOUX81dgqAutqOcifQ2jvoELWsnIyYOrYn6fxzYZaVcKB6I7vzA4Uv36T3O?= =?us-ascii?Q?YARYQskPtfiW6PIidKGJHfIkv9amCdXogY3pdCKNOgZvDao8P4UxjtvP3mCJ?= =?us-ascii?Q?vpT6vmh7lnk5r6LdnslNfIrGcFb5Wt5ey4T+f0YP51dkYe0GKwvAuuB9xZTd?= =?us-ascii?Q?YEHGiAYaaMJv+cBXJBbuVKXdmf9JrVw/PyxlNSryKUgqXwQBcY27GDSutE1S?= =?us-ascii?Q?b+2mVr/vv0xG+J0ke3WJHOTG04wwNeamgIed0CqfBZ/lhYMI5bJ6gPhhWFyl?= =?us-ascii?Q?zWD2gJYMX6UZtaygLiVzu1fT9OmhHJ9Q0iKXAjNnrVAzrffRuUUWeW7QLYVO?= =?us-ascii?Q?8eq3UUx32xsx5xeFplQ=3D?= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: MN6PR11MB8244.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e35238b3-2bc7-4721-832e-08db2908c6c2 X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Mar 2023 06:03:07.3701 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GbMbrERWinKJso0W6bV0Fi/jyU7J41ovm9yWMNHdog+AdDCbDJEarrm2MnPaEI3sXkIPc2a2oLqArHmmgy8g4g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6040 Return-Path: ray.ni@intel.com X-OriginatorOrg: intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > ASM_PFX(FspInfoHeaderRelativeOff): >=20 > DD 0x12345678 ; This value must be patched by the bu= ild script >=20 > - and rax, 0xffffffff >=20 > + mov eax, eax ; equal to and rax, 0xFFFFFFFF Based on the discussion, we know "mov eax, eax" clears upper 32bits of RAX. But this code looks very confusing. Is there any other instruction that can= do the same thing?